cobalt-rubocop 0.9.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e362d3b2d73010a79138252128e40a847240a636e0bf47b66420ff8e3fadece
-  data.tar.gz: c3e8d123ceb792de6b5f47838b9fcc119641875f9621cd5c495c64d06ba8f493
+  metadata.gz: 83361f0df69096d9c273be6b367c117e12ecf9f7f213d8d8838e6b4019332f73
+  data.tar.gz: 3699ad2b3cee6367a0ea14ac692437380f18f55405a5ae26a77a6831e32d0f99
 SHA512:
-  metadata.gz: 62efc720640cc2f3e29504ecc0fd81eb01ace1b820d3532c336b04cd99361625a9b97bdebb45f00dea9adc9761c89f03b8d3dd6a9515fdfa7b6b9148c45a67dc
-  data.tar.gz: ae22d0536f332f7bc4dd3a8a915424da94b215963e5c390c26570a55be26d2707f1883bc363d9e2ce7c7b3b87f40a93eb3233d8a2e14b72c695e339620063526
+  metadata.gz: 768f655514f4c7038d89af1cdc2d3f76bcf9df951b03f0050022adf241a639bb6ce9cb31d799aa148fcaed2e56198d46bd2e0b72de373b27203b8c344c5abe65
+  data.tar.gz: 28f1315e26ad48aa71ab4aca4771f6323a0e004994182ccffe7f4c19c4426c389f1b2ebb5f64c023b9cc849a13568e1b150f4416c34fd3294e18f1f67ee753ec

data/CHANGELOG.md

@@ -1,33 +1,68 @@
 # CHANGELOG
+
 ## main (unreleased)
 
+## 1.0.0 (2023-06-09)
+
+* Bump required ruby version to 3.2.x
+* Add default settings:
+
+```yaml
+RSpec/IndexedLet:
+  Enabled: false
+
+RSpec/Rails/InferredSpecType:
+  Enabled: false
+
+Style/RedundantConstantBase:
+  Enabled: false
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+```
+
 ## 0.9.0 (2023-04-20)
+
 * Allow either hash syntax (legacy vs 3.1) as long as the use is consistent.
 
 ## 0.8.0 (2023-04-04)
+
 * Relax dependency versions
 
 ## 0.7.0 (2022-08-24)
+
 * Update Gem versions: ([#12](https://github.com/cobalthq/cobalt-rubocop/pull/12))
 
 ## 0.6.0 (2022-06-24)
+
 * Update Gem versions: ([#11](https://github.com/cobalthq/cobalt-rubocop/pull/11))
 * Security: Require Multi-Factor Authentication for RubyGems privileged operations ([#10](https://github.com/cobalthq/cobalt-rubocop/pull/10))
 
 ## 0.5.0 (2022-01-25)
+
 * Update Gem versions ([#8](https://github.com/cobalthq/cobalt-rubocop/pull/8))
 
 ## 0.4.0 (2021-09-07)
+
 * Update Gem versions ([#7](https://github.com/cobalthq/cobalt-rubocop/pull/7))
 
 ## 0.3.0 (2021-04-16)
+
 * Update Rubocop and Rubocop Performance versions ([#6](https://github.com/cobalthq/cobalt-rubocop/pull/6))
 
 ## 0.2.0 (2021-04-14)
+
 * Avoid warnings on RSpec `let` with parameter arrays ([#5](https://github.com/cobalthq/cobalt-rubocop/pull/5))
 * Add new cop `InsecureHashAlgorithm`. ([#3](https://github.com/cobalthq/cobalt-rubocop/pull/3))
 
 ## 0.1.0 (2021-02-10)
+
 * Introduce default rules
 * Introduce rails rules
 * Introduce rspec rules

data/README.md

@@ -1,4 +1,5 @@
 # Cobalt RuboCop
+
 [![Gem Version](https://badge.fury.io/rb/cobalt-rubocop.svg)](https://badge.fury.io/rb/cobalt-rubocop)
 [![GitHub License](https://img.shields.io/github/license/cobalthq/cobalt-rubocop.svg)](https://github.com/cobalthq/cobalt-rubocop/blob/main/LICENSE)
 ![Gem Downloads](https://img.shields.io/gem/dt/cobalt-rubocop)
@@ -9,29 +10,35 @@ This repository provides recommended linting rules for Ruby repositories.
 ## Installation
 
 ### Gemfile
+
 #### Add
-  ```ruby
-  group :development do
-    gem 'cobalt-rubocop', require: false
-  end
-  ```
+
+```ruby
+group :development do
+  gem 'cobalt-rubocop', require: false
+end
+```
 
 #### Remove
-  ```ruby
-  gem 'rubocop', require: false
-  gem 'rubocop-performance', require: false
-  gem 'rubocop-rails', require: false
-  gem 'rubocop-rspec', require: false
-  ```
 
-  [Specific versions](https://github.com/cobalthq/cobalt-rubocop/blob/main/cobalt-rubocop.gemspec) installed for:
-  - [rubocop](https://github.com/rubocop-hq/rubocop)
-  - [rubocop-performance](https://github.com/rubocop/rubocop-performance)
-  - [rubocop-rails](https://github.com/rubocop/rubocop-rails)
-  - [rubocop-rspec](https://github.com/rubocop/rubocop-rspec)
+```ruby
+gem 'rubocop', require: false
+gem 'rubocop-performance', require: false
+gem 'rubocop-rails', require: false
+gem 'rubocop-rspec', require: false
+```
+
+[Specific versions](https://github.com/cobalthq/cobalt-rubocop/blob/main/cobalt-rubocop.gemspec) installed for:
+
+- [rubocop](https://github.com/rubocop-hq/rubocop)
+- [rubocop-performance](https://github.com/rubocop/rubocop-performance)
+- [rubocop-rails](https://github.com/rubocop/rubocop-rails)
+- [rubocop-rspec](https://github.com/rubocop/rubocop-rspec)
 
 ### .rubocop.yml
+
 Configuration Options:
+
 ```yaml
 inherit_gem:
   cobalt-rubocop:
@@ -60,10 +67,13 @@ grep "Offense count" .rubocop_todo.yml | awk -F: '{sum+=$2} END {print sum}'
 ```
 
 ## Custom Cops
+
 ### InsecureHashAlgorithm
+
 See [Ruby Docs](https://ruby-doc.org/stdlib-2.7.2/libdoc/openssl/rdoc/OpenSSL/Digest.html) for built in hash functions.
 
 - Default Configuration:
+
   ```yml
   Cobalt/InsecureHashAlgorithm:
     Allowed:
@@ -86,24 +96,30 @@ See [Ruby Docs](https://ruby-doc.org/stdlib-2.7.2/libdoc/openssl/rdoc/OpenSSL/Di
   ```
 
 ## Development
+
 ```shell
 git clone git@github.com:cobalthq/cobalt-rubocop.git
 bundle install
 ```
 
 ### Testing locally
+
 In your application, use the `path` attribute to point to your local copy of the gem
+
 ```ruby
   # Use the relative path from your application, to the cobalt-rubocop folder
   gem 'cobalt-rubocop', path: '../cobalt-rubocop', require: false
 ```
 
 Alternatively:
+
 - `rake build`
 - `gem install pkg/cobalt-rubocop-<version_number>.gem`
 
 ## Publish (internal)
+
 > Note: Publishing a new version of this gem is only meant for maintainers.
+
 - Ensure you have access to publish on [rubygems](https://rubygems.org/gems/cobalt-rubocop).
 - Update [CHANGELOG](https://github.com/cobalthq/cobalt-rubocop/blob/main/CHANGELOG.md).
 - Update [`VERSION`](https://github.com/cobalthq/cobalt-rubocop/blob/main/lib/rubocop/cobalt/version.rb).

data/config/default.yml

@@ -5,8 +5,8 @@ require:
 AllCops:
   NewCops: enable
 
-Naming/MethodName:
-  EnforcedStyle: snake_case
+Cobalt/InsecureHashAlgorithm:
+  Enabled: true
 
 Layout/ArgumentAlignment:
   EnforcedStyle: with_fixed_indentation
@@ -17,12 +17,12 @@ Layout/DotPosition:
 Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
+
 Layout/LineLength:
   Enabled: false
 
-Layout/ParameterAlignment:
-  EnforcedStyle: with_fixed_indentation
-
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
@@ -32,14 +32,17 @@ Layout/MultilineOperationIndentation:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
-Layout/FirstHashElementIndentation:
-  EnforcedStyle: consistent
+Layout/ParameterAlignment:
+  EnforcedStyle: with_fixed_indentation
+
+Metrics/AbcSize:
+  Enabled: false
 
 Metrics/MethodLength:
   Max: 20
 
-Metrics/AbcSize:
-  Enabled: false
+Naming/MethodName:
+  EnforcedStyle: snake_case
 
 Style/ClassAndModuleChildren:
   EnforcedStyle: nested
@@ -59,8 +62,17 @@ Style/HashSyntax:
 Style/IfUnlessModifier:
   Enabled: false
 
-Cobalt/InsecureHashAlgorithm:
-  Enabled: true
-
 Style/MutableConstant:
   Enabled: false
+
+Style/RedundantConstantBase:
+  Enabled: false
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma

data/config/rspec.yml

@@ -8,14 +8,15 @@ Metrics/BlockLength:
 RSpec/ExampleLength:
   Enabled: false
 
+RSpec/IndexedLet:
+  Enabled: false
+
+RSpec/Rails/InferredSpecType:
+  Enabled: false
+
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-RSpec/VariableName:
-  AllowedPatterns:
-    - ^Authorization
-    - '\[\]$' # For array parameters in rswag like `let(:'<parameter_name>[]')`
-
 RSpec/MultipleMemoizedHelpers:
   Max: 17
 
@@ -24,3 +25,8 @@ RSpec/NamedSubject:
 
 RSpec/NestedGroups:
   Max: 5
+
+RSpec/VariableName:
+  AllowedPatterns:
+    - ^Authorization
+    - '\[\]$' # For array parameters in rswag like `let(:'<parameter_name>[]')`

data/lib/rubocop/cobalt/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Cobalt
-    VERSION = '0.9.0'
+    VERSION = '1.0.0'
   end
 end

data/lib/rubocop/cop/cobalt/insecure_hash_algorithm.rb

@@ -103,16 +103,18 @@ module RuboCop
           add_offense(const_node, message: default_message) if insecure_const?(const_node) && !digest_uuid?(const_node)
         end
 
+        # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def on_send(send_node)
           if uuid_v3?(send_node) && !allowed_hash_functions.include?('md5')
             add_offense(send_node, message: "uuid_v3 uses MD5, which is not allowed. Prefer: #{allowed_hash_functions.join(', ')}")
           elsif uuid_v5?(send_node) && !allowed_hash_functions.include?('sha1')
             add_offense(send_node, message: "uuid_v5 uses SHA1, which is not allowed. Prefer: #{allowed_hash_functions.join(', ')}")
-          elsif openssl_hmac_new?(send_node) && openssl_hmac_new_insecure?(send_node) ||
+          elsif (openssl_hmac_new?(send_node) && openssl_hmac_new_insecure?(send_node)) ||
               insecure_digest?(send_node) || insecure_hash_lookup?(send_node)
             add_offense(send_node, message: default_message)
           end
         end
+        # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
         def default_message
           "This hash function is not allowed. Prefer: #{allowed_hash_functions.join(', ')}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cobalt-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Cobalt Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-21 00:00:00.000000000 Z
+date: 2023-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.10'
 description: Ruby code linting for Cobalt Ruby repositories
-email: 
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -104,7 +104,7 @@ metadata:
   source_code_uri: https://github.com/cobalthq/cobalt-rubocop
   changelog_uri: https://github.com/cobalthq/cobalt-rubocop/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -112,15 +112,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.5.0
+      version: 3.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.4.12
+signing_key:
 specification_version: 4
 summary: Cobalt RuboCop
 test_files: []