coaster 1.4.38 → 1.4.39

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d69bb86707fa932dcc3782453f4a1eaf5a0f6affb00ae4ad7cb512af8ee5502b
-  data.tar.gz: afdd5fee8f322409b3ab0a67c735172d7afadeb243831d5ecc7e759b6381f1f6
+  metadata.gz: db3e3c711b051a059c028d9de5543c55ea1db20e5134b790308a310357d04780
+  data.tar.gz: 75f518e585672bca7c8f84c034b4bbc92e3bb330126d6aebc8c867558a1f7396
 SHA512:
-  metadata.gz: 57bde1aabfa65503fbdfbc57e9c6c36d673fcd99838dcf914717ce5e09b70be5c4620ee9e3bdc0bb707f02b236cfc0e5cbade535d776bdf3aebab53bddae3ac9
-  data.tar.gz: 01da4d3b757a1cba48acdeda80bd3cd6adf0cb0b5f65f5f7592db9fde8b0465680f461467928d69b4870ecc4e780c8174f374598ace29dbe96cd52a441540d16
+  metadata.gz: a529d3b506a6ba67c320314746580007cdd5ff9912acdf4989581e8b622fdf6386e9bed1da388a192345bbbf306d705ff6a133b26c77aac601709906ffc39d32
+  data.tar.gz: d48154a8d863cd647a525fa9a3e2e4288d47daf43528f28f9f954092161beb3b4e2ab7ef16f5e77455337f502b1716a10d3a578ff049f04ad8aa1b1a56dc1108

data/lib/coaster/serialized_properties.rb

@@ -27,7 +27,6 @@ module Coaster
             setting = self.class.serialized_property_setting(key)
             return unless setting
             col = setting[:column]
-            send("#{col}_will_change!")
             hsh = send(col)
             if value.nil?
               hsh.delete(key.to_s)
@@ -312,7 +311,6 @@ module Coaster
       if is_active_record
         define_method "#{key}_without_callback=".to_sym do |val|
           col = serialize_column
-          send("#{col}_will_change!")
           hsh = send(col)
           if val.nil?
             hsh.delete(key.to_s)

data/lib/coaster/version.rb

@@ -1,3 +1,3 @@
 module Coaster
-  VERSION = '1.4.38'
+  VERSION = '1.4.39'
 end

data/test/test_serialized_property_dirty.rb

@@ -0,0 +1,142 @@
+require 'test_helper'
+require 'minitest/autorun'
+
+module Coaster
+  class TestSerializedProperty < Minitest::Test
+    def setup
+    end
+
+    def teardown
+    end
+
+    def test_dirty
+      user = User.create(name: 'abc')
+      mother = User.create(name: 'mother')
+      user.mother = mother
+      assert_equal mother, user.mother
+      assert_equal mother.id, user.mother_id
+      assert_equal({"mother_id"=>mother.id}, user.data)
+      assert_equal({"data" => [{}, {"mother_id"=>mother.id}]}, user.changes)
+      assert_equal({"mother_id" => [nil, mother.id]}, user.sprop_changes)
+      assert_equal(true, user.mother_id_changed?)
+      assert_equal(nil, user.mother_id_was)
+      user.save!
+      user = User.find(user.id)
+      user.mother_id = mother.id
+      assert_equal(false, user.mother_id_changed?)
+      assert_equal({}, user.changes)
+      step_mother = User.create(name: 'step_mother')
+      user.mother = step_mother
+      assert_equal({"data" => [{"mother_id" => mother.id}, {"mother_id" => step_mother.id}]}, user.changes)
+      assert_equal({"mother_id" => [mother.id, step_mother.id]}, user.sprop_changes)
+    end
+
+    # Tests for dirty tracking optimization (skip dirty marking when value unchanged)
+    def test_same_value_setter_does_not_mark_dirty
+      user = User.create(name: 'test_same_value')
+      user.simple = 'initial_value'
+      user.save!
+
+      # Reload to clear dirty state
+      user.reload
+      assert_equal false, user.changed?
+
+      # Set same value - should NOT mark dirty
+      user.simple = 'initial_value'
+      assert_equal false, user.simple_changed?, 'Setting same value should not mark property as changed'
+      assert_equal false, user.changed?, 'Setting same value should not mark record as changed'
+    end
+
+    def test_different_value_setter_marks_dirty
+      user = User.create(name: 'test_different_value')
+      user.simple = 'initial_value'
+      user.save!
+      user.reload
+
+      # Set different value - should mark dirty
+      user.simple = 'new_value'
+      assert_equal true, user.simple_changed?, 'Setting different value should mark property as changed'
+      assert_equal true, user.changed?, 'Setting different value should mark record as changed'
+      assert_equal ['initial_value', 'new_value'], user.simple_change
+    end
+
+    def test_nil_to_value_marks_dirty
+      user = User.create(name: 'test_nil_to_value')
+      user.save!
+      user.reload
+
+      assert_nil user.simple
+      user.simple = 'some_value'
+      assert_equal true, user.simple_changed?
+      assert_equal [nil, 'some_value'], user.simple_change
+    end
+
+    def test_value_to_nil_marks_dirty
+      user = User.create(name: 'test_value_to_nil')
+      user.simple = 'some_value'
+      user.save!
+      user.reload
+
+      user.simple = nil
+      assert_equal true, user.simple_changed?
+      assert_equal ['some_value', nil], user.simple_change
+    end
+
+    def test_nil_to_nil_does_not_mark_dirty
+      user = User.create(name: 'test_nil_to_nil')
+      user.save!
+      user.reload
+
+      assert_nil user.simple
+      user.simple = nil
+      assert_equal false, user.simple_changed?, 'Setting nil to nil should not mark as changed'
+      assert_equal false, user.changed?
+    end
+
+    def test_same_value_via_write_attribute_does_not_mark_dirty
+      user = User.create(name: 'test_write_attr_same')
+      user.write_attribute(:simple, 'initial')
+      user.save!
+      user.reload
+
+      user.write_attribute(:simple, 'initial')
+      assert_equal false, user.simple_changed?
+      assert_equal false, user.changed?
+    end
+
+    def test_same_value_via_bracket_accessor_does_not_mark_dirty
+      user = User.create(name: 'test_bracket_same')
+      user[:simple] = 'initial'
+      user.save!
+      user.reload
+
+      user[:simple] = 'initial'
+      assert_equal false, user.simple_changed?
+      assert_equal false, user.changed?
+    end
+
+    def test_same_value_with_setter_proc_does_not_mark_dirty
+      student = Student.create(name: 'test_setter_same')
+      student.uppercase_name = 'hello'  # Stored as 'HELLO'
+      student.save!
+      student.reload
+
+      # Setting same raw input - setter transforms to same value
+      student.uppercase_name = 'hello'
+      assert_equal false, student.uppercase_name_changed?, 'Same value after setter transform should not mark dirty'
+      assert_equal false, student.changed?
+    end
+
+    def test_different_case_with_setter_proc_marks_dirty
+      student = Student.create(name: 'test_setter_diff')
+      student.uppercase_name = 'hello'  # Stored as 'HELLO'
+      student.save!
+      student.reload
+
+      # Setting different value
+      student.uppercase_name = 'world'  # Stored as 'WORLD'
+      assert_equal true, student.uppercase_name_changed?
+      assert_equal ['HELLO', 'WORLD'], student.uppercase_name_change
+    end
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: coaster
 version: !ruby/object:Gem::Version
-  version: 1.4.38
+  version: 1.4.39
 platform: ruby
 authors:
 - buzz jung
 bindir: bin
 cert_chain: []
-date: 2025-12-10 00:00:00.000000000 Z
+date: 2025-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -234,6 +234,7 @@ files:
 - test/test_month.rb
 - test/test_object_translation.rb
 - test/test_serialized_property.rb
+- test/test_serialized_property_dirty.rb
 - test/test_standard_error.rb
 - test/test_string.rb
 - test/test_util.rb
@@ -257,7 +258,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A little convenient feature for standard library
 test_files:
@@ -277,6 +278,7 @@ test_files:
 - test/test_month.rb
 - test/test_object_translation.rb
 - test/test_serialized_property.rb
+- test/test_serialized_property_dirty.rb
 - test/test_standard_error.rb
 - test/test_string.rb
 - test/test_util.rb