coaster 1.0.4 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1efdff11e3158914f521590fb64642e9c1834987317b896db24896c31e772bcf
-  data.tar.gz: 3fcdb6480424ddcc27cc50c0568e6b8d9967bf494f8118d174d82e9072c03974
+  metadata.gz: c38985e1f47460405cf2cf2e4f9507d78dd0db1f45d939ad5768269f1e2a6e7a
+  data.tar.gz: 5fcefde9af96868f10520648de4d775f58282d42d33e07e8abbbd76806328a93
 SHA512:
-  metadata.gz: 270b1faeeae2fe9fcccd3e0f2c4d9d8234c7d0288ee949ea29b7faac70e711e5394b2cb06b14da11a6e71fe770c46416e9e8e10fadca2303470171986e6a3911
-  data.tar.gz: c895e44a856beae32d2b46f09547d5c69aba008a46581ee096f9b069e6909251574f6dccf62f899fa3e51771e48acc1ad601f0a46e07a87cb5c8e59b706ea1f4
+  metadata.gz: d682e58f09d22aff8992360821e7dffc4a02c057882fb9ba9b9603631d76600c591016c1543b2e561190b9c91354049bfeb907c663abe3523b22d1cfc53b0579
+  data.tar.gz: f5e73571a6ede546e38c34c2145c96b3832888cc642bdc60c15e61ac5f91241359e66a5387b501c2f60b0c6153fdc1fb9facff4caf1ff98dfde35e4b2c1ea769

data/lib/coaster.rb

@@ -5,7 +5,7 @@ require 'active_support/core_ext/string'
 require 'active_support/core_ext/hash/slice'
 
 module Coaster
-  mattr_accessor :logger
+  mattr_writer   :logger
   mattr_writer   :default_fingerprint
 
   DEFAULT_FINGERPRINT = [:default, :class].freeze
@@ -18,6 +18,16 @@ module Coaster
     def default_fingerprint
       @@default_fingerprint ||= DEFAULT_FINGERPRINT
     end
+
+    def logger
+      return @@logger if defined?(@@logger)
+      return Rails.logger if defined?(Rails)
+      nil
+    end
+  end
+
+  def logger
+    self.class.logger
   end
 end
 

data/lib/coaster/core_ext/object_translation.rb

@@ -4,7 +4,7 @@ class Object
   class << self
     def _translate(*args)
       options = args.last.is_a?(Hash) ? args.pop : {}
-      options.merge!(_translate_params)
+      options = _translate_params.merge(options)
       options = options.to_hash.symbolize_keys!
 
       key = args.shift
@@ -45,7 +45,10 @@ class Object
 
         if key_class.superclass == Object || key_class == Object
           return options[:description] if options[:description].present?
-          Coaster.logger && Coaster.logger.warn(result)
+          if Coaster.logger 
+            Coaster.logger.info(options[:original_missing])
+            Coaster.logger.debug(caller.join("\n"))
+          end
           throw :exception, result if options[:original_throw]
           missing = options[:original_missing] || result
           msg = missing.message
@@ -61,6 +64,7 @@ class Object
         result = result.dup if result.frozen?
         result.instance_variable_set(:@translated, true)
         result.instance_variable_set(:@tkey, options[:tkey])
+        result.instance_variable_set(:@missing, options[:original_missing])
         result
       end
     end
@@ -78,16 +82,7 @@ class Object
   def _translate(*args)
     options = (args.last.is_a?(Hash) ? args.pop : {}).with_indifferent_access
     key = args.shift || (respond_to?(:tkey) ? tkey : nil)
-
-    if respond_to?(:description) && description.present? && description != 'false' && description != self.class.name
-      if !key.is_a?(String) && key != :force
-        desc = description
-        return desc unless desc.instance_variable_get(:@raw)
-      end
-      options.merge!(description: description)
-    end
-
-    options.merge!(_translate_params)
+    options = _translate_params.merge(options)
     self.class._translate(key, *args, options)
   end
 

data/lib/coaster/core_ext/standard_error.rb

@@ -4,18 +4,29 @@ class StandardError
   cattr_accessor :cleaner, :cause_cleaner
 
   class << self
-    def status
-      999999 # Unknown
-    end
+    def status; 999999 end # Unknown
     alias_method :code, :status
-
-    def http_status
-      500
+    def http_status;  500 end
+    def report?;      true end
+    def intentional?; false end
+    def title; _translate('.title') end
+
+    def before_logging(name, &block)
+      @before_logging_blocks ||= {}
+      @before_logging_blocks[name] = block
+    end
+    def before_logging_blocks
+      @before_logging_blocks ||= {}
+      superclass <= StandardError ? superclass.before_logging_blocks.merge(@before_logging_blocks) : @before_logging_blocks
     end
 
-    def title
-      t = _translate('.title')
-      t.instance_variable_defined?(:@missing) ? nil : t
+    def after_logging(name, &block)
+      @after_logging_blocks ||= {}
+      @after_logging_blocks[name] = block
+    end
+    def after_logging_blocks
+      @after_logging_blocks ||= {}
+      superclass <= StandardError ? superclass.after_logging_blocks.merge(@after_logging_blocks) : @after_logging_blocks
     end
   end
 
@@ -66,17 +77,11 @@ class StandardError
     super(msg)
   end
 
-  def safe_message
-    message || ''
-  end
-
-  def status
-    self.class.status
-  end
-
-  def title
-    attributes[:title] || self.class.title
-  end
+  def safe_message; message || '' end
+  def status;       self.class.status end
+  def before_logging_blocks; self.class.before_logging_blocks end
+  def after_logging_blocks; self.class.after_logging_blocks end
+  def root_cause;   cause.respond_to?(:root_cause) ? cause.root_cause : self end
 
   def attributes
     return @attributes if defined?(@attributes)
@@ -88,57 +93,51 @@ class StandardError
   end
   alias_method :attr, :attributes
 
-  def http_status
-    attributes[:http_status] || self.class.http_status
-  end
-
-  def http_status=(value)
-    attributes[:http_status] = value
-  end
-
+  def http_status;         attributes[:http_status] || self.class.http_status end
+  def http_status=(value); attributes[:http_status] = value end
+  def code;         attributes[:code] || status end
+  def code=(value); attributes[:code] = value end
+  def title;        attributes[:title] || self.class.title end
+  def it_might_happen?;      attributes[:it] == :might_happen      end
+  def it_should_not_happen?; attributes[:it] == :should_not_happen end
   def report?
-    attributes.key?(:report) ? attributes[:report] : true
+    return attributes[:report] if attributes.key?(:report)
+    return false if it_might_happen?
+    self.class.report?
   end
-
-  def intentional?
-    attributes[:intentional]
+  def intentional? # not logging in test
+    return attributes[:intentional] if attributes.key?(:intentional)
+    return true if it_should_not_happen?
+    self.class.intentional?
   end
+  def object;       attributes[:object] || attributes[:obj] end
+  alias_method :obj, :object
 
-  def code
-    attributes[:code] || status
+  # description is user friendly message as a attribute, do not use error's message
+  # error message is not user friendly in many cases.
+  def description
+    attributes[:description] || attributes[:desc]
   end
+  alias_method :desc, :description
 
-  def code=(value)
-    attributes[:code] = value
+  def _translate(*args)
+    return description if description.present?
+    super
   end
 
-  # description is user friendly messages, do not use error's message
-  # error message is not user friendly in many cases.
-  def description
-    dsc = attributes[:description] || attributes[:desc]
-    return dsc if dsc
-    msg = safe_message.dup
-    msg.instance_variable_set(:@raw, true)
-    msg
+  # user friendly message, for overid
+  def user_message
+    return description if description.present?
+    _translate
   end
-  alias_method :desc, :description
 
-  # more user friendly messages
+  # another user friendly messages
   def descriptions
     return attributes[:descriptions] if attributes[:descriptions]
     attributes[:descriptions] = {}
     attributes[:descriptions]
   end
 
-  def object
-    attributes[:object] || attributes[:obj]
-  end
-  alias_method :obj, :object
-
-  def root_cause
-    cause.respond_to?(:root_cause) ? cause.root_cause : self
-  end
-
   def to_hash
     hash = attributes.merge(
       type: self.class.name, status: status,
@@ -206,13 +205,17 @@ class StandardError
   end
 
   def logging(options = {})
-    return unless report?
-    logger = nil
-    if defined?(Rails)
-      return if Rails.env.test? && intentional?
-      logger = Rails.logger 
+    before_logging_blocks.values.each { |blk| instance_exec &blk }
+
+    if !report? || intentional?
+      if defined?(Rails)
+        return if Rails.env.test?
+      else
+        return
+      end
     end
-    logger = options[:logger] || Coaster.logger || logger
+
+    logger = options[:logger] || Coaster.logger
     return unless logger
 
     cl = options[:cleaner] || cleaner
@@ -230,5 +233,8 @@ class StandardError
     else
       logger.error(msg)
     end
+    msg
+  ensure
+    after_logging_blocks.values.each { |blk| instance_exec &blk }
   end
 end

data/lib/coaster/version.rb

@@ -1,3 +1,3 @@
 module Coaster
-  VERSION = '1.0.4'
+  VERSION = '1.1.0'
 end

data/test/locales/en.yml

@@ -1,5 +1,8 @@
 en:
   class:
+    StandardError: 
+      self: 'standard error translation'
+      title: 'standard error title'
     Coaster:
       self: 'Coaster Translated'
       SampleObject:

data/test/test_helper.rb

@@ -6,3 +6,12 @@ require 'pry'
 require 'rubygems'
 require 'bundler/setup'
 require 'coaster'
+require 'logger'
+
+class Raven
+  def self.capture_exception(*args)
+  end
+end
+
+Coaster.logger = Logger.new(STDOUT)
+Coaster.logger.level = Logger::WARN

data/test/test_object_translation.rb

@@ -37,6 +37,7 @@ module Coaster
     def test_translation_sub
       assert_equal 'Coaster SampleObject Title (class.Coaster.SampleObject.title)', SampleObject._translate('.title')
       assert_equal 'Coaster SampleObject Title (class.Coaster.SampleObject.title)', SampleObject._translate(:title)
+      assert_nil SampleObject._translate(:title).instance_variable_get(:@missing)
     end
 
     def test_translation_with_key
@@ -46,6 +47,7 @@ module Coaster
     def test_translation_inheritance
       assert_equal 'Coaster SampleObject Translated', Inherited._translate
       assert_equal 'Coaster SampleObject Title (class.Coaster.Inherited.title)', Inherited._translate(:title)
+      assert Inherited._translate.instance_variable_get(:@missing)
     end
 
     def test_interpolation

data/test/test_standard_error.rb

@@ -20,6 +20,57 @@ module Coaster
       I18n.enforce_available_locales = false
     end
 
+    def test_standard_messages
+      e = StandardError.new('asdf')
+      assert_equal 'asdf', e.message
+      assert_nil e.description
+      assert_nil e.desc
+      assert_equal 'standard error translation', e._translate
+      assert_equal 'standard error translation', e.user_message
+      assert_equal 'standard error title', e.title
+      e = StandardError.new(m: 'foo', desc: 'bar')
+      assert_equal 'foo', e.message
+      assert_equal 'bar', e.description
+      assert_equal 'bar', e.desc
+      assert_equal 'bar', e._translate
+      assert_equal 'bar', e.user_message
+      assert_equal 'standard error title', e.title
+    end
+
+    def test_no_translation_class
+      e = UntitledError.new('asdf')
+      assert_equal 'asdf', e.message
+      assert_nil e.description
+      assert_nil e.desc
+      assert_equal 'standard error translation', e._translate
+      assert_equal 'standard error translation', e.user_message
+      assert_equal 'standard error title', e.title
+      e = UntitledError.new(m: 'foo', desc: 'bar')
+      assert_equal 'foo', e.message
+      assert_equal 'bar', e.description
+      assert_equal 'bar', e.desc
+      assert_equal 'bar', e._translate
+      assert_equal 'bar', e.user_message
+      assert_equal 'standard error title', e.title
+    end
+
+    def test_with_translation_class
+      e = SampleError.new('asdf')
+      assert_equal 'asdf', e.message
+      assert_nil e.description
+      assert_nil e.desc
+      assert_equal 'Test sample error', e._translate
+      assert_equal 'Test sample error', e.user_message
+      assert_equal 'Test this title', e.title
+      e = SampleError.new(m: 'foo', desc: 'bar')
+      assert_equal 'foo', e.message
+      assert_equal 'bar', e.description
+      assert_equal 'bar', e.desc
+      assert_equal 'bar', e._translate
+      assert_equal 'bar', e.user_message
+      assert_equal 'Test this title', e.title
+    end
+
     def test_message
       raise SampleError, {m: 'beer is proof'}
     rescue => e
@@ -39,16 +90,16 @@ module Coaster
         raise ExampleError, {wat: 'cha'}
       end
     rescue => e
-      assert_equal e.to_hash['wat'], 'cha'
-      assert_equal e.to_hash['type'], 'Coaster::TestStandardError::ExampleError'
-      assert_equal e.to_hash['status'], 20
-      assert_equal e.to_hash['http_status'], 500
-      assert_equal e.to_hash['message'], 'Test sample error'
-      assert_equal e.to_hash['cause']['frog'], 'rams'
-      assert_equal e.to_hash['cause']['type'], 'Coaster::TestStandardError::SampleError'
-      assert_equal e.to_hash['cause']['status'], 10
-      assert_equal e.to_hash['cause']['http_status'], 500
-      assert_equal e.to_hash['cause']['message'], 'Test sample error'
+      assert_equal 'cha', e.to_hash['wat']
+      assert_equal 'Coaster::TestStandardError::ExampleError', e.to_hash['type']
+      assert_equal 20, e.to_hash['status']
+      assert_equal 500, e.to_hash['http_status']
+      assert_equal 'Test sample error', e.to_hash['message']
+      assert_equal 'rams', e.to_hash['cause']['frog']
+      assert_equal 'Coaster::TestStandardError::SampleError', e.to_hash['cause']['type']
+      assert_equal 10, e.to_hash['cause']['status']
+      assert_equal 500, e.to_hash['cause']['http_status']
+      assert_equal 'Test sample error', e.to_hash['cause']['message']
     end
 
     def test_cause_attributes
@@ -58,9 +109,9 @@ module Coaster
         raise ExampleError, {wat: 'cha'}
       end
     rescue => e
-      assert_equal e.cause.attr['frog'], 'rams'
-      assert_equal e.attr['frog'], 'rams'
-      assert_equal e.attr['wat'], 'cha'
+      assert_equal 'rams', e.cause.attr['frog']
+      assert_equal 'rams', e.attr['frog']
+      assert_equal 'cha', e.attr['wat']
     end
 
     def test_to_detail
@@ -94,19 +145,19 @@ LOG
     def test_translation
       raise SampleError, {tkey: '.test'}
     rescue => e
-      assert_equal e._translate, 'Test this translation'
+      assert_equal 'Test this translation', e._translate
     end
 
     def test_title
       raise SampleError, 'foobar'
     rescue => e
-      assert_equal e.title, 'Test this title'
+      assert_equal 'Test this title', e.title
     end
 
     def test_title_missing
       raise UntitledError, 'untitled'
     rescue => e
-      assert_nil e.title
+      assert_equal 'standard error title', e.title
     end
 
     def root_cause_sample1
@@ -129,31 +180,54 @@ LOG
       begin
         root_cause_sample3
       rescue => e
-        assert_equal e.root_cause.message, 'a'
+        assert_equal 'a', e.root_cause.message
       end
     end
 
     def test_raven_notes
       raise SampleError, m: 'foofoo', something: 'other'
     rescue => e
-      assert_equal e.notes(the_other: 'something')[:extra][:something], 'other'
-      assert_equal e.notes(the_other: 'something')[:extra][:the_other], 'something'
+      assert_equal 'other', e.notes(the_other: 'something')[:extra][:something]
+      assert_equal 'something', e.notes(the_other: 'something')[:extra][:the_other]
     end
 
     def test_to_hash
       aa # raise NameError
     rescue => e
-      assert_equal e.to_hash['type'], 'NameError'
-      assert_equal e.to_hash['status'], 999999
-      assert_equal e.to_hash['http_status'], 500
-      assert e.to_hash['message'] =~ /undefined local variable or method `aa'/
+      assert_equal 'NameError', e.to_hash['type']
+      assert_equal 999999, e.to_hash['status']
+      assert_equal 500, e.to_hash['http_status']
+      assert_match /undefined local variable or method `aa'/, e.to_hash['message']
     end
 
     def test_descriptions
       raise SampleError
     rescue => e
       e.descriptions.merge!(a: 1)
-      assert_equal e.descriptions['a'], 1
+      assert_equal 1, e.descriptions['a']
+    end
+
+    class SampleErrorSub < SampleError; end
+    class SampleErrorSubSub < SampleErrorSub
+      def it_might_happen?; true end
+    end
+    SampleError.after_logging(:blah) do 
+      self.attributes[:abc] = 100
+      @blah = 101
+    end
+    def test_before_logging
+      e = SampleErrorSubSub.new(m: 'foo')
+      assert !e.after_logging_blocks[:blah].nil?
+      e.logging
+      assert_equal 100, e.attributes[:abc]
+      assert_equal 101, e.instance_variable_get(:@blah)
+    end
+    class SampleErrorMightHappen < SampleErrorSub
+      def it_might_happen?; true end
+    end
+    def test_might_happen
+      e = SampleErrorMightHappen.new('fbar')
+      assert !e.report?
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coaster
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.1.0
 platform: ruby
 authors:
 - buzz jung
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-08 00:00:00.000000000 Z
+date: 2020-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -226,7 +226,7 @@ signing_key:
 specification_version: 4
 summary: A little convenient feature for standard library
 test_files:
-- test/test_helper.rb
-- test/test_standard_error.rb
-- test/locales/en.yml
 - test/test_object_translation.rb
+- test/locales/en.yml
+- test/test_standard_error.rb
+- test/test_helper.rb