coaster 1.0.2 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 388b2f2f69156f7344ddd198dc1a68a6a41c886db2dc23b881576ca06e48ad80
-  data.tar.gz: 45e1be2338d2fb185bfa6c7652d0e82a0342a961911503f6af133b0bfbcf6c66
+  metadata.gz: ca45b5184489708bdeeb0381f2d540576f1b58cc324b3dca4f5bd698f021c687
+  data.tar.gz: 69ab2837c8159634389fefc993503c130bb8e14efcda3a2621646d909a3f9a4f
 SHA512:
-  metadata.gz: d35ee060873032921e4c165e529b99314e1115c083c3d616b5250975819c536f47df1b3c0de40272a990414273910f427013e5ff2d2705f3d807c87fd7cbf617
-  data.tar.gz: ccbd4fca13b51857c45ea9e5772375bc2019ba3cfcb5c730c54981618205a50f6e2f6bbfd2f51c2582977ad61703d19a70cd7ca71a0d4c382c7d5790c15f8c3c
+  metadata.gz: 417805608b285316128c95f4aadaa83d26ab9f2666e0273e1ee987baca5b4d346596dd0d1d8de925f7273bf6a4ee3ac057ceaf43c6213874b025e9df51533c5f
+  data.tar.gz: 795b2a27aaadf52aad1e6f723397dc13be68e3cd7028ca5c1a982cd9dda6cbe92d688ea4324ed72fd609274993c91c29978bf0d2ecc52bad7b4d6a82c68b4341

data/lib/coaster/core_ext/object_translation.rb

@@ -39,13 +39,13 @@ class Object
       end
 
       if result.is_a?(I18n::MissingTranslation)
-        Coaster.logger && Coaster.logger.warn(result)
         unless options.key?(:original_missing)
           options.merge!(original_missing: result)
         end
 
         if key_class.superclass == Object || key_class == Object
           return options[:description] if options[:description].present?
+          Coaster.logger && Coaster.logger.warn(result)
           throw :exception, result if options[:original_throw]
           missing = options[:original_missing] || result
           msg = missing.message

data/lib/coaster/core_ext/standard_error.rb

@@ -4,19 +4,34 @@ class StandardError
   cattr_accessor :cleaner, :cause_cleaner
 
   class << self
-    def status
-      999999 # Unknown
-    end
+    def status; 999999 end # Unknown
     alias_method :code, :status
-
-    def http_status
-      500
-    end
+    def http_status;  500 end
+    def report?;      true end
+    def intentional?; false end
 
     def title
       t = _translate('.title')
       t.instance_variable_defined?(:@missing) ? nil : t
     end
+
+    def before_logging(name, &block)
+      @before_logging_blocks ||= {}
+      @before_logging_blocks[name] = block
+    end
+    def before_logging_blocks
+      @before_logging_blocks ||= {}
+      superclass <= StandardError ? superclass.after_logging_blocks.merge(@before_logging_blocks) : @before_logging_blocks
+    end
+
+    def after_logging(name, &block)
+      @after_logging_blocks ||= {}
+      @after_logging_blocks[name] = block
+    end
+    def after_logging_blocks
+      @after_logging_blocks ||= {}
+      superclass <= StandardError ? superclass.after_logging_blocks.merge(@after_logging_blocks) : @after_logging_blocks
+    end
   end
 
   attr_accessor :tags, :level, :tkey, :fingerprint
@@ -66,17 +81,11 @@ class StandardError
     super(msg)
   end
 
-  def safe_message
-    message || ''
-  end
-
-  def status
-    self.class.status
-  end
-
-  def title
-    attributes[:title] || self.class.title
-  end
+  def safe_message; message || '' end
+  def status;       self.class.status end
+  def before_logging_blocks; self.class.before_logging_blocks end
+  def after_logging_blocks; self.class.after_logging_blocks end
+  def root_cause;   cause.respond_to?(:root_cause) ? cause.root_cause : self end
 
   def attributes
     return @attributes if defined?(@attributes)
@@ -88,21 +97,25 @@ class StandardError
   end
   alias_method :attr, :attributes
 
-  def http_status
-    attributes[:http_status] || self.class.http_status
-  end
-
-  def http_status=(value)
-    attributes[:http_status] = value
-  end
-
-  def code
-    attributes[:code] || status
-  end
-
-  def code=(value)
-    attributes[:code] = value
-  end
+  def http_status;         attributes[:http_status] || self.class.http_status end
+  def http_status=(value); attributes[:http_status] = value end
+  def code;         attributes[:code] || status end
+  def code=(value); attributes[:code] = value end
+  def title;        attributes[:title] || self.class.title end
+  def it_might_happen?;      attributes[:it] == :might_happen      end
+  def it_should_not_happen?; attributes[:it] == :should_not_happen end
+  def report?
+    return attributes[:report] if attributes.key?(:report)
+    return false if it_might_happen?
+    self.class.report?
+  end
+  def intentional? # not logging in test
+    return attributes[:intentional] if attributes.key?(:intentional)
+    return true if it_should_not_happen?
+    self.class.intentional?
+  end
+  def object;       attributes[:object] || attributes[:obj] end
+  alias_method :obj, :object
 
   # description is user friendly messages, do not use error's message
   # error message is not user friendly in many cases.
@@ -115,13 +128,11 @@ class StandardError
   end
   alias_method :desc, :description
 
-  def object
-    attributes[:object] || attributes[:obj]
-  end
-  alias_method :obj, :object
-
-  def root_cause
-    cause.respond_to?(:root_cause) ? cause.root_cause : self
+  # more user friendly messages
+  def descriptions
+    return attributes[:descriptions] if attributes[:descriptions]
+    attributes[:descriptions] = {}
+    attributes[:descriptions]
   end
 
   def to_hash
@@ -191,16 +202,25 @@ class StandardError
   end
 
   def logging(options = {})
-    logger = options[:logger] || Coaster.logger
-    logger = Rails.logger if logger.nil? && defined?(Rails)
-    return nil unless logger
+    before_logging_blocks.values.each { |blk| instance_exec &blk }
+
+    return unless report?
+    logger = nil
+    if defined?(Rails)
+      return if Rails.env.test? && intentional?
+      logger = Rails.logger 
+    end
+    logger = options[:logger] || Coaster.logger || logger
+    return unless logger
 
     cl = options[:cleaner] || cleaner
     msg = to_detail
 
     if cl && backtrace
+      bt = cl.clean(backtrace)
+      bt = bt[0..2] if intentional?
       msg += "\tBACKTRACE:\n\t"
-      msg += cl.clean(backtrace).join("\n\t")
+      msg += bt.join("\n\t")
     end
 
     if level && logger.respond_to?(level)
@@ -208,5 +228,7 @@ class StandardError
     else
       logger.error(msg)
     end
+
+    after_logging_blocks.values.each { |blk| instance_exec &blk }
   end
 end

data/lib/coaster/core_ext/standard_error/raven.rb

@@ -38,7 +38,7 @@ class StandardError
 
   def capture(options = {})
     return if options.key?(:report) && !options[:report]
-    return if attributes.key?(:report) && !attributes[:report]
+    return unless report?
     nt = notes(options)
     Raven.capture_exception(self, level: nt[:level]) do |event|
       event.user.merge!(nt[:user] || {})

data/lib/coaster/version.rb

@@ -1,3 +1,3 @@
 module Coaster
-  VERSION = '1.0.2'
+  VERSION = '1.0.7'
 end

data/test/test_helper.rb

@@ -6,3 +6,8 @@ require 'pry'
 require 'rubygems'
 require 'bundler/setup'
 require 'coaster'
+
+class Raven
+  def self.capture_exception(*args)
+  end
+end

data/test/test_standard_error.rb

@@ -148,5 +148,33 @@ LOG
       assert_equal e.to_hash['http_status'], 500
       assert e.to_hash['message'] =~ /undefined local variable or method `aa'/
     end
+
+    def test_descriptions
+      raise SampleError
+    rescue => e
+      e.descriptions.merge!(a: 1)
+      assert_equal e.descriptions['a'], 1
+    end
+
+    class SampleErrorSub < SampleError; end
+    class SampleErrorSubSub < SampleErrorSub; end
+    SampleError.after_logging(:blah) do 
+      self.attributes[:abc] = 100
+      @blah = 101
+    end
+    def test_before_logging
+      e = SampleErrorSubSub.new(m: 'foo')
+      assert !e.after_logging_blocks[:blah].nil?
+      e.logging
+      assert_equal e.attributes[:abc], 100
+      assert_equal e.instance_variable_get(:@blah), 101
+    end
+    class SampleErrorMightHappen < SampleErrorSub
+      def it_might_happen?; true end
+    end
+    def test_might_happen
+      e = SampleErrorMightHappen.new('fbar')
+      assert !e.report?
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coaster
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.7
 platform: ruby
 authors:
 - buzz jung
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-10 00:00:00.000000000 Z
+date: 2020-09-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -226,7 +226,7 @@ signing_key:
 specification_version: 4
 summary: A little convenient feature for standard library
 test_files:
+- test/test_object_translation.rb
 - test/locales/en.yml
 - test/test_standard_error.rb
 - test/test_helper.rb
-- test/test_object_translation.rb