coach 2.2.2 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 276731375be178d95795d5e004e395c1412272b287758e5b63939470a79cfcd3
-  data.tar.gz: fcecdd27c44dae3f26a8a6cc8d989e5267d6efda0f43432a2552d96666db90c8
+  metadata.gz: abbb55ace2b77bfa43bdac156e34fb30ccb37f3ace7ce76a7afb660f4fae754c
+  data.tar.gz: 1d730de41dfcb77e8d6b858f7fa4d0c7f48998e7bc8527d2e7ad2c0951f88b41
 SHA512:
-  metadata.gz: b42530f66daf019dd4a059615816da2f515c97c1464ee83d646b6ac28e5d8de8e632b4552cabaa17309a17b0066bd21526cc0199fcf36b1bac92ab983dd50239
-  data.tar.gz: 9f1b41f7b0a507738f2224606bb94bc60db8ac3679895b4b15fe92080d591e98238f468e01a61b51473a30a10629528edacb68ec2e4c37deb1d2e2179a66656c
+  metadata.gz: 433ee2ebb1f528ce6e599b6dca9a3eb2ab2f4766860d7053b5c8f896d721a04df460f5b4f2073efd54823d101201ae87be36cb57932a2dd641ae0a7c1eb35e80
+  data.tar.gz: bca365dfbab5ef5f1724a214498e521e0a1d9d21fc10e79cb8ac88be247d20fe1ea0ade9d6927e914bd33a24065f3f4873ecf12109ea09969d8795413196de02

data/CHANGELOG.md

@@ -2,7 +2,9 @@
 
 # Unreleased
 
-No unreleased changes.
+# 2.3.0 / 2020-04-29
+
+* [#90](https://github.com/gocardless/coach/pull/90) Instrument status `0` instead of `500` when Coach::Handler catches an exception
 
 # 2.2.1 / 2020-02-06
 

data/coach.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "activesupport", ">= 4.2"
   spec.add_dependency "commander", "~> 4.5"
 
-  spec.add_development_dependency "gc_ruboconfig", "= 2.9.0"
+  spec.add_development_dependency "gc_ruboconfig", "= 2.12.0"
   spec.add_development_dependency "pry", "~> 0.10"
   spec.add_development_dependency "rspec", "~> 3.2"
   spec.add_development_dependency "rspec-its", "~> 1.2"

data/lib/coach/handler.rb

@@ -5,7 +5,7 @@ require "active_support/core_ext/object/try"
 
 module Coach
   class Handler
-    STATUS_CODE_FOR_EXCEPTIONS = 500
+    STATUS_CODE_FOR_EXCEPTIONS = 0
 
     def initialize(middleware, config = {})
       @root_item = MiddlewareItem.new(middleware, config)
@@ -34,6 +34,8 @@ module Coach
       instrument("finish_handler.coach", event) do
         begin
           response = chain.instrument.call
+        rescue StandardError => e
+          raise
         ensure
           # We want to populate the response and metadata fields after the middleware
           # chain has completed so that the end of the instrumentation can see them. The
@@ -43,7 +45,10 @@ module Coach
           # This way, the last finish_handler.coach event will have all the details.
           status = response.try(:first) || STATUS_CODE_FOR_EXCEPTIONS
           event.merge!(
-            response: { status: status },
+            response: {
+              status: status,
+              exception: e,
+            }.compact,
             metadata: context.fetch(:_metadata, {}),
           )
         end

data/lib/coach/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Coach
-  VERSION = "2.2.2"
+  VERSION = "2.3.0"
 end

data/spec/lib/coach/handler_spec.rb

@@ -85,10 +85,10 @@ describe Coach::Handler do
 
         before { terminal_middleware.uses(middleware_a, callback: explosive_action) }
 
-        it "captures the error event with the metadata" do
+        it "captures the error event with the metadata and nil status" do
           expect(coach_events).
             to include(["finish_handler.coach", hash_including(
-              response: { status: 500 },
+              response: { status: 0, exception: instance_of(RuntimeError) },
               metadata: { A: true },
             )])
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coach
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.3.0
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-14 00:00:00.000000000 Z
+date: 2020-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.0
+        version: 2.12.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.9.0
+        version: 2.12.0
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -185,7 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Alternative controllers built with middleware