coach 2.2.1 → 2.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b69c1a3041e520ebf876b90ce472ab23c579fa93fe53c69692a6d3c0e553d918
-  data.tar.gz: ba41cb38a04d6756e5153383010173a353211ce31bdcf19df82d62c808647db8
+  metadata.gz: 276731375be178d95795d5e004e395c1412272b287758e5b63939470a79cfcd3
+  data.tar.gz: fcecdd27c44dae3f26a8a6cc8d989e5267d6efda0f43432a2552d96666db90c8
 SHA512:
-  metadata.gz: e4480d684b2ed592ebd33ee1b5463fc5a981fabd50805e3575da99be51950b962fae5265bdc4a08d1ec2837a39509c22b3e6b95198b1d3705a4fa1590b3599fe
-  data.tar.gz: 4f5e2c69d1b4ae613ae030f859580546bd7d364d9df421b546bce5aaeffdf899a8d48c397a8bc6b9a545d88540703752e0b475a6b3092df4e898bc53ade013c1
+  metadata.gz: b42530f66daf019dd4a059615816da2f515c97c1464ee83d646b6ac28e5d8de8e632b4552cabaa17309a17b0066bd21526cc0199fcf36b1bac92ab983dd50239
+  data.tar.gz: 9f1b41f7b0a507738f2224606bb94bc60db8ac3679895b4b15fe92080d591e98238f468e01a61b51473a30a10629528edacb68ec2e4c37deb1d2e2179a66656c

data/bin/coach

@@ -1,6 +1,7 @@
 #!/usr/bin/env ruby
 
 require "coach/cli/provider_finder"
+require "coach/version"
 require "commander"
 
 module Coach

data/lib/coach/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Coach
-  VERSION = "2.2.1"
+  VERSION = "2.2.2"
 end

data/spec/lib/coach/cli/provider_finder_spec.rb

@@ -201,7 +201,7 @@ describe Coach::Cli::ProviderFinder do
         expect(provider_finder.find_chain).
           to eq([
             %w[FirstProvidingMiddleware FirstIntermediateMiddleware RequiringMiddleware],
-            %w[SecondProvidingMiddleware SecondIntermediateMiddleware RequiringMiddleware], # rubocop:disable Metrics/LineLength
+            %w[SecondProvidingMiddleware SecondIntermediateMiddleware RequiringMiddleware], # rubocop:disable Layout/LineLength
           ].to_set)
       end
     end

data/spec/lib/coach/handler_spec.rb

@@ -19,19 +19,84 @@ describe Coach::Handler do
   before { Coach::Notifications.unsubscribe! }
 
   describe "#call" do
-    let(:a_double) { double }
-    let(:b_double) { double }
+    context "with multiple middleware" do
+      let(:a_double) { double }
+      let(:b_double) { double }
 
-    before do
-      terminal_middleware.uses(middleware_a, callback: a_double)
-      terminal_middleware.uses(middleware_b, callback: b_double)
+      before do
+        terminal_middleware.uses(middleware_a, callback: a_double)
+        terminal_middleware.uses(middleware_b, callback: b_double)
+      end
+
+      it "invokes all middleware in the chain" do
+        expect(a_double).to receive(:call)
+        expect(b_double).to receive(:call)
+        result = handler.call({})
+        expect(result).to eq(%w[A{} B{} Terminal{:handler=>true}])
+      end
     end
 
-    it "invokes all middleware in the chain" do
-      expect(a_double).to receive(:call)
-      expect(b_double).to receive(:call)
-      result = handler.call({})
-      expect(result).to eq(%w[A{} B{} Terminal{:handler=>true}])
+    describe "notifications" do
+      subject(:coach_events) do
+        events = []
+        subscription = ActiveSupport::Notifications.
+          subscribe(/\.coach$/) { |name, *_args| events << name }
+
+        handler.call({})
+        ActiveSupport::Notifications.unsubscribe(subscription)
+        events
+      end
+
+      before do
+        terminal_middleware.uses(middleware_a)
+
+        Coach::Notifications.subscribe!
+
+        # Prevent RequestSerializer from erroring due to insufficient request mock
+        allow(Coach::RequestSerializer).
+          to receive(:new).
+          and_return(instance_double("Coach::RequestSerializer", serialize: {}))
+      end
+
+      it { is_expected.to include("start_handler.coach") }
+      it { is_expected.to include("start_middleware.coach") }
+      it { is_expected.to include("request.coach") }
+      it { is_expected.to include("finish_middleware.coach") }
+      it { is_expected.to include("finish_handler.coach") }
+
+      context "when an exception is raised in the chain" do
+        subject(:coach_events) do
+          events = []
+          subscription = ActiveSupport::Notifications.
+            subscribe(/\.coach$/) do |name, *args|
+            events << [name, args.last]
+          end
+
+          begin
+            handler.call({})
+          rescue StandardError
+            :continue_anyway
+          end
+          ActiveSupport::Notifications.unsubscribe(subscription)
+          events
+        end
+
+        let(:explosive_action) { -> { raise "AH" } }
+
+        before { terminal_middleware.uses(middleware_a, callback: explosive_action) }
+
+        it "captures the error event with the metadata" do
+          expect(coach_events).
+            to include(["finish_handler.coach", hash_including(
+              response: { status: 500 },
+              metadata: { A: true },
+            )])
+        end
+
+        it "bubbles the error to the next handler" do
+          expect { handler.call({}) }.to raise_error(StandardError, "AH")
+        end
+      end
     end
   end
 
@@ -121,71 +186,6 @@ describe Coach::Handler do
     end
   end
 
-  describe "#call" do
-    before { terminal_middleware.uses(middleware_a) }
-
-    describe "notifications" do
-      subject(:coach_events) do
-        events = []
-        subscription = ActiveSupport::Notifications.
-          subscribe(/\.coach$/) { |name, *_args| events << name }
-
-        handler.call({})
-        ActiveSupport::Notifications.unsubscribe(subscription)
-        events
-      end
-
-      before do
-        Coach::Notifications.subscribe!
-
-        # Prevent RequestSerializer from erroring due to insufficient request mock
-        allow(Coach::RequestSerializer).
-          to receive(:new).
-          and_return(instance_double("Coach::RequestSerializer", serialize: {}))
-      end
-
-      it { is_expected.to include("start_handler.coach") }
-      it { is_expected.to include("start_middleware.coach") }
-      it { is_expected.to include("request.coach") }
-      it { is_expected.to include("finish_middleware.coach") }
-      it { is_expected.to include("finish_handler.coach") }
-
-      context "when an exception is raised in the chain" do
-        subject(:coach_events) do
-          events = []
-          subscription = ActiveSupport::Notifications.
-            subscribe(/\.coach$/) do |name, *args|
-            events << [name, args.last]
-          end
-
-          begin
-            handler.call({})
-          rescue StandardError
-            :continue_anyway
-          end
-          ActiveSupport::Notifications.unsubscribe(subscription)
-          events
-        end
-
-        let(:explosive_action) { -> { raise "AH" } }
-
-        before { terminal_middleware.uses(middleware_a, callback: explosive_action) }
-
-        it "captures the error event with the metadata" do
-          expect(coach_events).
-            to include(["finish_handler.coach", hash_including(
-              response: { status: 500 },
-              metadata: { A: true },
-            )])
-        end
-
-        it "bubbles the error to the next handler" do
-          expect { handler.call({}) }.to raise_error(StandardError, "AH")
-        end
-      end
-    end
-  end
-
   describe "#inspect" do
     its(:inspect) { is_expected.to eql("#<Coach::Handler[Terminal]>") }
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coach
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-06 00:00:00.000000000 Z
+date: 2020-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -185,8 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Alternative controllers built with middleware