coach 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5f0c3cad8cac567d6a7896cb42598f1c9215cb92
-  data.tar.gz: a235b7b236bede96cb741f6a660fcb5a1a52790b
+  metadata.gz: 55ee934083e8a8e015a13a1bab92877e1643475e
+  data.tar.gz: c54472da279b95b157b4c446d611be3fdaa5127b
 SHA512:
-  metadata.gz: 5211eac40826156ceb6687ecaa985d06b2173f09d1d6615b3439ac892ab2d9e823c21ee205cf4b4f74d52e289268b94def61ea4f37a35292cddf1f84ec21bd01
-  data.tar.gz: 514d4e0cde81513cc7d8386c926fca8ad7115bf8bc61e58e1cd5153d7cfa1a87069feddfa0eb9ca5f20066f270062da55c8739356d887e6cb576dea154dca029
+  metadata.gz: f3d692848efe36f3a591af122a3f8393a9dddae02f6cd38c122f80b37d8dc4b49512ae00b9700734b15f5be72b4f731aa49486d09185975590b1bf894631e6c2
+  data.tar.gz: 9fde65cf951062595231bee30227b44d083543fd84435f21b034f4a87877290918de21bce3b0cb2ff0598028d6def49696da53eeb313cac7fbfeb23cd5590d91

data/.rubocop.yml

@@ -44,7 +44,7 @@ Metrics/CyclomaticComplexity:
 Metrics/PerceivedComplexity:
   Max: 10
 
-Style/AccessorMethodName:
+Naming/AccessorMethodName:
   Enabled: false
 
 # Allow non-ASCII characters (e.g. £) in comments
@@ -92,7 +92,7 @@ Layout/MultilineOperationIndentation:
   Enabled: false
 
 # Configuration parameters: NamePrefix, NamePrefixBlacklist.
-Style/PredicateName:
+Naming/PredicateName:
   Enabled: false
 
 Style/RedundantSelf:
@@ -112,3 +112,6 @@ Style/TrivialAccessors:
 Metrics/BlockLength:
   Exclude:
     - "**/*_spec.rb"
+
+Lint/RescueWithoutErrorClass:
+  Enabled: false

data/CHANGELOG.md

@@ -1,43 +1,45 @@
 # CHANGELOG
 
+* [#29](https://github.com/gocardless/coach/pull/29) Replace Coach.require_matchers! with actual require
+
 # 0.5.1 / 2017-08-21
 
-* [https://github.com/gocardless/coach/pull/26](#26) Add `started_at` to the
+* [#26](https://github.com/gocardless/coach/pull/26) Add `started_at` to the
   request event metadata.
 
 # 0.5.0 / 2017-08-07
 
-* [https://github.com/gocardless/coach/pull/24](#24) Use
+* [#24](https://github.com/gocardless/coach/pull/24) Use
   ActiveSupport.instrument for coach.handler.finish event. Potentially breaking
   change as the coach.handler.finish subscribers may trigger twice, depending on
   how users have subscribed to them.
 
 # 0.4.6
 
-* [https://github.com/gocardless/coach/pull/22](#22) Publish ActiveSupport notifications
+* [#22](https://github.com/gocardless/coach/pull/22) Publish ActiveSupport notifications
   even on errors
 
 # 0.4.5 / 2017-04-26
 
-* [https://github.com/gocardless/coach/pull/17] Only require rspec/expectations
+* [#17](https://github.com/gocardless/coach/pull/17) Only require rspec/expectations
   when adding new matchers
-* [https://github.com/gocardless/coach/pull/18] Properly pin version of rubocop
+* [#18](https://github.com/gocardless/coach/pull/18) Properly pin version of rubocop
 
 # 0.4.4 / 2016-08-26
 
-* [https://github.com/gocardless/coach/pull/16] Fix middleware lookup issue in router
+* [#16](https://github.com/gocardless/coach/pull/16) Fix middleware lookup issue in router
 
 # 0.4.3 / 2016-05-07
 
-* [https://github.com/gocardless/coach/pull/15] Clean up `Coach::Handler#inspect`
+* [#15](https://github.com/gocardless/coach/pull/15) Clean up `Coach::Handler#inspect`
 
 # 0.4.2 / 2016-05-07
 
-* [https://github.com/gocardless/coach/pull/13] Add support for Rails 5.
+* [#13](https://github.com/gocardless/coach/pull/13) Add support for Rails 5.
 
 # 0.4.1 / 2016-03-09
 
-* [https://github.com/gocardless/coach/pull/10] Removed a dependency that Coach's RSpec matchers had on Rails' `.third` array method.
+* [#10](https://github.com/gocardless/coach/pull/10) Removed a dependency that Coach's RSpec matchers had on Rails' `.third` array method.
 
 # 0.4.0 / 2015-12-21
 

data/README.md

@@ -181,6 +181,10 @@ Each middleware is encouraged to rely on data passed through the `provide`/`requ
 syntax exclusively, except in stateful operations (such as database queries). By sticking
 to this rule, testing becomes as simple as mocking a `context` hash.
 
+Coach comes with some RSpec matchers to help simplify your testing, however they aren't
+required by default. You'll need to run `require 'coach/rspec'`, we recommend putting this
+in your `spec/spec_helper.rb` or `spec/rails_helper.rb` file.
+
 ```ruby
 require 'spec_helper'
 

data/coach.gemspec

@@ -1,5 +1,3 @@
-# coding: utf-8
-
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'coach/version'
@@ -23,5 +21,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.2'
   spec.add_development_dependency 'rspec-its', '~> 1.2'
   spec.add_development_dependency 'pry', '~> 0.10'
-  spec.add_development_dependency 'rubocop', '~> 0.49.1'
+  spec.add_development_dependency 'rubocop', '~> 0.50.0'
 end

data/lib/coach.rb

@@ -14,6 +14,8 @@ require_relative 'coach/version'
 
 module Coach
   def self.require_matchers!
-    require_relative 'spec/matchers'
+    puts "Calling Coach.require_matchers! is deprecated, " \
+         "please use `require 'coach/rspec'` instead"
+    require_relative 'coach/rspec'
   end
 end

data/lib/coach/version.rb

@@ -1,3 +1,3 @@
 module Coach
-  VERSION = '0.5.1'.freeze
+  VERSION = '0.5.2'.freeze
 end

data/spec/spec_helper.rb

@@ -1,8 +1,7 @@
 require 'rspec/its'
 require 'pry'
-require_relative '../lib/coach'
-
-Coach.require_matchers!
+require 'coach'
+require 'coach/rspec'
 
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coach
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-21 00:00:00.000000000 Z
+date: 2017-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.50.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.50.0
 description: 
 email:
 - developers@gocardless.com
@@ -120,8 +120,8 @@ files:
 - lib/coach/request_benchmark.rb
 - lib/coach/request_serializer.rb
 - lib/coach/router.rb
+- lib/coach/rspec.rb
 - lib/coach/version.rb
-- lib/spec/matchers.rb
 - spec/lib/coach/handler_spec.rb
 - spec/lib/coach/middleware_spec.rb
 - spec/lib/coach/middleware_validator_spec.rb
@@ -150,7 +150,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Alternative controllers built with middleware