co_aspects 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a6bb76c1733ed9e04c038330902a41c5988ee64a
-  data.tar.gz: 823a7f324eaf090a1d4e51946514dde9eb9c8dfa
+  metadata.gz: 208d908a472f5db2270994e56545883d57cba04d
+  data.tar.gz: b954c735a140a3e0fa68303150b11dbc684e915b
 SHA512:
-  metadata.gz: 1ea0d9be92f14f244926dd9e9a3358f6ecd9a5c80e8d7c1dc50d319fab0ca244aa483c65ce475c578b7cf3e09b8689464931a19d71cfd383212ffdb6767931e1
-  data.tar.gz: 4c34bdb2542ec172c769b9d1a5cebbd964ab69c9bb81b583a1ef5a91b04d16028474bc27e2476fcc05a46a1daf66a44122540d126faa8bbb7ddcbf37094a53aa
+  metadata.gz: bd2578906c5f440c6f6bdf0b745d193b164d7c3f8a7b8e6928c045baaa7e2e254b2af3dcdcdc953965f549803a940ea061924b61a05b5be89df96c6b340cd339
+  data.tar.gz: 2ce68cc56570b695063bb99b72dc3d4d4fa7ed42556eed9dc2fd2991ed35d39c48de89bcea98296a6564ebd6700b4af7f3d3d4edc907daeb01c63c65de89ca1d

data/lib/co_aspects/aspects/rescue_and_notify_aspect.rb

@@ -1,10 +1,17 @@
 require 'newrelic_rpm'
+require_relative 'rescue_and_notify_error'
 
 module CoAspects
   module Aspects
     # Rescues any error and notifies NewRelic about it, without raising it
     # again.
     #
+    # If the exception responds to `newrelic_opts` then the return value will be
+    # used as the noticed error options.
+    #
+    # Important: The class `CoAspects::Aspects::RescueAndNotifyError` can be
+    # used as parent to custom error classes.
+    #
     # Important: If CoAspects::Aspects::RescueAndNotifyAspect.enable_test_mode!
     # is executed, then instead of calling NewRelic, it will raise the exception
     # as if this aspect didn't exist. It's to be used by tests, to see
@@ -56,7 +63,11 @@ module CoAspects
           if RescueAndNotifyAspect.test_mode
             raise e
           else
-            NewRelic::Agent.notice_error(e, stack_trace: e.backtrace)
+            opts = {}
+            if e.respond_to?(:newrelic_opts)
+              opts.merge!(e.newrelic_opts)
+            end
+            NewRelic::Agent.notice_error(e, opts)
           end
         end
       end

data/lib/co_aspects/aspects/rescue_and_notify_error.rb

@@ -0,0 +1,12 @@
+module CoAspects
+  module Aspects
+    class RescueAndNotifyError < RuntimeError
+      attr_reader :newrelic_opts
+
+      def initialize(message, newrelic_opts)
+        super(message)
+        @newrelic_opts = newrelic_opts
+      end
+    end
+  end
+end

data/lib/co_aspects/aspects/stats_increment_aspect.rb

@@ -40,7 +40,7 @@ module CoAspects
     #   # => StatsD.increment('my_key.dynamic')
     class StatsIncrementAspect < Aspector::Base
       around interception_arg: true, method_arg: true do |interception, method, proxy, *args, &block|
-        key = StatsdHelper.key(self.class,
+        key = StatsdHelper.key(self,
                                method,
                                args,
                                interception.options[:annotation][:as],

data/lib/co_aspects/aspects/stats_measure_aspect.rb

@@ -41,7 +41,7 @@ module CoAspects
     #   # => StatsD.measure('my_key.dynamic')
     class StatsMeasureAspect < Aspector::Base
       around interception_arg: true, method_arg: true do |interception, method, proxy, *args, &block|
-        key = StatsdHelper.key(self.class,
+        key = StatsdHelper.key(self,
                                method,
                                args,
                                interception.options[:annotation][:as],

data/lib/co_aspects/aspects/statsd_helper.rb

@@ -7,13 +7,15 @@ module CoAspects
         klass.name.underscore.tr('/', '.') + ".#{method_name}"
       end
 
-      def key(klass, method_name, method_args, statsd_prefix, statsd_block)
+      def key(instance, method_name, method_args, statsd_prefix, statsd_block)
         if statsd_prefix || statsd_block
           key = statsd_prefix.to_s
-          key += statsd_block.call(*method_args) if statsd_block
+          if statsd_block
+            key += instance.instance_exec(*method_args, &statsd_block).to_s
+          end
           key.downcase
         else
-          default_prefix(klass, method_name)
+          default_prefix(instance.class, method_name)
         end
       end
     end

data/lib/co_aspects/version.rb

@@ -1,3 +1,3 @@
 module CoAspects
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: co_aspects
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Gaston Jorquera
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-01-19 00:00:00.000000000 Z
+date: 2016-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -133,6 +133,7 @@ files:
 - lib/co_aspects/aspects/deprecate_aspect.rb
 - lib/co_aspects/aspects/log_call_aspect.rb
 - lib/co_aspects/aspects/rescue_and_notify_aspect.rb
+- lib/co_aspects/aspects/rescue_and_notify_error.rb
 - lib/co_aspects/aspects/stats_increment_aspect.rb
 - lib/co_aspects/aspects/stats_measure_aspect.rb
 - lib/co_aspects/aspects/statsd_helper.rb