cnvrg 2.1.9 → 2.1.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 414c34615497d519b8df3fc1adf597aa18bb8d05eb7466b312bbfd517f0e74aa
-  data.tar.gz: ddde064e3ef2f144948d1b6d1859f4daef95290dd13ae28b544569f6b16f5be0
+  metadata.gz: 39ee04e88be68fe27beb93cf57070e9b63fc1f908f2ff97f722bcb402d03bc78
+  data.tar.gz: 28e404bb36262d03f29fa96fddadbcab76d4c9eb99a4861078bb1b266621b85c
 SHA512:
-  metadata.gz: 8d72d7b22df91d154e0313f24511ae9f6f007c077bf0f49a9329f0546ec9983833920fd567e4abfe7ab876ae2da4aae888d77840d10d7945f956d0b8e77047c1
-  data.tar.gz: f72cfb009f744ede0fdaec505610e32fa50ee570415cd729678c2d791b79351a891569f5ef1911920ddca242bc0354c61e6aa505252793b3345cdfdaeebe0dbc
+  metadata.gz: dbc2220a92859ebd7689fa3922c38d4a6cd64bd555507f5eed65f91edc1eb17f652ff886310dc3e82c78a4091f0490c0f59efbcceea785dc3b77d5a1a01ff48e
+  data.tar.gz: 78c3ec169b49cd9b5b87240db503f03bc6ccd3e7665a9961d022d82a272ddaf8ea12fb2399acda5c4a13a402c06ebaf4e1500a39142f6eae9c81618b3bea8190

data/Readme.md

@@ -108,4 +108,43 @@
 ## Version v2.1.9
 2022-09-06
 * DEV-15423 - Bug: Workspace - Jupyter process gets killed
-* DEV-15451 - Bug: CLI - sync error "undefined method `encode' for nil:NilClass" on GCP storage
+* DEV-15451 - Bug: CLI - sync error "undefined method `encode' for nil:NilClass" on GCP storage
+## Version v2.1.10
+2022-10-26
+* DEV-15858 - Bug: Tensorboard compare - ongoing experiments' artifacts aren't cloned to session
+## Version v2.1.11
+2022-11-03
+* DEV-16090 - Bug: Tensorboard compare - webapp gets stuck in "init" state 
+## Version v2.1.12
+2022-11-09
+* DEV-15972 - Bug: Customer cannot use dataset query due to ssl error
+## Version v2.1.13
+2023-03-05
+* DEV-16372 - Epic: Cli V2 release - phase 1
+h2. 🎯 Objective
+
+Release v2 of cnvrg cli and deprecate the old version
+
+h2. 🤔 Assumptions
+
+# *Docs will be released (joint effort of tech writer, support and dev)*
+# *cnvrg:v6 image will be released (with updated python version)*
+# *All issues on High & Highest priority n sdk-productionize fixVersion will be resolved*
+# *QA tests will be performed in different set ups (aks/eks/gke, windows device, mac m1)*
+
+
+Note: this is not the most detailed epic, as most things already exist in cliv1 or sdkv2. for any questions please contact [~accountid:5fb5461f4a09640069dbf768] 
+* DEV-16372 - Epic: Cli V2 release - phase 1
+h2. 🎯 Objective
+
+Release v2 of cnvrg cli and deprecate the old version
+
+h2. 🤔 Assumptions
+
+# *Docs will be released (joint effort of tech writer, support and dev)*
+# *cnvrg:v6 image will be released (with updated python version)*
+# *All issues on High & Highest priority n sdk-productionize fixVersion will be resolved*
+# *QA tests will be performed in different set ups (aks/eks/gke, windows device, mac m1)*
+
+
+Note: this is not the most detailed epic, as most things already exist in cliv1 or sdkv2. for any questions please contact [~accountid:5fb5461f4a09640069dbf768] 

data/lib/cnvrg/cli.rb

@@ -1019,7 +1019,7 @@ module Cnvrg
               begin
                 unless File.exist?(fullpath)
                   downloader.safe_operation("#{abs_path}/#{file_name}") do
-                    download = open(f["url"])
+                    download = open(f["url"],{ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE})
                     IO.copy_stream(download, fullpath)
                   end
                 end
@@ -3636,19 +3636,15 @@ module Cnvrg
           end
 
           log_message(str, Thor::Shell::Color::GREEN)
-          
+
           exit_status = 0
-          
+
           if options['wait']
             end_pos = 0
             while true
               tries = 0
               begin
-                result = Cnvrg::API_V2.request(
-                    "#{project.owner}/projects/#{project.slug}/experiments/#{res["result"]["exp_url"]}/info",
-                    'GET',
-                    { exit_status: true, grid: res["result"]["grid"], pos: end_pos }
-                )
+                result = fetch_experiment_info(res,project,end_pos)
 
                 exit_statuses = result.values.pluck('exit_status')
                 if exit_statuses.include? nil
@@ -5003,32 +4999,28 @@ module Cnvrg
 
       log_message("compare is running")
       while true
-        log_message("compare is running for slugs #{slugs}")
+        log_message("Comparing the following experiment slugs: #{slugs}")
         slugs.each do |exp_slug|
           begin
             if exps_map[exp_slug].blank?
               exp = @project.get_experiment(exp_slug)["experiment"]
             else
               exp = exps_map[exp_slug]
-              log_message("#{exp["title"]} has ended skipping it", Thor::Shell::Color::BLUE)
+              log_message("Experiment '#{exp["title"]}' end commit already cloned, skipping it", Thor::Shell::Color::BLUE)
               next
             end
             exp_name = exp["title"]
             if exp["end_commit"].present? and exp["status"] != "Ongoing"
-              log_message("#{exp_name} has ended, getting files from end commit", Thor::Shell::Color::BLUE)
+              log_message("Experiment '#{exp_name}' has ended, getting files from its end commit", Thor::Shell::Color::BLUE)
               num_of_new_files = Cnvrg::Helpers.get_experiment_events_log_from_server(exp, @project)
               exps_map[exp_slug] = exp
             else
-              log_message("#{exp_name} is running should get logs", Thor::Shell::Color::BLUE)
-              success, num_of_new_files = Cnvrg::Helpers.get_experiment_events_log_via_kubectl(exp, namespace)
-              if !success and exp["last_successful_commit"].present? and !copied_commits.include?(exp["last_successful_commit"]["sha1"])
-                log_message("Failed to get kube files, using last commit", Thor::Shell::Color::BLUE)
-                num_of_new_files = Cnvrg::Helpers.get_experiment_events_log_from_server(exp, @project, commit: exp["last_successful_commit"]["sha1"])
-                copied_commits << exp["last_successful_commit"]["sha1"]
-              end
+              log_message("Experiment '#{exp_name}' is running, getting files from its last successful commit", Thor::Shell::Color::BLUE)
+              num_of_new_files = Cnvrg::Helpers.get_experiment_events_log_from_server(exp, @project, commit: exp["last_successful_commit"]["sha1"])
+              copied_commits << exp["last_successful_commit"]["sha1"]
             end
 
-            log_message("New tf files copied", Thor::Shell::Color::BLUE) if num_of_new_files > 0
+            log_message("New .tfevent files downloaded", Thor::Shell::Color::BLUE) if num_of_new_files > 0
           rescue => e
             Cnvrg::Logger.log_error(e)
           end
@@ -5960,6 +5952,24 @@ module Cnvrg
         end
       end
 
+
+      def fetch_experiment_info(res, project, end_pos)
+
+        result =
+          Cnvrg::API_V2
+            .request("#{project.owner}/projects/#{project.slug}/experiments/#{res["result"]["exp_url"]}/info",
+          'GET',
+          { exit_status: true, grid: res["result"]["grid"], pos: end_pos }
+        )
+
+        if result.key?("exit_status")
+          return result
+        end
+
+        return result["data"]["attributes"]["info"]
+
+      end
+
     end
   end
 

data/lib/cnvrg/helpers.rb

@@ -374,48 +374,6 @@ parameters:
       end
       return num_of_new_files
     end
-
-    def get_experiment_events_log_via_kubectl(exp, namespace)
-      dest_dir = exp["slug"]
-      result = `kubectl -n #{namespace} get pods | grep #{exp["slug"]}`
-
-      pod_name = result.split(" ")[0]
-      return false, 0 if pod_name.blank?
-      FileUtils.mkdir_p(dest_dir)
-      working_dir = `kubectl -n #{namespace} exec #{pod_name} -c agent -- pwd`
-      working_dir.strip!
-      res = `kubectl -n #{namespace} exec #{pod_name} -c agent -- /bin/bash -c "ls -R #{working_dir}"`
-      files_and_folders = res.split("\n\n")
-      all_files = []
-
-      files_and_folders.each do |file_and_folder|
-        files = file_and_folder.split("\n")
-        if files.first.include?(":")
-          folder = files.first.gsub(":", "")
-
-          folder = folder.sub(working_dir + "/", "")
-          files = files.drop(1)
-        end
-        files.each do |file|
-          if file.include?("tfevents")
-            all_files << "#{folder}/#{file}"
-          end
-        end
-      end
-
-      num_of_new_files = 0
-      all_files.each do |file|
-        file_dir = "#{dest_dir}/#{File.dirname(file)}"
-        FileUtils.mkdir_p(file_dir)
-        num_of_new_files += 1 unless File.exist?("#{dest_dir}/#{file}")
-        res = `kubectl -n #{namespace} cp #{pod_name}:#{file} -c agent #{dest_dir}/#{file}`
-      end
-
-      return true, num_of_new_files
-    rescue => e
-      Cnvrg::Logger.log_error(e)
-      return false, 0
-    end
   end
 
 end

data/lib/cnvrg/version.rb

@@ -1,3 +1,3 @@
 module Cnvrg
-  VERSION = '2.1.9'
+  VERSION = '2.1.13'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cnvrg
 version: !ruby/object:Gem::Version
-  version: 2.1.9
+  version: 2.1.13
 platform: ruby
 authors:
 - Yochay Ettun
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-09-13 00:00:00.000000000 Z
+date: 2023-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler