cnvrg 1.11.6 → 1.11.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f3169f1879068224c90bee508cc59f70ea0511ddf035121f68fa3903a179cb6
-  data.tar.gz: '008d3c425851891ecc80363c141636c54a9ed3abcc3fa80083f5ef190a7bcba8'
+  metadata.gz: 1402d0759d20d1c1d9182cebc35fe5539c14a8a1bb2c4eeddf791f43ff768082
+  data.tar.gz: 4146973b1a98ea3d26af0efb96ee481093e29fe9fce6fb88c54a539b34e5c0cf
 SHA512:
-  metadata.gz: a3b9ad00997260f78fbdd3b492676847d85102ba2e87d6c54d64a8f0703250e87f01cd0346b797355f1206ff0b2c5dd2c1e2b70bbb50ec03dac2ff1a6f2a4c61
-  data.tar.gz: 87beff960a61713abab357b95e890c6e247fc3605f2cea7fed5767d259a728448a3bdfcd2e810833b4632f9794efc3e043e773ff600d47abf6d49d4792bc9953
+  metadata.gz: 53951eb4b7f82322640e75fdeae5ece07bb7189cc5b81257a9a78fd1398ab04c43ef0ed2784c1963f8d53dd983f874f2ed1ccc0ac4953ffced37deb75953d679
+  data.tar.gz: 8a046e229d0d14a2d36cb896c467aff3599e98b0e1cfb93e96fb72e80342751a47df4e1a90a57ff62e09ed92f1720afb783fe354dd34a5e06767e98c5bd8bdb6

data/lib/cnvrg/cli.rb

@@ -972,6 +972,7 @@ module Cnvrg
 
         if Dataset.blank_clone(owner, dataset_name, dataset_slug)
           dataset = Dataset.new(dataset_home)
+          downloader = dataset.get_storage_client
           log_message("Cloning #{dataset_name}", Thor::Shell::Color::BLUE)
           parallel_options = {
               :progress => {
@@ -994,15 +995,20 @@ module Cnvrg
               relative_path_dir = relative_path_dir.join("/")
               abs_path = dataset_home + "/" + relative_path_dir
               abs_path = dataset_home if flatten
+              fullpath = abs_path + "/" + file_name
 
               begin
-                FileUtils.mkdir_p(abs_path) unless File.exist? (abs_path + "/" + file_name)
+                FileUtils.mkdir_p(abs_path) unless File.exist? (fullpath)
               rescue
                 log_message("Could not create directory: #{abs_path}", Thor::Shell::Color::RED)
                 exit(1)
               end
               begin
-                File.write "#{abs_path}/#{file_name}", open(f["url"]).read unless File.exist? (abs_path + "/" + file_name)
+                unless File.exist?(fullpath)
+                  downloader.safe_operation("#{abs_path}/#{file_name}") do
+                    File.open(fullpath, "w") { |f| f.write open(f["url"]).read }
+                  end
+                end
               rescue => e
                 log_message("Could not download file: #{f["fullpath"]}", Thor::Shell::Color::RED)
                 exit(1)

data/lib/cnvrg/datafiles.rb

@@ -1338,7 +1338,7 @@ module Cnvrg
             #   Cnvrg::Logger.log_info("Trying to download #{local_path} but its already exists, skipping..")
             #   next
             # end
-            resp = @downloader.download(storage_path, local_path)
+            resp = @downloader.safe_download(storage_path, local_path)
             Cnvrg::Logger.log_info("Download #{local_path} success resp: #{resp}")
           rescue => e
             Cnvrg::Logger.log_error(e)

data/lib/cnvrg/downloader/client.rb

@@ -30,10 +30,14 @@ module Cnvrg
         file.gsub(prefix, '').gsub(/^\/*/, '')
       end
 
-      def download(storage_path, local_path)
+      def download(storage_path, local_path, decrypt: true)
         ### need to be implemented..
       end
 
+      def safe_download(storage_path, local_path, decrypt: true)
+        safe_operation(local_path) { self.download(storage_path, local_path, decrypt: decrypt) }
+      end
+
       def upload(storage_path, local_path)
         ### need to be implemented..
       end
@@ -51,17 +55,34 @@ module Cnvrg
       end
 
       def safe_upload(storage_path, local_path)
+        safe_operation(local_path) { self.upload(storage_path, local_path) }
+      end
+
+      def self.factory(params)
+        params = params.as_json
+        case params["storage"]
+        when 's3', 'minio'
+          return Cnvrg::Downloader::Clients::S3Client.new(sts_path: params["path_sts"], access_key: params["sts_a"], secret: params["sts_s"], session_token: params["sts_st"], region: params["region"], bucket: params["bucket"], encryption: params["encryption"], endpoint: params["endpoint"], storage: params["storage"])
+        when 'azure'
+          azure_params = params.symbolize_keys.slice(*[:storage_account_name, :storage_access_key, :container, :sts])
+          return Cnvrg::Downloader::Clients::AzureClient.new(**azure_params)
+        when 'gcp'
+          return Cnvrg::Downloader::Clients::GcpClient.new(project_id: params["project_id"], credentials: params["credentials"], bucket_name: params["bucket_name"], sts: params["sts"])
+        end
+      end
+
+      def safe_operation(local_path)
         n = 1
         error = nil
         while n <= RETRIES
           begin
-            self.upload(storage_path, local_path)
+            yield
             error = nil
             break
           rescue => e
             backoff_time_seconds = backoff_time(n)
 
-            message = "Got error: #{e.class.name} with message: #{e.message} while uploading a single file: #{local_path}, retry: #{n} of: #{RETRIES}"
+            message = "Got error: #{e.class.name} with message: #{e.message} while uploading / downloading a single file: #{local_path}, retry: #{n} of: #{RETRIES}"
             if n < RETRIES
               message += ", next retry in: #{backoff_time_seconds} seconds"
             else
@@ -79,19 +100,6 @@ module Cnvrg
         true
       end
 
-      def self.factory(params)
-        params = params.as_json
-        case params["storage"]
-        when 's3', 'minio'
-          return Cnvrg::Downloader::Clients::S3Client.new(sts_path: params["path_sts"], access_key: params["sts_a"], secret: params["sts_s"], session_token: params["sts_st"], region: params["region"], bucket: params["bucket"], encryption: params["encryption"], endpoint: params["endpoint"], storage: params["storage"])
-        when 'azure'
-          azure_params = params.symbolize_keys.slice(*[:storage_account_name, :storage_access_key, :container, :sts])
-          return Cnvrg::Downloader::Clients::AzureClient.new(**azure_params)
-        when 'gcp'
-          return Cnvrg::Downloader::Clients::GcpClient.new(project_id: params["project_id"], credentials: params["credentials"], bucket_name: params["bucket_name"], sts: params["sts"])
-        end
-      end
-
       private
 
       def random_number_milliseconds

data/lib/cnvrg/downloader/clients/gcp_client.rb

@@ -31,7 +31,7 @@ module Cnvrg
           @tempfile = t
         end
 
-        def download(storage_path, local_path)
+        def download(storage_path, local_path, decrypt: true)
           prepare_download(local_path)
           file = @bucket.file(decrypt(storage_path))
           file.download local_path

data/lib/cnvrg/files.rb

@@ -789,7 +789,7 @@ module Cnvrg
               end
               local_path = project_home+"/"+file_path
               storage_path = f["path"]
-              @client.download(storage_path, local_path)
+              @client.safe_download(storage_path, local_path)
               progress.progress += 1 if progress.present?
               download_succ_count += 1
             rescue => e
@@ -962,7 +962,7 @@ module Cnvrg
 
     def download_file(file_path: '', key: '', iv: '', bucket: '', path: '', client: nil)
       local_path = @project_home+"/"+file_path
-      @client.download(path, local_path)
+      @client.safe_download(path, local_path)
     end
 
     def delete(file)

data/lib/cnvrg/storage.rb

@@ -34,7 +34,7 @@ module Cnvrg
         @element.get_clone_chunk(commit: commit, chunk_size: params[:limit], offset: params[:offset])
       end
       action = Proc.new do |storage, local|
-        @client.download(storage, local)
+        @client.safe_download(storage, local)
       end
 
       @stats = @element.get_stats

data/lib/cnvrg/version.rb

@@ -1,3 +1,3 @@
 module Cnvrg
-  VERSION = '1.11.6'
+  VERSION = '1.11.7'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cnvrg
 version: !ruby/object:Gem::Version
-  version: 1.11.6
+  version: 1.11.7
 platform: ruby
 authors:
 - Yochay Ettun
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-17 00:00:00.000000000 Z
+date: 2020-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler