cnb 0.0.5 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5900cf0a63e8bfba9da32eb6e36f70898cb0a4c2
-  data.tar.gz: 099dad1d8d2db942144c5b11ffb20f416ead3e4e
+  metadata.gz: 74fa46a97bd5a68b12189edb0df0181100d04f1a
+  data.tar.gz: 17ee1ff9c96b3687285b34314e330b617e239b00
 SHA512:
-  metadata.gz: b5f7595d50d3cc5834ed71b73b90a5d9f786fd5ba503e6b9e4e26ac29662542b26acabfe812bc4e15be660ba767d7a4c23a337e167735f9eed73efe27c3aa922
-  data.tar.gz: 7c8e69002530cb07323d2b63ccae74940d39b22ab73586f079e9b51054ec0c823fb337a36708c7a72ccbd6cc2f182478fa1a230225751fd9d6898887b8f27b12
+  metadata.gz: cc371ab478158c10e9ca72dc46cb0c9d91e77262df1071288b4d858042dc9ace570d2604e510620ce6837642a4c1d291d03ddd50dde03cd5a464bfbbd5234443
+  data.tar.gz: eec19f4f464a1fbeb2a29be178c2bff5ea86ec9e798a5d32e8361d9a857820a137a4301c51f6034556dff527f537463fcf15fff0dc57b66010e6380f2c9fc77d

data/lib/cnb/{cur_rates_parser.rb → currency_rates.rb}

@@ -1,7 +1,7 @@
 require 'open-uri'
 
 module CNB
-  class CurRatesParser
+  class CurrencyRates
     CUR_RATES_URL = 'http://www.cnb.cz/cs/financni_trhy/devizovy_trh/'
 
     attr_reader :cur_rates_filepath, :date
@@ -26,10 +26,10 @@ module CNB
       @currencies[cur_code]
     end
 
-    def parse(filepath)
-      @date = parse_date(filepath)
-      cur_rates = File.read(filepath)
-      lines = cur_rates.lines.to_a
+    def parse
+      text = get_page_content(@cur_rates_url)
+      lines = text.split("\n")
+      @date = parse_date(lines.first)
 
       lines.shift(2)
       lines.each do |line|
@@ -47,19 +47,11 @@ module CNB
       { cur_code: columns[3], data: data }
     end
 
-    def parse_date(filepath)
-      line = File.open(filepath) { |f| f.readline }
+    def parse_date(line)
       date = line[0..line.index('#') - 1].chomp
       Date.parse(date)
     end
 
-    def download_cur_rates(url)
-      content = get_page_content(url)
-      f = File.new(@cur_rates_filepath, 'w')
-      f.write(content)
-      f.close
-    end
-
     def get_page_content(url)
       file = open(url)
       file.read

data/lib/cnb/daily_rates.rb

@@ -0,0 +1,10 @@
+module CNB
+  class DailyRates < CurrencyRates
+    def initialize
+      @currencies = {}
+      @cur_rates_url = "#{CUR_RATES_URL}kurzy_devizoveho_trhu/denni_kurz.txt"
+
+      parse
+    end
+  end
+end

data/lib/cnb/{monthly_cur_rates_parser.rb → monthly_rates.rb}

@@ -1,5 +1,5 @@
 module CNB
-  class MonthlyCurRatesParser < CurRatesParser
+  class MonthlyRates < CurrencyRates
     def initialize(month, year)
       @month = month
       @year = year
@@ -9,18 +9,12 @@ module CNB
 
       @currencies = {}
       @cur_rates_url = "#{CUR_RATES_URL}/kurzy_ostatnich_men/kurzy.txt?mesic=#{month}&rok=#{year}"
-      @cur_rates_filepath = "#{CONFIG['exchange_rates_dir']}/monthly_cur_rates_#{year}_#{month}.txt"
 
       parse
     end
 
     private
 
-    def parse
-      download_cur_rates(@cur_rates_url) unless File.exist?(cur_rates_filepath)
-      super(cur_rates_filepath)
-    end
-
     def valid_month?
       @month.to_i >= 1 && @month.to_i <= 12
     end

data/lib/cnb/version.rb

@@ -1,3 +1,3 @@
 module CNB
-  VERSION = '0.0.5'
+  VERSION = '0.0.7'
 end

data/lib/cnb.rb

@@ -1,18 +1,17 @@
-require_relative 'cnb/load_config'
-require_relative 'cnb/cur_rates_parser'
-require_relative 'cnb/daily_cur_rates_parser'
-require_relative 'cnb/monthly_cur_rates_parser'
+require_relative 'cnb/currency_rates'
+require_relative 'cnb/daily_rates'
+require_relative 'cnb/monthly_rates'
 
 module CNB
   PRIMARY_CURRENCY = 'CZK'
 
   class << self
     def daily_rates
-      @parser = DailyCurRatesParser.new
+      @parser = DailyRates.new
     end
 
     def monthly_rates(month, year)
-      @parser = MonthlyCurRatesParser.new(month, year)
+      @parser = MonthlyRates.new(month, year)
     end
 
     def date

data/spec/models/{daily_cur_rates_parser_spec.rb → daily_rates_spec.rb}

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
-describe CNB::DailyCurRatesParser do
+describe CNB::DailyRates do
   before(:each) do
-    filepath = File.join('spec', 'examples', 'daily_cur_rates.txt')
-    CNB::DailyCurRatesParser.any_instance.stub(:cur_rates_filepath) { filepath }
-    @parser = CNB::DailyCurRatesParser.new
+    filepath = File.join('spec', 'fixtures', 'daily_cur_rates.txt')
+    CNB::DailyRates.any_instance.stub(:get_page_content) { File.read(filepath) }
+    @parser = CNB::DailyRates.new
   end
 
   it 'returns date from the exchange rates file' do

data/spec/models/{monthly_cur_rates_parser_spec.rb → monthly_rates_spec.rb}

@@ -1,22 +1,22 @@
 require 'spec_helper'
 
-describe CNB::MonthlyCurRatesParser do
+describe CNB::MonthlyRates do
   before(:each) do
-    filepath = File.join('spec', 'examples', 'monthly_cur_rates_2013_3.txt')
-    CNB::MonthlyCurRatesParser.any_instance.stub(:cur_rates_filepath) { filepath }
-    @parser = CNB::MonthlyCurRatesParser.new(3, 2013)
+    filepath = File.join('spec', 'fixtures', 'monthly_cur_rates_2013_3.txt')
+    CNB::MonthlyRates.any_instance.stub(:get_page_content) { File.read(filepath) }
+    @parser = CNB::MonthlyRates.new(3, 2013)
   end
 
   it 'raises error if required month is invalid' do
-    expect{CNB::MonthlyCurRatesParser.new('abc', 2013)}.to raise_error(StandardError)
-    expect{CNB::MonthlyCurRatesParser.new(0, 2013)}.to raise_error(StandardError)
-    expect{CNB::MonthlyCurRatesParser.new(13, 2013)}.to raise_error(StandardError)
+    expect{CNB::MonthlyRates.new('abc', 2013)}.to raise_error(StandardError)
+    expect{CNB::MonthlyRates.new(0, 2013)}.to raise_error(StandardError)
+    expect{CNB::MonthlyRates.new(13, 2013)}.to raise_error(StandardError)
   end
 
   it 'raises error if required year is invalid' do
-    expect{CNB::MonthlyCurRatesParser.new(3, 'abc')}.to raise_error(StandardError)
-    expect{CNB::MonthlyCurRatesParser.new(3, 2000)}.to raise_error(StandardError)
-    expect{CNB::MonthlyCurRatesParser.new(3, 2050)}.to raise_error(StandardError)
+    expect{CNB::MonthlyRates.new(3, 'abc')}.to raise_error(StandardError)
+    expect{CNB::MonthlyRates.new(3, 2000)}.to raise_error(StandardError)
+    expect{CNB::MonthlyRates.new(3, 2050)}.to raise_error(StandardError)
   end
 
   it 'returns date from the exchange rates file' do

data/spec/spec_helper.rb

@@ -6,10 +6,9 @@ if ENV['COVERAGE']
   SimpleCov.start
 end
 
-require 'cnb/load_config'
-require 'cnb/cur_rates_parser'
-require 'cnb/daily_cur_rates_parser'
-require 'cnb/monthly_cur_rates_parser'
+require 'cnb/currency_rates'
+require 'cnb/daily_rates'
+require 'cnb/monthly_rates'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cnb
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.7
 platform: ruby
 authors:
 - Jan Zikán
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-25 00:00:00.000000000 Z
+date: 2014-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -80,17 +80,15 @@ files:
 - LICENSE
 - README.md
 - cnb.gemspec
-- config/cnb.yml.example
 - lib/cnb.rb
-- lib/cnb/cur_rates_parser.rb
-- lib/cnb/daily_cur_rates_parser.rb
-- lib/cnb/load_config.rb
-- lib/cnb/monthly_cur_rates_parser.rb
+- lib/cnb/currency_rates.rb
+- lib/cnb/daily_rates.rb
+- lib/cnb/monthly_rates.rb
 - lib/cnb/version.rb
-- spec/examples/daily_cur_rates.txt
-- spec/examples/monthly_cur_rates_2013_3.txt
-- spec/models/daily_cur_rates_parser_spec.rb
-- spec/models/monthly_cur_rates_parser_spec.rb
+- spec/fixtures/daily_cur_rates.txt
+- spec/fixtures/monthly_cur_rates_2013_3.txt
+- spec/models/daily_rates_spec.rb
+- spec/models/monthly_rates_spec.rb
 - spec/spec_helper.rb
 homepage: http://www.uol.cz
 licenses:
@@ -118,7 +116,7 @@ signing_key:
 specification_version: 4
 summary: CNB currency rates
 test_files:
-- spec/examples/daily_cur_rates.txt
-- spec/examples/monthly_cur_rates_2013_3.txt
-- spec/models/daily_cur_rates_parser_spec.rb
-- spec/models/monthly_cur_rates_parser_spec.rb
+- spec/fixtures/daily_cur_rates.txt
+- spec/fixtures/monthly_cur_rates_2013_3.txt
+- spec/models/daily_rates_spec.rb
+- spec/models/monthly_rates_spec.rb

data/config/cnb.yml.example

@@ -1 +0,0 @@
-exchange_rates_dir: /tmp

data/lib/cnb/daily_cur_rates_parser.rb

@@ -1,23 +0,0 @@
-module CNB
-  class DailyCurRatesParser < CurRatesParser
-    def initialize
-      @currencies = {}
-      @cur_rates_url = "#{CUR_RATES_URL}kurzy_devizoveho_trhu/denni_kurz.txt"
-      @cur_rates_filepath = "#{CONFIG['exchange_rates_dir']}/daily_cur_rates.txt"
-
-      parse
-    end
-
-    private
-
-    def parse
-      if File.exist?(cur_rates_filepath)
-        download_cur_rates(@cur_rates_url) unless parse_date(cur_rates_filepath) == Date.today
-      else
-        download_cur_rates(@cur_rates_url)
-      end
-
-      super(cur_rates_filepath)
-    end
-  end
-end

data/lib/cnb/load_config.rb

@@ -1,15 +0,0 @@
-require 'yaml'
-
-if File.exists?('config/cnb.yml')
-  filename = 'config/cnb.yml'
-elsif File.exists?(ENV['HOME'] + '/.cnb.yml')
-  filename = ENV['HOME'] + '/.cnb.yml'
-end
-
-if filename
-  CONFIG = YAML.load_file(filename)
-else
-  CONFIG = {}
-end
-
-CONFIG['exchange_rates_dir'] ||= '/tmp'