cmxl 2.0 → 2.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (16) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/ci.yml +3 -2
  3. data/.rspec +2 -1
  4. data/CHANGELOG.mdown +11 -0
  5. data/README.md +40 -21
  6. data/lib/cmxl/fields/statement_details.rb +1 -1
  7. data/lib/cmxl/statement.rb +1 -2
  8. data/lib/cmxl/version.rb +1 -1
  9. data/lib/cmxl.rb +6 -2
  10. data/spec/fields/statement_details_spec.rb +41 -0
  11. data/spec/fixtures/mt940-abnamro.txt +44 -0
  12. data/spec/fixtures/mt940-handelsbank.txt +16 -0
  13. data/spec/fixtures/mt940-windows-line-breaks.txt +16 -0
  14. data/spec/mt940_parsing_spec.rb +111 -0
  15. data/spec/statement_spec.rb +92 -1
  16. metadata +8 -2
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 1c172d6b56767a8860f57c4b802c7ed2ed2bae3658f6db104f44795a377bf067
4
- data.tar.gz: ececb262e0d6a40c97e7ca54dcac08208e1942792c5f493be179ba3c81ece6b7
3
+ metadata.gz: f7d3b16a51915ab4abdd146b5f213b4957392ace7f27be151fbc253ea820dd6c
4
+ data.tar.gz: cc398d5bd6fb2e112abfa815de950fd34a300107ba573b50ea8fb9ed98703f23
5
5
  SHA512:
6
- metadata.gz: f0f673453d6bbbc39313ed7ae86ff574c4c9d60a0ea5543283f38d1f3bf4f7477625e2bc87a1fbdc62714c86461735a7e16796edd54cd361d52d49d2eb05d8db
7
- data.tar.gz: a197094a3ccd4235f8811a456dbd54c43bc3b49a47062a72f7b9ee53610ddbb4e79ce97e53e0f90670a0c5e3cb5f08ef490792506dc6cc1202d5442c4f724710
6
+ metadata.gz: 9c9d4c881bc2f1f644471bf24a5c2f0c0fdc0543f828ba82e2960f1a015d397f10cdbc74d5fece4f79f2638625000ba8f8e80d0bbfa7ead01aec2b09992ff940
7
+ data.tar.gz: 2ba29e61b1060f43ddc7699211ff109064256366e18089a1d46b41b513906fabbb60ca12a74d322595f6ef726ea9068150829d0e0c5c4c3d2c7c690a0aeef309
data/.github/workflows/ci.yml CHANGED
@@ -2,9 +2,9 @@ name: CI
2
2
 
3
3
  on:
4
4
  push:
5
- branches: [master]
5
+ branches: [main]
6
6
  pull_request:
7
- branches: [master]
7
+ branches: [main]
8
8
 
9
9
  jobs:
10
10
  test:
@@ -13,6 +13,7 @@ jobs:
13
13
  strategy:
14
14
  matrix:
15
15
  ruby-version:
16
+ - 3.4
16
17
  - 3.3
17
18
  - 3.2
18
19
  - 3.1
data/.rspec CHANGED
@@ -1 +1,2 @@
1
- --color
1
+ --color
2
+ --require 'pry'
data/CHANGELOG.mdown CHANGED
@@ -1,5 +1,16 @@
1
1
  # NEXT release
2
2
 
3
+ # 2.2
4
+ - `[ENHANCEMENT]` enable `strip_headers` option per default.
5
+ - `[BUGFIX]` fix `strip_header` remove greedy regex logic
6
+ - `[BUGFIX]` support details parsing from files on windows os
7
+
8
+ # 2.1
9
+ - `[REFACTOR]` improve file parser to work with windows line breaks and any known header formats
10
+ - `[BUGFIX]` fix `strip_header` making it work on statements without headers
11
+ - `[HOUSEKEEPING]` use `main` instead of `master` as default branch
12
+ - `[ENHANCEMENT]` add support for ruby `3.4`
13
+
3
14
  # 2.0
4
15
  - `[REFACTOR]` **DEPRECATED:** `storno?` and related methods `storno_credit`, `storno_debit`. Use `reversal?` and related methods `reversal_credit?`, `reversal_debit?` instead
5
16
  - `[BUGFIX]` **DEPRECATED:** `funds_code` method returns the `credit_debit_indicator` from the SWIFT definition. Therefore the method is deprecated in favor of `credit_debit_indicator` method
data/README.md CHANGED
@@ -38,31 +38,17 @@ Or install it yourself as:
38
38
 
39
39
  ## Usage
40
40
 
41
- Simple usage:
41
+ ### Simple usage:
42
42
 
43
43
  ```ruby
44
+ statements = Cmxl.parse(File.read('mt940.txt'))
44
45
 
45
- # Configuration:
46
-
47
- # statement divider regex to split the individual statements in one file - the default is standard and should be good for most files
48
- Cmxl.config[:statement_separator] = /\n-.\n/m
49
-
50
- # do you want an error to be raised when a line can not be parsed? default is true
51
- Cmxl.config[:raise_line_format_errors] = true
52
-
53
- # try to stip the SWIFT header data. This strips everything until the actual first MT940 field. (if parsing fails, try this!)
54
- Cmxl.config[:strip_headers] = true
55
-
56
-
57
- # Statment parsing:
58
-
59
- statements = Cmxl.parse(File.read('mt940.txt'), :encoding => 'ISO-8859-1') # parses the file and returns an array of statement objects. Please note: if no encoding is given Cmxl tries to guess the encoding from the content and converts it to UTF-8.
60
46
  statements.each do |s|
61
47
  puts s.reference
62
48
  puts s.generation_date
63
49
  puts s.opening_balance.amount
64
50
  puts s.closing_balance.amount
65
- puts s.sha # SHA of the statement source - could be used as an identifier (see: https://github.com/railslove/cmxl/blob/master/lib/cmxl/statement.rb#L49-L55)
51
+ puts s.sha # SHA of the statement source - could be used as an identifier (see: https://github.com/railslove/cmxl/blob/main/lib/cmxl/statement.rb#L49-L55)
66
52
 
67
53
  s.transactions.each do |t|
68
54
  puts t.information
@@ -81,25 +67,58 @@ statements.each do |s|
81
67
  # ...
82
68
  end
83
69
  end
84
-
85
70
  ```
86
71
 
87
72
  Every object responds to `to_h` and let's you easily convert the data to a hash. Also every object responds to `to_json` which lets you easily represent the statements as JSON with your favorite JSON library.
88
73
 
89
- #### A note about encoding and file weirdnesses
74
+ ### File encoding options
90
75
 
91
76
  You probably will encounter encoding issues (hey, you are building banking applications!).
92
77
  We try to handle encoding and format weirdnesses as much as possible. If no encoding is passed we try to guess the encoding of the data and convert it to UTF8.
93
78
  In the likely case that you encounter encoding issues you can pass encoding options to `Cmxl.parse(<string>, <options hash>)`. It accepts the same options as [String#encode](http://ruby-doc.org/core-2.1.3/String.html#method-i-encode)
94
79
  If that fails, try to modify the file before you pass it to the parser - and please create an issue.
95
80
 
96
- ### MT940 SWIFT header data
81
+ ```ruby
82
+ Cmxl.parse(File.read('mt940.txt'), :encoding => 'ISO-8859-1')
83
+ ```
84
+
85
+ ## Global configurations:
86
+ The gem offers option to adjust behavior for the gem
87
+
88
+ ### `statement_separator`
89
+ statement divider regex to split the individual statements in one file
90
+
91
+ |type|default|
92
+ |----|-------|
93
+ |regex|[`/\R+-[^\n\r]*\R*/m`](https://github.com/railslove/cmxl/blob/main/lib/cmxl.rb#L18)|
97
94
 
95
+ ```ruby
96
+ Cmxl.config[:statement_separator] = ...
97
+ Cmxl.parse(...)
98
+ ```
99
+
100
+ ### `raise_line_format_errors`
101
+ do you want an error to be raised when a line can not be parsed?
102
+
103
+ |type|default|
104
+ |----|-------|
105
+ |boolean|[`true`](https://github.com/railslove/cmxl/blob/main/lib/cmxl.rb#L19)|
106
+
107
+ ```ruby
108
+ Cmxl.config[:raise_line_format_errors] = ...
109
+ Cmxl.parse(...)
110
+ ```
111
+
112
+ ### `strip_headers`
98
113
  Cmxl currently does not support parsing of the SWIFT headers (like {1:F01AXISINBBA ....)
99
114
  If your file comes with these headers try the `strip_headers` configuration option to strip data except the actual MT940 fields.
100
115
 
116
+ |type|default|
117
+ |----|-------|
118
+ |boolean|[`false`](https://github.com/railslove/cmxl/blob/main/lib/cmxl.rb#L20)|
119
+
101
120
  ```ruby
102
- Cmxl.config[:strip_headers] = true
121
+ Cmxl.config[:strip_headers] = ...
103
122
  Cmxl.parse(...)
104
123
  ```
105
124
 
data/lib/cmxl/fields/statement_details.rb CHANGED
@@ -7,7 +7,7 @@ module Cmxl
7
7
  class << self
8
8
  def parse(line)
9
9
  # remove line breaks as they are allowed via documentation but not needed for data-parsing
10
- super line.delete("\n")
10
+ super line.gsub(/\R?/, '')
11
11
  end
12
12
  end
13
13
 
data/lib/cmxl/statement.rb CHANGED
@@ -41,8 +41,7 @@ module Cmxl
41
41
  end
42
42
 
43
43
  def strip_headers!
44
- source.gsub!(/\A.+?(?=^:)/m, '') # beginning: strip every line in the beginning that does not start with a :
45
- source.gsub!(/^[^:]+\z/, '') # end: strip every line in the end that does not start with a :
44
+ source.gsub!(/\A.*?(?=^:)/m, '') # beginning: strip every line in the beginning that does not start with a :
46
45
  source.strip!
47
46
  end
48
47
 
data/lib/cmxl/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module Cmxl
2
- VERSION = '2.0'.freeze
2
+ VERSION = '2.2'.freeze
3
3
  end
data/lib/cmxl.rb CHANGED
@@ -11,9 +11,13 @@ module Cmxl
11
11
  @config
12
12
  end
13
13
  @config = {
14
- statement_separator: /\n-\s*\n/m,
14
+ # One or more newlines
15
+ # followed by `-` at the beginning of a line.
16
+ # "Eats up" but does not require characters until the end of the line and more newlines.
17
+ # \R is a platform independent newline but in the negated group `[^\n\r]` that did not seem to work.
18
+ statement_separator: /\R+-[^\n\r]*\R*/m,
15
19
  raise_line_format_errors: true,
16
- strip_headers: false
20
+ strip_headers: true
17
21
  }
18
22
 
19
23
  # Public: Parse a MT940 string
data/spec/fields/statement_details_spec.rb CHANGED
@@ -75,6 +75,47 @@ describe Cmxl::Fields::StatementDetails do
75
75
  )
76
76
  }
77
77
  it { expect(subject.to_hash).to eql(subject.to_h) }
78
+
79
+ context 'with newlines in windows format' do
80
+ it 'removes any newlines' do
81
+ data = ":86:171?00SEPA LASTSCHRIFT KUNDE?10281?\r\n20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22MREF+CAC97D2144174318AC18D9?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?\r\n32Peter Pan?99?34171"
82
+ result = Cmxl::Fields::StatementDetails.parse(data)
83
+
84
+ expect(result.to_h).to eql(
85
+ 'bic' => 'HYVEDEMMXXX',
86
+ 'iban' => 'HUkkbbbsssskcccccccccccccccx',
87
+ 'name' => 'Peter Pan',
88
+ 'sepa' => {
89
+ 'KREF' => '',
90
+ 'EREF' => 'TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
91
+ 'MREF' => 'CAC97D2144174318AC18D9BF815BD4FB',
92
+ 'CRED' => 'DE98ZZZ09999999999',
93
+ 'SVWZ' => 'FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F'
94
+ },
95
+ 'information' => 'KREF+EREF+TRX-0A4A47C3-F846-4729-8A1B-5DF620FMREF+CAC97D2144174318AC18D9BF815BD4FBCRED+DE98ZZZ09999999999SVWZ+FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
96
+ 'description' => 'SEPA LASTSCHRIFT KUNDE',
97
+ 'sub_fields' => {
98
+ '00' => 'SEPA LASTSCHRIFT KUNDE',
99
+ '10' => '281',
100
+ '20' => 'KREF+EREF+TRX-0A4A47C3-F846-4729',
101
+ '21' => '-8A1B-5DF620F',
102
+ '22' => 'MREF+CAC97D2144174318AC18D9',
103
+ '23' => 'BF815BD4FB',
104
+ '24' => 'CRED+DE98ZZZ09999999999',
105
+ '25' => 'SVWZ+FOO TRX-0A4A47C3-F84',
106
+ '26' => '6-4729-8A1B-5DF620F',
107
+ '30' => 'HYVEDEMMXXX',
108
+ '31' => 'HUkkbbbsssskcccccccccccccccx',
109
+ '32' => 'Peter Pan',
110
+ '34' => '171',
111
+ '99' => ''
112
+ },
113
+ 'transaction_code' => '171',
114
+ 'primanota' => '281',
115
+ 'details' => '?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22MREF+CAC97D2144174318AC18D9?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171'
116
+ )
117
+ end
118
+ end
78
119
  end
79
120
 
80
121
  describe 'information parsing with empty fields on the end' do
data/spec/fixtures/mt940-abnamro.txt ADDED
@@ -0,0 +1,44 @@
1
+ ABNANL2A
2
+ 940
3
+ ABNANL2A
4
+ :20:ABN AMRO BANK NV
5
+ :25:517852257
6
+ :28:19321/1
7
+ :60F:C110522EUR3236,28
8
+ :61:1105240524D9,N192NONREF
9
+ :86:GIRO 428428 KPN - DIGITENNE BETALINGSKENM. 000000042188659
10
+ 5314606715 BETREFT FACTUUR D.D. 20-05-2011
11
+ INCL. 1,44 BTW
12
+ :61:1105210523D11,59N426NONREF
13
+ :86:BEA NR:XXX1234 21.05.11/12.54 DIRCKIII FIL2500 KATWIJK,PAS999
14
+ :61:1105230523D11,63N426NONREF
15
+ :86:BEA NR:XXX1234 23.05.11/09.08 DIGROS FIL1015 KATWIJK Z,PAS999
16
+ :61:1105220523D11,8N426NONREF
17
+ :86:BEA NR:XXX1234 22.05.11/14.25 MC DONALDS A44 LEIDEN,PAS999
18
+ :61:1105210523D13,45N426NONREF
19
+ :86:BEA NR:XXX1234 21.05.11/12.09 PRINCE FIL. 55 KATWIJK Z,PAS999
20
+ :61:1105210523D15,49N426NONREF
21
+ :86:BEA NR:XXX1234 21.05.11/12.55 DIRX FIL6017 KATWIJK ZH ,PAS999
22
+
23
+ :61:1105210523D107,N426NONREF
24
+ :86:BEA NR:XXX1234 21.05.11/12.04 HANS ANDERS OPT./056 KAT,PAS999
25
+ :61:1105220523D141,48N426NONREF
26
+ :86:BEA NR:XXX1234 22.05.11/13.45 MYCOM DEN HAAG S-GRAVEN,PAS999
27
+ :62F:C110523EUR876,84
28
+
29
+ -
30
+
31
+ ABNANL2A
32
+ 940
33
+ ABNANL2A
34
+ :20:ABN AMRO BANK NV
35
+ :25:517852257
36
+ :28:19322/1
37
+ :60F:C110523EUR2876,84
38
+ :61:1105240524D9,49N426NONREF
39
+ :86:BEA NR:XXX1234 24.05.11/09.18 PETS PLACE KATWIJK KATWI,PAS999
40
+ :61:1105240524D15,N426NONREF
41
+ :86:52.89.39.882 MYCOM DEN HAAG S-GRAVEN,PAS999
42
+ :62F:C110524EUR1849,75
43
+
44
+ -
data/spec/fixtures/mt940-handelsbank.txt ADDED
@@ -0,0 +1,16 @@
1
+ ä4:
2
+ :20:5566778899100112
3
+ :25:10020030/1234567
4
+ :28C:188/1
5
+ :60F:C130928SEK0,
6
+ :62F:C130930SEK0,
7
+ :64:C130930SEK0,
8
+ -å
9
+ ä4:
10
+ :20:5566778899100169
11
+ :25:10020030/1234567
12
+ :28C:188/1
13
+ :60F:C130928SEK0,
14
+ :62F:C130930SEK0,
15
+ :64:C130930SEK0,
16
+ -å
data/spec/fixtures/mt940-windows-line-breaks.txt ADDED
@@ -0,0 +1,16 @@
1
+ {1:D02AASDISLNETAXXXXXXXXXXXXX}
2
+ {2:E623XXXXXXXXAXXXN}
3
+ {4:
4
+ :20:1234567
5
+ :21:9876543210
6
+ :25:10020030/1234567
7
+ :28C:5/1
8
+ :60F:C160314EUR2187,95
9
+ :61:0211011102DR800,NSTONONREF//55555
10
+ :86:008?00DAUERAUFTRAG?100599?20Miete November?3010020030?31234567?32MUELLER?34339
11
+ :61:0211021102CR3000,NTRFNONREF//55555
12
+ :86:051?00UEBERWEISUNG?100599?20Gehalt Oktober?21Firma
13
+ Mustermann GmbH?3050060400?310847564700?32MUELLER?34339
14
+ :62F:C160315EUR4387,95
15
+ :86:Some random data
16
+ -}
data/spec/mt940_parsing_spec.rb CHANGED
@@ -95,4 +95,115 @@ describe 'parsing a statement' do
95
95
  expect(subject[0].transactions.count).to eql(1)
96
96
  end
97
97
  end
98
+
99
+ describe "MT940 abnamro" do
100
+ it "splits the file into on statement with the headers included" do
101
+ expected_data = <<~MT940.chomp
102
+ ABNANL2A
103
+ 940
104
+ ABNANL2A
105
+ :20:ABN AMRO BANK NV
106
+ :25:517852257
107
+ :28:19321/1
108
+ :60F:C110522EUR3236,28
109
+ :61:1105240524D9,N192NONREF
110
+ :86:GIRO 428428 KPN - DIGITENNE BETALINGSKENM. 000000042188659
111
+ 5314606715 BETREFT FACTUUR D.D. 20-05-2011
112
+ INCL. 1,44 BTW
113
+ :61:1105210523D11,59N426NONREF
114
+ :86:BEA NR:XXX1234 21.05.11/12.54 DIRCKIII FIL2500 KATWIJK,PAS999
115
+ :61:1105230523D11,63N426NONREF
116
+ :86:BEA NR:XXX1234 23.05.11/09.08 DIGROS FIL1015 KATWIJK Z,PAS999
117
+ :61:1105220523D11,8N426NONREF
118
+ :86:BEA NR:XXX1234 22.05.11/14.25 MC DONALDS A44 LEIDEN,PAS999
119
+ :61:1105210523D13,45N426NONREF
120
+ :86:BEA NR:XXX1234 21.05.11/12.09 PRINCE FIL. 55 KATWIJK Z,PAS999
121
+ :61:1105210523D15,49N426NONREF
122
+ :86:BEA NR:XXX1234 21.05.11/12.55 DIRX FIL6017 KATWIJK ZH ,PAS999
123
+
124
+ :61:1105210523D107,N426NONREF
125
+ :86:BEA NR:XXX1234 21.05.11/12.04 HANS ANDERS OPT./056 KAT,PAS999
126
+ :61:1105220523D141,48N426NONREF
127
+ :86:BEA NR:XXX1234 22.05.11/13.45 MYCOM DEN HAAG S-GRAVEN,PAS999
128
+ :62F:C110523EUR876,84
129
+ MT940
130
+ stub = instance_double(Cmxl::Statement)
131
+ allow(Cmxl::Statement).to receive(:new).and_return(stub)
132
+
133
+ Cmxl.parse(mt940_file('mt940-abnamro'))
134
+
135
+ expect(Cmxl::Statement).to have_received(:new).with(expected_data)
136
+ end
137
+
138
+ it 'splits the file into two statements' do
139
+ allow(Cmxl::Statement).to receive(:new)
140
+
141
+ Cmxl.parse(mt940_file('mt940-abnamro'))
142
+
143
+ expect(Cmxl::Statement).to have_received(:new).twice
144
+ end
145
+ end
146
+
147
+ describe 'MT940 handelsbank' do
148
+ it 'splits the file with the special characters correctly' do
149
+ expected_data = <<~MT940.chomp
150
+ 채4:
151
+ :20:5566778899100112
152
+ :25:10020030/1234567
153
+ :28C:188/1
154
+ :60F:C130928SEK0,
155
+ :62F:C130930SEK0,
156
+ :64:C130930SEK0,
157
+ MT940
158
+ stub = instance_double(Cmxl::Statement)
159
+ allow(Cmxl::Statement).to receive(:new).and_return(stub)
160
+
161
+ Cmxl.parse(mt940_file('mt940-handelsbank'))
162
+
163
+ expect(Cmxl::Statement).to have_received(:new).with(expected_data)
164
+ end
165
+
166
+ it 'splits the file into two statements' do
167
+ allow(Cmxl::Statement).to receive(:new)
168
+
169
+ Cmxl.parse(mt940_file('mt940-handelsbank'))
170
+
171
+ expect(Cmxl::Statement).to have_received(:new).twice
172
+ end
173
+ end
174
+
175
+ describe "MT940 windows line breaks" do
176
+ it 'splits the file with the special characters correctly' do
177
+ expected_data =
178
+ "{1:D02AASDISLNETAXXXXXXXXXXXXX}\r\n"\
179
+ "{2:E623XXXXXXXXAXXXN}\r\n"\
180
+ "{4:\r\n"\
181
+ ":20:1234567\r\n"\
182
+ ":21:9876543210\r\n"\
183
+ ":25:10020030/1234567\r\n"\
184
+ ":28C:5/1\r\n"\
185
+ ":60F:C160314EUR2187,95\r\n"\
186
+ ":61:0211011102DR800,NSTONONREF//55555\r\n"\
187
+ ":86:008?00DAUERAUFTRAG?100599?20Miete November?3010020030?31234567?32MUELLER?34339\r\n"\
188
+ ":61:0211021102CR3000,NTRFNONREF//55555\r\n"\
189
+ ":86:051?00UEBERWEISUNG?100599?20Gehalt Oktober?21Firma\r\n"\
190
+ "Mustermann GmbH?3050060400?310847564700?32MUELLER?34339\r\n"\
191
+ ":62F:C160315EUR4387,95\r\n"\
192
+ ":86:Some random data"
193
+ stub = instance_double(Cmxl::Statement)
194
+ allow(Cmxl::Statement).to receive(:new).and_return(stub)
195
+
196
+ Cmxl.parse(mt940_file('mt940-windows-line-breaks'))
197
+
198
+ expect(Cmxl::Statement).to have_received(:new).with(expected_data)
199
+ end
200
+
201
+ it 'splits the file into two statements' do
202
+ allow(Cmxl::Statement).to receive(:new)
203
+
204
+ Cmxl.parse(mt940_file('mt940-windows-line-breaks'))
205
+
206
+ expect(Cmxl::Statement).to have_received(:new).once
207
+ end
208
+ end
98
209
  end
data/spec/statement_spec.rb CHANGED
@@ -101,7 +101,7 @@ describe Cmxl do
101
101
  end
102
102
  end
103
103
 
104
- describe 'statement issued over a years boudary' do
104
+ describe 'statement issued over a years boundary' do
105
105
  subject { Cmxl.parse(mt940_file('statement-mt940')).first.transactions.last }
106
106
 
107
107
  it { expect(subject.mt942?).to be_falsey }
@@ -167,4 +167,95 @@ describe Cmxl do
167
167
  it { expect(statement.generation_date).to eql(Date.new(2019, 1, 9)) }
168
168
  end
169
169
 
170
+ describe "header parsing" do
171
+ context "when strip_headers is enabled" do
172
+ around do |example|
173
+ existing_value = Cmxl.config[:strip_headers]
174
+ Cmxl.config[:strip_headers] = true
175
+ example.run
176
+ Cmxl.config[:strip_headers] = existing_value
177
+ end
178
+
179
+ it "removes any headers" do
180
+ data = <<~MT940.chomp
181
+ {1:D02AASDISLNETAXXXXXXXXXXXXX}
182
+ {2:E623XXXXXXXXAXXXN}
183
+ {4:
184
+ :20:MT940/78374
185
+ :25:xxxxxxxxxxxxxx
186
+ :28C:3/1
187
+ :60F:C160201INR0,00
188
+ :61:3622687806CR1368378,92NMSC37935531
189
+ :86:-TX TRN-REF NO.1156ADS5601187 EUR 13456/TSV
190
+ :62F:C141387INR11 27421,94
191
+ -}
192
+ MT940
193
+
194
+ result = Cmxl::Statement.new(data)
195
+
196
+ expect(result.fields.count).to eq(6)
197
+ end
198
+
199
+ it "does nothing if there are no headers" do
200
+ data = <<~MT940.chomp
201
+ :20:MT940/78374
202
+ :25:xxxxxxxxxxxxxx
203
+ :28C:3/1
204
+ :60F:C160201INR0,00
205
+ :61:3622687806CR1368378,92NMSC37935531
206
+ :86:-TX TRN-REF NO.1156ADS5601187 EUR 13456/TSV
207
+ :62F:C141387INR11 27421,94
208
+ MT940
209
+
210
+ result = Cmxl::Statement.new(data)
211
+
212
+ expect(result.fields.count).to eq(6)
213
+ end
214
+ end
215
+
216
+ context "when strip_headers is disabled" do
217
+ around do |example|
218
+ existing_value = Cmxl.config[:strip_headers]
219
+ Cmxl.config[:strip_headers] = false
220
+ example.run
221
+ Cmxl.config[:strip_headers] = existing_value
222
+ end
223
+
224
+ it "raise an parsing error exception if headers are present" do
225
+ data = <<~MT940.chomp
226
+ {1:D02AASDISLNETAXXXXXXXXXXXXX}
227
+ {2:E623XXXXXXXXAXXXN}
228
+ {4:
229
+ :20:MT940/78374
230
+ :25:xxxxxxxxxxxxxx
231
+ :28C:3/1
232
+ :60F:C160201INR0,00
233
+ :61:3622687806CR1368378,92NMSC37935531
234
+ :86:-TX TRN-REF NO.1156ADS5601187 EUR 13456/TSV
235
+ :62F:C141387INR11 27421,94
236
+ -}
237
+ MT940
238
+
239
+ expect{
240
+ Cmxl::Statement.new(data)
241
+ }.to raise_error(Cmxl::Field::LineFormatError)
242
+ end
243
+
244
+ it "extracts the field" do
245
+ data = <<~MT940.chomp
246
+ :20:MT940/78374
247
+ :25:xxxxxxxxxxxxxx
248
+ :28C:3/1
249
+ :60F:C160201INR0,00
250
+ :61:3622687806CR1368378,92NMSC37935531
251
+ :86:-TX TRN-REF NO.1156ADS5601187 EUR 13456/TSV
252
+ :62F:C141387INR11 27421,94
253
+ MT940
254
+
255
+ result = Cmxl::Statement.new(data)
256
+
257
+ expect(result.fields.count).to eq(6)
258
+ end
259
+ end
260
+ end
170
261
  end
metadata CHANGED
@@ -1,13 +1,13 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: cmxl
3
3
  version: !ruby/object:Gem::Version
4
- version: '2.0'
4
+ version: '2.2'
5
5
  platform: ruby
6
6
  authors:
7
7
  - Michael Bumann
8
8
  bindir: bin
9
9
  cert_chain: []
10
- date: 2025-01-10 00:00:00.000000000 Z
10
+ date: 2025-02-04 00:00:00.000000000 Z
11
11
  dependencies:
12
12
  - !ruby/object:Gem::Dependency
13
13
  name: rchardet
@@ -163,9 +163,12 @@ files:
163
163
  - spec/fixtures/lines/statement_supplementary_plain.txt
164
164
  - spec/fixtures/lines/vmk_summary_credit.txt
165
165
  - spec/fixtures/lines/vmk_summary_debit.txt
166
+ - spec/fixtures/mt940-abnamro.txt
166
167
  - spec/fixtures/mt940-deutsche_bank.txt
168
+ - spec/fixtures/mt940-handelsbank.txt
167
169
  - spec/fixtures/mt940-headers.txt
168
170
  - spec/fixtures/mt940-iso8859-1.txt
171
+ - spec/fixtures/mt940-windows-line-breaks.txt
169
172
  - spec/fixtures/mt940-with-colon-after-line-break.txt
170
173
  - spec/fixtures/mt940-with-detailed-end-balance.txt
171
174
  - spec/fixtures/mt940.txt
@@ -238,9 +241,12 @@ test_files:
238
241
  - spec/fixtures/lines/statement_supplementary_plain.txt
239
242
  - spec/fixtures/lines/vmk_summary_credit.txt
240
243
  - spec/fixtures/lines/vmk_summary_debit.txt
244
+ - spec/fixtures/mt940-abnamro.txt
241
245
  - spec/fixtures/mt940-deutsche_bank.txt
246
+ - spec/fixtures/mt940-handelsbank.txt
242
247
  - spec/fixtures/mt940-headers.txt
243
248
  - spec/fixtures/mt940-iso8859-1.txt
249
+ - spec/fixtures/mt940-windows-line-breaks.txt
244
250
  - spec/fixtures/mt940-with-colon-after-line-break.txt
245
251
  - spec/fixtures/mt940-with-detailed-end-balance.txt
246
252
  - spec/fixtures/mt940.txt