cmxl 1.4.1 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41f6f1b53eb060758d035fe5d0b3475b42b12bf10c749418a3b72b3c98482140
-  data.tar.gz: 1e5f3ee6fcbbdca480600b029c573ccc614a2adba34e66c440286a99d5be963b
+  metadata.gz: 661a3296bdc88ce9874f07cb4a1cf4220bf1a60ea559e289edc5c5c34774764b
+  data.tar.gz: 4f0217f656646bd14540e5993f6419354641f30d901e8b7afc884b46fc5ac69e
 SHA512:
-  metadata.gz: 1f4af37922a0e6d14795c7274a64a60697660b6e0f7399947e7bdae6973b4ea3dbe22a3e73e2923004a16ce215577565ac4f609283752401359228d8709e7c57
-  data.tar.gz: 0a9aecfe5f17a5bd09dcce8e96c45af26c3d89c79ce505aad9806849e1fbaa082dccb02d562ff8552283a14d6027a4f5b11de3a1237dc790d0c609bdc1f15d1f
+  metadata.gz: 407ecb157601f8cc767ddb7699edbadc66582041cdcd8d1de3b3e169a41865d3f81ffdb794b7b9f8add8a55ecea1e16e4048f30a117cfe2401b05b487d2e1bcf
+  data.tar.gz: 4cbfe3e46cc9a00527bfa1a4d465f5e0ad4311d915449b45a81b172e1a653ee3ec2605778bb1241aca752016651b8f54dad0daf00769349a6a80cb679cff0dcf

data/.travis.yml

@@ -1,18 +1,9 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.2.8
-  - 2.3.4
-  - 2.4.3
-  - 2.5.0
-  - jruby-9.1.10.0
-before_install: if [[ `ruby -v` =~ 2.2.8 ]];
-  then gem update --system 2.7.8;
-  else gem update --system;
-  fi
-
-after_success:
-  - bundle exec codeclimate-test-reporter
-addons:
-  code_climate:
-    repo_token: 149f0d20e17ace00c44be432a4194bc441ba805da89a7708fca0f4a2c3f2aed7
+  - 2.4.10
+  - 2.5.8
+  - 2.6.6
+  - 2.7.1
+  - jruby-9.1.17.0
+  - jruby-9.2.11.1

data/CHANGELOG.mdown

@@ -1,37 +1,65 @@
+# NEXT release
+
+# 1.5.0
+
+- `[BUGFIX]` fix potential bug when generation_date is not provided in field 20 and 13 (issue: [#35](https://github.com/railslove/cmxl/issues/35) PR: [#36](https://github.com/railslove/cmxl/pull/36))
+- `[FEATURE]` add transaction type 'S' to Field 61 (swift_code) (issue: [#38](https://github.com/railslove/cmxl/issues/38) PR: [#42](https://github.com/railslove/cmxl/pull/42)
+- `[ENHANCEMENT]` [Fix deprecations in ruby 2.7 for kw params](https://github.com/railslove/cmxl/commit/905cd50e5372da312a653c89e77727a14751b5ec)
+
+# 1.4.6
+
+- `[ENHANCEMENT]` make sure that tag, gemversion and readme align ʘ‿ʘ
+
+# 1.4.5
+
+- `[ENHANCEMENT]` renames transaction_id to primanota
+
+# 1.4.4
+
+- `[FEATURE]` adds transaction id parsing to statement details
+
+# 1.4.3
+
+- `[BUGFIX]` parse field identifier only at the beginning of lines
+
+# 1.4.2
+
+- `[ENHANCEMENT]` handles broken account data without blowing up
+
 # 1.4.1
 
-- [BUGFIX] changes entry date calculation for transaction
+- `[BUGFIX]` changes entry date calculation for transaction
   Thanks to [@grncdr](https://github.com/grncdr)
 
 # 1.4.0
 
-- [FEATURE] adds ability to parse non-numerical tags ([#23](https://github.com/railslove/cmxl/issues/23)) \
+- `[FEATURE]` adds ability to parse non-numerical tags ([#23](https://github.com/railslove/cmxl/issues/23)) \
   Thanks to [@prometh07](https://github.com/prometh07)
 
 # 1.3.0
 
-- [FEATURE] adds MT942 compatibility
+- `[FEATURE]` adds MT942 compatibility
 
 # 1.2.0
 
-- [FEATURE] strips mt940 header if configured ([#9](https://github.com/railslove/cmxl/issues/9))
+- `[FEATURE]` strips mt940 header if configured ([#9](https://github.com/railslove/cmxl/issues/9))
   ```ruby
     Cmxl.config[:strip_headers] = true
   ```
 
 # 1.1.1
 
-- [BUGFIX] prevents short bank references from swallowing supplementary details delimiter
+- `[BUGFIX]` prevents short bank references from swallowing supplementary details delimiter
 
 # 1.1.0
 
-- [FEATURE] adds support for supplementary details in transactions (Field 61, Subfield 9) ([#18](https://github.com/railslove/cmxl/issues/18))
+- `[FEATURE]` adds support for supplementary details in transactions (Field 61, Subfield 9) ([#18](https://github.com/railslove/cmxl/issues/18))
 
 # 1.0.0
 
-- [FEATURE] adds support for storno transactions ([#14](https://github.com/railslove/cmxl/issues/14))
-- [NOTE] full backwards compatibility
-- [NOTE] same as release 0.2.2, fixing versioning
+- `[FEATURE]` adds support for storno transactions ([#14](https://github.com/railslove/cmxl/issues/14))
+- `[NOTE]` full backwards compatibility
+- `[NOTE]` same as release 0.2.2, fixing versioning
 
 # 0.2.1
 
@@ -48,8 +76,8 @@
 
 # 0.1.3
 
-- [BUGFIX] fixed the statement details parser. It failed in case of empty values in the SEPA details
+- `[BUGFIX]` fixed the statement details parser. It failed in case of empty values in the SEPA details
 
 # 0.1.2
 
-- [BUGFIX] fixed the statement details parser. It failed in case of empty values in the sub fields
+- `[BUGFIX]` fixed the statement details parser. It failed in case of empty values in the sub fields

data/Gemfile

@@ -1,5 +1,4 @@
 source 'https://rubygems.org'
 
-gem "codeclimate-test-reporter", group: :test, require: nil
 # Specify your gem's dependencies in cmxl.gemspec
 gemspec

data/README.md

@@ -1,11 +1,12 @@
 [![Build Status](https://travis-ci.org/railslove/cmxl.svg?branch=master)](https://travis-ci.org/railslove/cmxl)
+[![Gem Version](https://badge.fury.io/rb/cmxl.svg)](http://badge.fury.io/rb/cmxl)
 
 # Cmxl - your friendly ruby MT940 parser
 
 At [Railslove](http://railslove.com) we build a lot of financial applications and work on integrating applications with banks and banking functionality.
 Our goal is to make simple solutions for what often looks complicated.
 
-Cmxl is a friendly and extendible MT940 bank statement file parser that helps your extracting data from the bank statement files.
+Cmxl is a friendly and extensible MT940 bank statement file parser that helps you extract data from bank statement files.
 
 ## What is MT940 & MT942?
 
@@ -13,13 +14,13 @@ MT940 (MT = Message Type) is the SWIFT-Standard for the electronic transfer of b
 When integrating with banks you often get MT940 or MT942 files as interface.
 For more information have a look at the different [SWIFT message types](http://en.wikipedia.org/wiki/SWIFT_message_types)
 
-At some point in the future MT940 file should be exchanged with newer XML documents - but banking institutions are slow so MT940 will stick around for a while.
+At some point in the future MT940 file should be exchanged with newer XML documents - but banking institutions are slow, so MT940 will stick around for a while.
 
 ## Reqirements
 
 Cmxl is a pure ruby parser and has no dependency on native extensions.
 
-- Ruby 1.9.3 or newer (jruby, etc.)
+- Ruby (current officially supported distributions)
 
 ## Installation
 
@@ -49,7 +50,7 @@ Cmxl.config[:statement_separator] = /\n-.\n/m
 # do you want an error to be raised when a line can not be parsed? default is true
 Cmxl.config[:raise_line_format_errors] = true
 
-# try to stip the SWIFT header data. This strips everything until the actual first MT940 field. (if parsing fails try this!)
+# try to stip the SWIFT header data. This strips everything until the actual first MT940 field. (if parsing fails, try this!)
 Cmxl.config[:strip_headers] = true
 
 
@@ -61,7 +62,7 @@ statements.each do |s|
   puts s.generation_date
   puts s.opening_balance.amount
   puts s.closing_balance.amount
-  puts s.sha # SHA of the statement source - could be used as an unique identifier
+  puts s.sha # SHA of the statement source - could be used as an identifier (see: https://github.com/railslove/cmxl/blob/master/lib/cmxl/statement.rb#L49-L55)
 
   s.transactions.each do |t|
     puts t.information
@@ -83,14 +84,14 @@ end
 
 ```
 
-Every object responds to `to_h` and let's you easily convert the data to a hash. Also every object responds to `to_json` which lets you easily represent the statements as JSON with your favorit JSON library.
+Every object responds to `to_h` and let's you easily convert the data to a hash. Also every object responds to `to_json` which lets you easily represent the statements as JSON with your favorite JSON library.
 
-#### A note about encoding and file wirednesses
+#### A note about encoding and file weirdnesses
 
 You probably will encounter encoding issues (hey, you are building banking applications!).
-We try to handle encoding and format wirednesses as much as possible. If no encoding is passed we try to guess the encoding of the data and convert it to UTF8.
-In the likely case that you encouter encoding issues you can pass encoding options to the `Cmxl.parse(<string>, <options hash>)` it accepts the same options as [String#encode](http://ruby-doc.org/core-2.1.3/String.html#method-i-encode)
-If that fails try to motify the file before you pass it to the parser - and please create an issue.
+We try to handle encoding and format weirdnesses as much as possible. If no encoding is passed we try to guess the encoding of the data and convert it to UTF8.
+In the likely case that you encounter encoding issues you can pass encoding options to `Cmxl.parse(<string>, <options hash>)`. It accepts the same options as [String#encode](http://ruby-doc.org/core-2.1.3/String.html#method-i-encode)
+If that fails, try to modify the file before you pass it to the parser - and please create an issue.
 
 ### MT940 SWIFT header data
 
@@ -184,13 +185,8 @@ other parsers:
 - [betterplace/mt940_parser](https://github.com/betterplace/mt940_parser)
 - [gmitrev/mt940parser](https://github.com/gmitrev/mt940parser)
 
-## Stats
-
-[![Build Status](https://travis-ci.org/railslove/cmxl.svg)](https://travis-ci.org/railslove/cmxl)
-[![Code Climate](https://codeclimate.com/github/railslove/cmxl/badges/gpa.svg)](https://codeclimate.com/github/railslove/cmxl)
-[![Test Coverage](https://codeclimate.com/github/railslove/cmxl/badges/coverage.svg)](https://codeclimate.com/github/railslove/cmxl)
-[![Gem Version](https://badge.fury.io/rb/cmxl.svg)](http://badge.fury.io/rb/cmxl)
-
 ---
+built with love by [Railslove](http://railslove.com) and some [amazing people](https://github.com/railslove/cmxl/graphs/contributors).  
+Released under the MIT-Licence. 
 
-2014 - built with love by [Railslove](http://railslove.com) and released under the MIT-Licence. We have built quite a number of FinTech products. If you need support we are happy to help. Please contact us at team@railslove.com.
+Railslove builds FinTech products, if you need support for your project we are happy to help. Please contact us at team@railslove.com.

data/lib/cmxl.rb

@@ -36,9 +36,9 @@ module Cmxl
     end
 
     if options[:encoding]
-      data.encode!('UTF-8', options.delete(:encoding), options)
+      data.encode!('UTF-8', options.delete(:encoding), **options)
     else
-      data.encode!('UTF-8', options) unless options.empty?
+      data.encode!('UTF-8', **options) unless options.empty?
     end
 
     data.split(options[:statement_separator]).reject { |s| s.strip.empty? }.collect { |s| Cmxl::Statement.new(s.strip) }

data/lib/cmxl/fields/account_balance.rb

@@ -2,7 +2,7 @@ module Cmxl
   module Fields
     class AccountBalance < Field
       self.tag = 60
-      self.parser = /(?<funds_code>\A[a-zA-Z]{1})(?<date>\d{6})(?<currency>[a-zA-Z]{3})(?<amount>[\d|,|\.]{4,15})/i
+      self.parser = /(?<funds_code>\A[a-zA-Z]{1})(?<date>\d{6})(?<currency>[a-zA-Z]{3})(?<amount>[\d|,|\.]{1,15})/i
 
       def date
         to_date(data['date'])

data/lib/cmxl/fields/statement_details.rb

@@ -38,6 +38,10 @@ module Cmxl
         end
       end
 
+      def primanota
+        sub_fields['10']
+      end
+
       def bic
         sub_fields['30']
       end
@@ -60,6 +64,7 @@ module Cmxl
           'description' => description,
           'sub_fields' => sub_fields,
           'transaction_code' => transaction_code,
+          'primanota' => primanota,
           'details' => details
         }
       end

data/lib/cmxl/fields/transaction.rb

@@ -2,7 +2,7 @@ module Cmxl
   module Fields
     class Transaction < Field
       self.tag = 61
-      self.parser = %r{^(?<date>\d{6})(?<entry_date>\d{4})?(?<storno_flag>R?)(?<funds_code>[CD]{1})(?<currency_letter>[a-zA-Z])?(?<amount>\d{1,12},\d{0,2})(?<swift_code>(?:N|F).{3})(?<reference>NONREF|(.(?!\/\/)){,16}([^\/]){,1})((?:\/\/)(?<bank_reference>[^\n]{,16}))?((?:\n)(?<supplementary>.{,34}))?$}
+      self.parser = %r{^(?<date>\d{6})(?<entry_date>\d{4})?(?<storno_flag>R?)(?<funds_code>[CD]{1})(?<currency_letter>[a-zA-Z])?(?<amount>\d{1,12},\d{0,2})(?<swift_code>(?:N|F|S).{3})(?<reference>NONREF|(.(?!\/\/)){,16}([^\/]){,1})((?:\/\/)(?<bank_reference>[^\n]{,16}))?((?:\n)(?<supplementary>.{,34}))?$}
 
       attr_accessor :details
 
@@ -126,6 +126,10 @@ module Cmxl
         details.sub_fields if details
       end
 
+      def primanota
+        details.primanota if details
+      end
+
       def to_h
         {
           'sha' => sha,

data/lib/cmxl/statement.rb

@@ -26,7 +26,7 @@ module Cmxl
     def parse!
       self.fields = []
 
-      lines = source.split(/(:[0-9A-Z]{2,3}:)/m).reject(&:empty?).each_slice(2).map(&:join)
+      lines = source.split(/(^:[0-9A-Z]{2,3}:)/m).reject(&:empty?).each_slice(2).map(&:join)
 
       lines.map do |line|
         if line =~ /\A:86:/
@@ -58,8 +58,9 @@ module Cmxl
       field(20).reference
     end
 
+    #Get generation date from field 20. If generation date is not provided in field 20, method will fall back to field 13 if present.
     def generation_date
-      field(20).date || field(13).date
+      field(20).date || (field(13).nil? ? nil : field(13).date)
     end
 
     def account_identification

data/lib/cmxl/version.rb

@@ -1,3 +1,3 @@
 module Cmxl
-  VERSION = '1.4.1'.freeze
+  VERSION = '1.5.0'.freeze
 end

data/spec/fields/account_balance_spec.rb

@@ -39,4 +39,11 @@ describe Cmxl::Fields::AccountBalance do
     it { expect(subject.amount_in_cents).to eql(14_764) }
     it { expect(subject.sign).to eql(-1) }
   end
+
+  context 'broken debit' do
+    subject { Cmxl::Fields::AccountBalance.parse(fixture_line(:account_balance_debit_broken)) }
+
+    it { expect(subject.amount).to eql(0.0) }
+    it { expect(subject.amount_in_cents).to eql(0) }
+  end
 end

data/spec/fields/statement_details_spec.rb

@@ -70,6 +70,7 @@ describe Cmxl::Fields::StatementDetails do
           '99' => ''
         },
         'transaction_code' => '171',
+        'primanota' => '281',
         'details' => '?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22MREF+CAC97D2144174318AC18D9?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171'
       )
     }

data/spec/fields/transaction_spec.rb

@@ -9,6 +9,7 @@ describe Cmxl::Fields::Transaction do
   subject(:complex_supplementary_transaction) { Cmxl::Fields::Transaction.parse(fixture_line(:statement_supplementary_complex)) }
   subject(:valuta_after_enty_date) { Cmxl::Fields::Transaction.parse(fixture[3]) }
   subject(:entry_before_valuta_transaction) { Cmxl::Fields::Transaction.parse(fixture[2]) }
+  subject(:transaction_type_swift) { Cmxl::Fields::Transaction.parse(fixture[4]) }
 
   let(:fixture) { fixture_line(:statement_line).split(/\n/) }
 
@@ -91,4 +92,19 @@ describe Cmxl::Fields::Transaction do
       expect(valuta_after_enty_date.entry_date).to eql(Date.new(2015, 1, 2))
     end
   end
+
+  context 'transaction type swift transfer' do
+    it { expect(transaction_type_swift.date).to eql(Date.new(2019, 11, 18)) }
+    it { expect(transaction_type_swift.entry_date).to eql(Date.new(2019, 11, 18)) }
+    it { expect(transaction_type_swift.funds_code).to eql('C') }
+    it { expect(transaction_type_swift.currency_letter).to eql('R') }
+    it { expect(transaction_type_swift.amount).to eql(653.0) }
+    it { expect(transaction_type_swift.amount_in_cents).to eql(65300) }
+    it { expect(transaction_type_swift.swift_code).to eql('S445') }
+    it { expect(transaction_type_swift.reference).to eql('328556-76501096') }
+    it { expect(transaction_type_swift).to be_credit }
+    it { expect(transaction_type_swift).not_to be_debit }
+    it { expect(transaction_type_swift).not_to be_storno }
+    it { expect(transaction_type_swift.sign).to eql(1) }
+  end
 end

data/spec/fixtures/lines/account_balance_debit_broken.txt

@@ -0,0 +1 @@
+:60F:D140829EUR0,

data/spec/fixtures/lines/statement_line.txt

@@ -2,3 +2,5 @@
 :61:1409010902RCR000000000001,62NTRF0000549855700010//025498557/000001
 :61:1401101224CR000000000001,62NTRF0000549855700010//025498557/000001
 :61:1412240102CR000000000001,62NTRF0000549855700010//025498557/000001
+:61:1911181118CR653,00S445328556-76501096
+

data/spec/fixtures/mt940.txt

@@ -74,3 +74,34 @@ Interest credit
 :62F:C020325PLN50040,00
 
 -
+
+:20:01ANWZTPJTYEGJWA
+:25:45050050/76198810
+:28:27/01
+:60F:C131016DEM84349,74
+:61:131017D6800,NCHK16703074
+:86:999PN5477SCHECK-NR. 0000016703074
+:61:131017D620,3NSTON
+:86:999PN0911DAUERAUFTR.NR. 14
+:61:131017C18500,NCLRN
+:86:999PN2406SCHECK
+:61:131015D14220,NBOEN
+:86:999PN0920WECHSEL
+:61:131017D1507,NTRFN
+:86:999PN0920SCHNELLUEB
+:61:131024C4200,NMSCN
+:86:999PN2506AUSSENH. NR. 1
+:61:131017D19900,NTRFN
+:86:999PN0907UEBERTRAG
+:61:131017D400,NTRFN
+:86:999PN0891BTX
+:61:131018C3656,74NMSCN
+:86:999PN0850EINZAHLG.N
+:61:131019C23040,NMSCN
+:86:999PN0812LT.ANLAGE
+:61:131027D5862,14NCHKN
+:86:999PN5329AUSLSCHECK
+:62F:C131017DEM84437,04
+
+-
+

data/spec/fixtures/mt942.txt

@@ -7,3 +7,15 @@
 :86:008?00DAUERAUFTRAG?100599?20Miete Dezember?3010020030?31234567?32MUELLER?34339
 :90D:0EUR0,00
 :90C:1EUR9792,00
+
+-
+
+:20:01ANWZTPJTYEGJWA
+:25:45050050/76198810
+:28C:13/37
+:34F:EURD12345,67
+:13D:1901091733+0100
+:61:190109C9792,00FTRFNONREF
+:86:008?00DAUERAUFTRAG?100599?20Miete Dezember?3010020030?31234567?32MUELLER?34339
+:90D:0EUR0,00
+:90C:1EUR9792,00

data/spec/fixtures/statement-details-mt940.txt

@@ -1,2 +1,2 @@
 :61:1409010902DR000000000001,62NTRF0000549855700010//025498557/000001
-:86:171?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22MREF+CAC97D2144174318AC18D9?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171
+:86:171?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22:FOO:MREF+CAC97D2144174318A?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171

data/spec/mt940_parsing_spec.rb

@@ -61,11 +61,18 @@ describe 'parsing a statement' do
     it { expect(subject.field('NS').to_h).to eql({tag: 'NS', modifier: 'F', source: 'HelloWorld'}) }
   end
 
+  context 'no generation date' do
+    subject { Cmxl.parse(mt940_file('mt940'))[3] }
+
+    it { expect(subject.reference).to eql('01ANWZTPJTYEGJWA') }
+    it { expect(subject.generation_date).to eql(nil) }
+  end
+
   context 'statement separator as used by most banks' do
     subject { Cmxl.parse(mt940_file('mt940')) }
 
     it 'detects all statements by default' do
-      expect(subject.size).to eq(3)
+      expect(subject.size).to eq(4)
     end
   end
 

data/spec/statement_spec.rb

@@ -13,6 +13,7 @@ describe Cmxl do
       it { expect(subject.entry_date).to eql(Date.new(2014, 9, 2)) }
       it { expect(subject.amount).to eql(1.62) }
       it { expect(subject.amount_in_cents).to eql(162) }
+      it { expect(subject.primanota).to eql('281') }
       it {
         expect(subject.to_h).to eql(
           'date' => Date.new(2014, 9, 1),
@@ -34,19 +35,19 @@ describe Cmxl do
           'name' => 'Peter Pan',
           'sepa' => {
             'KREF' => '',
-            'EREF' => 'TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
-            'MREF' => 'CAC97D2144174318AC18D9BF815BD4FB',
+            'EREF' => 'TRX-0A4A47C3-F846-4729-8A1B-5DF620F:FOO:',
+            'MREF' => 'CAC97D2144174318ABF815BD4FB',
             'CRED' => 'DE98ZZZ09999999999',
             'SVWZ' => 'FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F'
           },
-          'information' => 'KREF+EREF+TRX-0A4A47C3-F846-4729-8A1B-5DF620FMREF+CAC97D2144174318AC18D9BF815BD4FBCRED+DE98ZZZ09999999999SVWZ+FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
+          'information' => 'KREF+EREF+TRX-0A4A47C3-F846-4729-8A1B-5DF620F:FOO:MREF+CAC97D2144174318ABF815BD4FBCRED+DE98ZZZ09999999999SVWZ+FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
           'description' => 'SEPA LASTSCHRIFT KUNDE',
           'sub_fields' => {
             '00' => 'SEPA LASTSCHRIFT KUNDE',
             '10' => '281',
             '20' => 'KREF+EREF+TRX-0A4A47C3-F846-4729',
             '21' => '-8A1B-5DF620F',
-            '22' => 'MREF+CAC97D2144174318AC18D9',
+            '22' => ':FOO:MREF+CAC97D2144174318A',
             '23' => 'BF815BD4FB',
             '24' => 'CRED+DE98ZZZ09999999999',
             '25' => 'SVWZ+FOO TRX-0A4A47C3-F84',
@@ -58,7 +59,8 @@ describe Cmxl do
             '34' => '171'
           },
           'transaction_code' => '171',
-          'details' => '?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22MREF+CAC97D2144174318AC18D9?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171'
+          'primanota' => '281',
+          'details' => '?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22:FOO:MREF+CAC97D2144174318A?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171'
         )
       }
     end
@@ -143,4 +145,20 @@ describe Cmxl do
       expect(subject.transactions.first.iban).to eq('234567')
     end
   end
+
+  context 'mt942 generation date from field 20' do
+    subject(:statement) { Cmxl.parse(mt940_file('mt942')).first }
+
+    it { expect(statement.mt942?).to be_truthy }
+    it { expect(statement.generation_date).to eql(Date.new(2013, 11, 10)) }
+
+  end
+
+  context 'mt942 generation date from field 13' do
+    subject(:statement) { Cmxl.parse(mt940_file('mt942'))[1] }
+
+    it { expect(statement.mt942?).to be_truthy }
+    it { expect(statement.generation_date).to eql(Date.new(2019, 1, 9)) }
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cmxl
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.5.0
 platform: ruby
 authors:
 - Michael Bumann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-18 00:00:00.000000000 Z
+date: 2020-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -143,6 +143,7 @@ files:
 - spec/fields/vmk_summary_spec.rb
 - spec/fixtures/lines/account_balance_credit.txt
 - spec/fixtures/lines/account_balance_debit.txt
+- spec/fixtures/lines/account_balance_debit_broken.txt
 - spec/fixtures/lines/account_identification_iban.txt
 - spec/fixtures/lines/account_identification_legacy.txt
 - spec/fixtures/lines/available_balance.txt
@@ -197,7 +198,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Cmxl is your friendly MT940 bank statement parser
@@ -218,6 +219,7 @@ test_files:
 - spec/fields/vmk_summary_spec.rb
 - spec/fixtures/lines/account_balance_credit.txt
 - spec/fixtures/lines/account_balance_debit.txt
+- spec/fixtures/lines/account_balance_debit_broken.txt
 - spec/fixtures/lines/account_identification_iban.txt
 - spec/fixtures/lines/account_identification_legacy.txt
 - spec/fixtures/lines/available_balance.txt