cmxl 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 41f6f1b53eb060758d035fe5d0b3475b42b12bf10c749418a3b72b3c98482140
-  data.tar.gz: 1e5f3ee6fcbbdca480600b029c573ccc614a2adba34e66c440286a99d5be963b
+  metadata.gz: e3e78d30d71b355b7ac3b69166d19b07f8c2476b0060fe62963367f817bfcef0
+  data.tar.gz: 92e4ddeb3db1528466f80c60817bf851fb8ff736a27a360db7752b5ace03d1e6
 SHA512:
-  metadata.gz: 1f4af37922a0e6d14795c7274a64a60697660b6e0f7399947e7bdae6973b4ea3dbe22a3e73e2923004a16ce215577565ac4f609283752401359228d8709e7c57
-  data.tar.gz: 0a9aecfe5f17a5bd09dcce8e96c45af26c3d89c79ce505aad9806849e1fbaa082dccb02d562ff8552283a14d6027a4f5b11de3a1237dc790d0c609bdc1f15d1f
+  metadata.gz: b7b08fef90747fb155744813e72e3e771d5e86d45d5e61a48742cb20d59aedb14663474f7a06600bcedaad7858d1f3d4706c4c7748e7444aff62564da796daf0
+  data.tar.gz: 1f0d3b254dc14f10a37c275ccfb949356e5b37fa533aa0558fc0dbf11593e9f049d1593beae5bb4ce4e356732233b895d4b36c5a84d514944d47500ccb948243

data/CHANGELOG.mdown

@@ -1,37 +1,41 @@
+# 1.4.2
+
+- `[ENHANCEMENT]` handles broken account data without blowing up
+
 # 1.4.1
 
-- [BUGFIX] changes entry date calculation for transaction
+- `[BUGFIX]` changes entry date calculation for transaction
   Thanks to [@grncdr](https://github.com/grncdr)
 
 # 1.4.0
 
-- [FEATURE] adds ability to parse non-numerical tags ([#23](https://github.com/railslove/cmxl/issues/23)) \
+- `[FEATURE]` adds ability to parse non-numerical tags ([#23](https://github.com/railslove/cmxl/issues/23)) \
   Thanks to [@prometh07](https://github.com/prometh07)
 
 # 1.3.0
 
-- [FEATURE] adds MT942 compatibility
+- `[FEATURE]` adds MT942 compatibility
 
 # 1.2.0
 
-- [FEATURE] strips mt940 header if configured ([#9](https://github.com/railslove/cmxl/issues/9))
+- `[FEATURE]` strips mt940 header if configured ([#9](https://github.com/railslove/cmxl/issues/9))
   ```ruby
     Cmxl.config[:strip_headers] = true
   ```
 
 # 1.1.1
 
-- [BUGFIX] prevents short bank references from swallowing supplementary details delimiter
+- `[BUGFIX]` prevents short bank references from swallowing supplementary details delimiter
 
 # 1.1.0
 
-- [FEATURE] adds support for supplementary details in transactions (Field 61, Subfield 9) ([#18](https://github.com/railslove/cmxl/issues/18))
+- `[FEATURE]` adds support for supplementary details in transactions (Field 61, Subfield 9) ([#18](https://github.com/railslove/cmxl/issues/18))
 
 # 1.0.0
 
-- [FEATURE] adds support for storno transactions ([#14](https://github.com/railslove/cmxl/issues/14))
-- [NOTE] full backwards compatibility
-- [NOTE] same as release 0.2.2, fixing versioning
+- `[FEATURE]` adds support for storno transactions ([#14](https://github.com/railslove/cmxl/issues/14))
+- `[NOTE]` full backwards compatibility
+- `[NOTE]` same as release 0.2.2, fixing versioning
 
 # 0.2.1
 
@@ -48,8 +52,8 @@
 
 # 0.1.3
 
-- [BUGFIX] fixed the statement details parser. It failed in case of empty values in the SEPA details
+- `[BUGFIX]` fixed the statement details parser. It failed in case of empty values in the SEPA details
 
 # 0.1.2
 
-- [BUGFIX] fixed the statement details parser. It failed in case of empty values in the sub fields
+- `[BUGFIX]` fixed the statement details parser. It failed in case of empty values in the sub fields

data/lib/cmxl/fields/account_balance.rb

@@ -2,7 +2,7 @@ module Cmxl
   module Fields
     class AccountBalance < Field
       self.tag = 60
-      self.parser = /(?<funds_code>\A[a-zA-Z]{1})(?<date>\d{6})(?<currency>[a-zA-Z]{3})(?<amount>[\d|,|\.]{4,15})/i
+      self.parser = /(?<funds_code>\A[a-zA-Z]{1})(?<date>\d{6})(?<currency>[a-zA-Z]{3})(?<amount>[\d|,|\.]{1,15})/i
 
       def date
         to_date(data['date'])

data/lib/cmxl/statement.rb

@@ -99,7 +99,7 @@ module Cmxl
     end
 
     def mt942?
-      fields.any? { |field| field.is_a? Fields::FloorLimitIndicator }
+      fields.any? { |field| field.is_a?(Fields::FloorLimitIndicator) }
     end
 
     def to_h

data/lib/cmxl/version.rb

@@ -1,3 +1,3 @@
 module Cmxl
-  VERSION = '1.4.1'.freeze
+  VERSION = '1.4.2'.freeze
 end

data/spec/fields/account_balance_spec.rb

@@ -39,4 +39,11 @@ describe Cmxl::Fields::AccountBalance do
     it { expect(subject.amount_in_cents).to eql(14_764) }
     it { expect(subject.sign).to eql(-1) }
   end
+
+  context 'broken debit' do
+    subject { Cmxl::Fields::AccountBalance.parse(fixture_line(:account_balance_debit_broken)) }
+
+    it { expect(subject.amount).to eql(0.0) }
+    it { expect(subject.amount_in_cents).to eql(0) }
+  end
 end

data/spec/fixtures/lines/account_balance_debit_broken.txt

@@ -0,0 +1 @@
+:60F:D140829EUR0,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cmxl
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Michael Bumann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-18 00:00:00.000000000 Z
+date: 2019-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -143,6 +143,7 @@ files:
 - spec/fields/vmk_summary_spec.rb
 - spec/fixtures/lines/account_balance_credit.txt
 - spec/fixtures/lines/account_balance_debit.txt
+- spec/fixtures/lines/account_balance_debit_broken.txt
 - spec/fixtures/lines/account_identification_iban.txt
 - spec/fixtures/lines/account_identification_legacy.txt
 - spec/fixtures/lines/available_balance.txt
@@ -218,6 +219,7 @@ test_files:
 - spec/fields/vmk_summary_spec.rb
 - spec/fixtures/lines/account_balance_credit.txt
 - spec/fixtures/lines/account_balance_debit.txt
+- spec/fixtures/lines/account_balance_debit_broken.txt
 - spec/fixtures/lines/account_identification_iban.txt
 - spec/fixtures/lines/account_identification_legacy.txt
 - spec/fixtures/lines/available_balance.txt