cmxl 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a9d2c6d5faed6e357abd5459811d43764a89448fc46763993938b1519b17a2a
-  data.tar.gz: 3861abc066158de7c4468d9df01a57331d1913b1d84645b7618f2d146c419a47
+  metadata.gz: d5e0a335b0d8a997acf80ab578362f77f08880b0d7258f3c3af365b71eb53925
+  data.tar.gz: b2d3c8dd9925866da29d27cc43457652f2fdf377bcd1080feb87d654a88b37e4
 SHA512:
-  metadata.gz: 716ee9967921b4539174032223aae5eb996ada741c2181b556e7bb8ec5355668aedd8167ba564836ee73a8a8fa7256d83a74c4f6d8309496cde600c7d631b66c
-  data.tar.gz: 4395610ac7de16b264b309940eda9a2727cfce3c49f8cf051b91f4ab0f8f0486c2caf0528a8efd995fd327f31ccefc288a860f8e458b6ba7b0f1ffe7be85939e
+  metadata.gz: fa0be57b4e8643e1a20f4bb276d7953eb7cc3f16cc3c89286b5ca6fa7e2a9b285b1358424f6904d086315907d1ba77f2d89616980a82bb4360f162e91eaf2477
+  data.tar.gz: 2990c106239b3f65c35abdc662af7afdba0ba4d539e1e9f3838179d5f238e1b72fbf43b82743bce5a060b291a4a9f28031f3bc4aba9e39f76c155d178d1f1b83

data/CHANGELOG.mdown

@@ -1,3 +1,8 @@
+# 1.4.0
+
+- [FEATURE] adds ability to parse non-numerical tags ([#23](https://github.com/railslove/cmxl/issues/23)) \
+  Thanks to [@prometh07](https://github.com/prometh07)
+
 # 1.3.0
 
 - [FEATURE] adds MT942 compatibility

data/lib/cmxl/field.rb

@@ -47,7 +47,7 @@ module Cmxl
     # Cmxl::Field.parse(':60F:C031002PLN40000,00') #=> returns an AccountBalance instance
     #
     def self.parse(line)
-      if line =~ /\A:(\d{2,2})(\w)?:(.*)\z/m
+      if line =~ /\A:(\w{2,2})(\w)?:(.*)\z/m
         tag = Regexp.last_match(1)
         modifier = Regexp.last_match(2)
         content = Regexp.last_match(3).delete("\r").gsub(/\n\z/, '') # remove trailing line break to prevent empty field parsing

data/lib/cmxl/version.rb

@@ -1,3 +1,3 @@
 module Cmxl
-  VERSION = '1.3.0'.freeze
+  VERSION = '1.4.0'.freeze
 end

data/spec/fields/unknown_spec.rb

@@ -1,8 +1,24 @@
 require 'spec_helper'
 
-describe 'Unknwn fields' do
-  subject { Cmxl::Field.parse(':42F:C140908EUR000000000136,02') }
-  it { expect(subject.tag).to eql('42') }
-  it { expect(subject.source).to eql('C140908EUR000000000136,02') }
-  it { expect(subject.to_h).to eql(tag: '42', modifier: 'F', source: 'C140908EUR000000000136,02') }
+describe 'Unknown fields' do
+  context 'numerical fields' do
+    subject { Cmxl::Field.parse(':42F:C140908EUR000000000136,02') }
+    it { expect(subject.tag).to eql('42') }
+    it { expect(subject.source).to eql('C140908EUR000000000136,02') }
+    it { expect(subject.to_h).to eql(tag: '42', modifier: 'F', source: 'C140908EUR000000000136,02') }
+  end
+
+  context 'alphanumerical fields w/ modifier' do
+    subject { Cmxl::Field.parse(':NSF:SomethingSomethingDarkSide') }
+    it { expect(subject.tag).to eql('NS') }
+    it { expect(subject.source).to eql('SomethingSomethingDarkSide') }
+    it { expect(subject.to_h).to eql(tag: 'NS', modifier: 'F', source: 'SomethingSomethingDarkSide') }
+  end
+
+  context 'alphanumerical fields wo/ modifier' do
+    subject { Cmxl::Field.parse(':FO:oBar') }
+    it { expect(subject.tag).to eql('FO') }
+    it { expect(subject.source).to eql('oBar') }
+    it { expect(subject.to_h).to eql(tag: 'FO', modifier: nil, source: 'oBar') }
+  end
 end

data/spec/fixtures/mt940.txt

@@ -49,6 +49,7 @@ GmbH?3050060400?31084756
 :20:TELEWIZORY S.A.
 :25:BPHKPLPK/320000546101
 :28C:00084/001
+:NSF:HelloWorld
 :60F:C031002PLN40000,00
 :61:0310201020C20000,00FMSCNONREF//8327000090031789
 Card transaction

data/spec/mt940_parsing_spec.rb

@@ -57,6 +57,8 @@ describe 'parsing a statement' do
     it { expect(subject.transactions.first.bic).to eql('10600076') }
     it { expect(subject.transactions.first.iban).to eql('PL08106000760000777777777777') }
     it { expect(subject.transactions.first.sepa).to eql({}) }
+
+    it { expect(subject.field('NS').to_h).to eql({tag: 'NS', modifier: 'F', source: 'HelloWorld'}) }
   end
 
   context 'statement separator as used by most banks' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cmxl
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Michael Bumann
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-14 00:00:00.000000000 Z
+date: 2019-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -196,7 +196,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Cmxl is your friendly MT940 bank statement parser