cmxl 1.2.0 → 1.3.0

data/spec/field_spec.rb

@@ -5,7 +5,7 @@ describe Cmxl::Field do
 
   it { expect(Cmxl::Field.parser).to eql(/(?<details>.*)/) } # default must be set
 
-  it { expect(subject.to_h).to eql({'tag' => 42, 'details' => 'D140829EUR000000000147,64'}) }
+  it { expect(subject.to_h).to eql('tag' => 42, 'details' => 'D140829EUR000000000147,64') }
   it { expect(subject.to_hash).to eql(subject.to_h) }
 
   it { expect(subject.to_amount('123.')).to eql(123.00) }
@@ -14,14 +14,13 @@ describe Cmxl::Field do
   it { expect(subject.to_amount('123,1')).to eql(123.10) }
   it { expect(subject.to_amount('123,11')).to eql(123.11) }
 
-  it { expect(subject.to_amount_in_cents('123.')).to eql(12300) }
-  it { expect(subject.to_amount_in_cents('123.1')).to eql(12310) }
-  it { expect(subject.to_amount_in_cents('123.11')).to eql(12311) }
-  it { expect(subject.to_amount_in_cents('123,1')).to eql(12310) }
-  it { expect(subject.to_amount_in_cents('123,11')).to eql(12311) }
+  it { expect(subject.to_amount_in_cents('123.')).to eql(12_300) }
+  it { expect(subject.to_amount_in_cents('123.1')).to eql(12_310) }
+  it { expect(subject.to_amount_in_cents('123.11')).to eql(12_311) }
+  it { expect(subject.to_amount_in_cents('123,1')).to eql(12_310) }
+  it { expect(subject.to_amount_in_cents('123,11')).to eql(12_311) }
 
   it { expect(subject.to_date('invalid')).to eql('invalid') }
-  it { expect(subject.to_date('140914')).to eql(Date.new(2014,9,14)) }
-  it { expect(subject.to_date('140914', 2013)).to eql(Date.new(2013,9,14)) }
-
+  it { expect(subject.to_date('140914')).to eql(Date.new(2014, 9, 14)) }
+  it { expect(subject.to_date('140914', 2013)).to eql(Date.new(2013, 9, 14)) }
 end

data/spec/fields/account_balance_spec.rb

@@ -1,42 +1,42 @@
 require 'spec_helper'
 require 'date'
 describe Cmxl::Fields::AccountBalance do
-
   context 'Credit' do
-    subject { Cmxl::Fields::AccountBalance.parse( fixture_line(:account_balance_credit) ) }
+    subject { Cmxl::Fields::AccountBalance.parse(fixture_line(:account_balance_credit)) }
 
-    it { expect(subject.date).to eql(Date.new(2014,8,29)) }
+    it { expect(subject.date).to eql(Date.new(2014, 8, 29)) }
     it { expect(subject).to be_credit }
     it { expect(subject).to_not be_debit }
     it { expect(subject.currency).to eql('EUR') }
 
     it { expect(subject.amount).to eql(147.64) }
-    it { expect(subject.amount_in_cents).to eql(14764) }
+    it { expect(subject.amount_in_cents).to eql(14_764) }
     it { expect(subject.sign).to eql(1) }
-    it { expect(subject.to_h).to eql({
-        'date' =>Date.new(2014,8,29),
-        'funds_code' =>"C",
-        'credit' =>true,
-        'debit' =>false,
-        'currency' =>"EUR",
-        'amount' =>147.64,
-        'amount_in_cents' =>14764,
-        'sign' =>1,
+    it {
+      expect(subject.to_h).to eql(
+        'date' => Date.new(2014, 8, 29),
+        'funds_code' => 'C',
+        'credit' => true,
+        'debit' => false,
+        'currency' => 'EUR',
+        'amount' => 147.64,
+        'amount_in_cents' => 14_764,
+        'sign' => 1,
         'tag' => '60'
-    }) }
+      )
+    }
   end
 
   context 'Debit' do
-    subject { Cmxl::Fields::AccountBalance.parse( fixture_line(:account_balance_debit) ) }
+    subject { Cmxl::Fields::AccountBalance.parse(fixture_line(:account_balance_debit)) }
 
-    it { expect(subject.date).to eql(Date.new(2014,8,29)) }
+    it { expect(subject.date).to eql(Date.new(2014, 8, 29)) }
     it { expect(subject).to_not be_credit }
     it { expect(subject).to be_debit }
     it { expect(subject.currency).to eql('EUR') }
 
     it { expect(subject.amount).to eql(147.64) }
-    it { expect(subject.amount_in_cents).to eql(14764) }
+    it { expect(subject.amount_in_cents).to eql(14_764) }
     it { expect(subject.sign).to eql(-1) }
   end
-
 end

data/spec/fields/account_identification_spec.rb

@@ -1,24 +1,20 @@
 require 'spec_helper'
 
 describe Cmxl::Fields::AccountIdentification do
-
   context 'legacy data' do
-    subject { Cmxl::Fields::AccountBalance.parse( fixture_line(:account_identification_legacy) ) }
+    subject { Cmxl::Fields::AccountBalance.parse(fixture_line(:account_identification_legacy)) }
 
     it { expect(subject.bank_code).to eql('70011110') }
     it { expect(subject.account_number).to eql('4005287001') }
     it { expect(subject.currency).to eql('EUR') }
     it { expect(subject.country).to be_nil }
-
   end
 
   context 'iban' do
-    subject { Cmxl::Fields::AccountBalance.parse( fixture_line(:account_identification_iban) ) }
+    subject { Cmxl::Fields::AccountBalance.parse(fixture_line(:account_identification_iban)) }
     it { expect(subject.country).to eql('PL') }
     it { expect(subject.ban).to eql('25106000760000888888888888') }
     it { expect(subject.iban).to eql('PL25106000760000888888888888') }
     it { expect(subject.bank_code).to be_nil }
-
   end
-
 end

data/spec/fields/available_balance_spec.rb

@@ -1,10 +1,9 @@
 require 'spec_helper'
 
 describe Cmxl::Fields::AvailableBalance do
-
   subject { Cmxl::Fields::AvailableBalance.parse(fixture_line(:available_balance)) }
 
-  it { expect(subject.date).to eql(Date.new(2014,9,1)) }
+  it { expect(subject.date).to eql(Date.new(2014, 9, 1)) }
   it { expect(subject).to_not be_credit }
   it { expect(subject).to be_debit }
   it { expect(subject.currency).to eql('EUR') }
@@ -12,5 +11,4 @@ describe Cmxl::Fields::AvailableBalance do
   it { expect(subject.amount).to eql(3.66) }
   it { expect(subject.amount_in_cents).to eql(366) }
   it { expect(subject.sign).to eql(-1) }
-
 end

data/spec/fields/closing_balance_spec.rb

@@ -1,15 +1,13 @@
 require 'spec_helper'
 
 describe Cmxl::Fields::ClosingBalance do
-
   subject { Cmxl::Fields::ClosingBalance.parse(fixture_line(:closing_balance)) }
 
-  it { expect(subject.date).to eql(Date.new(2014,9,1)) }
+  it { expect(subject.date).to eql(Date.new(2014, 9, 1)) }
   it { expect(subject).to be_credit }
   it { expect(subject).to_not be_debit }
 
   it { expect(subject.amount).to eql(137.0) }
-  it { expect(subject.amount_in_cents).to eql(13700) }
+  it { expect(subject.amount_in_cents).to eql(13_700) }
   it { expect(subject.sign).to eql(1) }
-
 end

data/spec/fields/entry_date_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 
 describe Cmxl::Fields::EntryDate do
   context 'iban' do
-    subject { Cmxl::Fields::EntryDate.parse( fixture_line(:entry_date) ) }
+    subject { Cmxl::Fields::EntryDate.parse(fixture_line(:entry_date)) }
 
     it { expect(subject.date).to eql(Date.parse('2017/12/29')) }
   end

data/spec/fields/floor_limit_indicator_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe Cmxl::Fields::FloorLimitIndicator do
+  context 'credit' do
+    subject { Cmxl::Fields::FloorLimitIndicator.parse(fixture_line(:floor_limit_indicator_credit)) }
+
+    it { expect(subject.amount).to eql(47.11) }
+    it { expect(subject.currency).to eql('EUR') }
+    it { expect(subject.credit?).to be_truthy }
+    it { expect(subject.debit?).to be_falsey }
+  end
+
+  context 'debit' do
+    subject { Cmxl::Fields::FloorLimitIndicator.parse(fixture_line(:floor_limit_indicator_debit)) }
+
+    it { expect(subject.amount).to eql(13.37) }
+    it { expect(subject.currency).to eql('EUR') }
+    it { expect(subject.credit?).to be_falsey }
+    it { expect(subject.debit?).to be_truthy }
+  end
+
+  context 'both' do
+    subject { Cmxl::Fields::FloorLimitIndicator.parse(fixture_line(:floor_limit_indicator_both)) }
+
+    it { expect(subject.amount).to eql(13.37) }
+    it { expect(subject.currency).to eql('EUR') }
+    it { expect(subject.credit?).to be_truthy }
+    it { expect(subject.debit?).to be_truthy }
+  end
+end

data/spec/fields/reference_spec.rb

@@ -1,13 +1,12 @@
 require 'spec_helper'
 
 describe Cmxl::Fields::Reference do
-
   subject { Cmxl::Fields::Reference.parse(fixture_line(:reference)) }
 
   it { expect(subject.reference).to eql('D140902049') }
-  it { expect(subject.date).to eql(Date.new(2014,9,2)) }
+  it { expect(subject.date).to eql(Date.new(2014, 9, 2)) }
   it { expect(subject.statement_identifier).to eql('D') }
   it { expect(subject.additional_number).to eql('049') }
-  it { expect(subject.to_h).to eql({"tag" => '20', "statement_identifier"=>"D", "date"=> Date.new(2014,9,2), "additional_number"=>"049", "reference"=>"D140902049"}) }
+  it { expect(subject.to_h).to eql('tag' => '20', 'statement_identifier' => 'D', 'date' => Date.new(2014, 9, 2), 'additional_number' => '049', 'reference' => 'D140902049') }
   it { expect(subject.to_hash).to eql(subject.to_h) }
 end

data/spec/fields/statement_details_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
 describe Cmxl::Fields::StatementDetails do
-
   context 'sepa' do
     subject { Cmxl::Fields::StatementDetails.parse(fixture_line(:statement_details)) }
 
@@ -9,65 +8,69 @@ describe Cmxl::Fields::StatementDetails do
     it { expect(subject.seperator).to eql('?') }
     it { expect(subject.description).to eql('SEPA LASTSCHRIFT KUNDE') }
     it { expect(subject.information).to eql('KREF+EREF+TRX-0A4A47C3-F846-4729-8A1B-5DF620FMREF+CAC97D2144174318AC18D9BF815BD4FBCRED+DE98ZZZ09999999999SVWZ+FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F') }
-    it { expect(subject.bic).to eql('HYVEDEMMXXX' ) }
+    it { expect(subject.bic).to eql('HYVEDEMMXXX') }
     it { expect(subject.name).to eql('Peter Pan') }
     it { expect(subject.iban).to eql('HUkkbbbsssskcccccccccccccccx') }
-    it { expect(subject.sub_fields).to eql({
-        "00" => "SEPA LASTSCHRIFT KUNDE",
-        "10" => "281",
-        "20" => "KREF+EREF+TRX-0A4A47C3-F846-4729",
-        "21" => "-8A1B-5DF620F",
-        "22" => "MREF+CAC97D2144174318AC18D9",
-        "23" => "BF815BD4FB",
-        "24" => "CRED+DE98ZZZ09999999999",
-        "25" => "SVWZ+FOO TRX-0A4A47C3-F84",
-        "26" => "6-4729-8A1B-5DF620F",
-        "30" => "HYVEDEMMXXX",
-        "31" => "HUkkbbbsssskcccccccccccccccx",
-        "32" => "Peter Pan",
-        "99" => "",
-        "34" => "171"
-    }) }
-    it { expect(subject.sepa).to eql({
-          "KREF" => "",
-          "CRED" => "DE98ZZZ09999999999",
-          "EREF" => "TRX-0A4A47C3-F846-4729-8A1B-5DF620F",
-          "MREF" => "CAC97D2144174318AC18D9BF815BD4FB",
-          "SVWZ" => "FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F"
-    }) }
+    it {
+      expect(subject.sub_fields).to eql(
+        '00' => 'SEPA LASTSCHRIFT KUNDE',
+        '10' => '281',
+        '20' => 'KREF+EREF+TRX-0A4A47C3-F846-4729',
+        '21' => '-8A1B-5DF620F',
+        '22' => 'MREF+CAC97D2144174318AC18D9',
+        '23' => 'BF815BD4FB',
+        '24' => 'CRED+DE98ZZZ09999999999',
+        '25' => 'SVWZ+FOO TRX-0A4A47C3-F84',
+        '26' => '6-4729-8A1B-5DF620F',
+        '30' => 'HYVEDEMMXXX',
+        '31' => 'HUkkbbbsssskcccccccccccccccx',
+        '32' => 'Peter Pan',
+        '99' => '',
+        '34' => '171'
+      )
+    }
+    it {
+      expect(subject.sepa).to eql(
+        'KREF' => '',
+        'CRED' => 'DE98ZZZ09999999999',
+        'EREF' => 'TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
+        'MREF' => 'CAC97D2144174318AC18D9BF815BD4FB',
+        'SVWZ' => 'FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F'
+      )
+    }
 
     it {
-      expect(subject.to_h).to eql({
-        'bic'=>"HYVEDEMMXXX",
-        'iban'=>"HUkkbbbsssskcccccccccccccccx",
-        'name' => "Peter Pan",
+      expect(subject.to_h).to eql(
+        'bic' => 'HYVEDEMMXXX',
+        'iban' => 'HUkkbbbsssskcccccccccccccccx',
+        'name' => 'Peter Pan',
         'sepa' => {
-          "KREF"=>"",
-          "EREF"=>"TRX-0A4A47C3-F846-4729-8A1B-5DF620F",
-          "MREF"=>"CAC97D2144174318AC18D9BF815BD4FB",
-          "CRED"=>"DE98ZZZ09999999999",
-          "SVWZ"=>"FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F"
+          'KREF' => '',
+          'EREF' => 'TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
+          'MREF' => 'CAC97D2144174318AC18D9BF815BD4FB',
+          'CRED' => 'DE98ZZZ09999999999',
+          'SVWZ' => 'FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F'
         },
-        'information' => "KREF+EREF+TRX-0A4A47C3-F846-4729-8A1B-5DF620FMREF+CAC97D2144174318AC18D9BF815BD4FBCRED+DE98ZZZ09999999999SVWZ+FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F",
-        'description' => "SEPA LASTSCHRIFT KUNDE",
+        'information' => 'KREF+EREF+TRX-0A4A47C3-F846-4729-8A1B-5DF620FMREF+CAC97D2144174318AC18D9BF815BD4FBCRED+DE98ZZZ09999999999SVWZ+FOO TRX-0A4A47C3-F846-4729-8A1B-5DF620F',
+        'description' => 'SEPA LASTSCHRIFT KUNDE',
         'sub_fields' => {
-          "00"=>"SEPA LASTSCHRIFT KUNDE",
-          "10"=>"281",
-          "20"=>"KREF+EREF+TRX-0A4A47C3-F846-4729",
-          "21"=>"-8A1B-5DF620F",
-          "22"=>"MREF+CAC97D2144174318AC18D9",
-          "23"=>"BF815BD4FB",
-          "24"=>"CRED+DE98ZZZ09999999999",
-          "25"=>"SVWZ+FOO TRX-0A4A47C3-F84",
-          "26"=>"6-4729-8A1B-5DF620F",
-          "30"=>"HYVEDEMMXXX",
-          "31"=>"HUkkbbbsssskcccccccccccccccx",
-          "32"=>"Peter Pan",
-          "34"=>"171",
-          "99" => ""
+          '00' => 'SEPA LASTSCHRIFT KUNDE',
+          '10' => '281',
+          '20' => 'KREF+EREF+TRX-0A4A47C3-F846-4729',
+          '21' => '-8A1B-5DF620F',
+          '22' => 'MREF+CAC97D2144174318AC18D9',
+          '23' => 'BF815BD4FB',
+          '24' => 'CRED+DE98ZZZ09999999999',
+          '25' => 'SVWZ+FOO TRX-0A4A47C3-F84',
+          '26' => '6-4729-8A1B-5DF620F',
+          '30' => 'HYVEDEMMXXX',
+          '31' => 'HUkkbbbsssskcccccccccccccccx',
+          '32' => 'Peter Pan',
+          '34' => '171',
+          '99' => ''
         },
-        'transaction_code' => "171",
-        'details' => "?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22MREF+CAC97D2144174318AC18D9?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171"}
+        'transaction_code' => '171',
+        'details' => '?00SEPA LASTSCHRIFT KUNDE?10281?20KREF+EREF+TRX-0A4A47C3-F846-4729?21-8A1B-5DF620F?22MREF+CAC97D2144174318AC18D9?23BF815BD4FB?24CRED+DE98ZZZ09999999999?25SVWZ+FOO TRX-0A4A47C3-F84?266-4729-8A1B-5DF620F?30HYVEDEMMXXX?31HUkkbbbsssskcccccccccccccccx?32Peter Pan?99?34171'
       )
     }
     it { expect(subject.to_hash).to eql(subject.to_h) }
@@ -76,9 +79,11 @@ describe Cmxl::Fields::StatementDetails do
   describe 'information parsing with empty fields on the end' do
     subject { Cmxl::Fields::StatementDetails.parse(fixture_line(:statement_details_empty_fields)) }
 
-    it { expect(subject.sepa).to eql({
-          "EREF" => "S1001675",
-          "SVWZ" => ""
-    }) }
+    it {
+      expect(subject.sepa).to eql(
+        'EREF' => 'S1001675',
+        'SVWZ' => ''
+      )
+    }
   end
 end

data/spec/fields/statement_number_spec.rb

@@ -1,10 +1,8 @@
 require 'spec_helper'
 
 describe Cmxl::Fields::StatementNumber do
-
   subject { Cmxl::Fields::StatementNumber.parse(fixture_line(:statement_number)) }
 
   it { expect(subject.statement_number).to eql('00035') }
   it { expect(subject.sequence_number).to eql('001') }
-
 end

data/spec/fields/transaction_spec.rb

@@ -11,8 +11,8 @@ describe Cmxl::Fields::Transaction do
   let(:fixture) { fixture_line(:statement_line).split(/\n/) }
 
   context 'debit' do
-    it { expect(debit_transaction.date).to eql(Date.new(2014,9,1)) }
-    it { expect(debit_transaction.entry_date).to eql(Date.new(2014,9,2)) }
+    it { expect(debit_transaction.date).to eql(Date.new(2014, 9, 1)) }
+    it { expect(debit_transaction.entry_date).to eql(Date.new(2014, 9, 2)) }
     it { expect(debit_transaction.funds_code).to eql('D') }
     it { expect(debit_transaction.currency_letter).to eql('R') }
     it { expect(debit_transaction.amount).to eql(1.62) }
@@ -27,8 +27,8 @@ describe Cmxl::Fields::Transaction do
   end
 
   context 'storno credit' do
-    it { expect(storno_credit_transaction.date).to eql(Date.new(2014,9,1)) }
-    it { expect(storno_credit_transaction.entry_date).to eql(Date.new(2014,9,2)) }
+    it { expect(storno_credit_transaction.date).to eql(Date.new(2014, 9, 1)) }
+    it { expect(storno_credit_transaction.entry_date).to eql(Date.new(2014, 9, 2)) }
     it { expect(storno_credit_transaction.funds_code).to eql('RC') }
     it { expect(storno_credit_transaction.currency_letter).to eql('R') }
     it { expect(storno_credit_transaction.amount).to eql(1.62) }

data/spec/fields/transaction_supplementary_spec.rb

@@ -7,18 +7,18 @@ describe Cmxl::Fields::TransactionSupplementary do
   it { expect(supplementary.initial_amount_in_cents).to eql(4711) }
   it { expect(supplementary.initial_currency).to eql('CAD') }
 
-  it { expect(supplementary.charges_in_cents).to eql(12345) }
+  it { expect(supplementary.charges_in_cents).to eql(12_345) }
   it { expect(supplementary.charges_currency).to eql('EUR') }
 
   describe '.to_h' do
     it 'returns expected hash' do
-      expect(supplementary.to_h).to eql({
+      expect(supplementary.to_h).to eql(
         source: 'Card Transaction/OCMT/CAD47,11/CHGS/EUR123,45',
         initial_amount_in_cents: 4711,
         initial_currency: 'CAD',
-        charges_in_cents: 12345,
+        charges_in_cents: 12_345,
         charges_currency: 'EUR'
-      })
+      )
     end
   end
 end

data/spec/fields/unknown_spec.rb

@@ -1,9 +1,8 @@
 require 'spec_helper'
 
 describe 'Unknwn fields' do
-
   subject { Cmxl::Field.parse(':42F:C140908EUR000000000136,02') }
   it { expect(subject.tag).to eql('42') }
   it { expect(subject.source).to eql('C140908EUR000000000136,02') }
-  it { expect(subject.to_h).to eql({tag: '42', modifier: 'F', source: 'C140908EUR000000000136,02'}) }
+  it { expect(subject.to_h).to eql(tag: '42', modifier: 'F', source: 'C140908EUR000000000136,02') }
 end

data/spec/fields/vmk_summary_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Cmxl::Fields::VmkSummary do
+  context 'credit' do
+    subject { Cmxl::Fields::VmkSummary.parse(fixture_line(:vmk_summary_credit)) }
+
+    it { expect(subject.amount).to eql(47.11) }
+    it { expect(subject.entries).to eql(2) }
+    it { expect(subject.currency).to eql('EUR') }
+    it { expect(subject.credit?).to be_truthy }
+    it { expect(subject.debit?).to be_falsey }
+  end
+
+  context 'debit' do
+    subject { Cmxl::Fields::VmkSummary.parse(fixture_line(:vmk_summary_debit)) }
+
+    it { expect(subject.amount).to eql(13.37) }
+    it { expect(subject.entries).to eql(3) }
+    it { expect(subject.currency).to eql('EUR') }
+    it { expect(subject.credit?).to be_falsey }
+    it { expect(subject.debit?).to be_truthy }
+  end
+end