cmfrec 0.3.4 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47db0dbacef97527ad7947e2c9a38daa21700f9159d55fa19bc9efb404fb7b7b
-  data.tar.gz: 16f3a1a20149a3182d681d0b1c8727eb95c841e7bc459b9fe7abf319df98cb83
+  metadata.gz: 69ad906f81dd246a338be341b9e80ed3737fcda945be654128116e16bef07626
+  data.tar.gz: 8430bd95b51e2f00dd57976d963fa60bb0d82e334951349be32f0a54f3a0aa1c
 SHA512:
-  metadata.gz: 06eced36e5c9d529da867507586c607f3020f0145d473feaae24eaecaebbfe07c2fab82160823aee36ade1f49d5b555dff7e479e16f239d833df09641f04e122
-  data.tar.gz: b432da1dec1af34c4beaa67413eeb6d58de68df5566b72bb9cab053335300a92f6ec633e14bdb4d824097b03e83aa1970d8d74d983be0b6a2ad270fc03db08b0
+  metadata.gz: 59212029fa16618b83b11a9f3e9a5d32feac79c6aa9d017333c6b652d39edb72080efdab2020d5b0ce5b969ca0ca23ca2dfeb846d83f91883bd7d4c024004ac5
+  data.tar.gz: d0a3d418eac306dba55a2aa4d5ef605e31f1ac4fa5d2a87adcc0d2c298b374b90b724df88e61910b18aa965e9b76105113164aedf1943200d5b77e0c576d8d26

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.0 (2026-04-14)
+
+- Dropped support for Ruby < 3.3
+
 ## 0.3.4 (2025-11-22)
 
 - Added ARM shared library for Linux

data/LICENSE.txt

@@ -1,7 +1,7 @@
 MIT License
 
 Copyright (c) 2020 David Cortes
-Copyright (c) 2020-2025 Andrew Kane
+Copyright (c) 2020-2026 Andrew Kane
 
 All rights reserved.
 

data/lib/cmfrec/data.rb

@@ -54,9 +54,7 @@ module Cmfrec
 
     def download_file(fname, origin, file_hash:)
       require "digest"
-      require "fileutils"
-      require "net/http"
-      require "tmpdir"
+      require "open-uri"
 
       cache_home = ENV["XDG_CACHE_HOME"] || "#{ENV.fetch("HOME")}/.cache"
       dest = "#{cache_home}/cmfrec/#{fname}"
@@ -64,38 +62,24 @@ module Cmfrec
 
       return dest if File.exist?(dest)
 
-      temp_path = "#{Dir.tmpdir}/cmfrec-#{Time.now.to_f}" # TODO better name
-
-      digest = Digest::SHA2.new
-
-      uri = URI(origin)
-
-      # Net::HTTP automatically adds Accept-Encoding for compression
-      # of response bodies and automatically decompresses gzip
-      # and deflateresponses unless a Range header was sent.
-      # https://ruby-doc.org/stdlib-2.6.4/libdoc/net/http/rdoc/Net/HTTP.html
-      Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == "https") do |http|
-        request = Net::HTTP::Get.new(uri)
-
-        puts "Downloading data from #{origin}"
-        File.open(temp_path, "wb") do |f|
-          http.request(request) do |response|
-            response.read_body do |chunk|
-              f.write(chunk)
-              digest.update(chunk)
-            end
+      puts "Downloading data from #{origin}"
+      URI.parse(origin).open(redirect: false) do |download|
+        digest =
+          if download.respond_to?(:path)
+            download.flush
+            Digest::SHA256.file(download.path).hexdigest
+          else
+            Digest::SHA256.hexdigest(download.string)
           end
+
+        if digest != file_hash
+          raise Error, "Bad hash: #{digest}"
         end
-      end
+        puts "Hash verified: #{file_hash}"
 
-      if digest.hexdigest != file_hash
-        raise Error, "Bad hash: #{digest.hexdigest}"
+        IO.copy_stream(download, dest)
       end
 
-      puts "Hash verified: #{file_hash}"
-
-      FileUtils.mv(temp_path, dest)
-
       dest
     end
   end

data/lib/cmfrec/recommender.rb

@@ -158,10 +158,10 @@ module Cmfrec
           @lambda_, @l1_lambda, @alpha, @w_main, @w_user,
           @w_main_multiplier,
           @apply_log_transf,
-          nil, #BeTBe,
-          nil, #BtB,
-          nil, #BeTBeChol,
-          nil, #CtUbias,
+          nil, # BeTBe
+          nil, # BtB
+          nil, # BeTBeChol
+          nil, # CtUbias
           include_ix, n_include,
           exclude_ix, n_exclude,
           outp_ix, outp_score,
@@ -194,15 +194,15 @@ module Cmfrec
           @scale_bias_const, scaling_bias_a,
           @w_main, @w_user, @w_implicit,
           n_max, @include_all_x,
-          nil, #BtB,
-          nil, #TransBtBinvBt,
-          nil, #BtXbias,
-          nil, #BeTBeChol,
-          nil, #BiTBi,
-          nil, #CtCw,
-          nil, #TransCtCinvCt,
-          nil, #CtUbias,
-          nil, #B_plus_bias,
+          nil, # BtB
+          nil, # TransBtBinvBt
+          nil, # BtXbias
+          nil, # BeTBeChol
+          nil, # BiTBi
+          nil, # CtCw
+          nil, # TransCtCinvCt
+          nil, # CtUbias
+          nil, # B_plus_bias
           include_ix, n_include,
           exclude_ix, n_exclude,
           outp_ix, outp_score,
@@ -275,7 +275,7 @@ module Cmfrec
       # mean
       obj[:global_mean] = @global_mean
 
-      unless (@user_info_map.keys + @item_info_map.keys).all? { |v| v.is_a?(Symbol) }
+      unless (@user_info_map.keys + @item_info_map.keys).all?(Symbol)
         raise "Side info keys must be symbols to save"
       end
 
@@ -449,10 +449,10 @@ module Cmfrec
           @use_cg, @max_cg_steps, @precondition_cg, @finalize_chol,
           @nonneg, @max_cd_steps, @nonneg_c, @nonneg_d,
           @precompute_for_predictions,
-          nil, #precomputedBtB,
-          nil, #precomputedBeTBe,
-          nil, #precomputedBeTBeChol
-          nil  #precomputedCtUbias
+          nil, # precomputedBtB
+          nil, # precomputedBeTBe
+          nil, # precomputedBeTBeChol
+          nil  # precomputedCtUbias
         ]
         check_status FFI.fit_collective_implicit_als(*fiddle_args(args))
 
@@ -505,15 +505,15 @@ module Cmfrec
           @nonneg, @max_cd_steps, @nonneg_c, @nonneg_d,
           @precompute_for_predictions,
           @include_all_x,
-          nil, #B_plus_bias,
-          nil, #precomputedBtB,
-          nil, #precomputedTransBtBinvBt,
-          nil, #precomputedBtXbias
-          nil, #precomputedBeTBeChol,
-          nil, #precomputedBiTBi,
-          nil, #precomputedTransCtCinvCt,
-          nil, #precomputedCtCw
-          nil  #precomputedCtUbias
+          nil, # B_plus_bias
+          nil, # precomputedBtB
+          nil, # precomputedTransBtBinvBt
+          nil, # precomputedBtXbias
+          nil, # precomputedBeTBeChol
+          nil, # precomputedBiTBi
+          nil, # precomputedTransCtCinvCt
+          nil, # precomputedCtCw
+          nil  # precomputedCtUbias
         ]
         check_status FFI.fit_collective_explicit_als(*fiddle_args(args))
 
@@ -604,7 +604,7 @@ module Cmfrec
       unless ratings.all? { |r| !r.nil? }
         raise ArgumentError, "Missing ratings"
       end
-      unless ratings.all? { |r| r.is_a?(Numeric) }
+      unless ratings.all?(Numeric)
         raise ArgumentError, "Ratings must be numeric"
       end
     end
@@ -660,7 +660,7 @@ module Cmfrec
     def prepare_top_n(count: nil, rated: nil, item_ids: nil)
       if item_ids
         # remove missing ids
-        item_ids = item_ids.map { |v| @item_map[v] }.compact
+        item_ids = item_ids.filter_map { |v| @item_map[v] }
         return [] if item_ids.empty?
 
         include_ix = int_ptr(item_ids)

data/lib/cmfrec/version.rb

@@ -1,3 +1,3 @@
 module Cmfrec
-  VERSION = "0.3.4"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cmfrec
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.4.0
 platform: ruby
 authors:
 - Andrew Kane
@@ -59,14 +59,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.1'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Recommendations for Ruby using collective matrix factorization
 test_files: []