cmdx 1.17.0 → 1.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f8ab8732cd1ac0a15ac46872e78dc5d9549905c52bfda74d24948cae216b0d5
-  data.tar.gz: 7735fc7d16163a8265adc59ad35f17990887c853aded67a92d5039c44c2df888
+  metadata.gz: ead1d181ed1eac565ea3287eeaaca3216e5d24a40f4071000539584435fc1327
+  data.tar.gz: ba0273c00286e10621f06fc5b0ba7be760afa99dd8d3fbfc6fc7da1c3c11891f
 SHA512:
-  metadata.gz: 294c1f8cf3eab880c4e2f5d12c8655b246534cb61c357531171e90102f73146c37efc185cc6e877e4680c5a2809f0d3cba4fb64bf59fe1b6fea410da65454c9e
-  data.tar.gz: d5e8e31425d658cfe151eeab44c938352d92d4f9e96326691d0c63b2688f0eeb64db26f7297d38264cbc6485c7355ae1ea3ad9a486a4ea0ccea8c02e4cd07a13
+  metadata.gz: 30e8c09228e765f2ac8e9b4f8db854da21a13e3a2d7e67b9ad61ecad66d09dd7f8ca9327ac9a8ef8777e78d56d5844a06f52e55d282cc1d78d7ddb9141b9acc2
+  data.tar.gz: 922de5ad8342195dc94bf8137e7023612db4df09b3979581c0e77aecf599cae971004e64b9ab71261ea6795feb8ca8b7fe3fe4fc3f37a570ed50157c404aff33

data/CHANGELOG.md

@@ -4,7 +4,25 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [TODO]
+## [UNRELEASED]
+
+### Changed
+- Add attribute `source` fallback to `:context` when no task is given
+- Improve falsy attribute derived Hash value lookup
+- Freeze chain results
+- Fix missing fault cause no method error issue
+- Add context respond_to? with setter methods
+- Fix validator `allow_nil` inverted logic
+- Array coercion JSON parse error no returns CoercionError
+- Boolean coercions now return `false` for `nil` and `""`
+- Coerce anaglous date, datetime, and time class checks to rely on `to_date`, `to_time`, `to_datetime` methods
+
+## [1.18.0] - 2025-03-09
+
+### Changed
+- Use `Fiber.storage` instead of `Thread.current` for `Chain` and `Correlate` storage, with fallback to `Thread.current` for Ruby < 3.2, making them thread and fiber safe
+- Clone shared logger in `Task#logger` when `log_level` or `log_formatter` is customized to prevent mutation of the shared instance
+- Derive attribute values from source objects that respond to the attribute name (via `send`) as fallback when the source is not callable
 
 ## [1.17.0] - 2025-02-23
 

data/lib/cmdx/attribute.rb

@@ -208,7 +208,8 @@ module CMDx
       !!@required
     end
 
-    # Determines the source of the attribute value.
+    # Determines the source of the attribute value. Returns :context
+    # as a safe fallback when task is not yet set (e.g., schema introspection).
     #
     # @return [Symbol] The source identifier for the attribute value
     #
@@ -217,13 +218,15 @@ module CMDx
     #
     # @rbs () -> untyped
     def source
-      @source ||= parent&.method_name || begin
+      return @source if defined?(@source)
+
+      @source = parent&.method_name || begin
         value = options[:source]
 
         if value.is_a?(Proc)
-          task.instance_eval(&value)
+          task ? task.instance_eval(&value) : :context
         elsif value.respond_to?(:call)
-          value.call(task)
+          task ? value.call(task) : :context
         else
           value || :context
         end
@@ -239,7 +242,9 @@ module CMDx
     #
     # @rbs () -> Symbol
     def method_name
-      @method_name ||= options[:as] || begin
+      return @method_name if defined?(@method_name)
+
+      @method_name = options[:as] || begin
         prefix = AFFIX.call(options[:prefix]) { "#{source}_" }
         suffix = AFFIX.call(options[:suffix]) { "_#{source}" }
 

data/lib/cmdx/attribute_value.rb

@@ -166,10 +166,20 @@ module CMDx
       derived_value =
         case source_value
         when Context then source_value[name]
-        when Hash then source_value[name.to_s] || source_value[name.to_sym]
+        when Hash
+          if source_value.key?(name.to_s)
+            source_value[name.to_s]
+          elsif source_value.key?(name.to_sym)
+            source_value[name.to_sym]
+          end
         when Symbol then source_value.send(name)
         when Proc then task.instance_exec(name, &source_value)
-        else source_value.call(task, name) if source_value.respond_to?(:call)
+        else
+          if source_value.respond_to?(:call)
+            source_value.call(task, name)
+          elsif source_value.respond_to?(name, true)
+            source_value.send(name)
+          end
         end
 
       derived_value.nil? ? default_value : derived_value

data/lib/cmdx/chain.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 module CMDx
-  # Manages a collection of task execution results in a thread-safe manner.
+  # Manages a collection of task execution results in a thread and fiber safe manner.
   # Chains provide a way to track related task executions and their outcomes
   # within the same execution context.
   class Chain
 
     extend Forwardable
 
-    # @rbs THREAD_KEY: Symbol
-    THREAD_KEY = :cmdx_chain
+    # @rbs CONCURRENCY_KEY: Symbol
+    CONCURRENCY_KEY = :cmdx_chain
 
     # Returns the unique identifier for this chain.
     #
@@ -47,7 +47,7 @@ module CMDx
 
     class << self
 
-      # Retrieves the current chain for the current thread.
+      # Retrieves the current chain for the current execution context.
       #
       # @return [Chain, nil] The current chain or nil if none exists
       #
@@ -59,10 +59,10 @@ module CMDx
       #
       # @rbs () -> Chain?
       def current
-        Thread.current[THREAD_KEY]
+        thread_or_fiber[CONCURRENCY_KEY]
       end
 
-      # Sets the current chain for the current thread.
+      # Sets the current chain for the current execution context.
       #
       # @param chain [Chain] The chain to set as current
       #
@@ -73,10 +73,10 @@ module CMDx
       #
       # @rbs (Chain chain) -> Chain
       def current=(chain)
-        Thread.current[THREAD_KEY] = chain
+        thread_or_fiber[CONCURRENCY_KEY] = chain
       end
 
-      # Clears the current chain for the current thread.
+      # Clears the current chain for the current execution context.
       #
       # @return [nil] Always returns nil
       #
@@ -85,7 +85,7 @@ module CMDx
       #
       # @rbs () -> nil
       def clear
-        Thread.current[THREAD_KEY] = nil
+        thread_or_fiber[CONCURRENCY_KEY] = nil
       end
 
       # Builds or extends the current chain by adding a result.
@@ -111,6 +111,17 @@ module CMDx
         current
       end
 
+      private
+
+      # Returns the thread or fiber storage for the current execution context.
+      #
+      # @return [Hash] The thread or fiber storage
+      #
+      # @rbs () -> Hash
+      def thread_or_fiber
+        Fiber.respond_to?(:storage) ? Fiber.storage : Thread.current
+      end
+
     end
 
     # Returns whether the chain is running in dry-run mode.
@@ -125,6 +136,20 @@ module CMDx
       !!@dry_run
     end
 
+    # Freezes the chain and its internal results to prevent modifications.
+    #
+    # @return [Chain] the frozen chain
+    #
+    # @example
+    #   chain.freeze
+    #   chain.results << result # => raises FrozenError
+    #
+    # @rbs () -> self
+    def freeze
+      results.freeze
+      super
+    end
+
     # Converts the chain to a hash representation.
     #
     # @option return [String] :id The chain identifier

data/lib/cmdx/coercions/array.rb

@@ -18,7 +18,7 @@ module CMDx
       #
       # @return [Array] The converted array value
       #
-      # @raise [JSON::ParserError] If the string value contains invalid JSON
+      # @raise [CoercionError] If the value cannot be converted to an array
       #
       # @example Convert a JSON-like string to an array
       #   Array.call("[1, 2, 3]") # => [1, 2, 3]
@@ -26,6 +26,8 @@ module CMDx
       #   Array.call("hello")     # => ["hello"]
       #   Array.call(42)          # => [42]
       #   Array.call(nil)         # => []
+      # @example Handle invalid JSON-like strings
+      #   Array.call("[not json") # => raises CoercionError
       #
       # @rbs (untyped value, ?Hash[Symbol, untyped] options) -> Array[untyped]
       def call(value, options = {})
@@ -37,6 +39,9 @@ module CMDx
         else
           Array(value)
         end
+      rescue JSON::ParserError
+        type = Locale.t("cmdx.types.array")
+        raise CoercionError, Locale.t("cmdx.coercions.into_an", type:)
       end
 
     end

data/lib/cmdx/coercions/boolean.rb

@@ -34,14 +34,18 @@ module CMDx
       #   Boolean.call("false")  # => false
       #   Boolean.call("no")     # => false
       #   Boolean.call("0")      # => false
+      #   Boolean.call(nil)      # => false
+      #   Boolean.call("")       # => false
       # @example Handle case-insensitive input
       #   Boolean.call("TRUE")   # => true
       #   Boolean.call("False")  # => false
+      # @example Handle edge cases
+      #   Boolean.call("abc")    # => raises CoercionError
       #
       # @rbs (untyped value, ?Hash[Symbol, untyped] options) -> bool
       def call(value, options = {})
         case value.to_s
-        when FALSEY then false
+        when FALSEY, "" then false
         when TRUTHY then true
         else
           type = Locale.t("cmdx.types.boolean")

data/lib/cmdx/coercions/date.rb

@@ -11,11 +11,6 @@ module CMDx
 
       extend self
 
-      # Types that are already date-like and don't need conversion
-      #
-      # @rbs ANALOG_TYPES: Array[String]
-      ANALOG_TYPES = %w[Date DateTime Time].freeze
-
       # Converts a value to a Date object
       #
       # @param value [Object] The value to convert to a Date
@@ -38,7 +33,7 @@ module CMDx
       #
       # @rbs (untyped value, ?Hash[Symbol, untyped] options) -> Date
       def call(value, options = {})
-        return value if ANALOG_TYPES.include?(value.class.name)
+        return value.to_date if value.respond_to?(:to_date)
         return ::Date.strptime(value, options[:strptime]) if options[:strptime]
 
         ::Date.parse(value)

data/lib/cmdx/coercions/date_time.rb

@@ -11,11 +11,6 @@ module CMDx
 
       extend self
 
-      # Types that are already date-time-like and don't need conversion
-      #
-      # @rbs ANALOG_TYPES: Array[String]
-      ANALOG_TYPES = %w[Date DateTime Time].freeze
-
       # Converts a value to a DateTime
       #
       # @param value [Object] The value to convert to DateTime
@@ -38,7 +33,7 @@ module CMDx
       #
       # @rbs (untyped value, ?Hash[Symbol, untyped] options) -> DateTime
       def call(value, options = {})
-        return value if ANALOG_TYPES.include?(value.class.name)
+        return value.to_datetime if value.respond_to?(:to_datetime)
         return ::DateTime.strptime(value, options[:strptime]) if options[:strptime]
 
         ::DateTime.parse(value)

data/lib/cmdx/coercions/integer.rb

@@ -30,10 +30,9 @@ module CMDx
       #   Integer.call(3.14)      # => 3
       #   Integer.call(0.0)       # => 0
       # @example Handle edge cases
-      #   Integer.call("")        # => 0
-      #   Integer.call(nil)       # => 0
-      #   Integer.call(false)     # => 0
-      #   Integer.call(true)      # => 1
+      #   Integer.call("")        # => raises CoercionError
+      #   Integer.call(nil)       # => raises CoercionError
+      #   Integer.call("abc")     # => raises CoercionError
       #
       # @rbs (untyped value, ?Hash[Symbol, untyped] options) -> Integer
       def call(value, options = {})

data/lib/cmdx/coercions/time.rb

@@ -11,11 +11,6 @@ module CMDx
 
       extend self
 
-      # Types that are already time-like and don't need conversion
-      #
-      # @rbs ANALOG_TYPES: Array[String]
-      ANALOG_TYPES = %w[DateTime Time].freeze
-
       # Converts a value to a Time object
       #
       # @param value [Object] The value to convert to a Time object
@@ -40,7 +35,6 @@ module CMDx
       #
       # @rbs (untyped value, ?Hash[Symbol, untyped] options) -> Time
       def call(value, options = {})
-        return value if ANALOG_TYPES.include?(value.class.name)
         return value.to_time if value.respond_to?(:to_time)
         return ::Time.strptime(value, options[:strptime]) if options[:strptime]
 

data/lib/cmdx/executor.rb

@@ -169,7 +169,7 @@ module CMDx
           jitter.to_f * current_retry
         end
 
-      sleep(jitter) if jitter.positive?
+      sleep(jitter) if Float(jitter).positive?
 
       true
     end
@@ -291,8 +291,8 @@ module CMDx
     def log_backtrace!
       return unless result.failed?
 
-      exception = result.caused_failure.cause
-      return if exception.is_a?(Fault)
+      exception = result.caused_failure&.cause
+      return if exception.nil? || exception.is_a?(Fault)
 
       task.logger.error do
         "[#{exception.class}] #{exception.message}\n" <<

data/lib/cmdx/middlewares/correlate.rb

@@ -4,18 +4,18 @@ module CMDx
   module Middlewares
     # Middleware for correlating task executions with unique identifiers.
     #
-    # The Correlate middleware provides thread-safe correlation ID management
-    # for tracking task execution flows across different operations.
-    # It automatically generates correlation IDs when none are provided and
-    # stores them in task result metadata for traceability.
+    # The Correlate middleware provides thread and fiber safe correlation ID management
+    # for tracking task execution flows across different operations. It automatically
+    # generates correlation IDs when none are provided and stores them in task result
+    # metadata for traceability.
     module Correlate
 
       extend self
 
-      # @rbs THREAD_KEY: Symbol
-      THREAD_KEY = :cmdx_correlate
+      # @rbs CONCURRENCY_KEY: Symbol
+      CONCURRENCY_KEY = :cmdx_correlate
 
-      # Retrieves the current correlation ID from thread-local storage.
+      # Retrieves the current correlation ID from local storage.
       #
       # @return [String, nil] The current correlation ID or nil if not set
       #
@@ -24,10 +24,10 @@ module CMDx
       #
       # @rbs () -> String?
       def id
-        Thread.current[THREAD_KEY]
+        thread_or_fiber[CONCURRENCY_KEY]
       end
 
-      # Sets the correlation ID in thread-local storage.
+      # Sets the correlation ID in local storage.
       #
       # @param id [String] The correlation ID to set
       # @return [String] The set correlation ID
@@ -37,10 +37,10 @@ module CMDx
       #
       # @rbs (String id) -> String
       def id=(id)
-        Thread.current[THREAD_KEY] = id
+        thread_or_fiber[CONCURRENCY_KEY] = id
       end
 
-      # Clears the current correlation ID from thread-local storage.
+      # Clears the current correlation ID from local storage.
       #
       # @return [nil] Always returns nil
       #
@@ -49,7 +49,7 @@ module CMDx
       #
       # @rbs () -> nil
       def clear
-        Thread.current[THREAD_KEY] = nil
+        thread_or_fiber[CONCURRENCY_KEY] = nil
       end
 
       # Temporarily uses a new correlation ID for the duration of a block.
@@ -122,6 +122,17 @@ module CMDx
         use(correlation_id, &)
       end
 
+      private
+
+      # Returns the thread or fiber storage for the current execution context.
+      #
+      # @return [Hash] The thread or fiber storage
+      #
+      # @rbs () -> Hash
+      def thread_or_fiber
+        Fiber.respond_to?(:storage) ? Fiber.storage : Thread.current
+      end
+
     end
   end
 end

data/lib/cmdx/task.rb

@@ -95,7 +95,9 @@ module CMDx
       @id = Identifier.generate
       @context = Context.build(context)
       @result = Result.new(self)
-      @chain = Chain.build(@result, dry_run: @context.delete(:dry_run))
+
+      dry_run = @context.delete(:dry_run)
+      @chain = Chain.build(@result, dry_run:)
     end
 
     class << self
@@ -259,8 +261,8 @@ module CMDx
       #
       # @rbs () -> Hash[Symbol, Hash[Symbol, untyped]]
       def attributes_schema
-        Array(settings[:attributes]).each_with_object({}) do |attr, schema|
-          schema[attr.method_name] = attr.to_h
+        Array(settings[:attributes]).to_h do |attr|
+          [attr.method_name, attr.to_h]
         end
       end
 
@@ -351,6 +353,10 @@ module CMDx
       raise UndefinedMethodError, "undefined method #{self.class.name}#work"
     end
 
+    # Returns a logger for this task. When a custom log_level or
+    # log_formatter is configured, the shared logger is duplicated
+    # so the original instance is never mutated.
+    #
     # @return [Logger] The logger instance for this task
     #
     # @example
@@ -360,10 +366,17 @@ module CMDx
     # @rbs () -> Logger
     def logger
       @logger ||= begin
-        logger = self.class.settings[:logger] || CMDx.configuration.logger
-        logger.level = self.class.settings[:log_level] || logger.level
-        logger.formatter = self.class.settings[:log_formatter] || logger.formatter
-        logger
+        log_instance = self.class.settings[:logger] || CMDx.configuration.logger
+        log_level = self.class.settings[:log_level]
+        log_formatter = self.class.settings[:log_formatter]
+
+        if log_level || log_formatter
+          log_instance = log_instance.dup
+          log_instance.level = log_level if log_level
+          log_instance.formatter = log_formatter if log_formatter
+        end
+
+        log_instance
       end
     end
 

data/lib/cmdx/validator_registry.rb

@@ -102,7 +102,7 @@ module CMDx
       match =
         if options.is_a?(Hash)
           case options
-          in allow_nil: then allow_nil && value.nil?
+          in allow_nil: then !(allow_nil && value.nil?)
           else Utils::Condition.evaluate(task, options, value)
           end
         else

data/lib/cmdx/version.rb

@@ -5,6 +5,6 @@ module CMDx
   # @return [String] the version of the CMDx gem
   #
   # @rbs return: String
-  VERSION = "1.17.0"
+  VERSION = "1.19.0"
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cmdx
 version: !ruby/object:Gem::Version
-  version: 1.17.0
+  version: 1.19.0
 platform: ruby
 authors:
 - Juan Gomez
@@ -420,7 +420,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.4
+rubygems_version: 4.0.6
 specification_version: 4
 summary: CMDx is a framework for building maintainable business processes.
 test_files: []