cmdx 1.17.0 → 1.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f8ab8732cd1ac0a15ac46872e78dc5d9549905c52bfda74d24948cae216b0d5
-  data.tar.gz: 7735fc7d16163a8265adc59ad35f17990887c853aded67a92d5039c44c2df888
+  metadata.gz: 80c55fa1f758dc69cebff57fa5dd770b4bd7692f4a37768c320b6813d28cc9fb
+  data.tar.gz: babf14b98faa436de370d039cc2b6c796f2d0c43d9e408137ccdd1f666f4abe3
 SHA512:
-  metadata.gz: 294c1f8cf3eab880c4e2f5d12c8655b246534cb61c357531171e90102f73146c37efc185cc6e877e4680c5a2809f0d3cba4fb64bf59fe1b6fea410da65454c9e
-  data.tar.gz: d5e8e31425d658cfe151eeab44c938352d92d4f9e96326691d0c63b2688f0eeb64db26f7297d38264cbc6485c7355ae1ea3ad9a486a4ea0ccea8c02e4cd07a13
+  metadata.gz: cbcb58370126bc18aec53218930b11a7c6a3194b4b1e1c6247ae2d6e693ef16f84cc4dbf90a7dbd816e900f421e625cac3ca227aca7ce4898fa711c1451230e0
+  data.tar.gz: de88ce41eacbf4f843803f84055d46dcfb7774aa5532396c820112a5ca3d80d68deb9dbc296f8b782d990122ed6ccc082bbc582f93d3714373c2705c55a936fe

data/CHANGELOG.md

@@ -4,7 +4,14 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [TODO]
+## [UNRELEASED]
+
+## [1.18.0] - 2025-03-09
+
+### Changed
+- Use `Fiber.storage` instead of `Thread.current` for `Chain` and `Correlate` storage, with fallback to `Thread.current` for Ruby < 3.2, making them thread and fiber safe
+- Clone shared logger in `Task#logger` when `log_level` or `log_formatter` is customized to prevent mutation of the shared instance
+- Derive attribute values from source objects that respond to the attribute name (via `send`) as fallback when the source is not callable
 
 ## [1.17.0] - 2025-02-23
 

data/lib/cmdx/attribute_value.rb

@@ -169,7 +169,12 @@ module CMDx
         when Hash then source_value[name.to_s] || source_value[name.to_sym]
         when Symbol then source_value.send(name)
         when Proc then task.instance_exec(name, &source_value)
-        else source_value.call(task, name) if source_value.respond_to?(:call)
+        else
+          if source_value.respond_to?(:call)
+            source_value.call(task, name)
+          elsif source_value.respond_to?(name, true)
+            source_value.send(name)
+          end
         end
 
       derived_value.nil? ? default_value : derived_value

data/lib/cmdx/chain.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 module CMDx
-  # Manages a collection of task execution results in a thread-safe manner.
+  # Manages a collection of task execution results in a thread and fiber safe manner.
   # Chains provide a way to track related task executions and their outcomes
   # within the same execution context.
   class Chain
 
     extend Forwardable
 
-    # @rbs THREAD_KEY: Symbol
-    THREAD_KEY = :cmdx_chain
+    # @rbs CONCURRENCY_KEY: Symbol
+    CONCURRENCY_KEY = :cmdx_chain
 
     # Returns the unique identifier for this chain.
     #
@@ -47,7 +47,7 @@ module CMDx
 
     class << self
 
-      # Retrieves the current chain for the current thread.
+      # Retrieves the current chain for the current execution context.
       #
       # @return [Chain, nil] The current chain or nil if none exists
       #
@@ -59,10 +59,10 @@ module CMDx
       #
       # @rbs () -> Chain?
       def current
-        Thread.current[THREAD_KEY]
+        thread_or_fiber[CONCURRENCY_KEY]
       end
 
-      # Sets the current chain for the current thread.
+      # Sets the current chain for the current execution context.
       #
       # @param chain [Chain] The chain to set as current
       #
@@ -73,10 +73,10 @@ module CMDx
       #
       # @rbs (Chain chain) -> Chain
       def current=(chain)
-        Thread.current[THREAD_KEY] = chain
+        thread_or_fiber[CONCURRENCY_KEY] = chain
       end
 
-      # Clears the current chain for the current thread.
+      # Clears the current chain for the current execution context.
       #
       # @return [nil] Always returns nil
       #
@@ -85,7 +85,7 @@ module CMDx
       #
       # @rbs () -> nil
       def clear
-        Thread.current[THREAD_KEY] = nil
+        thread_or_fiber[CONCURRENCY_KEY] = nil
       end
 
       # Builds or extends the current chain by adding a result.
@@ -111,6 +111,17 @@ module CMDx
         current
       end
 
+      private
+
+      # Returns the thread or fiber storage for the current execution context.
+      #
+      # @return [Hash] The thread or fiber storage
+      #
+      # @rbs () -> Hash
+      def thread_or_fiber
+        Fiber.respond_to?(:storage) ? Fiber.storage : Thread.current
+      end
+
     end
 
     # Returns whether the chain is running in dry-run mode.

data/lib/cmdx/middlewares/correlate.rb

@@ -4,18 +4,18 @@ module CMDx
   module Middlewares
     # Middleware for correlating task executions with unique identifiers.
     #
-    # The Correlate middleware provides thread-safe correlation ID management
-    # for tracking task execution flows across different operations.
-    # It automatically generates correlation IDs when none are provided and
-    # stores them in task result metadata for traceability.
+    # The Correlate middleware provides thread and fiber safe correlation ID management
+    # for tracking task execution flows across different operations. It automatically
+    # generates correlation IDs when none are provided and stores them in task result
+    # metadata for traceability.
     module Correlate
 
       extend self
 
-      # @rbs THREAD_KEY: Symbol
-      THREAD_KEY = :cmdx_correlate
+      # @rbs CONCURRENCY_KEY: Symbol
+      CONCURRENCY_KEY = :cmdx_correlate
 
-      # Retrieves the current correlation ID from thread-local storage.
+      # Retrieves the current correlation ID from local storage.
       #
       # @return [String, nil] The current correlation ID or nil if not set
       #
@@ -24,10 +24,10 @@ module CMDx
       #
       # @rbs () -> String?
       def id
-        Thread.current[THREAD_KEY]
+        thread_or_fiber[CONCURRENCY_KEY]
       end
 
-      # Sets the correlation ID in thread-local storage.
+      # Sets the correlation ID in local storage.
       #
       # @param id [String] The correlation ID to set
       # @return [String] The set correlation ID
@@ -37,10 +37,10 @@ module CMDx
       #
       # @rbs (String id) -> String
       def id=(id)
-        Thread.current[THREAD_KEY] = id
+        thread_or_fiber[CONCURRENCY_KEY] = id
       end
 
-      # Clears the current correlation ID from thread-local storage.
+      # Clears the current correlation ID from local storage.
       #
       # @return [nil] Always returns nil
       #
@@ -49,7 +49,7 @@ module CMDx
       #
       # @rbs () -> nil
       def clear
-        Thread.current[THREAD_KEY] = nil
+        thread_or_fiber[CONCURRENCY_KEY] = nil
       end
 
       # Temporarily uses a new correlation ID for the duration of a block.
@@ -122,6 +122,17 @@ module CMDx
         use(correlation_id, &)
       end
 
+      private
+
+      # Returns the thread or fiber storage for the current execution context.
+      #
+      # @return [Hash] The thread or fiber storage
+      #
+      # @rbs () -> Hash
+      def thread_or_fiber
+        Fiber.respond_to?(:storage) ? Fiber.storage : Thread.current
+      end
+
     end
   end
 end

data/lib/cmdx/task.rb

@@ -259,8 +259,8 @@ module CMDx
       #
       # @rbs () -> Hash[Symbol, Hash[Symbol, untyped]]
       def attributes_schema
-        Array(settings[:attributes]).each_with_object({}) do |attr, schema|
-          schema[attr.method_name] = attr.to_h
+        Array(settings[:attributes]).to_h do |attr|
+          [attr.method_name, attr.to_h]
         end
       end
 
@@ -351,6 +351,10 @@ module CMDx
       raise UndefinedMethodError, "undefined method #{self.class.name}#work"
     end
 
+    # Returns a logger for this task. When a custom log_level or
+    # log_formatter is configured, the shared logger is duplicated
+    # so the original instance is never mutated.
+    #
     # @return [Logger] The logger instance for this task
     #
     # @example
@@ -360,10 +364,17 @@ module CMDx
     # @rbs () -> Logger
     def logger
       @logger ||= begin
-        logger = self.class.settings[:logger] || CMDx.configuration.logger
-        logger.level = self.class.settings[:log_level] || logger.level
-        logger.formatter = self.class.settings[:log_formatter] || logger.formatter
-        logger
+        log_instance = self.class.settings[:logger] || CMDx.configuration.logger
+        log_level = self.class.settings[:log_level]
+        log_formatter = self.class.settings[:log_formatter]
+
+        if log_level || log_formatter
+          log_instance = log_instance.dup
+          log_instance.level = log_level if log_level
+          log_instance.formatter = log_formatter if log_formatter
+        end
+
+        log_instance
       end
     end
 

data/lib/cmdx/version.rb

@@ -5,6 +5,6 @@ module CMDx
   # @return [String] the version of the CMDx gem
   #
   # @rbs return: String
-  VERSION = "1.17.0"
+  VERSION = "1.18.0"
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cmdx
 version: !ruby/object:Gem::Version
-  version: 1.17.0
+  version: 1.18.0
 platform: ruby
 authors:
 - Juan Gomez
@@ -420,7 +420,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.4
+rubygems_version: 4.0.6
 specification_version: 4
 summary: CMDx is a framework for building maintainable business processes.
 test_files: []