cm-admin 0.6.1 → 0.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e28d75f3c079c84bbf3e36a395b277390810ae103b87f2678b15c5c12210257
-  data.tar.gz: f207f2665af3246e6f285c626dcfc23bd2f6160b893e665311e4e0babf42f919
+  metadata.gz: cb9d2bfcdbec704c6259f45f51e317e32ad05d5ca4990a52fca17af831f62566
+  data.tar.gz: 6a357cfe4458e4da3409c8e95e51cda3e36d6d8ebbd00c4518a6928f1815926e
 SHA512:
-  metadata.gz: 2c1834f17fa138e419d25cd20140ee6e9b78594a3ce8d37f1834eb113f9e88def0b9532b09e3d4c0f0c3e5d1334ddb88d298274b4e70e12779d9e349732d215e
-  data.tar.gz: 0e2781411e73d8ba757462451992f65292a47bb9d9042546a0b70486e7d38e6a60209bf4130ca08d47dc6617ecec75558f15f586c21c90187d998ba9ec74f699
+  metadata.gz: 242b5d01155399a9c9038b1a0811db95c82824ace0c9e4b592c98d9dae5a51b23cf28a80cb89db771f0d647685b5b5b9c83e0ac6774269eb0c88d4c90c792c83
+  data.tar.gz: 17cd6516e61f6e3ff3aa6fc7515807c3a5fb423d0fa016992aba51bbe2b2f40b885aa6e200c8aefa71b713dd2477fcb3bbb7f63e0ba7de96ca6e2351ae058356

data/app/helpers/cm_admin/application_helper.rb

@@ -7,5 +7,11 @@ module CmAdmin
     def current_webpacker_instance
       CmAdmin.webpacker
     end
+
+    # Allow if policy is not defined.
+    def has_valid_policy(model_name, action_name)
+      return true unless policy([:cm_admin, model_name.classify.constantize]).methods.include?(:"#{action_name}?")
+      policy([:cm_admin, model_name.classify.constantize]).send(:"#{action_name}?")
+    end
   end
 end

data/app/views/cm_admin/main/_table.html.slim

@@ -47,7 +47,7 @@
                     = link_to "#{page_url('edit', ar_object)}" do
                       .popup-option Edit
                   - custom_actions.each do |custom_action|
-                    - if custom_action.name.present? && policy([:cm_admin, @model.name.classify.constantize]).send(:"#{custom_action.name}?")
+                    - if custom_action.name.present? && has_valid_policy(@model.name, custom_action.name)
                       - if custom_action.display_if.call(ar_object)
                         = link_to custom_action.path.gsub(':id', ar_object.id.to_s), method: custom_action.verb do
                           .popup-option = custom_action.name.titleize

data/app/views/cm_admin/main/_top_navbar.html.slim

@@ -24,14 +24,14 @@
       - if new_action.any? && policy([:cm_admin, @model.name.classify.constantize]).new?
         = link_to 'Add', "#{page_url('new')}", class: 'primary-btn ml-2'
       - @model.available_actions.select{|act| act if act.route_type == 'collection'}.each do |custom_action|
-        - if custom_action.name.present? && policy([:cm_admin, @model.name.classify.constantize]).send(:"#{custom_action.name}?")
+        - if custom_action.name.present? && has_valid_policy(@model.name, custom_action.name)
           - if custom_action.display_type == :button
             = link_to custom_action.name.titleize, @model.ar_model.table_name + '/' + custom_action.path, class: 'primary-btn ml-2', method: custom_action.verb
           - elsif custom_action.display_type == :modal
             = link_to custom_action.name.titleize, '', class: 'primary-btn ml-2', data: { bs_toggle: "modal", bs_target: "##{custom_action.name.classify}Modal" }
     - elsif @model.current_action.name == 'show'
       - @model.available_actions.select{|act| act if act.route_type == 'member'}.each do |custom_action|
-        - if custom_action.name.present? && policy([:cm_admin, @model.name.classify.constantize]).send(:"#{custom_action.name}?")
+        - if custom_action.name.present? && has_valid_policy(@model.name, custom_action.name)
           - if custom_action.display_type == :button && custom_action.display_if.call(@ar_object)
             = link_to custom_action.name.titleize, custom_action.path.gsub(':id', params[:id]), class: 'primary-btn ml-2', method: custom_action.verb
           - elsif custom_action.display_type == :modal && custom_action.display_if.call(@ar_object)

data/lib/cm_admin/model.rb

@@ -45,7 +45,6 @@ module CmAdmin
       actions unless @actions_set
       $available_actions = @available_actions.dup
       self.class.all_actions.push(@available_actions)
-      define_policy
       define_controller
     end
 
@@ -101,23 +100,6 @@ module CmAdmin
 
     private
 
-    def define_policy
-      klass = Class.new(ApplicationPolicy) do
-        def initialize(user, record)
-          @user = user
-          @record = record
-        end
-
-        $available_actions.each do |action|
-          define_method :"#{action.name}?" do
-            accessible_by = action.accessible_by.map { |role| "user.#{role}" }.join(' || ')
-            eval(accessible_by)
-          end
-        end
-      end
-      CmAdmin.const_set "#{@name}Policy", klass
-    end
-
     # Controller defined for each model
     # If model is User, controller will be UsersController
     def define_controller
@@ -135,7 +117,7 @@ module CmAdmin
             @model.current_action = @action
             @ar_object = @model.try(@action.parent || action_name, params)
             @ar_object, @associated_model, @associated_ar_object = @model.custom_controller_action(action_name, params.permit!) if !@ar_object.present? && params[:id].present?
-            authorize controller_name.classify.constantize, policy_class: "CmAdmin::#{controller_name.classify}Policy".constantize
+            authorize controller_name.classify.constantize, policy_class: "CmAdmin::#{controller_name.classify}Policy".constantize if defined? "CmAdmin::#{controller_name.classify}Policy".constantize
             aar_model = request.url.split('/')[-2].classify.constantize  if params[:aar_id]
             @associated_ar_object = aar_model.find(params[:aar_id]) if params[:aar_id]
             nested_tables = @model.available_fields[:new].except(:fields).keys

data/lib/cm_admin/models/action.rb

@@ -6,7 +6,7 @@ module CmAdmin
       include Actions::Blocks
       attr_accessor :name, :verb, :layout_type, :layout, :partial, :path, :page_title, :page_description,
         :child_records, :is_nested_field, :nested_table_name, :parent, :display_if, :route_type, :code_block,
-        :display_type, :action_type, :redirection_url, :sort_direction, :sort_column, :accessible_by
+        :display_type, :action_type, :redirection_url, :sort_direction, :sort_column
 
       VALID_SORT_DIRECTION = Set[:asc, :desc].freeze
 
@@ -34,14 +34,12 @@ module CmAdmin
         self.action_type = :default
         self.sort_column = :created_at
         self.sort_direction = :desc
-        self.accessible_by = CmAdmin.authorized_roles
       end
 
-      def set_values(page_title, page_description, partial, accessible_by)
+      def set_values(page_title, page_description, partial)
         self.page_title = page_title
         self.page_description = page_description
         self.partial = partial
-        self.accessible_by = (CmAdmin.authorized_roles.dup << accessible_by).flatten.compact.uniq if accessible_by
       end
 
       class << self

data/lib/cm_admin/models/controller_method.rb

@@ -5,7 +5,8 @@ module CmAdmin
 
       def show(params)
         @current_action = CmAdmin::Models::Action.find_by(self, name: 'show')
-        @ar_object = @ar_model.name.classify.constantize.find(params[:id])
+        scoped_model = "CmAdmin::#{self.name}Policy::Scope".constantize.new(Current.user, self.name.constantize).resolve
+        @ar_object = scoped_model.find(params[:id])
       end
 
       def index(params)
@@ -40,7 +41,8 @@ module CmAdmin
         sort_column = "created_at"
         sort_direction = %w[asc desc].include?(sort_params[:sort_direction]) ? sort_params[:sort_direction] : "asc"
         sort_params = {sort_column: sort_column, sort_direction: sort_direction}
-        records = self.name.constantize.where(nil) if records.nil?
+        
+        records = "CmAdmin::#{self.name}Policy::Scope".constantize.new(Current.user, self.name.constantize).resolve if records.nil?
         records = records.order("#{current_action.sort_column} #{current_action.sort_direction}")
 
         final_data = CmAdmin::Models::Filter.filtered_data(filter_params, records, @filters)

data/lib/cm_admin/models/dsl_method.rb

@@ -10,28 +10,28 @@ module CmAdmin
         # @current_action = CmAdmin::Models::CustomAction.find_by(self, name: name)
       end
 
-      def cm_index(page_title: nil, page_description: nil, partial: nil, accessible_by: nil, &block)
+      def cm_index(page_title: nil, page_description: nil, partial: nil, &block)
         @current_action = CmAdmin::Models::Action.find_by(self, name: 'index')
-        @current_action.set_values(page_title, page_description, partial, accessible_by)
+        @current_action.set_values(page_title, page_description, partial)
         yield
         # action.instance_eval(&block)
       end
 
-      def cm_show(page_title: nil, page_description: nil, partial: nil, accessible_by: nil, &block)
+      def cm_show(page_title: nil, page_description: nil, partial: nil, &block)
         @current_action = CmAdmin::Models::Action.find_by(self, name: 'show')
-        @current_action.set_values(page_title, page_description, partial, accessible_by)
+        @current_action.set_values(page_title, page_description, partial)
         yield
       end
 
-      def cm_edit(page_title: nil,page_description: nil, partial: nil, accessible_by: nil, &block)
+      def cm_edit(page_title: nil,page_description: nil, partial: nil, &block)
         @current_action = CmAdmin::Models::Action.find_by(self, name: 'edit')
-        @current_action.set_values(page_title, page_description, partial, accessible_by)
+        @current_action.set_values(page_title, page_description, partial)
         yield
       end
 
-      def cm_new(page_title: nil,page_description: nil, partial: nil, accessible_by: nil, &block)
+      def cm_new(page_title: nil,page_description: nil, partial: nil, &block)
         @current_action = CmAdmin::Models::Action.find_by(self, name: 'new')
-        @current_action.set_values(page_title, page_description, partial, accessible_by)
+        @current_action.set_values(page_title, page_description, partial)
         yield
       end
 
@@ -47,16 +47,14 @@ module CmAdmin
         end
       end
 
-      def tab(tab_name, custom_action, associated_model: nil, layout_type: nil, layout: nil, partial: nil, accessible_by: nil, &block)
+      def tab(tab_name, custom_action, associated_model: nil, layout_type: nil, layout: nil, partial: nil, &block)
         if custom_action.to_s == ''
           @current_action = CmAdmin::Models::Action.find_by(self, name: 'show')
-          @current_action.accessible_by = (CmAdmin.authorized_roles.dup << accessible_by).flatten.compact.uniq  if accessible_by
           @available_tabs << CmAdmin::Models::Tab.new(tab_name, '', &block)
         else
           action = CmAdmin::Models::Action.new(name: custom_action.to_s, verb: :get, path: ':id/'+custom_action,
                       layout_type: layout_type, layout: layout, partial: partial, child_records: associated_model,
                       action_type: :custom, display_type: :page)
-          action.accessible_by = (CmAdmin.authorized_roles.dup << accessible_by).flatten.compact.uniq  if accessible_by
           @available_actions << action
           @current_action = action
           @available_tabs << CmAdmin::Models::Tab.new(tab_name, custom_action, &block)
@@ -117,12 +115,11 @@ module CmAdmin
       #     end
       #   end
       # end
-      def custom_action(name: nil, verb: nil, layout: nil, layout_type: nil, partial: nil, path: nil, display_type: nil, display_if: lambda { |arg| return true }, route_type: nil, accessible_by: nil, &block)
+      def custom_action(name: nil, verb: nil, layout: nil, layout_type: nil, partial: nil, path: nil, display_type: nil, display_if: lambda { |arg| return true }, route_type: nil, &block)
         action = CmAdmin::Models::CustomAction.new(
                     name: name, verb: verb, layout: layout, layout_type: layout_type, partial: partial, path: path,
                     parent: self.current_action.name, display_type: display_type, display_if: display_if,
                     action_type: :custom, route_type: route_type, &block)
-        action.accessible_by = (CmAdmin.authorized_roles.dup << accessible_by).flatten.compact.uniq  if accessible_by
         @available_actions << action
         # self.class.class_eval(&block)
       end

data/lib/cm_admin/version.rb

@@ -1,3 +1,3 @@
 module CmAdmin
-  VERSION = "0.6.1"
+  VERSION = "0.6.2"
 end

data/lib/generators/cm_admin/install_generator.rb

@@ -9,6 +9,7 @@ module CmAdmin
         copy_file 'cm_admin_initializer.rb', 'config/initializers/cm_admin.rb'
         copy_file 'custom.js', 'app/assets/javascripts/custom.js'
         copy_file 'custom.css', 'app/assets/stylesheets/custom.css'
+        copy_file 'application_policy.rb', 'app/policies/application_policy.rb'
         route 'mount CmAdmin::Engine => "/admin"'
       end
     end

data/lib/generators/cm_admin/policy_generator.rb

@@ -0,0 +1,13 @@
+require 'rails/generators'
+
+module CmAdmin
+  module Generators
+    class PolicyGenerator < Rails::Generators::NamedBase
+      source_root File.expand_path('templates', __dir__)
+
+      def copy_policy_files
+        template "policy.rb", "app/policies/cm_admin/#{file_name}_policy.rb"
+      end
+    end
+  end
+end

data/{app/policies → lib/generators/cm_admin/templates}/application_policy.rb

@@ -17,7 +17,7 @@ class ApplicationPolicy
   end
 
   def create?
-    false
+    true
   end
 
   def new?
@@ -43,7 +43,7 @@ class ApplicationPolicy
     end
 
     def resolve
-      raise NotImplementedError, "You must define #resolve in #{self.class}"
+      scope.all
     end
 
     private

data/lib/generators/cm_admin/templates/policy.rb

@@ -0,0 +1,8 @@
+class CmAdmin::<%= class_name %>Policy < ApplicationPolicy
+  <%- available_action_names = (CmAdmin::Model.find_by({name: class_name}).available_actions.map{|action| action.name}.uniq - ['custom_action', 'new', 'edit']) %>
+  <%- available_action_names.each do |action_name| %>
+  def <%= action_name %>?
+    <%= CmAdmin.authorized_roles.map {|role| "@user.#{role}" }.join(' && ') %>
+  end
+  <% end %>
+end

data/tmp/cache/webpacker/last-compilation-digest-development

@@ -1 +1 @@
-d5850cd60f91abe79ff8a84a45a9e24c75cb0e4b
+07d558738c316293586496817b2bccbf6430b5bd

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cm-admin
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
 platform: ruby
 authors:
 - sajinmp
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-03-25 00:00:00.000000000 Z
+date: 2022-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pagy
@@ -152,7 +152,6 @@ files:
 - app/javascript/packs/cm_admin/quick_search.js
 - app/javascript/packs/cm_admin/scaffolds.js
 - app/javascript/stylesheets/cm_admin/application.scss
-- app/policies/application_policy.rb
 - app/views/cm_admin/main/_associated_table.html.slim
 - app/views/cm_admin/main/_cm_pagy_nav.html.slim
 - app/views/cm_admin/main/_drawer.html.slim
@@ -222,9 +221,12 @@ files:
 - lib/cm_admin/view_helpers/navigation_helper.rb
 - lib/cm_admin/view_helpers/page_info_helper.rb
 - lib/generators/cm_admin/install_generator.rb
+- lib/generators/cm_admin/policy_generator.rb
+- lib/generators/cm_admin/templates/application_policy.rb
 - lib/generators/cm_admin/templates/cm_admin_initializer.rb
 - lib/generators/cm_admin/templates/custom.css
 - lib/generators/cm_admin/templates/custom.js
+- lib/generators/cm_admin/templates/policy.rb
 - lib/tasks/webpack_install.rake
 - package.json
 - postcss.config.js