clsx-rails 1.0.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 458496856224ba13decce2fcc1c4a15efd2eb8a44f86639c7eba9ecd5a06027a
-  data.tar.gz: 10dffbb660e3888a3d1379642d9895cc2cb63acde24e15cce06ae00428517722
+  metadata.gz: 5ac79817d0d2f653dbc76e4f3d044c6d599f342acecc1c6d6c6639dbbdec1ecf
+  data.tar.gz: ce38f0509202614f8aeab6f16f0079eb93d686e6c5c42d48170af8d50ccd801b
 SHA512:
-  metadata.gz: 72edd36ee323a3a8900d949142676f0539e44e1daa965fd2a02c87d7e8ec182bb2caa69f7494468d3bc500e8ad600d320839e70e4d0f3fac41589e3a541981ff
-  data.tar.gz: b65cf587a989e8ceac0b2b71c1e6ef518e2bd0761143fba3db407e9598d7c3e69de58fe92445e69eb70deb6df77e57c1e25c1f8c61c5601bbedeab4ab417657d
+  metadata.gz: 0c8e9e1d7100c07f7336b9a8ac4fd699b4a1a90f78bd4c2fa51cdd931583948913d9622e901a17f3fa03104fbebca4f92ac07df50287a1f4209bb531cf4886fe
+  data.tar.gz: 155e24fb75550a7a12e050fc20089fc9677e0435d7b08f0412d65b19a727f7fbca2cb86cbb0d7cf6df44b037e4e515efa947c42d2da9f020805ac8c4461d7e58

data/CHANGELOG.md

@@ -6,30 +6,52 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 
 ## Unreleased changes
 
+## v2.0.0 (2025-01-11)
+
+### Breaking Changes
+- Drop Rails 6.1 and 7.0 support, require Rails 7.1+
+
+### Features
+- Add Ruby 3.4 support
+- Add Rails 8.0, 8.1, and edge support
+
+### Performance Improvements
+- Rewrite algorithm for 2-5x performance improvement
+- Add fast-paths for single string, string array, and simple hash
+- Use Hash-based deduplication instead of Array + `uniq!`
+- Use `Symbol#name` instead of `to_s` for faster symbol conversion
+- Use direct class comparison for type checking
+- Remove unused `require 'set'`
+
+### Chore
+- Refactor benchmark infrastructure (data.rb, original.rb, quick.rb, run.rb)
+- Add CLAUDE.md for AI coding assistants
+
 ## v1.0.1 (2024-03-04)
 
 ### Performance Improvements
-- Speeds up the performance by 2x [`32236ed`](git@github.com:svyatov/clsx-rails/commit/32236ed)
+- Speeds up the performance by 2x [`32236ed`](https://github.com/svyatov/clsx-rails/commit/32236ed)
 
 ### Chore
-- Fixes CI action [`f1b948c`](git@github.com:svyatov/clsx-rails/commit/f1b948c)
-- Upload code coverage to CodeCov for the latest combination of Ruby and ActionView only [`4e5d768`](git@github.com:svyatov/clsx-rails/commit/4e5d768)
+- Fixes CI action [`f1b948c`](https://github.com/svyatov/clsx-rails/commit/f1b948c)
+- Upload code coverage to CodeCov for the latest combination of Ruby and ActionView only [`4e5d768`](https://github.com/svyatov/clsx-rails/commit/4e5d768)
 
 ### Documentation
-- Adds information about supported Ruby and Rails version [skip ci] [`2e6483f`](git@github.com:svyatov/clsx-rails/commit/2e6483f)
-- Adds link to the CodeCov badge, switch to Conventional Commits [`b48cc84`](git@github.com:svyatov/clsx-rails/commit/b48cc84)
+- Changelog update + version bump [`13b408d`](https://github.com/svyatov/clsx-rails/commit/13b408d)
+- Adds information about supported Ruby and Rails version [skip ci] [`2e6483f`](https://github.com/svyatov/clsx-rails/commit/2e6483f)
+- Adds link to the CodeCov badge, switch to Conventional Commits [`b48cc84`](https://github.com/svyatov/clsx-rails/commit/b48cc84)
 
 ### Other
-- Updates CI badge [skip ci] [`a829613`](git@github.com:svyatov/clsx-rails/commit/a829613)
-- Adds code coverage tracking [`0c5d34c`](git@github.com:svyatov/clsx-rails/commit/0c5d34c)
-- Ignore ruby-head in the CI matrix [`f3ab4df`](git@github.com:svyatov/clsx-rails/commit/f3ab4df)
-- Better name for the GitHub Action job [`a28adb7`](git@github.com:svyatov/clsx-rails/commit/a28adb7)
-- Adds badges, fixes rubocop configuration for CI [`56fab44`](git@github.com:svyatov/clsx-rails/commit/56fab44)
-- Create dependabot.yml [`ed1e0eb`](git@github.com:svyatov/clsx-rails/commit/ed1e0eb)
-- Fixes GitHub Actions [`f58a4b2`](git@github.com:svyatov/clsx-rails/commit/f58a4b2)
+- Updates CI badge [skip ci] [`a829613`](https://github.com/svyatov/clsx-rails/commit/a829613)
+- Adds code coverage tracking [`0c5d34c`](https://github.com/svyatov/clsx-rails/commit/0c5d34c)
+- Ignore ruby-head in the CI matrix [`f3ab4df`](https://github.com/svyatov/clsx-rails/commit/f3ab4df)
+- Better name for the GitHub Action job [`a28adb7`](https://github.com/svyatov/clsx-rails/commit/a28adb7)
+- Adds badges, fixes rubocop configuration for CI [`56fab44`](https://github.com/svyatov/clsx-rails/commit/56fab44)
+- Create dependabot.yml [`ed1e0eb`](https://github.com/svyatov/clsx-rails/commit/ed1e0eb)
+- Fixes GitHub Actions [`f58a4b2`](https://github.com/svyatov/clsx-rails/commit/f58a4b2)
 
 ## v1.0.0 (2024-03-03)
 
 ### Other
-- Initial commit [`f65b9b8`](git@github.com:svyatov/clsx-rails/commit/f65b9b8)
+- Initial commit [`f65b9b8`](https://github.com/svyatov/clsx-rails/commit/f65b9b8)
 

data/CLAUDE.md

@@ -0,0 +1,54 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+## Project Overview
+
+clsx-rails is a Ruby gem that provides a Rails view helper (`clsx`/`cn`) for constructing CSS class strings conditionally. It's a Ruby port of the JavaScript [clsx](https://github.com/lukeed/clsx) package, adapted for Rails conventions.
+
+## Common Commands
+
+```bash
+# Run all tests and linting (default rake task)
+bundle exec rake
+
+# Run tests only
+bundle exec rake test
+
+# Run a single test file
+bundle exec ruby -Itest test/clsx/helper_test.rb
+
+# Run a specific test method
+bundle exec ruby -Itest test/clsx/helper_test.rb -n test_with_strings
+
+# Run linter
+bundle exec rake rubocop
+
+# Run benchmark
+bundle exec ruby benchmark/run.rb
+
+# Install dependencies
+bin/setup
+```
+
+## Architecture
+
+The gem has a minimal structure:
+
+- `lib/clsx-rails.rb` - Entry point that auto-includes the helper into ActionView via `ActiveSupport.on_load`
+- `lib/clsx/helper.rb` - Core implementation with `clsx` method and `cn` alias
+- `lib/clsx/version.rb` - Version constant
+
+The helper uses an optimized algorithm with fast-paths for common cases (single string, string array, simple hash) and Hash-based deduplication for complex inputs.
+
+## Key Behaviors
+
+- Returns `nil` (not empty string) when no classes apply - this prevents Rails from rendering empty `class=""` attributes
+- Eliminates duplicate classes automatically
+- Ruby falsy values are only `false` and `nil` (unlike JS, `0`, `''`, `[]`, `{}` are truthy)
+- Ignores `Proc`/lambda objects and boolean `true` values
+- Supports complex hash keys like `{ %w[foo bar] => true }` which resolve recursively
+
+## Commit Convention
+
+Uses [Conventional Commits](https://www.conventionalcommits.org/): `feat`, `fix`, `perf`, `chore`, `docs`, `refactor`

data/README.md

@@ -8,7 +8,7 @@ It is especially useful when you have a lot of conditional classes and you want
 
 ## Supported Ruby and Rails versions
 
-Ruby 3.1+ and Rails 7.0+ are supported.
+Ruby 3.1+ and Rails 7.1+ are supported.
 
 ## Installation
 

data/lib/clsx/helper.rb

@@ -1,15 +1,14 @@
 # frozen_string_literal: true
 
-require 'set'
-
 # :nodoc:
 module Clsx
   # :nodoc:
   module Helper
     # The clsx function can take any number of arguments,
-    # each of which can be an Hash, Array, Boolean, String, or Symbol.
+    # each of which can be Hash, Array, Boolean, String, or Symbol.
     #
-    # **Important**: Any falsy values are discarded! Standalone Boolean values are discarded as well.
+    # **Important**
+    # Any falsy values are discarded! Standalone Boolean values are discarded as well.
     #
     # @param [Mixed] args
     #
@@ -25,33 +24,97 @@ module Clsx
     #   <div class="<%= clsx('foo', 'bar') %>">
     #   <div class="<%= clsx('foo', active: @is_active, 'another-class' => @condition) %>">
     #   <%= tag.div class: clsx(%w[foo bar], hidden: @condition) do ... end %>
+    #
+    # @note Implementation prioritizes performance over readability.
+    #   Direct class comparisons and explicit conditionals are used
+    #   instead of more idiomatic Ruby patterns for speed.
+
+    # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
     def clsx(*args)
-      result = clsx_args_processor(*args)
-      result.uniq!
-      result.join(' ').presence
+      return nil if args.empty?
+
+      # Fast path: single argument (most common cases)
+      if args.size == 1
+        arg = args[0]
+        klass = arg.class
+
+        if klass == String
+          return arg.empty? ? nil : arg
+        elsif klass == Symbol
+          return arg.name
+        elsif klass == Array && arg.all?(String)
+          seen = {}
+          arg.each { |s| seen[s] = true unless s.empty? || seen.key?(s) }
+          return seen.empty? ? nil : seen.keys.join(' ')
+        elsif klass == Hash
+          return clsx_simple_hash(arg)
+        end
+      end
+
+      seen = {}
+      clsx_process(args, seen)
+      seen.empty? ? nil : seen.keys.join(' ')
     end
+    # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+
     alias cn clsx
 
     private
 
-    # @param [Mixed] args
-    #
-    # @return [Array]
-    def clsx_args_processor(*args) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-      result = []
-      complex_keys = []
+    # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+    def clsx_simple_hash(hash)
+      return nil if hash.empty?
 
-      args.flatten!
-      args.each do |arg|
-        next if arg.blank? || arg.is_a?(TrueClass) || arg.is_a?(Proc)
-        next result << arg.to_s unless arg.is_a?(Hash)
+      seen = {}
+      hash.each do |key, value|
+        next unless value
+
+        klass = key.class
 
-        arg.each { |key, value| complex_keys << key if value }
+        if klass == Symbol
+          seen[key.name] = true
+        elsif klass == String
+          seen[key] = true unless key.empty?
+        else
+          # Complex key - fall back to full processing
+          seen = {}
+          clsx_process([hash], seen)
+          return seen.empty? ? nil : seen.keys.join(' ')
+        end
       end
 
-      return result if complex_keys.empty?
+      seen.empty? ? nil : seen.keys.join(' ')
+    end
+
+    # rubocop:disable Style/MultipleComparison
+    def clsx_process(args, seen)
+      deferred = nil
+
+      args.each do |arg|
+        klass = arg.class
+
+        if klass == String
+          seen[arg] = true unless arg.empty? || seen.key?(arg)
+        elsif klass == Symbol
+          str = arg.name
+          seen[str] = true unless seen.key?(str)
+        elsif klass == Array
+          clsx_process(arg, seen)
+        elsif klass == Hash
+          arg.each { |key, value| (deferred ||= []) << key if value }
+        elsif klass == Integer || klass == Float
+          str = arg.to_s
+          seen[str] = true unless seen.key?(str)
+        elsif klass == NilClass || klass == FalseClass || klass == TrueClass || klass == Proc
+          next
+        else
+          str = arg.to_s
+          seen[str] = true unless str.empty? || seen.key?(str)
+        end
+      end
 
-      result + clsx_args_processor(*complex_keys)
+      clsx_process(deferred, seen) if deferred
     end
+    # rubocop:enable Style/MultipleComparison, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
   end
 end

data/lib/clsx/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Clsx
-  VERSION = '1.0.1'
+  VERSION = '2.0.0'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: clsx-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Leonid Svyatov
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-04 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -16,14 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '6.1'
+        version: '7.1'
 description: A tiny Rails view helper for constructing CSS class strings conditionally
 email:
 - leonid@svyatov.com
@@ -32,6 +31,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - CHANGELOG.md
+- CLAUDE.md
 - LICENSE.txt
 - README.md
 - lib/clsx-rails.rb
@@ -45,7 +45,6 @@ metadata:
   source_code_uri: https://github.com/svyatov/clsx-rails
   changelog_uri: https://github.com/svyatov/clsx-rails/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -60,8 +59,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.6
-signing_key:
+rubygems_version: 4.0.3
 specification_version: 4
 summary: clsx / classnames for Rails views
 test_files: []