cloudfront_asset_host 1.0.1 → 1.0.2

data/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2

data/cloudfront_asset_host.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{cloudfront_asset_host}
-  s.version = "1.0.1"
+  s.version = "1.0.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Menno van der Sman"]
-  s.date = %q{2010-03-18}
+  s.date = %q{2010-03-23}
   s.description = %q{Easy deployment of your assets on CloudFront or S3 using a simple rake-task. When enabled in production, the application's asset_host and public_paths will point to the correct location.}
   s.email = %q{menno@wakoopa.com}
   s.extra_rdoc_files = [

data/lib/cloudfront_asset_host.rb

@@ -55,7 +55,12 @@ module CloudfrontAssetHost
 
       if source && request && CloudfrontAssetHost.gzip
         gzip_allowed  = CloudfrontAssetHost.gzip_allowed_for_source?(source)
-        gzip_accepted = !(request.headers['User-Agent'].to_s =~ /(Mozilla\/4\.0[678])|(MSIE\s[1-6])/) && request.headers['Accept-Encoding'].to_s.include?('gzip')
+
+        # Only Netscape 4 does not support gzip
+        # IE masquerades as Netscape 4, so we check that as well
+        user_agent = request.headers['User-Agent'].to_s
+        gzip_accepted = !(user_agent =~ /^Mozilla\/4/) || user_agent =~ /\bMSIE/
+        gzip_accepted &&= request.headers['Accept-Encoding'].to_s.include?('gzip')
 
         if gzip_accepted && gzip_allowed
           host << "/#{CloudfrontAssetHost.gzip_prefix}"

data/test/cloudfront_asset_host_test.rb

@@ -34,23 +34,46 @@ class CloudfrontAssetHostTest < Test::Unit::TestCase
     context "asset-host" do
 
       setup do
-        @gzip_request = stub(:headers => {'Accept-Encoding' => 'gzip, compress'})
-        @request = stub(:headers => {})
-        @img_source = "/images/logo.png"
-        @js_source  = "/javascripts/application.js"
+        @source  = "/javascripts/application.js"
       end
 
       should "use cname for asset_host" do
-        assert_equal "http://assethost.com", CloudfrontAssetHost.asset_host(@img_source, @request)
+        assert_equal "http://assethost.com", CloudfrontAssetHost.asset_host(@source)
       end
 
       should "use bucket_host when cname is not present" do
         CloudfrontAssetHost.cname = nil
-        assert_equal "http://bucketname.s3.amazonaws.com", CloudfrontAssetHost.asset_host(@img_source, @request)
+        assert_equal "http://bucketname.s3.amazonaws.com", CloudfrontAssetHost.asset_host(@source)
       end
 
-      should "add gz to asset_host when applicable" do
-        assert_equal "http://assethost.com/gz", CloudfrontAssetHost.asset_host(@js_source, @gzip_request)
+      should "not support gzip for images" do
+        request = stub(:headers => {'User-Agent' => 'Mozilla/5.0', 'Accept-Encoding' => 'gzip, compress'})
+        source  = "/images/logo.png"
+        assert_equal "http://assethost.com", CloudfrontAssetHost.asset_host(source, request)
+      end
+
+      context "when taking the headers into account" do
+
+        should "support gzip for IE" do
+          request = stub(:headers => {'User-Agent' => 'Mozilla/4.0 (compatible; MSIE 8.0)', 'Accept-Encoding' => 'gzip, compress'})
+          assert_equal "http://assethost.com/gz", CloudfrontAssetHost.asset_host(@source, request)
+        end
+
+        should "support gzip for modern browsers" do
+          request = stub(:headers => {'User-Agent' => 'Mozilla/5.0', 'Accept-Encoding' => 'gzip, compress'})
+          assert_equal "http://assethost.com/gz", CloudfrontAssetHost.asset_host(@source, request)
+        end
+
+        should "support not support gzip for Netscape 4" do
+          request = stub(:headers => {'User-Agent' => 'Mozilla/4.0', 'Accept-Encoding' => 'gzip, compress'})
+          assert_equal "http://assethost.com", CloudfrontAssetHost.asset_host(@source, request)
+        end
+
+        should "require gzip in accept-encoding" do
+          request = stub(:headers => {'User-Agent' => 'Mozilla/5.0'})
+          assert_equal "http://assethost.com", CloudfrontAssetHost.asset_host(@source, request)
+        end
+
       end
 
     end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 0
-  - 1
-  version: 1.0.1
+  - 2
+  version: 1.0.2
 platform: ruby
 authors: 
 - Menno van der Sman
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-18 00:00:00 +01:00
+date: 2010-03-23 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency