closure_tree 6.5.0 → 7.4.0

data/spec/parallel_spec.rb

@@ -1,159 +0,0 @@
-require 'spec_helper'
-
-# We don't need to run the expensive parallel tests for every combination of prefix/suffix.
-# Those affect SQL generation, not parallelism.
-# SQLite doesn't support concurrency reliably, either.
-def run_parallel_tests?
-  !sqlite? &&
-    ActiveRecord::Base.table_name_prefix.empty? &&
-    ActiveRecord::Base.table_name_suffix.empty?
-end
-
-def max_threads
-  5
-end
-
-class WorkerBase
-  extend Forwardable
-  attr_reader :name
-  def_delegators :@thread, :join, :wakeup, :status, :to_s
-
-  def log(msg)
-    puts("#{Thread.current}: #{msg}") if ENV['VERBOSE']
-  end
-
-  def initialize(target, name)
-    @target = target
-    @name = name
-    @thread = Thread.new do
-      ActiveRecord::Base.connection_pool.with_connection { before_work } if respond_to? :before_work
-      log 'going to sleep...'
-      sleep
-      log 'woke up...'
-      ActiveRecord::Base.connection_pool.with_connection { work }
-      log 'done.'
-    end
-  end
-end
-
-class FindOrCreateWorker < WorkerBase
-  def work
-    path = [name, :a, :b, :c]
-    log "making #{path}..."
-    t = (@target || Tag).find_or_create_by_path(path)
-    log "made #{t.id}, #{t.ancestry_path}"
-  end
-end
-
-describe 'Concurrent creation' do
-  before :each do
-    @target = nil
-    @iterations = 5
-  end
-
-  def log(msg)
-    puts(msg) if ENV['VERBOSE']
-  end
-
-  def run_workers(worker_class = FindOrCreateWorker)
-    @names = @iterations.times.map { |iter| "iteration ##{iter}" }
-    @names.each do |name|
-      workers = max_threads.times.map { worker_class.new(@target, name) }
-      # Wait for all the threads to get ready:
-      while true
-        unready_workers = workers.select { |ea| ea.status != 'sleep' }
-        if unready_workers.empty?
-          break
-        else
-          log "Not ready to wakeup: #{unready_workers.map { |ea| [ea.to_s, ea.status] }}"
-          sleep(0.1)
-        end
-      end
-      sleep(0.25)
-      # OK, GO!
-      log 'Calling .wakeup on all workers...'
-      workers.each(&:wakeup)
-      sleep(0.25)
-      # Then wait for them to finish:
-      log 'Calling .join on all workers...'
-      workers.each(&:join)
-    end
-    # Ensure we're still connected:
-    ActiveRecord::Base.connection_pool.connection
-  end
-
-  it 'will not create dupes from class methods' do
-    run_workers
-    expect(Tag.roots.collect { |ea| ea.name }).to match_array(@names)
-    # No dupe children:
-    %w(a b c).each do |ea|
-      expect(Tag.where(name: ea).size).to eq(@iterations)
-    end
-  end
-
-  it 'will not create dupes from instance methods' do
-    @target = Tag.create!(name: 'root')
-    run_workers
-    expect(@target.reload.children.collect { |ea| ea.name }).to match_array(@names)
-    expect(Tag.where(name: @names).size).to eq(@iterations)
-    %w(a b c).each do |ea|
-      expect(Tag.where(name: ea).size).to eq(@iterations)
-    end
-  end
-
-  it 'creates dupe roots without advisory locks' do
-    # disable with_advisory_lock:
-    allow(Tag).to receive(:with_advisory_lock) { |_lock_name, &block| block.call }
-    run_workers
-    # duplication from at least one iteration:
-    expect(Tag.where(name: @names).size).to be > @iterations
-  end
-
-  class SiblingPrependerWorker < WorkerBase
-    def before_work
-      @target.reload
-      @sibling = Label.new(name: SecureRandom.hex(10))
-    end
-
-    def work
-      @target.prepend_sibling @sibling
-    end
-  end
-
-  it 'fails to deadlock while simultaneously deleting items from the same hierarchy' do
-    target = User.find_or_create_by_path((1..200).to_a.map { |ea| ea.to_s })
-    emails = target.self_and_ancestors.to_a.map(&:email).shuffle
-    Parallel.map(emails, :in_threads => max_threads) do |email|
-      ActiveRecord::Base.connection_pool.with_connection do
-        User.transaction do
-          log "Destroying #{email}..."
-          User.where(email: email).destroy_all
-        end
-      end
-    end
-    User.connection.reconnect!
-    expect(User.all).to be_empty
-  end
-
-  class SiblingPrependerWorker < WorkerBase
-    def before_work
-      @target.reload
-      @sibling = Label.new(name: SecureRandom.hex(10))
-    end
-
-    def work
-      @target.prepend_sibling @sibling
-    end
-  end
-
-  it 'fails to deadlock from prepending siblings' do
-    @target = Label.find_or_create_by_path %w(root parent)
-    run_workers(SiblingPrependerWorker)
-    children = Label.roots
-    uniq_order_values = children.collect { |ea| ea.order_value }.uniq
-    expect(children.size).to eq(uniq_order_values.size)
-
-    # The only non-root node should be "root":
-    expect(Label.all.select { |ea| ea.root? }).to eq([@target.parent])
-  end
-end if run_parallel_tests?

data/spec/spec_helper.rb

@@ -1,24 +0,0 @@
-$LOAD_PATH.unshift(File.dirname(__FILE__) + '/../lib')
-
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
-require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])
-
-require 'database_cleaner'
-require 'closure_tree/test/matcher'
-require 'tmpdir'
-require 'timecop'
-require 'forwardable'
-require 'parallel'
-begin
-  require 'foreigner'
-rescue LoadError
-  #Foreigner is not needed in ActiveRecord 4.2+
-end
-
-Thread.abort_on_exception = true
-
-Dir['./spec/support/**/*.rb'].sort.each { |f| require f }
-
-RSpec.configure do |config|
-  config.include ClosureTree::Test::Matcher
-end

data/spec/support/database.rb

@@ -1,52 +0,0 @@
-database_folder = "#{File.dirname(__FILE__)}/../db"
-database_adapter = ENV['DB'] ||= 'postgresql'
-
-def sqlite?
-  ENV['DB'] == 'sqlite'
-end
-
-log = Logger.new('db.log')
-log.sev_threshold = Logger::DEBUG
-ActiveRecord::Base.logger = log
-
-ActiveRecord::Migration.verbose = false
-ActiveRecord::Base.table_name_prefix = ENV['DB_PREFIX'].to_s
-ActiveRecord::Base.table_name_suffix = ENV['DB_SUFFIX'].to_s
-
-def db_name
-  @db_name ||= "closure_tree_test_#{rand(1..2**31)}"
-end
-
-ActiveRecord::Base.configurations = YAML::load(ERB.new(IO.read("#{database_folder}/database.yml")).result)
-
-config = ActiveRecord::Base.configurations[database_adapter]
-
-begin
-  case database_adapter
-  when 'sqlite'
-    ActiveRecord::Base.establish_connection(database_adapter.to_sym)
-  when 'mysql'
-    ActiveRecord::Base.establish_connection(config.merge('database' => nil))
-    ActiveRecord::Base.connection.recreate_database(config['database'], {charset: 'utf8', collation: 'utf8_unicode_ci'})
-  when 'postgresql'
-    ActiveRecord::Base.establish_connection(config.merge('database' => 'postgres', 'schema_search_path' => 'public'))
-    ActiveRecord::Base.connection.recreate_database(config['database'], config.merge('encoding' => 'utf8'))
-  end
-end unless ENV['NONUKES']
-
-ActiveRecord::Base.establish_connection(config)
-# Drop this when support for ActiveRecord 4.1 is removed
-Foreigner.load if defined?(Foreigner)
-
-require "#{database_folder}/schema"
-require "#{database_folder}/models"
-
-# See http://stackoverflow.com/a/22388177/1268016
-def count_queries(&block)
-  count = 0
-  counter_fn = ->(name, started, finished, unique_id, payload) do
-    count += 1 unless %w[CACHE SCHEMA].include? payload[:name]
-  end
-  ActiveSupport::Notifications.subscribed(counter_fn, 'sql.active_record', &block)
-  count
-end

data/spec/support/database_cleaner.rb

@@ -1,14 +0,0 @@
-RSpec.configure do |config|
-
-  DatabaseCleaner.strategy = :truncation
-
-  config.before(:each) do
-    ActiveRecord::Base.connection_pool.connection
-    DatabaseCleaner.start
-  end
-
-  config.after(:each) do
-    ActiveRecord::Base.connection_pool.connection
-    DatabaseCleaner.clean
-  end
-end

data/spec/support/exceed_query_limit.rb

@@ -1,18 +0,0 @@
-# Derived from http://stackoverflow.com/a/13423584/153896. Updated for RSpec 3.
-RSpec::Matchers.define :exceed_query_limit do |expected|
-  supports_block_expectations
-
-  match do |block|
-    query_count(&block) > expected
-  end
-
-  failure_message_when_negated do |actual|
-    "Expected to run maximum #{expected} queries, got #{@counter.query_count}"
-  end
-
-  def query_count(&block)
-    @counter = ActiveRecord::QueryCounter.new
-    ActiveSupport::Notifications.subscribed(@counter.to_proc, 'sql.active_record', &block)
-    @counter.query_count
-  end
-end

data/spec/support/hash_monkey_patch.rb

@@ -1,13 +0,0 @@
-class Hash
-  def render_from_yield(&block)
-    reduce({}) do |h, entry|
-      k, v = entry
-      h[block.call(k)] = if v.is_a?(Hash) then
-        v.render_from_yield(&block)
-      else
-        block.call(v)
-      end
-      h
-    end
-  end
-end

data/spec/support/query_counter.rb

@@ -1,18 +0,0 @@
-# From http://stackoverflow.com/a/13423584/153896
-module ActiveRecord
-  class QueryCounter
-    attr_reader :query_count
-
-    def initialize
-      @query_count = 0
-    end
-
-    def to_proc
-      lambda(&method(:callback))
-    end
-
-    def callback(name, start, finish, message_id, values)
-      @query_count += 1 unless %w(CACHE SCHEMA).include?(values[:name])
-    end
-  end
-end

data/spec/support/sqlite3_with_advisory_lock.rb

@@ -1,10 +0,0 @@
-if sqlite?
-  RSpec.configure do |config|
-    config.before(:suite) do
-      ENV['FLOCK_DIR'] = Dir.mktmpdir
-    end
-    config.after(:suite) do
-      FileUtils.remove_entry_secure ENV['FLOCK_DIR']
-    end
-  end
-end

data/spec/support_spec.rb

@@ -1,14 +0,0 @@
-require 'spec_helper'
-
-describe ClosureTree::Support do
-  let(:sut) { Tag._ct }
-  it 'passes through table names without prefix and suffix' do
-    expected = 'some_random_table_name'
-    expect(sut.remove_prefix_and_suffix(expected)).to eq(expected)
-  end
-  it 'extracts through table name with prefix and suffix' do
-    expected = 'some_random_table_name'
-    tn = ActiveRecord::Base.table_name_prefix + expected + ActiveRecord::Base.table_name_suffix
-    expect(sut.remove_prefix_and_suffix(tn)).to eq(expected)
-  end
-end