closure_tree 6.5.0 → 6.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8612efc584f34d7e880cfe02d66791eba5cdc639
-  data.tar.gz: feb72d046d18b9c097002ac65af76343f616fcbd
+  metadata.gz: c2a4b1786131c2b97479335f02da9e7c07a07f68
+  data.tar.gz: a2a1803ef7cb252a5f6f3996b3196606abf4c396
 SHA512:
-  metadata.gz: 65e6a3c45fadbfc87546db2e1b8417207f19d12c26f0683bd621fb6e5b6714c66dd95f17e7a4b36895589404479c45b0a2fe6fb40a9811160381a105ff02995a
-  data.tar.gz: da5d009c2bfd51f56911c0838ed5ca8d0662e53c34630e75bd1b390b530993a25c7ff76d16e2650dea474b655c780204f9f6dcb0c9f96eda8adc3dd68adcc148
+  metadata.gz: e088751351930a9ff34d6fbcd0468e6949bff95d4ffccdaaab36cd240163029fccc752234c3ba04ceabb819a8be9a1af39b4e11beecb38003d36da7ed17dd6de
+  data.tar.gz: fc9d0ce048a35d852767bbed49b3b3dae1f6bd2efe92c31b37517205a5999fb69b8ae5d7c38984537121ea00702df667a4ed4e35e170c44d307eb9ddfa528136

data/.travis.yml

@@ -4,15 +4,15 @@ language: ruby
 rvm:
   - 2.4.0
   - 2.3.3
-  - 2.2.6
+  - 2.2.7
 # these haven't been passing for a while:
 #  - jruby-head
 #  - rbx
 
 gemfile:
-  - gemfiles/activerecord_4.2.gemfile
-  - gemfiles/activerecord_5.0_foreigner.gemfile
+  - gemfiles/activerecord_5.1.gemfile
   - gemfiles/activerecord_5.0.gemfile
+  - gemfiles/activerecord_4.2.gemfile
   - gemfiles/activerecord_edge.gemfile
 
 env:

data/Appraisals

@@ -1,19 +1,14 @@
 
 appraise 'activerecord-4.2' do
   gem 'activerecord', '~> 4.2.0'
-
-  platforms :ruby, :rbx do
-    gem 'mysql2', '~> 0.3.20'
-  end
 end
 
-appraise 'activerecord-5.0-foreigner' do
+appraise 'activerecord-5.0' do
   gem 'activerecord', '~> 5.0.0'
-  gem 'foreigner'
 end
 
-appraise 'activerecord-5.0' do
-  gem 'activerecord', '~> 5.0.0'
+appraise 'activerecord-5.1' do
+  gem 'activerecord', '~> 5.1.0'
 end
 
 appraise 'activerecord-edge' do

data/CHANGELOG.md

@@ -1,27 +1,45 @@
 # Changelog
 
-### 6.5.0
+### 6.6.0
+
+Closure Tree is now tested against Rails 5.1, and just passed 50 contributors and
+1000 stars on github! 🎉!
+
+Note that Closure Tree has moved to a new "Closure Tree" github organization.
+**Future gem releases will be done by other contributors.**
 
-* Merged [PR 258](https://github.com/mceachen/closure_tree/pull/258) which improves hierarchy maintenance with large trees.
-  Thanks, [Nikolay Bekirov](https://github.com/nbekirov)!
+* ActiveSupport 5.1 deprecation warnings were addressed in [PR
+  262](https://github.com/ClosureTree/closure_tree/pull/262). Thanks, [Charles
+  Pence](https://github.com/cpence)!
+* ActiveSupport 5.1 test failures were fixed in 
+  [PR 280](https://github.com/ClosureTree/closure_tree/pull/280). 
+  Thanks, [Bobby Uhlenbrock](https://github.com/uhlenbrock)!
+* A database connection was leaked at startup, fixed in [PR
+  263](https://github.com/ClosureTree/closure_tree/pull/263). Thanks, [Andrey
+  Novikov](https://github.com/Envek)!
+
+### 6.5.0
 
+* Merged [PR 258](https://github.com/ClosureTree/closure_tree/pull/258) which
+  improves hierarchy maintenance with large trees. Thanks, [Nikolay
+  Bekirov](https://github.com/nbekirov)!
 ### 6.4.0
 
-* Merged [PR 236](https://github.com/mceachen/closure_tree/pull/236) which adds documentation for `has_closure_tree_root`.
+* Merged [PR 236](https://github.com/ClosureTree/closure_tree/pull/236) which adds documentation for `has_closure_tree_root`.
 * Added ruby 2.4 and dropped Rails 4.1 from the build matrix.
 
 ### 6.3.0
 
-* `prepend_child` [handles invalid children properly now](https://github.com/mceachen/closure_tree/issues/249).
+* `prepend_child` [handles invalid children properly now](https://github.com/ClosureTree/closure_tree/issues/249).
   Thanks [Amit Saxena](https://github.com/amitsaxena)!
 * Dropped official support for jruby and ruby 2.0 (no code was changed)
 
 ### 6.2.0
 
-* Fix for [MySQL lock lengths](https://github.com/mceachen/closure_tree/issues/231).
+* Fix for [MySQL lock lengths](https://github.com/ClosureTree/closure_tree/issues/231).
    Thanks to [Liam](https://github.com/hut8)!
-* [Tom Smyth](https://github.com/hooverlunch) added [eager tree loading](https://github.com/mceachen/closure_tree/pull/232)
-* Merged [PR 200](https://github.com/mceachen/closure_tree/pull/200) which may or may not add support to SQLServer 2008 (but this is not a supported RDBMS).
+* [Tom Smyth](https://github.com/hooverlunch) added [eager tree loading](https://github.com/ClosureTree/closure_tree/pull/232)
+* Merged [PR 200](https://github.com/ClosureTree/closure_tree/pull/200) which may or may not add support to SQLServer 2008 (but this is not a supported RDBMS).
 
 ### 6.1.0
 
@@ -45,7 +63,7 @@
 * Dropped support for versions of Rails 3.2 and 4.0 (which are no longer supported).
 * Dropped support for Ruby 1.9 and JRuby 1.9 (which are no longer supported).
 * Added support for `.hash_tree` from `.parent` and `.children`. 
-  Addresses [PR146](https://github.com/mceachen/closure_tree/pull/146).
+  Addresses [PR146](https://github.com/ClosureTree/closure_tree/pull/146).
   Thanks for reporting this and the breaking test, [Mike](https://github.com/mkralla11)!
 
 ### 5.2.0
@@ -56,7 +74,7 @@
 * [Ryan Selk](https://github.com/rselk) made several enhancements to the migration generation (thanks!).
 * [ruok5](https://github.com/ruok5) updated the README to clarify a heirarchy maintenance usecase. Thanks!
 * Made migrations error with a helpful message if the target didn't have the `has_closure_tree` or
-  `acts_as_tree` annotation. This addresses [issue 131](https://github.com/mceachen/closure_tree/issues/131).
+  `acts_as_tree` annotation. This addresses [issue 131](https://github.com/ClosureTree/closure_tree/issues/131).
 
 ### 5.1.1
 
@@ -67,7 +85,7 @@
 
 * [Abdelkader Boudih](https://github.com/seuros) added a database generator
   for the hierarchies table. Thanks!
-* [Jason Weathered](https://github.com/jasoncodes) fixed [issue #117](https://github.com/mceachen/closure_tree/pull/117)
+* [Jason Weathered](https://github.com/jasoncodes) fixed [issue #117](https://github.com/ClosureTree/closure_tree/pull/117)
   with the preordered traversal code that assumed the primary key column was called `id`. Thanks!
 
 ### 5.0.0
@@ -91,13 +109,13 @@
 
 ### 4.6.2
 
-* Pulled in [106](https://github.com/mceachen/closure_tree/pull/106) which fixed a bug introduced
+* Pulled in [106](https://github.com/ClosureTree/closure_tree/pull/106) which fixed a bug introduced
   in 4.6.0 which broke if the numeric ordering column wasn't named 'sort_order'. Tests have been
   added. Thanks for the fix, [Fission Xuiptz](https://github.com/fissionxuiptz)!
 
 ### 4.6.1
 
-* Address [issue 60](https://github.com/mceachen/closure_tree/issues/60) (use `.empty?` rather 
+* Address [issue 60](https://github.com/ClosureTree/closure_tree/issues/60) (use `.empty?` rather 
   than `.nil?`—thanks for the suggestion, [Leonel Galán](https://github.com/leonelgalan),
   [Doug Mayer](https://github.com/doxavore) and [Samnang Chhun](https://github.com/samnang)!
 
@@ -124,7 +142,7 @@
 
 ### 4.4.0
 
-* Added ```.self_and_descendant_ids``` and ```.self_and_ancestors_ids``` from [PR92](https://github.com/mceachen/closure_tree/pull/92).
+* Added ```.self_and_descendant_ids``` and ```.self_and_ancestors_ids``` from [PR92](https://github.com/ClosureTree/closure_tree/pull/92).
   Thanks, [Kir Shatrov](https://github.com/kirs)!
 
 * Dropped support for Rails 3.0.
@@ -139,7 +157,7 @@
 ### 4.2.9
 
 * Support for Heroku's cray assets:precompile hack for Rails 4.
-  Addresses [issue 78](https://github.com/mceachen/closure_tree/issues/78).
+  Addresses [issue 78](https://github.com/ClosureTree/closure_tree/issues/78).
   Thanks for the assist, [Alex Bowman](https://github.com/axlekb).
 
 ### 4.2.8
@@ -149,7 +167,7 @@
 ### 4.2.7
 
 * ```self_and_ancestors``` and ```ancestry_hierarchy``` are reloaded
-  when nodes are reparented. Addresses [issue 68](https://github.com/mceachen/closure_tree/issues/68).
+  when nodes are reparented. Addresses [issue 68](https://github.com/ClosureTree/closure_tree/issues/68).
   Thanks for the assist, [Ivan Stana](https://github.com/istana).
 
 ### 4.2.6
@@ -169,12 +187,12 @@
 ### 4.2.4
 
 * Support for ```root?```, ```child?```, and proper parent-child associations
-  when both the parent and the child are not persisted. Addresses [issue 64](https://github.com/mceachen/closure_tree/issues/64).
+  when both the parent and the child are not persisted. Addresses [issue 64](https://github.com/ClosureTree/closure_tree/issues/64).
   Thanks for the help, [Gabriel Mazetto](https://github.com/brodock)!
 
 ### 4.2.3
 
-* Fixed ```attr_accessible?``` error introduced in 4.2.2 ([issue 66](https://github.com/mceachen/closure_tree/issues/66)).
+* Fixed ```attr_accessible?``` error introduced in 4.2.2 ([issue 66](https://github.com/ClosureTree/closure_tree/issues/66)).
 * Switched to use new WithAdvisoryLock::DatabaseAdapterSupport (in v0.0.9) to add Postgis support
 
 ### 4.2.2
@@ -204,11 +222,11 @@
 
 * Numeric, deterministically ordered siblings will always be [0..#{self_and_siblings.count}]
   (previously, the sort order might use negative values, which broke the preordering).
-  Resolves [issue 49](https://github.com/mceachen/closure_tree/issues/49). Thanks for the help,
+  Resolves [issue 49](https://github.com/ClosureTree/closure_tree/issues/49). Thanks for the help,
   [Leonel Galan](https://github.com/leonelgalan), [Juan Hoyos](https://github.com/elhoyos), and
   [Michael Elfassy](https://github.com/elfassy)!
 
-* The ```order``` option can be a symbol now. Resolves [issue 46](https://github.com/mceachen/closure_tree/issues/46).
+* The ```order``` option can be a symbol now. Resolves [issue 46](https://github.com/ClosureTree/closure_tree/issues/46).
 
 ### 4.0.0
 
@@ -223,22 +241,22 @@
 ### 3.10.2
 
 * Prevent faulty SQL statement when ```#siblings``` is called on an unsaved records.
-  Resolves [issue 52](https://github.com/mceachen/closure_tree/pull/52). Perfect pull
+  Resolves [issue 52](https://github.com/ClosureTree/closure_tree/pull/52). Perfect pull
   request by [Gary Greyling](https://github.com/garygreyling).
 
 * The ```.roots``` class method now correctly respects the ```:order``` option.
-  Resolves [issue 53](https://github.com/mceachen/closure_tree/issues/53).
+  Resolves [issue 53](https://github.com/ClosureTree/closure_tree/issues/53).
   Thanks for finding this, [Brendon Muir](https://github.com/brendon)!
 
 ### 3.10.1
 
 * Multipart constant names like "Admin::PageHierarchy" are now supported.
-  Resolves [issue 47](https://github.com/mceachen/closure_tree/issues/47).
+  Resolves [issue 47](https://github.com/ClosureTree/closure_tree/issues/47).
   Thanks for the perfect pull request, [Simon Menke](https://github.com/fd)!
 
 * Committing transactions involving large numbers of hierarchy model classes was very slow due
   to hash collisions in the hierarchy class. A better hash implementation addressed
-  [issue 48](https://github.com/mceachen/closure_tree/issues/48).
+  [issue 48](https://github.com/ClosureTree/closure_tree/issues/48).
   Thanks, [Joel Turkel](https://github.com/jturkel)!
 
 ### 3.10.0
@@ -267,19 +285,19 @@ All three of these improvements were suggested by Andrew Bromwich. Thanks!
 ### 3.8.0
 
 * Support for preordered descendants. This requires a numeric sort order column.
-  Resolves [feature request 38](https://github.com/mceachen/closure_tree/issues/38).
+  Resolves [feature request 38](https://github.com/ClosureTree/closure_tree/issues/38).
 * Moved modules from ```acts_as_tree``` into separate files
 
 ### 3.7.3
 
 Due to MySQL's inability to lock rows properly, I've switched to advisory_locks for
 all write paths. This will prevent deadlocks, addressing
-[issue 41](https://github.com/mceachen/closure_tree/issues/41).
+[issue 41](https://github.com/ClosureTree/closure_tree/issues/41).
 
 ### 3.7.2
 
 * Support for UUID primary keys. Addresses
-  [issue 40](https://github.com/mceachen/closure_tree/issues/40). Thanks for the pull request,
+  [issue 40](https://github.com/ClosureTree/closure_tree/issues/40). Thanks for the pull request,
   [Julien](https://github.com/calexicoz)!
 
 ### 3.7.1
@@ -290,7 +308,7 @@ all write paths. This will prevent deadlocks, addressing
 ### 3.7.0
 
 **Thread safety!**
-* [Advisory locks](https://github.com/mceachen/with_advisory_lock) were
+* [Advisory locks](https://github.com/ClosureTree/with_advisory_lock) were
   integrated with the class-level ```find_or_create_by_path``` and ```rebuild!```.
 * Pessimistic locking is used by the instance-level ```find_or_create_by_path```.
 
@@ -303,7 +321,7 @@ wasting time on the ruby side.
 ### 3.6.7
 
 * Added workaround for ActiveRecord::Observer usage pre-db-creation. Addresses
-  [issue 32](https://github.com/mceachen/closure_tree/issues/32).
+  [issue 32](https://github.com/ClosureTree/closure_tree/issues/32).
   Thanks, [Don Morrison](https://github.com/elskwid)!
 
 ### 3.6.6
@@ -314,28 +332,28 @@ Thanks, [James Miller](https://github.com/bensie)!
 ### 3.6.5
 
 * Use ```quote_table_name``` instead of ```quote_column_name```. Addresses
- [issue 29](https://github.com/mceachen/closure_tree/issues/29). Thanks,
+ [issue 29](https://github.com/ClosureTree/closure_tree/issues/29). Thanks,
  [Marcello Barnaba](https://github.com/vjt)!
 
 ### 3.6.4
 
 * Use ```.pluck``` when available for ```.ids_from```. Addresses
- [issue 26](https://github.com/mceachen/closure_tree/issues/26). Thanks,
+ [issue 26](https://github.com/ClosureTree/closure_tree/issues/26). Thanks,
  [Chris Sturgill](https://github.com/sturgill)!
 
 ### 3.6.3
 
-* Fixed [issue 24](https://github.com/mceachen/closure_tree/issues/24), which optimized ```#hash_tree```
+* Fixed [issue 24](https://github.com/ClosureTree/closure_tree/issues/24), which optimized ```#hash_tree```
   for roots. Thanks, [Saverio Trioni](https://github.com/rewritten)!
 
 ### 3.6.2
 
-* Fixed [issue 23](https://github.com/mceachen/closure_tree/issues/23), which added support for ```#siblings```
+* Fixed [issue 23](https://github.com/ClosureTree/closure_tree/issues/23), which added support for ```#siblings```
   when sort_order wasn't specified. Thanks, [Gary Greyling](https://github.com/garygreyling)!
 
 ### 3.6.1
 
-* Fixed [issue 20](https://github.com/mceachen/closure_tree/issues/20), which affected
+* Fixed [issue 20](https://github.com/ClosureTree/closure_tree/issues/20), which affected
   deterministic ordering when siblings where different STI classes. Thanks, [edwinramirez](https://github.com/edwinramirez)!
 
 ### 3.6.0
@@ -345,16 +363,16 @@ Added support for:
 * ActiveRecord::Base.table_name_prefix
 * ActiveRecord::Base.table_name_suffix
 
-This addresses [issue 21](https://github.com/mceachen/closure_tree/issues/21). Thanks, [Judd Blair](https://github.com/juddblair)!
+This addresses [issue 21](https://github.com/ClosureTree/closure_tree/issues/21). Thanks, [Judd Blair](https://github.com/juddblair)!
 
 ### 3.5.2
 
 * Added ```find_all_by_generation```
-  for [feature request 17](https://github.com/mceachen/closure_tree/issues/17).
+  for [feature request 17](https://github.com/ClosureTree/closure_tree/issues/17).
 
 ### 3.4.2
 
-* Fixed [issue 18](https://github.com/mceachen/closure_tree/issues/18), which affected
+* Fixed [issue 18](https://github.com/ClosureTree/closure_tree/issues/18), which affected
   append_node/prepend_node ordering when the first node didn't have an explicit order_by value
 
 ### 3.4.1
@@ -363,7 +381,7 @@ This addresses [issue 21](https://github.com/mceachen/closure_tree/issues/21). T
 
 ### 3.4.0
 
-Fixed [issue 15](https://github.com/mceachen/closure_tree/issues/15):
+Fixed [issue 15](https://github.com/ClosureTree/closure_tree/issues/15):
 * "parent" is now attr_accessible, which adds support for constructor-provided parents.
 * updated readme accordingly
 
@@ -373,7 +391,7 @@ Fixed [issue 15](https://github.com/mceachen/closure_tree/issues/15):
 
 ### 3.3.1
 
-* Added support for partially-unsaved hierarchies [issue 13](https://github.com/mceachen/closure_tree/issues/13):
+* Added support for partially-unsaved hierarchies [issue 13](https://github.com/ClosureTree/closure_tree/issues/13):
 ```
 a = Tag.new(name: "a")
 b = Tag.new(name: "b")
@@ -388,7 +406,7 @@ a.save
 ### 3.2.1
 
 * Added ```ancestor_ids```, ```descendant_ids```, and ```sibling_ids```
-* Added example spec to solve [issue 9](https://github.com/mceachen/closure_tree/issues/9)
+* Added example spec to solve [issue 9](https://github.com/ClosureTree/closure_tree/issues/9)
 
 ### 3.2.0
 
@@ -400,7 +418,7 @@ a.save
 
 ### 3.0.4
 
-* Merged [pull request](https://github.com/mceachen/closure_tree/pull/8) to fix ```.siblings``` and ```.self_and_siblings```
+* Merged [pull request](https://github.com/ClosureTree/closure_tree/pull/8) to fix ```.siblings``` and ```.self_and_siblings```
   (Thanks, [eljojo](https://github.com/eljojo)!)
 
 ### 3.0.3
@@ -415,7 +433,7 @@ a.save
 
 ### 3.0.1
 
-* Support 3.2.0's fickle deprecation of InstanceMethods (Thanks, [jheiss](https://github.com/mceachen/closure_tree/pull/5))!
+* Support 3.2.0's fickle deprecation of InstanceMethods (Thanks, [jheiss](https://github.com/ClosureTree/closure_tree/pull/5))!
 
 ### 3.0.0
 

data/README.md

@@ -1,15 +1,16 @@
 # Closure Tree
 
+__Important: please [vote on the future of ClosureTree](https://github.com/ClosureTree/closure_tree/issues/277)!__
+
 ### Closure_tree lets your ActiveRecord models act as nodes in a [tree data structure](http://en.wikipedia.org/wiki/Tree_%28data_structure%29)
 
 Common applications include modeling hierarchical data, like tags, threaded comments, page graphs in CMSes,
 and tracking user referrals.
 
 [![Join the chat at https://gitter.im/closure_tree/Lobby](https://badges.gitter.im/closure_tree/Lobby.svg)](https://gitter.im/closure_tree/Lobby?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
-[![Build Status](https://api.travis-ci.org/mceachen/closure_tree.svg?branch=master)](http://travis-ci.org/mceachen/closure_tree)
+[![Build Status](https://api.travis-ci.org/ClosureTree/closure_tree.svg?branch=master)](http://travis-ci.org/ClosureTree/closure_tree)
 [![Gem Version](https://badge.fury.io/rb/closure_tree.svg)](https://badge.fury.io/rb/closure_tree)
-[![Codacy Badge](https://api.codacy.com/project/badge/Grade/fa5a8ae2193d42adb30b4256732a757d)](https://www.codacy.com/app/matthew-github/closure_tree)
-[![Dependency Status](https://gemnasium.com/badges/github.com/mceachen/closure_tree.svg)](https://gemnasium.com/github.com/mceachen/closure_tree)
+[![Dependency Status](https://gemnasium.com/badges/github.com/ClosureTree/closure_tree.svg)](https://gemnasium.com/github.com/ClosureTree/closure_tree)
 
 Dramatically more performant than
 [ancestry](https://github.com/stefankroes/ancestry) and
@@ -26,9 +27,8 @@ closure_tree has some great features:
 * __Best-in-class mutation performance__:
   * 2 SQL INSERTs on node creation
   * 3 SQL INSERT/UPDATEs on node reparenting
-* __Support for [concurrency](#concurrency)__ (using [with_advisory_lock](https://github.com/mceachen/with_advisory_lock))
-* __Support for ActiveRecord 4.2 and 5.0__
-* __Support for Ruby 2.2 and 2.3__
+* __Support for [concurrency](#concurrency)__ (using [with_advisory_lock](https://github.com/ClosureTree/with_advisory_lock))
+* __Tested against ActiveRecord 4.2, 5.0, and 5.1, with  Ruby 2.2 and 2.3__
 * Support for reparenting children (and all their descendants)
 * Support for [single-table inheritance (STI)](#sti) within the hierarchy
 * ```find_or_create_by_path``` for [building out heterogeneous hierarchies quickly and conveniently](#find_or_create_by_path)
@@ -254,7 +254,7 @@ b.hash_tree(:limit_depth => 2)
 Without this option, ```hash_tree``` will load the entire contents of that table into RAM. Your
 server may not be happy trying to do this.
 
-HT: [ancestry](https://github.com/stefankroes/ancestry#arrangement) and [elhoyos](https://github.com/mceachen/closure_tree/issues/11)
+HT: [ancestry](https://github.com/stefankroes/ancestry#arrangement) and [elhoyos](https://github.com/ClosureTree/closure_tree/issues/11)
 
 ### Eager loading
 
@@ -305,13 +305,13 @@ File.open("example.dot", "w") { |f| f.write(Tag.root.to_dot_digraph) }
 ```
 Then, in a shell, ```dot -Tpng example.dot > example.png```, which produces:
 
-![Example tree](https://raw.github.com/mceachen/closure_tree/master/img/example.png)
+![Example tree](https://raw.github.com/ClosureTree/closure_tree/master/img/example.png)
 
 If you want to customize the label value, override the ```#to_digraph_label``` instance method in your model.
 
 Just for kicks, this is the test tree I used for proving that preordered tree traversal was correct:
 
-![Preordered test tree](https://raw.github.com/mceachen/closure_tree/master/img/preorder.png)
+![Preordered test tree](https://raw.github.com/ClosureTree/closure_tree/master/img/preorder.png)
 
 ### Available options
 
@@ -484,7 +484,7 @@ Several methods, especially ```#rebuild``` and ```#find_or_create_by_path```, ca
 
 Database row-level locks work correctly with PostgreSQL, but MySQL's row-level locking is broken, and
 erroneously reports deadlocks where there are none. To work around this, and have a consistent implementation
-for both MySQL and PostgreSQL, [with_advisory_lock](https://github.com/mceachen/with_advisory_lock)
+for both MySQL and PostgreSQL, [with_advisory_lock](https://github.com/ClosureTree/with_advisory_lock)
 is used automatically to ensure correctness.
 
 If you are already managing concurrency elsewhere in your application, and want to disable the use
@@ -499,6 +499,15 @@ end
 Note that you *will eventually have data corruption* if you disable advisory locks, write to your
 database with multiple threads, and don't provide an alternative mutex.
 
+## I18n
+
+You can customize error messages using [I18n](http://guides.rubyonrails.org/i18n.html):
+
+```yaml
+en-US:
+  closure_tree:
+    loop_error: Your descendant cannot be your parent!
+```
 
 ## FAQ
 
@@ -508,7 +517,7 @@ Yup! [Ilya Bodrov](https://github.com/bodrovis) wrote [Nested Comments with Rail
 
 ### Does this work well with ```#default_scope```?
 
-**No.** Please see [issue 86](https://github.com/mceachen/closure_tree/issues/86) for details.
+**No.** Please see [issue 86](https://github.com/ClosureTree/closure_tree/issues/86) for details.
 
 ### Can I update parentage with `update_attribute`?
 
@@ -517,7 +526,7 @@ hierarchy table.
 
 ### Can I assign a parent to multiple children with  ```#update_all```?
 
-**No.** Please see [issue 197](https://github.com/mceachen/closure_tree/issues/197) for details.
+**No.** Please see [issue 197](https://github.com/ClosureTree/closure_tree/issues/197) for details.
 
 ### Does this gem support multiple parents?
 
@@ -576,11 +585,11 @@ bundle install
 
 ### Object destroy fails with MySQL v5.7+
 
-A bug was introduced in MySQL's query optimizer. [See the workaround here](https://github.com/mceachen/closure_tree/issues/206).
+A bug was introduced in MySQL's query optimizer. [See the workaround here](https://github.com/ClosureTree/closure_tree/issues/206).
 
 ### Hierarchy maintenance errors from MySQL v5.7.9-v5.7.10
 
-Upgrade to MySQL 5.7.12 or later if you see [this issue](https://github.com/mceachen/closure_tree/issues/190):
+Upgrade to MySQL 5.7.12 or later if you see [this issue](https://github.com/ClosureTree/closure_tree/issues/190):
 
     Mysql2::Error: You can't specify target table '*_hierarchies' for update in FROM clause
 
@@ -617,10 +626,10 @@ end
 
 ## Testing
 
-Closure tree is [tested under every valid combination](http://travis-ci.org/#!/mceachen/closure_tree) of
+Closure tree is [tested under every valid combination](http://travis-ci.org/#!/ClosureTree/closure_tree) of
 
 * Ruby 2.2, 2.3
-* ActiveRecord 4.2 and 5.0
+* ActiveRecord 4.2, 5.0, and 5.1
 * PostgreSQL, MySQL, and SQLite. Concurrency tests are only run with MySQL and PostgreSQL.
 
 Assuming you're using [rbenv](https://github.com/sstephenson/rbenv), you can use ```tests.sh``` to
@@ -628,12 +637,12 @@ run the test matrix locally.
 
 ## Change log
 
-See the [change log](https://github.com/mceachen/closure_tree/blob/master/CHANGELOG.md).
+See the [change log](https://github.com/ClosureTree/closure_tree/blob/master/CHANGELOG.md).
 
 ## Thanks to
 
 * The 45+ engineers around the world that have contributed their time and code to this gem
-  (see the [changelog](https://github.com/mceachen/closure_tree/blob/master/CHANGELOG.md)!)
+  (see the [changelog](https://github.com/ClosureTree/closure_tree/blob/master/CHANGELOG.md)!)
 * https://github.com/collectiveidea/awesome_nested_set
 * https://github.com/patshaughnessy/class_factory
 * JetBrains, which provides an [open-source license](http://www.jetbrains.com/ruby/buy/buy.jsp#openSource) to

data/gemfiles/{activerecord_5.0_foreigner.gemfile → activerecord_5.1.gemfile}

@@ -2,8 +2,7 @@
 
 source "https://rubygems.org"
 
-gem "activerecord", "~> 5.0.0"
-gem "foreigner"
+gem "activerecord", "~> 5.1.0"
 
 platforms :ruby, :rbx do
   gem "mysql2"

data/lib/closure_tree/has_closure_tree.rb

@@ -29,6 +29,8 @@ module ClosureTree
 
       include ClosureTree::DeterministicOrdering if _ct.order_option?
       include ClosureTree::NumericDeterministicOrdering if _ct.order_is_numeric?
+
+      connection_pool.release_connection
     rescue StandardError => e
       raise e unless ClosureTree.configuration.database_less
     end

data/lib/closure_tree/has_closure_tree_root.rb

@@ -81,6 +81,8 @@ module ClosureTree
 
         @closure_tree_roots[assoc_name][assoc_map] = root
       end
+
+      connection_pool.release_connection
     end
   end
 end

data/lib/closure_tree/hierarchy_maintenance.rb

@@ -35,10 +35,13 @@ module ClosureTree
     end
 
     def _ct_after_save
-      if changes[_ct.parent_column_name] || @was_new_record
+      as_5_1 = ActiveSupport.version >= Gem::Version.new('5.1.0')
+      changes_method = as_5_1 ? :saved_changes : :changes
+
+      if public_send(changes_method)[_ct.parent_column_name] || @was_new_record
         rebuild!
       end
-      if changes[_ct.parent_column_name] && !@was_new_record
+      if public_send(changes_method)[_ct.parent_column_name] && !@was_new_record
         # Resetting the ancestral collections addresses
         # https://github.com/mceachen/closure_tree/issues/68
         ancestor_hierarchies.reload

data/lib/closure_tree/numeric_deterministic_ordering.rb

@@ -10,8 +10,13 @@ module ClosureTree
     end
 
     def _ct_reorder_prior_siblings_if_parent_changed
-      if attribute_changed?(_ct.parent_column_name) && !@was_new_record
-        was_parent_id = attribute_was(_ct.parent_column_name)
+      as_5_1 = ActiveSupport.version >= Gem::Version.new('5.1.0')
+      change_method = as_5_1 ? :saved_change_to_attribute? : :attribute_changed?
+
+      if public_send(change_method, _ct.parent_column_name) && !@was_new_record
+        attribute_method = as_5_1 ? :attribute_before_last_save : :attribute_was
+
+        was_parent_id = public_send(attribute_method, _ct.parent_column_name)
         _ct.reorder_with_parent_id(was_parent_id)
       end
     end

data/lib/closure_tree/numeric_order_support.rb

@@ -44,7 +44,8 @@ module ClosureTree
             FROM #{quoted_table_name}
             WHERE #{where_eq(parent_column_name, parent_id)} #{min_where}
           ) AS t
-          WHERE #{quoted_table_name}.#{quoted_id_column_name} = t.id
+          WHERE #{quoted_table_name}.#{quoted_id_column_name} = t.id and
+                #{quoted_table_name}.#{quoted_order_column(false)} is distinct from t.seq + #{minimum_sort_order_value.to_i - 1}
         SQL
       end
 

data/lib/closure_tree/version.rb

@@ -1,3 +1,3 @@
 module ClosureTree
-  VERSION = Gem::Version.new('6.5.0')
+  VERSION = Gem::Version.new('6.6.0')
 end

data/spec/db/schema.rb

@@ -5,7 +5,7 @@ ActiveRecord::Schema.define(:version => 0) do
   create_table "tags" do |t|
     t.string "name"
     t.string "title"
-    t.integer "parent_id"
+    t.references "parent"
     t.integer "sort_order"
     t.timestamps null: false
   end
@@ -13,8 +13,8 @@ ActiveRecord::Schema.define(:version => 0) do
   add_foreign_key(:tags, :tags, :column => 'parent_id')
 
   create_table "tag_hierarchies", :id => false do |t|
-    t.integer "ancestor_id", :null => false
-    t.integer "descendant_id", :null => false
+    t.references "ancestor", :null => false
+    t.references "descendant", :null => false
     t.integer "generations", :null => false
   end
 
@@ -61,7 +61,7 @@ ActiveRecord::Schema.define(:version => 0) do
 
   create_table "users" do |t|
     t.string "email"
-    t.integer "referrer_id"
+    t.references "referrer"
     t.integer "group_id"
     t.timestamps null: false
   end
@@ -69,8 +69,8 @@ ActiveRecord::Schema.define(:version => 0) do
   add_foreign_key(:users, :users, :column => 'referrer_id')
 
   create_table "contracts" do |t|
-    t.integer "user_id", :null => false
-    t.integer "contract_type_id"
+    t.references "user", :null => false
+    t.references "contract_type"
     t.string "title"
   end
 
@@ -79,8 +79,8 @@ ActiveRecord::Schema.define(:version => 0) do
   end
 
   create_table "referral_hierarchies", :id => false do |t|
-    t.integer "ancestor_id", :null => false
-    t.integer "descendant_id", :null => false
+    t.references "ancestor", :null => false
+    t.references "descendant", :null => false
     t.integer "generations", :null => false
   end
 
@@ -91,14 +91,14 @@ ActiveRecord::Schema.define(:version => 0) do
     t.string "name"
     t.string "type"
     t.integer "column_whereby_ordering_is_inferred"
-    t.integer "mother_id"
+    t.references "mother"
   end
 
   add_foreign_key(:labels, :labels, :column => 'mother_id')
 
   create_table "label_hierarchies", :id => false do |t|
-    t.integer "ancestor_id", :null => false
-    t.integer "descendant_id", :null => false
+    t.references "ancestor", :null => false
+    t.references "descendant", :null => false
     t.integer "generations", :null => false
   end
 
@@ -107,28 +107,28 @@ ActiveRecord::Schema.define(:version => 0) do
 
   create_table "cuisine_types" do |t|
     t.string "name"
-    t.integer "parent_id"
+    t.references "parent"
   end
 
   create_table "cuisine_type_hierarchies", :id => false do |t|
-    t.integer "ancestor_id", :null => false
-    t.integer "descendant_id", :null => false
+    t.references "ancestor", :null => false
+    t.references "descendant", :null => false
     t.integer "generations", :null => false
   end
 
   create_table "namespace_types" do |t|
     t.string "name"
-    t.integer "parent_id"
+    t.references "parent"
   end
 
   create_table "namespace_type_hierarchies", :id => false do |t|
-    t.integer "ancestor_id", :null => false
-    t.integer "descendant_id", :null => false
+    t.references "ancestor", :null => false
+    t.references "descendant", :null => false
     t.integer "generations", :null => false
   end
 
   create_table "metal" do |t|
-    t.integer "parent_id"
+    t.references "parent"
     t.string "metal_type"
     t.string "value"
     t.string "description"
@@ -138,8 +138,8 @@ ActiveRecord::Schema.define(:version => 0) do
   add_foreign_key(:metal, :metal, :column => 'parent_id')
 
   create_table "metal_hierarchies", :id => false do |t|
-    t.integer "ancestor_id", :null => false
-    t.integer "descendant_id", :null => false
+    t.references "ancestor", :null => false
+    t.references "descendant", :null => false
     t.integer "generations", :null => false
   end
 
@@ -148,15 +148,15 @@ ActiveRecord::Schema.define(:version => 0) do
 
   create_table 'menu_items' do |t|
     t.string 'name'
-    t.integer 'parent_id'
+    t.references 'parent'
     t.timestamps null: false
   end
 
   add_foreign_key(:menu_items, :menu_items, :column => 'parent_id')
 
   create_table 'menu_item_hierarchies', :id => false do |t|
-    t.integer 'ancestor_id', :null => false
-    t.integer 'descendant_id', :null => false
+    t.references 'ancestor', :null => false
+    t.references 'descendant', :null => false
     t.integer 'generations', :null => false
   end
 

data/spec/pool_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe 'Configuration' do
+  it 'returns connection to the pool after has_closure_tree setup' do
+    class TypeDuplicate < ActiveRecord::Base
+      self.table_name = "namespace_type#{table_name_suffix}"
+      has_closure_tree
+    end
+    expect(ActiveRecord::Base.connection_pool.active_connection?).to be_falsey # +false+ in AR 4, +nil+ in AR 5
+  end
+
+  it 'returns connection to the pool after has_closure_tree setup with order' do
+    class MetalDuplicate < ActiveRecord::Base
+      self.table_name = "#{table_name_prefix}metal#{table_name_suffix}"
+      has_closure_tree order: 'sort_order', name_column: 'value'
+    end
+    expect(ActiveRecord::Base.connection_pool.active_connection?).to be_falsey
+  end
+
+  it 'returns connection to the pool after has_closure_tree_root setup' do
+    class GroupDuplicate < ActiveRecord::Base
+      self.table_name = "#{table_name_prefix}group#{table_name_suffix}"
+      has_closure_tree_root :root_user
+    end
+    expect(ActiveRecord::Base.connection_pool.active_connection?).to be_falsey
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: closure_tree
 version: !ruby/object:Gem::Version
-  version: 6.5.0
+  version: 6.6.0
 platform: ruby
 authors:
 - Matthew McEachen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-17 00:00:00.000000000 Z
+date: 2017-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -142,7 +142,7 @@ files:
 - closure_tree.gemspec
 - gemfiles/activerecord_4.2.gemfile
 - gemfiles/activerecord_5.0.gemfile
-- gemfiles/activerecord_5.0_foreigner.gemfile
+- gemfiles/activerecord_5.1.gemfile
 - gemfiles/activerecord_edge.gemfile
 - img/example.png
 - img/preorder.png
@@ -185,6 +185,7 @@ files:
 - spec/model_spec.rb
 - spec/namespace_type_spec.rb
 - spec/parallel_spec.rb
+- spec/pool_spec.rb
 - spec/spec_helper.rb
 - spec/support/database.rb
 - spec/support/database_cleaner.rb
@@ -218,7 +219,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Easily and efficiently make your ActiveRecord model support hierarchies
@@ -238,6 +239,7 @@ test_files:
 - spec/model_spec.rb
 - spec/namespace_type_spec.rb
 - spec/parallel_spec.rb
+- spec/pool_spec.rb
 - spec/spec_helper.rb
 - spec/support/database.rb
 - spec/support/database_cleaner.rb