closure_tree 4.2.3 → 4.2.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NGI4ZjJlMTkxYzc2MDc1OWNmZWZjZmE5NDYzMDIyMzhlZTRjMmY4YQ==
+    NmE3ZGYxNDE5MjE5Y2FkMjMxNjY5YjVmMTZkYmM4MTY5ZGQ0NTUxZQ==
   data.tar.gz: !binary |-
-    MTdjZTY3OWMzOThlODYyODBjYWY5MmFlYmE1ZGE4Mjc3NTBkNjE4Yg==
+    NGMyNmRiZGY1N2RiNGZiYTk1NzgzYzg4N2U2MDIxZWFlNjNmNjMxZg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    Njc0MTM5MTg1ZmMzMDFiNTg2YmExYmNmOThjNWVhNDljNzlkYzA4OTg1MTZi
-    MzcyOTc0YjhiOTIxYmZjNGI2ZTJiYTA2NGJhMDg2ZTA0N2QxYTIyNzFlODJm
-    OTBhZjgxNWFlZDBiMWNlYjMxYjk1MTBkNTliNjkyYWM1MmZjNWM=
+    NzE2ZTUxMDY0YzAxMDY1ZTFjMzlkM2ZjZDcwNDJhMjg3YWRiODU2NWYxMjgz
+    YjJkNzIxNzA2MjQwYTliMjEyNTVmYjZkMDExNGZlMzM3MjVjYjY0NGZjZDNi
+    ODA4MzQ4OTFkYmE1YWYzODQ4ZDY2YmRhMjIyZWJhZDQ4NjU1MDA=
   data.tar.gz: !binary |-
-    M2MzYTY5ZTgwNjQ1M2FlMWZkMWYzNGU0OTY1NWVhNWEyZDg5OGI1ZTUxMGU5
-    ZWY4ZDY4MTE2MjY4YzdhYjM1MjhlNGI1ZDBkMGNiNzhkZWU0NmIwYjlhZmI1
-    NzZhNTM0MTc2N2U3NWEyZGMwMWYwZDlkODczMWU1MGViNjIxYTg=
+    ZThkMTI0YTU0OTJlNjEzMjdlMjU2Mjc5M2I5NGI2M2UxODQwMjc0NDUzMTEw
+    NWZmNDM1Yjk3YmI4M2I5OGIzYWQ2Zjg0YzE0NWIxYjMyNTY3ZjBjOTdmZDBh
+    OTYyMGEzZjFjYTAyZjBlZWY3NDMyNDNhMDllODY2ZjNhZWVkYjk=

data/README.md

@@ -490,263 +490,7 @@ Parallelism is not tested with Rails 3.0.x nor 3.1.x due to this
 
 ## Change log
 
-### 4.2.3
-
-* Fixed ```attr_accessible?``` error introduced in 4.2.2 ([issue 66](https://github.com/mceachen/closure_tree/issues/66)).
-* Switched to use new WithAdvisoryLock::DatabaseAdapterSupport (in v0.0.9) to add Postgis support
-
-### 4.2.2
-
-* Support attr_accessible and strong_attributes even if you're on Rails 4
-
-### 4.2.1
-
-* Deleting from NumericDeterministicOrdering doesn't create sort order gaps anymore.
-
-### 4.2.0
-
-* Added ```with_ancestor(*ancestors)```. Thanks for the idea, [Matt](https://github.com/mgornick)!
-* Applied [Leonel Galan](https://github.com/leonelgalan)'s fix for Strong Attribute support
-* ```find_or_create_by``` now uses passed-in attributes as both selection and creation criteria.
-  Thanks for the help, [Judd Blair](https://github.com/juddblair)!
-  **Please note that this changes prior behavior—test your code with this new version!**
-* ```ct_advisory_lock``` was moved into the ```_ct``` support class, to reduce model method pollution
-* Moved a bunch of code into more focused piles of module mixins
-
-### 4.1.0
-
-* Added support for Rails 4.0.0.rc1 and Ruby 2.0.0 (while maintaining backward compatibility with Rails 3, BOOYA)
-* Added ```#to_dot_digraph```, suitable for Graphviz rendering
-
-### 4.0.1
-
-* Numeric, deterministically ordered siblings will always be [0..#{self_and_siblings.count}]
-  (previously, the sort order might use negative values, which broke the preordering).
-  Resolves [issue 49](https://github.com/mceachen/closure_tree/issues/49). Thanks for the help,
-  [Leonel Galan](https://github.com/leonelgalan), [Juan Hoyos](https://github.com/elhoyos), and
-  [Michael Elfassy](https://github.com/elfassy)!
-
-* The ```order``` option can be a symbol now. Resolves [issue 46](https://github.com/mceachen/closure_tree/issues/46).
-
-### 4.0.0
-
-* Moved all of closure_tree's implementation-detail methods into a ```ClosureTree::Support```
-  instance, which removes almost all of the namespace pollution in your models that wasn't
-  for normal consumption. If you were using any of these methods, they're now available through
-  the "_ct" class and instance member.
-
-  *This change may break consumers*, so I incremented the major version number, even though no new
-  functionality was released.
-
-### 3.10.2
-
-* Prevent faulty SQL statement when ```#siblings``` is called on an unsaved records.
-  Resolves [issue 52](https://github.com/mceachen/closure_tree/pull/52). Perfect pull
-  request by [Gary Greyling](https://github.com/garygreyling).
-
-* The ```.roots``` class method now correctly respects the ```:order``` option.
-  Resolves [issue 53](https://github.com/mceachen/closure_tree/issues/53).
-  Thanks for finding this, [Brendon Muir](https://github.com/brendon)!
-
-### 3.10.1
-
-* Multipart constant names like "Admin::PageHierarchy" are now supported.
-  Resolves [issue 47](https://github.com/mceachen/closure_tree/issues/47).
-  Thanks for the perfect pull request, [Simon Menke](https://github.com/fd)!
-
-* Committing transactions involving large numbers of hierarchy model classes was very slow due
-  to hash collisions in the hierarchy class. A better hash implementation addressed
-  [issue 48](https://github.com/mceachen/closure_tree/issues/48).
-  Thanks, [Joel Turkel](https://github.com/jturkel)!
-
-### 3.10.0
-
-* Added ```#roots_and_descendants_preordered```.
-  Thanks for the suggestion, [Leonel Galan](https://github.com/leonelgalan)!
-
-### 3.9.0
-
-* Added ```.child_ids```.
-* Removed ```dependent => destroy``` on the descendant_hierarchy and ancestor_hierarchy collections
-  (they were a mistake).
-* Clarified documentation for creation and child associations.
-  Because ```Tag.create!(:parent => ...)``` requires a ```.reload```, I removed it as an example.
-
-All three of these improvements were suggested by Andrew Bromwich. Thanks!
-
-### 3.8.2
-
-* find_by_path uses 1 SELECT now. BOOM.
-
-### 3.8.1
-
-* Double-check locking for find_or_create_by_path
-
-### 3.8.0
-
-* Support for preordered descendants. This requires a numeric sort order column.
-  Resolves [feature request 38](https://github.com/mceachen/closure_tree/issues/38).
-* Moved modules from ```acts_as_tree``` into separate files
-
-### 3.7.3
-
-Due to MySQL's inability to lock rows properly, I've switched to advisory_locks for
-all write paths. This will prevent deadlocks, addressing
-[issue 41](https://github.com/mceachen/closure_tree/issues/41).
-
-### 3.7.2
-
-* Support for UUID primary keys. Addresses
-  [issue 40](https://github.com/mceachen/closure_tree/issues/40). Thanks for the pull request,
-  [Julien](https://github.com/calexicoz)!
-
-### 3.7.1
-
-* Moved requires into ActiveSupport.on_load
-* Added ```require 'with_advisory_lock'```
-
-### 3.7.0
-
-**Thread safety!**
-* [Advisory locks](https://github.com/mceachen/with_advisory_lock) were
-  integrated with the class-level ```find_or_create_by_path``` and ```rebuild!```.
-* Pessimistic locking is used by the instance-level ```find_or_create_by_path```.
-
-### 3.6.9
-
-* [Don Morrison](https://github.com/elskwid) massaged the [#hash_tree](#nested-hashes) query to
-be more efficient, and found a bug in ```hash_tree```'s query that resulted in duplicate rows,
-wasting time on the ruby side.
-
-### 3.6.7
-
-* Added workaround for ActiveRecord::Observer usage pre-db-creation. Addresses
-  [issue 32](https://github.com/mceachen/closure_tree/issues/32).
-  Thanks, [Don Morrison](https://github.com/elskwid)!
-
-### 3.6.6
-
-* Added support for Rails 4's [strong parameter](https://github.com/rails/strong_parameters).
-Thanks, [James Miller](https://github.com/bensie)!
-
-### 3.6.5
-
-* Use ```quote_table_name``` instead of ```quote_column_name```. Addresses
- [issue 29](https://github.com/mceachen/closure_tree/issues/29). Thanks,
- [Marcello Barnaba](https://github.com/vjt)!
-
-### 3.6.4
-
-* Use ```.pluck``` when available for ```.ids_from```. Addresses
- [issue 26](https://github.com/mceachen/closure_tree/issues/26). Thanks,
- [Chris Sturgill](https://github.com/sturgill)!
-
-### 3.6.3
-
-* Fixed [issue 24](https://github.com/mceachen/closure_tree/issues/24), which optimized ```#hash_tree```
-  for roots. Thanks, [Saverio Trioni](https://github.com/rewritten)!
-
-### 3.6.2
-
-* Fixed [issue 23](https://github.com/mceachen/closure_tree/issues/23), which added support for ```#siblings```
-  when sort_order wasn't specified. Thanks, [Gary Greyling](https://github.com/garygreyling)!
-
-### 3.6.1
-
-* Fixed [issue 20](https://github.com/mceachen/closure_tree/issues/20), which affected
-  deterministic ordering when siblings where different STI classes. Thanks, [edwinramirez](https://github.com/edwinramirez)!
-
-### 3.6.0
-
-Added support for:
-* ```:hierarchy_class_name``` as an option
-* ActiveRecord::Base.table_name_prefix
-* ActiveRecord::Base.table_name_suffix
-
-This addresses [issue 21](https://github.com/mceachen/closure_tree/issues/21). Thanks, [Judd Blair](https://github.com/juddblair)!
-
-### 3.5.2
-
-* Added ```find_all_by_generation```
-  for [feature request 17](https://github.com/mceachen/closure_tree/issues/17).
-
-### 3.4.2
-
-* Fixed [issue 18](https://github.com/mceachen/closure_tree/issues/18), which affected
-  append_node/prepend_node ordering when the first node didn't have an explicit order_by value
-
-### 3.4.1
-
-* Reverted .gemspec mistake that changed add_development_dependency to add_runtime_dependency
-
-### 3.4.0
-
-Fixed [issue 15](https://github.com/mceachen/closure_tree/issues/15):
-* "parent" is now attr_accessible, which adds support for constructor-provided parents.
-* updated readme accordingly
-
-### 3.3.2
-
-* Merged calebphillips' patch for a more efficient leaves query
-
-### 3.3.1
-
-* Added support for partially-unsaved hierarchies [issue 13](https://github.com/mceachen/closure_tree/issues/13):
-```
-a = Tag.new(name: "a")
-b = Tag.new(name: "b")
-a.children << b
-a.save
-```
-
-### 3.3.0
-
-* Added [```hash_tree```](#nested-hashes).
-
-### 3.2.1
-
-* Added ```ancestor_ids```, ```descendant_ids```, and ```sibling_ids```
-* Added example spec to solve [issue 9](https://github.com/mceachen/closure_tree/issues/9)
-
-### 3.2.0
-
-* Added support for deterministic ordering of nodes.
-
-### 3.1.0
-
-* Switched to using ```has_many :though``` rather than ```has_and_belongs_to_many```
-
-### 3.0.4
-
-* Merged [pull request](https://github.com/mceachen/closure_tree/pull/8) to fix ```.siblings``` and ```.self_and_siblings```
-  (Thanks, [eljojo](https://github.com/eljojo)!)
-
-### 3.0.3
-
-* Added support for ActiveRecord's whitelist_attributes
-  (Make sure you read [the Rails Security Guide](http://guides.rubyonrails.org/security.html), and
-  enable ```config.active_record.whitelist_attributes``` in your ```config/application.rb``` ASAP!)
-
-### 3.0.2
-
-* Fix for ancestry-loop detection (performed by a validation, not through raising an exception in before_save)
-
-### 3.0.1
-
-* Support 3.2.0's fickle deprecation of InstanceMethods (Thanks, [jheiss](https://github.com/mceachen/closure_tree/pull/5))!
-
-### 3.0.0
-
-* Support for polymorphic trees
-* ```find_by_path``` and ```find_or_create_by_path``` signatures changed to support constructor attributes
-* tested against Rails 3.1.3
-
-### 2.0.0
-
-* Had to increment the major version, as rebuild! will need to be called by prior consumers to support the new ```leaves``` class and instance methods.
-* Tag deletion is supported now along with ```:dependent => :destroy``` and ```:dependent => :delete_all```
-* Switched from default rails plugin directory structure to rspec
-* Support for running specs under different database engines: ```export DB ; for DB in sqlite3 mysql postgresql ; do rake ; done```
+See https://github.com/mceachen/closure_tree/blob/master/CHANGELOG.md
 
 ## Thanks to
 

data/lib/closure_tree/model.rb

@@ -7,7 +7,8 @@ module ClosureTree
     included do
       belongs_to :parent,
         :class_name => _ct.model_class.to_s,
-        :foreign_key => _ct.parent_column_name
+        :foreign_key => _ct.parent_column_name,
+        :inverse_of => :children
 
       attr_accessible :parent if _ct.use_attr_accessible?
 
@@ -16,7 +17,8 @@ module ClosureTree
       has_many :children, *_ct.has_many_with_order_option(
         :class_name => _ct.model_class.to_s,
         :foreign_key => _ct.parent_column_name,
-        :dependent => _ct.options[:dependent])
+        :dependent => _ct.options[:dependent],
+        :inverse_of => :parent)
 
       has_many :ancestor_hierarchies, *_ct.has_many_without_order_option(
         :class_name => _ct.hierarchy_class_name,
@@ -46,12 +48,14 @@ module ClosureTree
 
     # Returns true if this node has no parents.
     def root?
-      _ct_parent_id.nil?
+      # Accessing the parent will fetch that row from the database,
+      # so if we are persisted, just check that the parent_id column is nil.
+      persisted? ? _ct_parent_id.nil? : parent.nil?
     end
 
     # Returns true if this node has a parent, and is not a root.
     def child?
-      !parent.nil?
+      !root?
     end
 
     # Returns true if this node has no children.

data/lib/closure_tree/version.rb

@@ -1,3 +1,3 @@
 module ClosureTree
-  VERSION = Gem::Version.new("4.2.3") unless defined?(::ClosureTree::VERSION)
+  VERSION = Gem::Version.new("4.2.4") unless defined?(::ClosureTree::VERSION)
 end

data/spec/label_spec.rb

@@ -84,6 +84,17 @@ describe Label do
     end
   end
 
+  context "Parent/child inverse relationships" do
+    it "should associate both sides of the parent and child relationships" do
+      parent = Label.new(:name => 'parent')
+      child = parent.children.build(:name => 'child')
+      parent.should be_root
+      parent.should_not be_leaf
+      child.should_not be_root
+      child.should be_leaf
+    end
+  end
+
   context "DateLabel" do
     it "should find or create by path" do
       date = DateLabel.find_or_create_by_path(%w{2011 November 23})

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: closure_tree
 version: !ruby/object:Gem::Version
-  version: 4.2.3
+  version: 4.2.4
 platform: ruby
 authors:
 - Matthew McEachen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-26 00:00:00.000000000 Z
+date: 2013-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord