close_encounters 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e7c56a469fc69cd3a15c93f84ac6a3789415a41d8499df1ea2fd28f5f1aeb07b
-  data.tar.gz: 8e0b47517ce53491205e3a89c65a56347bed80473e7cb7ac0cec908aaddd06d8
+  metadata.gz: 67adeb4fe53671ebcc9e37f040245dd7650ec3afc83433e13415c290617ee356
+  data.tar.gz: e7afee308898aa7a25cf3ddfaa652369c74fdb074c014054ee37438babe0b714
 SHA512:
-  metadata.gz: a376bbdf0a61509ec060f2624a97498493decb68f7f5655eae922e2980c802378e6c3550fff069dd7d9582cf3c3923befed034bfaa1e735d83375dcbe0156cdb
-  data.tar.gz: 5af33cc8325f9db5f3a8a5db639049e02509111c83c096f046c1248114e85ede0b743e69fa2f5f4eba57de998c8192ad592c5d91e39c82006c0dbe17e51014d4
+  metadata.gz: e0131dcd0a979e6bf3583fe3b90c91b597defbf0f660b8bfaaf2f8d2988a3b1714177148a6cec10078f1a69b8175de7c27d6bccc29523001264ca8c6f667e381
+  data.tar.gz: 117c8347983b35986897f55920c4d8472be867598901ca2e83bbf51f2560f083e8c6b9e27559f67c327faa66cbde30b93c1cdb19abd1e9356e792411992ff385

data/CHANGELOG.md

@@ -5,24 +5,18 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
-## [0.2.1] - 2025-03-05
+## [0.2.3] - 2025-09-08
 
-### Added
+### Fixed
 
-- Add alias for verify method as scan.
-- Add configuration for auto_contact and verify_scan_statuses.
+- Fix duplicate event creation in `scan` method when status and verification state are unchanged
 
-### Changed
-
-- Ensure that events are only created if the status has changed or if the status is in the verify_scan_statuses list and verification fails.
-
-## [0.2.0] - 2025-02-26
+## [0.2.2] - 2025-09-04
 
 ### Changed
 
-- Test with Ruby 3.4
+- Update handling of the same status for multiple requests when creating events.
 
-### Added
+### Fixed
 
-- Ability to use CloseEncounters::Middleware and CloseEncounters.auto_contact! to automatically track responses from third-party services.
-- Add metadata to events for storing extra information about the event.
+- Ensure that status is an integer when creating events and comparing results.

data/lib/close_encounters/version.rb

@@ -1,3 +1,3 @@
 module CloseEncounters
-  VERSION = "0.2.1"
+  VERSION = "0.2.3"
 end

data/lib/close_encounters.rb

@@ -31,8 +31,13 @@ module CloseEncounters
   # @param response [String] the response object
   def contact(name, status:, response:)
     service = ParticipantService.find_by!(name:)
-    unless service.events.newest.pick(:status) == status
-      service.events.create!(status: status, response:)
+    status = status.to_i # Ensure status is always an integer
+
+    # Use a transaction with a lock to prevent race conditions
+    service.with_lock do
+      unless service.events.newest.pick(:status) == status
+        service.events.create!(status: status, response:)
+      end
     end
   end
 
@@ -49,14 +54,26 @@ module CloseEncounters
   # @param verifier [Proc] the verification callable which must also respond to to_s
   def scan(name, status:, response:, verifier:)
     service = ParticipantService.find_by!(name:)
-    last_status = service.events.newest.pick(:status)
+    status = status.to_i # Ensure status is always an integer
 
-    if last_status != status
-      verified = verifier.call(response)
-      service.events.create!(status:, response:, metadata: {verified:, verification: verifier.to_s})
-    elsif verify_scan_statuses.include?(status)
+    service.with_lock do
+      last_event = service.events.newest.first
+      last_status = last_event&.status
+      last_verified = last_event&.verified?
+
+      # Calculate current verification result
       verified = verifier.call(response)
-      service.events.create!(status:, response:, metadata: {verified:, verification: verifier.to_s}) if !verified
+
+      # Create a new event if:
+      # 1. Status has changed OR
+      # 2. Status is in verify_scan_statuses AND verified flag has changed
+      if last_status != status
+        # Status changed, always create new event
+        service.events.create!(status:, response:, metadata: {verified:, verification: verifier.to_s})
+      elsif verify_scan_statuses.include?(status) && last_verified != verified
+        # Status same but verification result changed for a monitored status
+        service.events.create!(status:, response:, metadata: {verified:, verification: verifier.to_s})
+      end
     end
   end
   alias_method :verify, :scan

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: close_encounters
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Jim Gay
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-03-05 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -129,7 +128,6 @@ metadata:
   homepage_uri: https://github.com/SOFware/close_encounters
   source_code_uri: https://github.com/SOFware/close_encounters
   changelog_uri: https://github.com/SOFware/close_encounters/blob/main/CHANGELOG.md
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -144,8 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
-signing_key:
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Close Encounters of the Third Party
 test_files: []