clockwork 3.0.2 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e5a8d520eb475e3eb5b3e75b3b175a4a66c3804584912afc9d4392c1d82f3d7
-  data.tar.gz: 558bc615e123ceaf146c2107b71202fef3eaf307215c93aa8f421826e25a8d4a
+  metadata.gz: 5255c8fe897e90a63054c6415e08ff418ed66adbf445c77620ffb752eae30d82
+  data.tar.gz: 2d3eed087aa8d2f65b54ba8f57e5e0c9e99ca234d4fcb9e2f8909d6aff67f845
 SHA512:
-  metadata.gz: d60240815eee8a5001004f854ccfd1fe94f01023ca5099799100bcc04a99ae982bc96f14b746b4965c4afc2aba77d2138ebae96c41da075bb7b8c4f15b863493
-  data.tar.gz: 4beb2d7f2cd09940e9159e5d4e1d1e62db2268f82b75ff86c344e7b11076a2e6d57865039fe19c361208c1fee8e5af8c3f72657880f6183107e8f90f33129e47
+  metadata.gz: 01bb4c858593124f009ed4495f9168a7b6d58272f01be0058a308858550a3aeea37f297bbd505a8974288fb00653fe4e55de6d20569af0f65c5f172dc7f2ff76
+  data.tar.gz: c6c1e75718e04f708f7785132bd1003d3bfa269560349a8281e40a08b36787633448fbf459b3bd29b125b84010dca8be8c6b100c276681c7cefa94fb2c9b0d64

data/.github/workflows/tests.yml

@@ -11,15 +11,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby: [ "2.7", "3.0", "3.1", "3.2", jruby ]
-        active_support: [ "6.0", "7.0" ]
-        exclude:
-          - ruby: "3.0"
-            active_support: "6.0"
-          - ruby: "3.1"
-            active_support: "6.0"
-          - ruby: "3.2"
-            active_support: "6.0"
+        ruby: [ "3.2", "3.3", "3.4", "4.0" ]
+        active_support: [ "8.0", "8.1" ]
     name: Ruby ${{ matrix.ruby }} - ActiveSupport ${{ matrix.active_support }}
     env:
       ACTIVE_SUPPORT_VERSION: ${{ matrix.active_support }}

data/clockwork.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "clockwork"
-  s.version = "3.0.2"
+  s.version = "4.0.0"
 
   s.authors = ["Adam Wiggins", "tomykaira"]
   s.license = 'MIT'
@@ -19,6 +19,9 @@ Gem::Specification.new do |s|
 
   s.add_dependency(%q<tzinfo>)
   s.add_dependency(%q<activesupport>)
+  s.add_dependency(%q<base64>)
+  s.add_dependency(%q<bigdecimal>)
+  s.add_dependency(%q<ostruct>)
 
   s.add_development_dependency "rake"
   s.add_development_dependency "daemons"

data/lib/clockwork/event.rb

@@ -71,7 +71,15 @@ module Clockwork
     end
 
     def elapsed_ready?(t)
-      @last.nil? || (t - @last.to_i).to_i >= @period
+      # We only need to calculate this if the period is >= 1 day. The UTC offset check only makes sense
+      # for periods >= 1.day since these are the shortest period where increasing the date by a day, may not
+      # exactly match the exact elapsed time.
+      change_in_utc_offset = if @period >= 1.day
+        t.utc_offset - (t - @period).utc_offset
+      else
+        0
+      end
+      @last.nil? || (t - @last.to_i).to_i >= (@period - change_in_utc_offset)
     end
 
     def run_at?(t)

data/test/event_test.rb

@@ -70,5 +70,36 @@ describe Clockwork::Event do
         assert_equal true, event.run_now?(Time.now)
       end
     end
+
+    describe 'with Pacific Time TZ' do
+      before do
+        @manager = Class.new
+        @manager.stubs(:config).returns({ :tz => 'America/Los_Angeles' })
+      end
+
+      describe 'event non DST to DST transition' do
+        it 'returns true when it crosses the transition' do
+          event = Clockwork::Event.new(@manager, 1.day, nil, nil)
+          starting_time = Time.utc(2022, 3, 13, 6)
+          assert_equal true, event.run_now?(starting_time)
+          event.instance_variable_set('@last', starting_time)
+          # This will return true, since the UTC offset is moved forward by 1 hour. With the 1 hour, it will be
+          # equal to 1 day since the last time it was run.
+          assert_equal true, event.run_now?(starting_time + 23.hours)
+        end
+      end
+
+      describe 'event DST to non DST transition' do
+        it 'returns true when it crosses the transition' do
+          event = Clockwork::Event.new(@manager, 1.day, nil, nil)
+          starting_time = Time.utc(2021, 11, 7, 5)
+          assert_equal true, event.run_now?(starting_time)
+          event.instance_variable_set('@last', starting_time)
+          # This returns false since it hasn't reached a full 'real' day yet.
+          assert_equal false, event.run_now?(starting_time + 24.hours)
+          assert_equal true, event.run_now?(starting_time + 25.hours)
+        end
+      end
+    end
   end
 end

data/test/manager_test.rb

@@ -3,6 +3,7 @@ require "minitest/autorun"
 require 'mocha/minitest'
 require 'time'
 require 'active_support/time'
+require 'stringio'
 
 describe Clockwork::Manager do
   before do
@@ -117,7 +118,7 @@ describe Clockwork::Manager do
     @manager.handler { raise 'boom' }
     @manager.every(1.minute, 'myjob')
 
-    mocked_logger = MiniTest::Mock.new
+    mocked_logger = Minitest::Mock.new
     mocked_logger.expect :error, true, [RuntimeError]
     @manager.configure { |c| c[:logger] = mocked_logger }
     @manager.tick(Time.now)

data/test/samples/signal_test.rb

@@ -1,5 +1,6 @@
 require 'clockwork'
 require 'active_support/time'
+require 'stringio'
 
 module Clockwork
   LOGFILE = File.expand_path('../../tmp/signal_test.log', __FILE__)

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: clockwork
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 4.0.0
 platform: ruby
 authors:
 - Adam Wiggins
 - tomykaira
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-12 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: tzinfo
@@ -39,6 +38,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: base64
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bigdecimal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: ostruct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -157,7 +198,6 @@ homepage: http://github.com/Rykian/clockwork
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -172,8 +212,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3.1
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A scheduler process to replace cron.
 test_files: