clockwork 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c3178abe3610be706ab5cbb8ca2b62ee014fa94232a35346c27d48ec31fc0ab
-  data.tar.gz: b6a65f9d5c6ea01047cb2bc6fd2b9f58f9f2093ac5d043eecdee1ef8a221034a
+  metadata.gz: 7ad11e2b8e79db572d4240dd9ce2065067b22514919d4debc3758065b438ebca
+  data.tar.gz: 5dec51edf5bbd101a002e8c6ede3f11918441d75281b2baff3091bc0995721c4
 SHA512:
-  metadata.gz: 52dee0a57f8b01792089770f77aad73af9fa7eab7a113b44733e66bd7d335abe268a7bd60f36c7f96d9c56e17d1e4d26eb94b066b9eb9ea8a669d67de1e2d9b7
-  data.tar.gz: fcacc19bfd3ffd3a12df1ad2d6cf71a32802e9de17b7833704af19d766cb76b8000ca236741208447af6e04515b25029da2d999c808c921b222d7076b961f985
+  metadata.gz: f06770eaf4eb2b473ee165a00ddf7b6326f957ccfbf1eb71ee65a3e4a840ea8a42fe052a52a7032f7b786677bad54e94bc58a7f3961a44bb404c16685dcddc48
+  data.tar.gz: 5a60bddb9ae7b7312e8df9a4b01a022d9072a3a4f2fdb7f5790f03a61cf8b31a0d6fc4a76c3b80abeee63eeb269447922b2c065982497f2d6f7becd33082f78e

data/.travis.yml

@@ -1,14 +1,18 @@
 language: ruby
 sudo: false
 cache: bundler
+before_install:
+  - gem update --system
+  # This is required to support ActiveSupport 4
+  # https://docs.travis-ci.com/user/languages/ruby/#bundler-20
+  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
+  - gem install bundler -v '< 2'
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1
-  - 2.2
-  - ruby-2.3.1
-  - jruby-19mode
-  - # rbx-2.2.7
+  - 2.3.8
+  - 2.4.5
+  - 2.5.3
+  - jruby-9.1.17.0
+  - jruby-9.2.6.0
 gemfile:
-  - gemfiles/activesupport3.gemfile
   - gemfiles/activesupport4.gemfile
+  - gemfiles/activesupport5.gemfile

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+## 2.0.4 ##
+
+*   Reverts the breaking changes in PR #18 that went out in patch 2.0.3
+
+    *Javier Julio*
+
+## 2.0.3 (February 15, 2018) ##
+
+*   [See the version release](https://github.com/Rykian/clockwork/releases) for the commits that were included.

data/README.md

@@ -1,4 +1,4 @@
-Clockwork - a clock process to replace cron [![Build Status](https://api.travis-ci.org/Rykian/clockwork.png?branch=master)](https://travis-ci.org/Rykian/clockwork) [![Dependency Status](https://gemnasium.com/Rykian/clockwork.png)](https://gemnasium.com/Rykian/clockwork)
+Clockwork - a clock process to replace cron [![Build Status](https://api.travis-ci.org/Rykian/clockwork.png?branch=master)](https://travis-ci.org/Rykian/clockwork)
 ===========================================
 
 Cron is non-ideal for running scheduled application tasks, especially in an app
@@ -18,6 +18,8 @@ Create clock.rb:
 
 ```ruby
 require 'clockwork'
+require 'active_support/time' # Allow numeric durations (eg: 1.minutes)
+
 module Clockwork
   handler do |job|
     puts "Running #{job}"
@@ -58,8 +60,8 @@ Quickstart for Heroku
 
 Clockwork fits well with heroku's cedar stack.
 
-Consider to use [clockwork-init.sh](https://gist.github.com/1312172) to create
-a new project for heroku.
+Consider using [clockwork-init.sh](https://gist.github.com/tomykaira/1312172) to create
+a new project for Heroku.
 
 Use with queueing
 -----------------
@@ -80,6 +82,7 @@ For example, if you're using Beanstalk/Stalker:
 
 ```ruby
 require 'stalker'
+require 'active_support/time'
 
 module Clockwork
   handler { |job| Stalker.enqueue(job) }
@@ -150,25 +153,23 @@ When one of the events is ready to be run (based on it's `frequency`, and possib
 
 `ActiveRecord` models are a perfect candidate for the model class. Having said that, the only requirements are:
 
-  1. the class responds to `all` returning an array of instances from the database
-
-  2. the instances returned respond to:
-
-    - `id` returning a unique identifier (this is needed to track changes to event settings)
+1. the class responds to `all` returning an array of instances from the database
 
-    - `frequency` returning the how frequently (in seconds) the database event should be run
+2. the instances returned respond to:
+   - `id` returning a unique identifier (this is needed to track changes to event settings)
+   - `frequency` returning the how frequently (in seconds) the database event should be run
 
-    - `attributes` returning a hash of [attribute name] => [attribute value] values (or really anything that we can use store on registering the event, and then compare again to see if the state has changed later)
+   - `attributes` returning a hash of [attribute name] => [attribute value] values (or really anything that we can use store on registering the event, and then compare again to see if the state has changed later)
 
-    - (optionally) `at` return any acceptable clockwork `:at` string
+   - `at` *(optional)* return any acceptable clockwork `:at` string
 
-    - (optionally) `name` returning the name for the event (used to identify it in the Clockwork output)
+   - `name` *(optional)* returning the name for the event (used to identify it in the Clockwork output)
 
-    - (optionally) `if?` returning either true or false, depending on whether the database event should run at the given time (this method will be passed the time as a parameter, much like the standard clockwork `:if`)
+   - `if?`*(optional)*  returning either true or false, depending on whether the database event should run at the given time (this method will be passed the time as a parameter, much like the standard clockwork `:if`)
 
-    - (optionally) `ignored_attributes` returning an array of model attributes (as symbols) to ignore when determining whether the database event has been modified since our last run
+   - `ignored_attributes` *(optional)* returning an array of model attributes (as symbols) to ignore when determining whether the database event has been modified since our last run
 
-    - (optionally) `tz` returning the timezone to use (default is the local timezone)
+   - `tz` *(optional)* returning the timezone to use (default is the local timezone)
 
 #### Example Setup
 
@@ -329,7 +330,8 @@ If this is a problem, please use the `:thread` option to prevent the long runnin
 ```ruby
 every(1.day, 'reminders.send', :at => '00:00', :tz => 'UTC')
 # Runs the job each day at midnight, UTC.
-# The value for :tz can be anything supported by [TZInfo](http://tzinfo.rubyforge.org/)
+# The value for :tz can be anything supported by [TZInfo](https://github.com/tzinfo/tzinfo)
+# Using the 'tzinfo' gem, run TZInfo::Timezone.all_identifiers to get a list of acceptable identifiers.
 ```
 
 ### :if
@@ -343,7 +345,7 @@ Run on every first day of month.
 Clockwork.every(1.day, 'myjob', :if => lambda { |t| t.day == 1 })
 ```
 
-The argument is an instance of `Time`. If the `:tz` option is set, it has the given time zone. Otherwise, the time zone is the system time zone.
+The argument is an instance of `ActiveSupport::TimeWithZone` if the `:tz` option is set. Otherwise, it's an instance of `Time`.
 
 This argument cannot be omitted.  Please use _ as placeholder if not needed.
 
@@ -560,6 +562,13 @@ clockworkd -c YOUR_CLOCK.rb start
 
 For more details, you can run `clockworkd -h`.
 
+Integration Testing
+-------------------
+
+You could take a look at:
+* [clockwork-mocks](https://github.com/dpoetzsch/clockwork-mocks) that helps with running scheduled tasks during integration testing.
+* [clockwork-test](https://github.com/kevin-j-m/clockwork-test) which ensures that tasks are triggered at the right time
+
 Issues and Pull requests
 ------------------------
 

data/bin/clockwork

@@ -4,7 +4,7 @@ STDERR.sync = STDOUT.sync = true
 
 require 'clockwork'
 
-usage = 'clockwork <clock.rb>'
+usage = 'Usage: clockwork <clock.rb>'
 file = ARGV.shift or abort usage
 
 file = "./#{file}" unless file.match(/^[\/.]/)

data/clockwork.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name = "clockwork"
-  s.version = "2.0.3"
+  s.version = "2.0.4"
 
   s.authors = ["Adam Wiggins", "tomykaira"]
   s.license = 'MIT'
@@ -18,10 +18,9 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_dependency(%q<tzinfo>)
+  s.add_dependency(%q<activesupport>)
 
-  s.add_development_dependency "bundler", "~> 1.3"
   s.add_development_dependency "rake"
-  s.add_development_dependency "activesupport"
   s.add_development_dependency "daemons"
   s.add_development_dependency "minitest", "~> 5.8"
   s.add_development_dependency "mocha"

data/gemfiles/activesupport4.gemfile

@@ -6,6 +6,6 @@ platforms :rbx do
   gem 'rubinius-developer_tools'
 end
 
-gem 'activesupport', '~> 4.0.0'
-gem 'minitest', '~> 4.2'
+gem 'activesupport', '~> 4.2'
+gem 'minitest', '~> 5.0'
 gemspec :path=>"../"

data/gemfiles/{activesupport3.gemfile → activesupport5.gemfile}

@@ -6,5 +6,6 @@ platforms :rbx do
   gem 'rubinius-developer_tools'
 end
 
-gem 'activesupport', '~> 3.2.14'
+gem 'activesupport', '~> 5.0'
+gem 'minitest', '~> 5.0'
 gemspec :path=>"../"

data/lib/clockwork.rb

@@ -1,5 +1,5 @@
 require 'logger'
-require 'tzinfo'
+require 'active_support/time'
 
 require 'clockwork/at'
 require 'clockwork/event'

data/lib/clockwork/event.rb

@@ -17,7 +17,7 @@ module Clockwork
     end
 
     def convert_timezone(t)
-      @timezone ? t.getlocal(TZInfo::Timezone.get(@timezone).period_for_utc(t).utc_total_offset) : t
+      @timezone ? t.in_time_zone(@timezone) : t
     end
 
     def run_now?(t)

data/test/at_test.rb

@@ -2,6 +2,7 @@ require File.expand_path('../../lib/clockwork', __FILE__)
 require "minitest/autorun"
 require 'mocha/setup'
 require 'time'
+require 'active_support/time'
 
 describe 'Clockwork::At' do
   def time_in_day(hour, minute)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clockwork
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Adam Wiggins
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-15 00:00:00.000000000 Z
+date: 2019-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: tzinfo
@@ -26,27 +26,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: rake
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -54,7 +40,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,6 +123,7 @@ extra_rdoc_files:
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -146,8 +133,8 @@ files:
 - clockwork.gemspec
 - clockworkd.1
 - example.rb
-- gemfiles/activesupport3.gemfile
 - gemfiles/activesupport4.gemfile
+- gemfiles/activesupport5.gemfile
 - lib/clockwork.rb
 - lib/clockwork/at.rb
 - lib/clockwork/database_events.rb
@@ -188,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A scheduler process to replace cron.