client_side_validations 9.3.4 → 10.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8bceb161a57c46e4dfe0e6a6885551507ccc7711
-  data.tar.gz: 27e9454b3c119a965a412b5e0324819b39640215
+  metadata.gz: 1c59886758b11f1721e68456f762260ebac95d5e
+  data.tar.gz: 1295e066607efc41e1aed2d9b1e7b928a40fbf3b
 SHA512:
-  metadata.gz: 297c1c2cded360d5352fff89fb797d180afcbb3ff7b0e2cbeeb3c7e534d9d19a034f2e1150a7511108e6cdabad125715e215de974f0d9685d1aacda260706fa7
-  data.tar.gz: 9160c9702b3c47d26450d49ce408a5e2e2319e6f2ba617b49d7856c0eaaa7094050f00738450a54dfd48fccee60944a49cee281a89235d2dfafad29bb3e7b704
+  metadata.gz: 79707fcac5b515a7c618e17d0a0eef06a0bd3c20e63400574368bc46002231380d715059d73d3e864c3943d4f0cbf09f203baf7c7dd5466bb340047a18b17ae4
+  data.tar.gz: 3aa020cec77bcf778ce766f5f1e3f45ff742ac6cb071b9a7610ebde3081af41d77312b51960ebd6300dea94663fff512f0dc1aa58f2bbf08c3a9cd1b67caf56f

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 10.0.0 / 2017-10-09
+
+* [FEATURE] Refactor client-side numericality validator ([#717](https://github.com/DavyJonesLocker/client_side_validations/issues/717))
+* [ENHANCEMENT] Test against Ruby 2.2.8, 2.3.5, and 2.4.2
+* [ENHANCEMENT] Update js_regex runtime depenency to 2.0
+* [ENHANCEMENT] Update development dependencies
+
 ## 9.3.4 / 2017-07-15
 
 * [BUGFIX] Validate will_save_change_to? conditionals

data/lib/client_side_validations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ClientSideValidations
-  VERSION = '9.3.4'.freeze
+  VERSION = '10.0.0'.freeze
 end

data/vendor/assets/javascripts/rails.validations.js

@@ -1,6 +1,6 @@
 
 /*!
- * Client Side Validations - v9.3.4 (https://github.com/DavyJonesLocker/client_side_validations)
+ * Client Side Validations - v10.0.0 (https://github.com/DavyJonesLocker/client_side_validations)
  * Copyright (c) 2017 Geremia Taglialatela, Brian Cardarella
  * Licensed under MIT (http://opensource.org/licenses/mit-license.php)
  */
@@ -309,8 +309,9 @@
       }
     },
     patterns: {
-      numericality: function(number_format) {
-        return new RegExp("^(-|\\+)?(?:\\d+|\\d{1,3}(?:\\" + number_format.delimiter + "\\d{3})+)(?:\\" + number_format.separator + "\\d*)?$");
+      numericality: {
+        "default": new RegExp('^[-+]?[0-9]*\\.?[0-9]+([eE][-+]?[0-9]+)?$'),
+        only_integer: new RegExp('^[+-]?\\d+$')
       }
     },
     selectors: {
@@ -366,9 +367,12 @@
         numericality: function(element, options) {
           var $form, CHECKS, check, checkValue, fn, number_format, operator, val;
           $form = $(element[0].form);
-          val = $.trim(element.val());
           number_format = $form[0].ClientSideValidations.settings.number_format;
-          if (!ClientSideValidations.patterns.numericality(number_format).test(val)) {
+          val = $.trim(element.val()).replace(new RegExp("\\" + number_format.separator, 'g'), '.');
+          if (options.only_integer && !ClientSideValidations.patterns.numericality.only_integer.test(val)) {
+            return options.messages.only_integer;
+          }
+          if (!ClientSideValidations.patterns.numericality["default"].test(val)) {
             if (options.allow_blank === true && this.presence(element, {
               message: options.messages.numericality
             })) {
@@ -376,10 +380,6 @@
             }
             return options.messages.numericality;
           }
-          val = val.replace(new RegExp("\\" + number_format.delimiter, 'g'), '').replace(new RegExp("\\" + number_format.separator, 'g'), '.');
-          if (options.only_integer && !/^[+-]?\d+$/.test(val)) {
-            return options.messages.only_integer;
-          }
           CHECKS = {
             greater_than: '>',
             greater_than_or_equal_to: '>=',

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: client_side_validations
 version: !ruby/object:Gem::Version
-  version: 9.3.4
+  version: 10.0.0
 platform: ruby
 authors:
 - Geremia Taglialatela
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-15 00:00:00.000000000 Z
+date: 2017-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -51,14 +51,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -79,14 +79,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '9.0'
+        version: '9.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '9.0'
+        version: '9.1'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -135,42 +135,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.2'
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '12.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '12.1'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.50.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.49.1
+        version: 0.50.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -316,7 +316,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Client Side Validations