client_side_validations 6.0.0 → 7.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62857994d1326cfb20a2c2d3c1c5fd746fa72065
-  data.tar.gz: 5d187e21b9b0b8935f3d5bfee8099095a128a389
+  metadata.gz: a667f554594c134de2b2ab3e77679337a8bfcb22
+  data.tar.gz: fd9fd106426a734c79c9a6f9e3bc96877b4bd152
 SHA512:
-  metadata.gz: 284d47098c63a20c73aad2d252028e54ecd7b519d6130d16170206440e4f70b6e28f70be895a71c4f71dc555acf65765f1137acbded5910aa5aea779bdf3862a
-  data.tar.gz: 4c0b3c38d2254184cd34841d87683a3c21e0e5c1805be57134b913078f96e964e920cf78b85efb41a214f9bb81721b24e3e78996ca82e2877e751d15717cb6b2
+  metadata.gz: 378f957247dbfab1182963dadb3adf802cb4e79b2a2570af0d9507f3e94b2c7d87fe93002300542f4613b5d7a235f52dded3e906d358fdade2903ae36842ba4d
+  data.tar.gz: 04f88efc2d59603ea7189d1aefeda34f3e7678cbecfffed791df36612f35582c940ed4ef6df82b0db1d6e4da1d54023dc2d3722a99dda6ccbd4ebb72b608a790

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 7.0.1 (2017-01-22)
+
+* Fix `rails.validations` asset not found error
+
+## 7.0.0 (2017-01-22)
+
+* Remove middleware for remote validations
+* Update development dependencies
+
 ## 6.0.0 (2017-01-20)
 
 * Rails 5.0 compatibility

data/README.md

@@ -183,37 +183,6 @@ You can even turn them off per fieldset:
   ...
 ```
 
-## Wrapper objects and remote validations ##
-
-For example, we have a wrapper class for the User model, UserForm, and it uses remote uniqueness validation for the `email` field.
-
-```ruby
-class UserForm
-  include ActiveRecord::Validations
-  attr_accessor :email
-  validates_uniqueness_of :email
-end
-...
-<% form_for(UserForm.new) do %>
-...
-```
-
-However, this won't work since middleware will try to perform validation against UserForm, and it's not persisted.
-
-This is solved by passing `client_validations` options hash to the validator, that currently supports one key — `:class`, and setting correct name to the form object:
-
-```ruby
-class UserForm
-  include ActiveRecord::Validations
-  attr_accessor :email
-  validates_uniqueness_of :email, client_validations: { class:
-  'User' }
-end
-...
-<% form_for(UserForm.new, as: :user) do %>
-...
-```
-
 ## Understanding the embedded `<script>` tag ##
 
 A rendered form with validations will always have a `<script>` appended
@@ -259,7 +228,7 @@ passing nothing:
 You can also force validators similarly to the input syntax:
 
 ```erb
-<%= f.validate :email, uniqueness: false %>
+<%= f.validate :email, presence: false %>
 ```
 
 Take care when using this method. The embedded validators are
@@ -267,11 +236,11 @@ overwritten based upon the order they are rendered. So if you do
 something like:
 
 ```erb
-<%= f.text_field :email, validate: { uniqueness: false } %>
+<%= f.text_field :email, validate: { presence: false } %>
 <%= f.validate %>
 ```
 
-The `uniqueness` validator will not be turned off because the options
+The `presence` validator will not be turned off because the options
 were overwritten by the call to `FormBuilder#validate`
 
 
@@ -357,71 +326,6 @@ end
 
 Client Side Validations will apply the new validator and validate your forms as needed.
 
-### Remote Validators ###
-A good example of a remote validator would be for Zipcodes. It wouldn't be reasonable to embed every single zipcode inline, so we'll need to check for its existence with remote javascript call back to our app. Assume we have a zipcode database mapped to the model Zipcode. The primary key is the unique zipcode. Our Rails validator would probably look something like this:
-
-```ruby
-class ZipcodeValidator < ActiveModel::EachValidator
-  def validate_each(record, attr_name, value)
-    unless ::Zipcode.where(id: value).exists?
-      record.errors.add(attr_name, :zipcode, options.merge(value: value))
-    end
-  end
-end
-
-# This allows us to assign the validator in the model
-module ActiveModel::Validations::HelperMethods
-  def validates_zipcode(*attr_names)
-    validates_with ZipcodeValidator, _merge_attributes(attr_names)
-  end
-end
-```
-
-Of course we still need to add the i18n message:
-
-```yaml
-en:
-  errors:
-    messages:
-      zipcode: "Not a valid US zip code"
-```
-
-And let's add the Javascript validator. Because this will be remote validator we need to add it to `ClientSideValidations.validators.remote`:
-
-```js
-window.ClientSideValidations.validators.remote['zipcode'] = function(element, options) {
-  if ($.ajax({
-    url: '/validators/zipcode',
-    data: { id: element.val() },
-    // async *must* be false
-    async: false
-  }).status == 404) { return options.message; }
-}
-```
-
-All we're doing here is checking to see if the resource exists (in this case the given zipcode) and if it doesn't the error message is returned.
-
-Notice that the remote call is forced to *async: false*. This is necessary and the validator may not work properly if this is left out.
-
-Now the extra step for adding a remote validator is to add to the middleware. All ClientSideValidations middleware should inherit from `ClientSideValidations::Middleware::Base`:
-
-```ruby
-module ClientSideValidations::Middleware
-  class Zipcode < ClientSideValidations::Middleware::Base
-    def response
-      if ::Zipcode.where(id: request.params[:id]).exists?
-        self.status = 200
-      else
-        self.status = 404
-      end
-      super
-    end
-  end
-end
-```
-
-The `#response` method is always called and it should set the status accessor. Then a call to `super` is required. In the javascript we set the 'id' in the params to the value of the zipcode input, in the middleware we check to see if this zipcode exists in our zipcode database. If it does, we return 200, if it doesn't we return 404.
-
 ## Enabling, Disabling, and Resetting on the client ##
 
 There are many reasons why you might want to enable, disable, or even completely reset the bound validation events on the client. `ClientSideValidations` offers a simple API for this.
@@ -510,16 +414,6 @@ div.field_with_errors div.ui-effects-wrapper {
 
 Finally uncomment the `ActionView::Base.field_error_proc` override in `config/initializers/client_side_validations.rb`
 
-## Security ##
-
-Client Side Validations comes with a uniqueness middleware. This can be a potential security issue, so the uniqueness validator is disabled by default. If you want to enable it, set the `disabled_validators` config variable in `config/initializers/client_side_validations.rb`:
-
-```ruby
-ClientSideValidations::Config.disabled_validators = []
-```
-
-Note that the `FormBuilder` will automatically skip building validators that are disabled.
-
 ## Authors ##
 
 [Brian Cardarella](https://twitter.com/bcardarella)

data/lib/client_side_validations.rb

@@ -1,12 +1,9 @@
-module ClientSideValidations
-end
-
 require 'client_side_validations/config'
 require 'client_side_validations/active_model'  if defined?(::ActiveModel)
 require 'client_side_validations/active_record' if defined?(::ActiveRecord)
 require 'client_side_validations/action_view'   if defined?(::ActionView)
+
 if defined?(::Rails)
-  require 'client_side_validations/generators'
-  require 'client_side_validations/middleware'
   require 'client_side_validations/engine'
+  require 'client_side_validations/generators'
 end

data/lib/client_side_validations/active_model.rb

@@ -1,4 +1,5 @@
 require 'client_side_validations/core_ext'
+require 'client_side_validations/extender'
 require 'client_side_validations/active_model/conditionals'
 
 module ClientSideValidations
@@ -145,7 +146,4 @@ end
 ActiveModel::Validator.send(:include, ClientSideValidations::ActiveModel::Validator)
 ActiveModel::Validations.send(:include, ClientSideValidations::ActiveModel::Validations)
 
-%w(Absence Acceptance Exclusion Format Inclusion Length Numericality Presence).each do |validator|
-  require "client_side_validations/active_model/#{validator.downcase}"
-  ActiveModel::Validations.const_get("#{validator}Validator").send :include, ClientSideValidations::ActiveModel.const_get(validator)
-end
+ClientSideValidations::Extender.extend 'ActiveModel', %w(Absence Acceptance Exclusion Format Inclusion Length Numericality Presence)

data/lib/client_side_validations/active_record.rb

@@ -1,11 +1,6 @@
 require 'client_side_validations/active_model'
-require 'client_side_validations/middleware'
-require 'client_side_validations/active_record/middleware'
+require 'client_side_validations/extender'
 
 ActiveRecord::Base.send(:include, ClientSideValidations::ActiveModel::Validations)
-ClientSideValidations::Middleware::Uniqueness.register_orm(ClientSideValidations::ActiveRecord::Middleware)
 
-%w(Uniqueness).each do |validator|
-  require "client_side_validations/active_record/#{validator.downcase}"
-  ActiveRecord::Validations.const_get("#{validator}Validator").send :include, ClientSideValidations::ActiveRecord.const_get(validator)
-end
+ClientSideValidations::Extender.extend 'ActiveRecord', %w(Uniqueness)

data/lib/client_side_validations/config.rb

@@ -6,7 +6,7 @@ module ClientSideValidations
       attr_accessor :root_path
     end
 
-    self.disabled_validators = [:uniqueness]
+    self.disabled_validators = []
     self.number_format_with_locale = false
     self.root_path = nil
   end

data/lib/client_side_validations/engine.rb

@@ -1,5 +1,4 @@
 module ClientSideValidations
   class Engine < ::Rails::Engine
-    config.app_middleware.use ClientSideValidations::Middleware::Validators
   end
 end

data/lib/client_side_validations/extender.rb

@@ -0,0 +1,12 @@
+module ClientSideValidations
+  module Extender
+    module_function
+
+    def extend(klass, validators)
+      validators.each do |validator|
+        require "client_side_validations/#{klass.underscore}/#{validator.downcase}"
+        const_get(klass)::Validations.const_get("#{validator}Validator").send :include, ClientSideValidations.const_get(klass).const_get(validator)
+      end
+    end
+  end
+end

data/lib/client_side_validations/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module ClientSideValidations
-  VERSION = '6.0.0'.freeze
+  VERSION = '7.0.1'.freeze
 end

data/lib/generators/templates/client_side_validations/initializer.rb

@@ -1,7 +1,7 @@
 # ClientSideValidations Initializer
 
-# Disabled validators. The uniqueness validator is disabled by default for security issues. Enable it on your own responsibility!
-# ClientSideValidations::Config.disabled_validators = [:uniqueness]
+# Disabled validators
+# ClientSideValidations::Config.disabled_validators = []
 
 # Uncomment to validate number format with current I18n locale
 # ClientSideValidations::Config.number_format_with_locale = true

data/vendor/assets/javascripts/rails.validations.js

@@ -1,6 +1,6 @@
 
 /*!
- * Client Side Validations - v6.0.0 (https://github.com/DavyJonesLocker/client_side_validations)
+ * Client Side Validations - v7.0.1 (https://github.com/DavyJonesLocker/client_side_validations)
  * Copyright (c) 2017 Geremia Taglialatela, Brian Cardarella
  * Licensed under MIT (http://opensource.org/licenses/mit-license.php)
  */
@@ -505,64 +505,7 @@
         }
       }
     },
-    remote: {
-      uniqueness: function(element, options) {
-        var data, key, message, name, ref, scope_value, scoped_element, scoped_name;
-        message = ClientSideValidations.validators.local.presence(element, options);
-        if (message) {
-          if (options.allow_blank === true) {
-            return;
-          }
-          return message;
-        }
-        data = {};
-        data.case_sensitive = !!options.case_sensitive;
-        if (options.id) {
-          data.id = options.id;
-        }
-        if (options.scope) {
-          data.scope = {};
-          ref = options.scope;
-          for (key in ref) {
-            scope_value = ref[key];
-            scoped_name = element.attr('name').replace(/\[\w+\]$/, "[" + key + "]");
-            scoped_element = $("[name='" + scoped_name + "']");
-            $("[name='" + scoped_name + "']:checkbox").each(function() {
-              if (this.checked) {
-                return scoped_element = this;
-              }
-            });
-            if (scoped_element[0] && scoped_element.val() !== scope_value) {
-              data.scope[key] = scoped_element.val();
-              scoped_element.unbind("change." + element.id).bind("change." + element.id, function() {
-                element.trigger('change.ClientSideValidations');
-                return element.trigger('focusout.ClientSideValidations');
-              });
-            } else {
-              data.scope[key] = scope_value;
-            }
-          }
-        }
-        if (/_attributes\]/.test(element.attr('name'))) {
-          name = element.attr('name').match(/\[\w+_attributes\]/g).pop().match(/\[(\w+)_attributes\]/).pop();
-          name += /(\[\w+\])$/.exec(element.attr('name'))[1];
-        } else {
-          name = element.attr('name');
-        }
-        if (options['class']) {
-          name = options['class'] + "[" + (name.split('[')[1]);
-        }
-        data[name] = element.val();
-        if ($.ajax({
-          url: ClientSideValidations.remote_validators_url_for('uniqueness'),
-          data: data,
-          async: false,
-          cache: false
-        }).status === 200) {
-          return options.message;
-        }
-      }
-    }
+    remote: {}
   };
 
   window.ClientSideValidations.remote_validators_url_for = function(validator) {

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: client_side_validations
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 7.0.1
 platform: ruby
 authors:
 - Geremia Taglialatela
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-20 00:00:00.000000000 Z
+date: 2017-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -93,14 +93,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.18
+        version: 0.8.19
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.18
+        version: 0.8.19
 - !ruby/object:Gem::Dependency
   name: m
   requirement: !ruby/object:Gem::Requirement
@@ -119,22 +119,16 @@ dependencies:
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.7.5
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: '5.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.7.5
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.0
+        version: '5.10'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -287,17 +281,16 @@ files:
 - lib/client_side_validations/active_model/numericality.rb
 - lib/client_side_validations/active_model/presence.rb
 - lib/client_side_validations/active_record.rb
-- lib/client_side_validations/active_record/middleware.rb
 - lib/client_side_validations/active_record/uniqueness.rb
 - lib/client_side_validations/config.rb
 - lib/client_side_validations/core_ext.rb
 - lib/client_side_validations/core_ext/range.rb
 - lib/client_side_validations/core_ext/regexp.rb
 - lib/client_side_validations/engine.rb
+- lib/client_side_validations/extender.rb
 - lib/client_side_validations/files.rb
 - lib/client_side_validations/generators.rb
 - lib/client_side_validations/generators/rails_validations.rb
-- lib/client_side_validations/middleware.rb
 - lib/client_side_validations/version.rb
 - lib/generators/client_side_validations/copy_assets_generator.rb
 - lib/generators/client_side_validations/install_generator.rb
@@ -323,7 +316,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.9
 signing_key: 
 specification_version: 4
 summary: Client Side Validations

data/lib/client_side_validations/active_record/middleware.rb

@@ -1,62 +0,0 @@
-module ClientSideValidations
-  module ActiveRecord
-    class Middleware
-      def self.class?(klass)
-        klass.abstract_class.blank? && klass < ::ActiveRecord::Base
-      end
-
-      def self.unique?(klass, attribute, value, params)
-        klass      = find_topmost_superclass(klass)
-        connection = klass.connection
-        column     = klass.columns_hash[attribute.to_s]
-        value      = type_cast_value(connection, column, value)
-
-        sql      = sql_statement(klass, connection, attribute, value, params)
-        relation = Arel::Nodes::SqlLiteral.new(sql)
-
-        klass.where(relation).empty?
-      end
-
-      def self.sql_statement(klass, connection, attribute, value, params)
-        sql = []
-        t   = klass.arel_table
-
-        if params[:case_sensitive] == 'true'
-          sql << 'BINARY' if connection.adapter_name =~ /^mysql/i
-          sql << t[attribute].eq(value).to_sql
-        else
-          escaped_value = value.gsub(/[%_]/, '\\\\\0')
-          sql << "#{t[attribute].matches(escaped_value).to_sql} ESCAPE '\\'"
-        end
-
-        sql << "AND #{t[klass.primary_key].not_eq(params[:id]).to_sql}" if params[:id]
-
-        (params[:scope] || {}).each do |scope_attribute, scope_value|
-          scope_value = type_cast_value(connection, klass.columns_hash[scope_attribute], scope_value)
-          sql << "AND #{t[scope_attribute].eq(scope_value).to_sql}"
-        end
-
-        sql.join ' '
-      end
-
-      def self.type_cast_value(connection, column, value)
-        type  = connection.lookup_cast_type_from_column(column)
-        value = type.deserialize(value)
-
-        if column.limit && value.is_a?(String)
-          value.mb_chars[0, column.limit]
-        else
-          value
-        end
-      end
-
-      def self.find_topmost_superclass(klass)
-        if class?(klass.superclass)
-          find_topmost_superclass(klass.superclass)
-        else
-          klass
-        end
-      end
-    end
-  end
-end

data/lib/client_side_validations/middleware.rb

@@ -1,159 +0,0 @@
-require 'client_side_validations/core_ext'
-
-module ClientSideValidations
-  module Middleware
-    class Validators
-      def initialize(app)
-        @app = app
-      end
-
-      def call(env)
-        matches = %r{\A/?#{ClientSideValidations::Config.root_path}/validators\/(\w+)\z}.match(env['PATH_INFO'])
-        if matches
-          process_request(matches.captures.first, env)
-        else
-          @app.call(env)
-        end
-      end
-
-      def process_request(validation, env)
-        if disabled_validators.include?(validation)
-          error_resp
-        else
-          klass_name = validation.camelize
-          klass_name = "::ClientSideValidations::Middleware::#{klass_name}"
-          klass_name.constantize.new(env).response
-        end
-      rescue
-        error_resp
-      end
-
-      def disabled_validators
-        ClientSideValidations::Config.disabled_validators.map(&:to_s)
-      end
-
-      def error_resp
-        [500, { 'Content-Type' => 'application/json', 'Content-Length' => '0' }, ['']]
-      end
-    end
-
-    class Base
-      attr_accessor :request, :body, :status
-
-      def initialize(env)
-        # Filter out cache buster
-        env['QUERY_STRING'] = env['QUERY_STRING'].split('&').select { |p| !p.match(/^_=/) }.join('&')
-        self.body           = ''
-        self.status         = 200
-        self.request        = ActionDispatch::Request.new(env)
-      end
-
-      def response
-        [status, { 'Content-Type' => content_type, 'Content-Length' => body.length.to_s }, [body]]
-      end
-
-      def content_type
-        'application/json'
-      end
-    end
-
-    class Uniqueness < Base
-      IGNORE_PARAMS = %w(case_sensitive id scope).freeze
-      @@registered_orms = []
-      class NotValidatable < StandardError; end
-
-      def response
-        begin
-          if unique?
-            self.status = 404
-            self.body   = 'true'
-          else
-            self.status = 200
-            self.body   = 'false'
-          end
-        rescue NotValidatable
-          self.status = 500
-          self.body = ''
-        end
-        super
-      end
-
-      def self.register_orm(orm)
-        registered_orms << orm
-      end
-
-      def self.registered_orms
-        @@registered_orms
-      end
-
-      def registered_orms
-        self.class.registered_orms
-      end
-
-      private
-
-      def unique?
-        convert_scope_value_from_null_to_nil
-        klass, attribute, value = extract_resources
-        middleware_class        = nil
-
-        unless Array.wrap(klass._validators[attribute.to_sym]).find { |v| v.kind == :uniqueness }
-          raise NotValidatable
-        end
-
-        registered_orms.each do |orm|
-          if orm.class?(klass)
-            middleware_class = orm
-            break
-          end
-        end
-
-        middleware_class.unique?(klass, attribute, value, request.params)
-      end
-
-      def convert_scope_value_from_null_to_nil
-        return unless request.params['scope']
-        request.params['scope'].each do |key, value|
-          request.params['scope'][key] = nil if value == 'null'
-        end
-      end
-
-      def extract_resources
-        parent_key = (request.params.keys - IGNORE_PARAMS).first
-
-        if nested?(request.params[parent_key], 1)
-          klass, attribute, value = uproot(request.params[parent_key])
-          klass = klass.classify.constantize
-        else
-          klass            = parent_key.classify.constantize
-          attribute        = request.params[parent_key].keys.first
-          value            = request.params[parent_key][attribute]
-        end
-
-        [klass, attribute, value]
-      end
-
-      def uproot(nested_hash = nil)
-        uproot_helper(nested_hash)[-3..-1]
-      end
-
-      def uproot_helper(nested_hash = nil, keys = [])
-        if nested_hash.respond_to?(:keys)
-          keys << nested_hash.keys.first
-          uproot_helper(nested_hash[nested_hash.keys.first], keys)
-        else
-          keys << nested_hash
-        end
-      end
-
-      def nested?(hash = nil, levels = 0)
-        i = 0
-        while hash.respond_to? :keys
-          hash = hash[hash.keys.first]
-          i += 1
-        end
-        i > levels
-      end
-    end
-  end
-end