client_side_validations 16.0.2 → 16.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 11a781942eb32f699c3409faa441c7f72b4a6d49c5050f6ed677bf9202f3320c
-  data.tar.gz: 88e915020768a159ecc2d2e85ae3577d5cfd73abe6d1e4dd9abee3d6554564fb
+  metadata.gz: 9893d8ea2559c48246a18e75f05032a3503708a7dbda3be04a822d6ca743e439
+  data.tar.gz: 6069c83656296d9811dadab566f89e019d626518f4612c920ab8ed7073b8c4f1
 SHA512:
-  metadata.gz: 8327b3bd03f91b7114488dff342c42de349321ff8bd1d2992bfd1fdbc0f26996be91d76a5529aa5ecc5216c34aec3d1ee01d80fbb8592f4664a7ecbe1f80438a
-  data.tar.gz: 481e25e87b9ff63897312328dd948953b1d9cf4b3991f1b271cda8d5c6b3dac81d18a3c2e9596a708467073b2b072c1af91067cd62d3a4ab918ba77ff1a93751
+  metadata.gz: 14988e0e4674b7870643fd56fc12eed129e7937f1b79a99afa62b5bc9516d40c7b407944738e0f80bfdfafcd72fecc2ce480f0d193e41152277bf9b3b9174c84
+  data.tar.gz: 6a56df2ab28a446ee19b0fc42d30743c4d72e8def54b693c9c9a82d1c1309a67350745d0f824f55fd28cf80eda26c565c69fe9afb72faee1fd89619fd7f4d6bf

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 16.0.3 / 2019-10-06
+
+* [BUGFIX] Fix `validators.all` function
+* [ENHANCEMENT] Update development dependencies
+
 ## 16.0.2 / 2019-09-21
 
 * [BUGFIX] Guard against prototype extended arrays ([#769](https://github.com/DavyJonesLocker/client_side_validations/pull/769))

data/README.md

@@ -76,10 +76,17 @@ import '@client-side-validations/client-side-validations'
 require('@client-side-validations/client-side-validations')
 ```
 
-If you are using [Turbolinks](https://github.com/turbolinks/turbolinks),
-make sure that `@client-side-validations/client-side-validations` is imported
-(or required) **after** `Turbolinks.start()`, so ClientSideValidations can
-properly attach its event handlers.
+##### Heads-up for Turbolinks users #####
+
+If you are using [Turbolinks](https://github.com/turbolinks/turbolinks) 5.2,
+use the require syntax and make sure that `@client-side-validations/client-side-validations`
+is required after`Turbolinks.start()`, so ClientSideValidations can properly
+attach its event handlers.
+
+Turbolinks 5.3 automatically calls `start()`, so you can use the `import` syntax.
+Just make sure that `@client-side-validations/client-side-validations` is imported
+**after** `turbolinks`, so ClientSideValidations can properly
+attach its event handlers.
 
 ####  When using Sprockets ####
 

data/lib/client_side_validations/action_view.rb

@@ -16,5 +16,5 @@ end
 
 require 'client_side_validations/action_view/form_builder'
 
-ActionView::Base.send(:include, ClientSideValidations::ActionView::Helpers::FormHelper)
-ActionView::Helpers::FormBuilder.send(:prepend, ClientSideValidations::ActionView::Helpers::FormBuilder)
+ActionView::Base.include ClientSideValidations::ActionView::Helpers::FormHelper
+ActionView::Helpers::FormBuilder.prepend ClientSideValidations::ActionView::Helpers::FormBuilder

data/lib/client_side_validations/active_model.rb

@@ -172,7 +172,7 @@ module ClientSideValidations
   end
 end
 
-ActiveModel::Validator.send(:include, ClientSideValidations::ActiveModel::Validator)
-ActiveModel::Validations.send(:include, ClientSideValidations::ActiveModel::Validations)
+ActiveModel::Validator.include ClientSideValidations::ActiveModel::Validator
+ActiveModel::Validations.include ClientSideValidations::ActiveModel::Validations
 
 ClientSideValidations::Extender.extend 'ActiveModel', %w[Absence Acceptance Exclusion Format Inclusion Length Numericality Presence]

data/lib/client_side_validations/active_record.rb

@@ -3,6 +3,6 @@
 require 'client_side_validations/active_model'
 require 'client_side_validations/extender'
 
-ActiveRecord::Base.send(:include, ClientSideValidations::ActiveModel::Validations)
+ActiveRecord::Base.include ClientSideValidations::ActiveModel::Validations
 
 ClientSideValidations::Extender.extend 'ActiveRecord', %w[Uniqueness]

data/lib/client_side_validations/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ClientSideValidations
-  VERSION = '16.0.2'
+  VERSION = '16.0.3'
 end

data/vendor/assets/javascripts/rails.validations.js

@@ -1,5 +1,5 @@
 /*!
- * Client Side Validations JS - v0.0.5 (https://github.com/DavyJonesLocker/client_side_validations)
+ * Client Side Validations JS - v0.1.0 (https://github.com/DavyJonesLocker/client_side_validations)
  * Copyright (c) 2019 Geremia Taglialatela, Brian Cardarella
  * Licensed under MIT (https://opensource.org/licenses/mit-license.php)
  */
@@ -219,7 +219,7 @@
     },
     validators: {
       all: function all() {
-        return $.extend({});
+        return $.extend({}, ClientSideValidations.validators.local, ClientSideValidations.validators.remote);
       },
       local: {},
       remote: {}
@@ -726,12 +726,14 @@
   };
 
   var executeAllValidators = function executeAllValidators(element, validators) {
-    if (element.data('changed') !== false) {
-      element.data('changed', false);
+    if (element.data('changed') === false) {
+      return;
+    }
 
-      if (executeValidators(ClientSideValidations.validators.local, element, validators) && executeValidators(ClientSideValidations.validators.remote, element, validators)) {
-        passElement(element);
-      }
+    element.data('changed', false);
+
+    if (executeValidators(ClientSideValidations.validators.all(), element, validators)) {
+      passElement(element);
     }
   };
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: client_side_validations
 version: !ruby/object:Gem::Version
-  version: 16.0.2
+  version: 16.0.3
 platform: ruby
 authors:
 - Geremia Taglialatela
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-21 00:00:00.000000000 Z
+date: 2019-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -127,14 +127,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '5.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.11'
+        version: '5.12'
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
@@ -155,42 +155,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: 0.75.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: 0.75.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement