clickwrap 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98648fe84ac49eb6e6f0aa31206529051b15a13317c28ea8405d1b78f49b6668
-  data.tar.gz: f3dd9f393dcd3b0ced96de1fa320608e631962c8531edd2365110d7825c88d85
+  metadata.gz: 4f6304579666eb5ab8765fd22bb279e897ae328b166fe7f6d3ae5addcc61b61a
+  data.tar.gz: 67be7cf559b23e5f85b14a37f0d72a343015ba2ac69d717b0951ef9e026d1199
 SHA512:
-  metadata.gz: 5d5ccebc49daf312d199a0d0eede813f80966dadb04654ea49345d408b4708b520208e3dd5018dba99eacb815c93ac735fd562691f5a0ddbb88acb725ea86221
-  data.tar.gz: dcdcd70b597f09f91ccf43efed3f7ebd55e1389275e9701598e015e47a759089ed8003933e17c56fbe643cbcf26df69399eca1472c3be9ba06585e3f2ffdaddc
+  metadata.gz: b382d32b2a7c4dbccb05a2700b06b334255016c0c6bd8883e20ee1129030e47fc68959dcfc5aeebddd73ba517b68da927ec460bbb64ca52e7f82188d6ebe450a
+  data.tar.gz: 4b98d8d3d68a1d35d4497c1ebf6091de0fc2699ea382884495657f207b4f428b34a596d2adc7a1e95abf951e14287d1d0ab38a49e2bce4f9f2c06cfc5966e598

data/CHANGELOG.md

@@ -6,6 +6,44 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.1.1] - 2026-08-19
+
+### Fixed — the composed sentence in a language that declines its articles
+
+- **Per-key sentence fragments.** Spanish cannot say "acepto %{documents}" for
+  every document — the article agrees with the noun ("los Términos", "la
+  Política"). The composer now looks up
+  `clickwrap.sentence.fragments.<kind>.<key>` before falling back to the
+  per-kind template, and the gem ships Spanish defaults for its standard keys.
+  An application adds its own in its locale files; no DSL change.
+- **One opening capital.** Fragment templates are written lowercase for the
+  middle of a sentence; the composer capitalizes exactly one letter — the
+  first — once, at build time, so the signed manifest and the rendered HTML
+  can never disagree. The Spanish signup now reads
+  "Acepto los Términos y Condiciones y doy por recibida la Política de
+  Privacidad." instead of "Acepto Términos y Condiciones y He recibido
+  Política de Privacidad."
+- **One voice, composed or itemized.** The Spanish composed acknowledgment now
+  says "doy por recibida" — the same words as the itemized default statement —
+  instead of the flatter "he recibido". The same act reads the same way in
+  either rendering. (Still never "he leído": the evidence records an
+  affirmative act on an offered notice, not that anyone read it. A host that
+  wants the first-person read-declaration owns that wording via its locale
+  files — see the next fix.)
+- **Host locale overrides actually win now.** The engine appended its locale
+  files to `app.config.i18n.load_path` on top of Rails's automatic engine
+  locale loading. Railties paths are unshifted ahead of that list, so the
+  appended copy landed AFTER the host's own locale files — and every host
+  override of a gem key silently lost to the gem's default. The manual append
+  is gone; Rails::Engine's own `:add_locales` ordering (gem first, host last)
+  is the contract, and a test now pins it.
+- **Checkbox optical alignment.** The box was mathematically centred on the
+  first line and still read as floating high: Latin text carries its mass
+  between cap-height and baseline, below the line box's midpoint. The offset
+  gains an optical eighth of an em, calibrated against rendered screenshots.
+
+## [0.1.0] - 2026-08-19
+
 ### Changed — the signup clickwrap is one line
 
 - **`form.clickwrap` renders ONE checkbox carrying ONE sentence** whenever every

data/app/assets/stylesheets/clickwrap.css

@@ -88,14 +88,18 @@
 .clickwrap-statement__checkbox,
 .clickwrap-statement__radio {
   /* Sized in em so the box matches the sentence it belongs to instead of
-     towering over small text, and optically centered against the FIRST line
-     of the label: (line-height minus box) halved. Flex `baseline` cannot do
-     this — a checkbox aligns its bottom edge to the baseline and ends up
-     floating high. The rem fallback covers engines without the lh unit. */
+     towering over small text, and aligned against the FIRST line of the
+     label: (line-height minus box) halved, plus an optical eighth of an em.
+     The mathematical centre is not the visual one — Latin text carries its
+     mass between cap-height and baseline, below the line box's midpoint, so
+     a box centred by arithmetic reads as floating high (calibrated against
+     rendered screenshots at 400%). Flex `baseline` is still worse: a
+     checkbox aligns its bottom edge to the baseline and floats higher. The
+     em fallback covers engines without the lh unit. */
   width: 1em;
   height: 1em;
-  margin: 0.2em 0 0;
-  margin-top: calc((1lh - 1em) / 2);
+  margin: 0.325em 0 0;
+  margin-top: calc((1lh - 1em) / 2 + 0.125em);
   flex: 0 0 auto;
   accent-color: var(--clickwrap-focus);
 }

data/config/locales/es.yml

@@ -22,13 +22,29 @@ es:
       acknowledgment:
         privacy_notice: "Doy por recibida la Política de Privacidad."
 
-    # La frase de una sola línea. En español el artículo concuerda con el
-    # documento ("los Términos", "la Política"), y solo la aplicación sabe qué
-    # documento nombra, así que el artículo vive en la etiqueta del enlace y no
-    # en estas plantillas — por eso `documents_joiner` es " y " y no " y el ".
+    # La frase de una sola línea. Las plantillas se escriben en minúscula y
+    # PARA EL MEDIO de la frase ("… y he recibido …"): la mayúscula inicial la
+    # pone el compositor, una sola vez, al primer fragmento.
+    #
+    # En español el artículo concuerda con el documento ("los Términos", "la
+    # Política"), así que cada clave estándar lleva su propia plantilla bajo
+    # `fragments`, con el artículo correcto. Una aplicación con documentos
+    # propios añade aquí los suyos (p. ej.
+    # `fragments.agreement.contrato_marco: "acepto el %{documents}"`); sin
+    # plantilla propia se usa la genérica, que es neutra y correcta aunque
+    # menos idiomática.
     sentence:
-      agreement: "Acepto %{documents}"
-      acknowledgment: "He recibido %{documents}"
+      fragments:
+        agreement:
+          terms: "acepto los %{documents}"
+        acknowledgment:
+          # La misma voz que la declaración detallada ("Doy por recibida la
+          # Política de Privacidad."): el mismo acto debe leerse igual
+          # compuesto que detallado. Nunca "he leído": la evidencia registra
+          # un acto afirmativo sobre un aviso ofrecido, no que alguien leyera.
+          privacy_notice: "doy por recibida la %{documents}"
+      agreement: "acepto %{documents}"
+      acknowledgment: "he recibido %{documents}"
       documents_joiner: " y "
       joiner: " y "
       terminator: "."

data/lib/clickwrap/engine.rb

@@ -124,12 +124,15 @@ module Clickwrap
       end
     end
 
-    # Ship the gem's locale files. Host locale files with the same keys override
-    # these automatically (I18n's load order puts the app last), which is how a
-    # host rewords a statement without forking a view.
-    initializer "clickwrap.locales" do |app|
-      app.config.i18n.load_path += Dir[root.join("config", "locales", "**", "*.{rb,yml}").to_s]
-    end
+    # The gem's locale files ship through Rails::Engine's own :add_locales
+    # (every engine's `config/locales` is picked up automatically) — and NOT
+    # through a manual `app.config.i18n.load_path +=` on top of it. The manual
+    # append is not merely redundant: railties paths are UNSHIFTED before
+    # everything in `load_path`, so an appended copy of these files lands
+    # AFTER the host's own locales and quietly overrides them. Load order is
+    # the whole contract here — gem first, host last — because a host rewords
+    # a statement by shipping the same key in its own locale file, and the
+    # host's counsel must always get the last word.
 
     initializer "clickwrap.assets" do |app|
       app.config.assets.paths << root.join("app/assets/stylesheets") if app.config.respond_to?(:assets)

data/lib/clickwrap/presenter.rb

@@ -383,6 +383,12 @@ module Clickwrap
 
     def build_combined(composable, fragments, connectives)
       control = composable.first
+      # Fragment templates are written for the middle of a sentence ("he
+      # recibido la …"), because every fragment but the first sits there. The
+      # sentence's opening capital is applied here, once, so the signed
+      # manifest text and the rendered HTML can never disagree about it.
+      fragments = [fragments.first.with(prefix: fragments.first.prefix.sub(/\A\p{Ll}/, &:upcase))] +
+                  fragments[1..]
 
       Combined.new(
         sentence: fragments.map(&:to_text).join(connectives[:joiner]) + connectives[:terminator],
@@ -433,7 +439,14 @@ module Clickwrap
     end
 
     def sentence_fragment(statement, connectives)
-      template = sentence_text(statement.kind)
+      # A language that needs to agree with its nouns — an article, a gendered
+      # participle — cannot say "acepto %{documents}" for every document. A
+      # per-key template carries those words for THIS document
+      # (clickwrap.sentence.fragments.agreement.terms: "acepto los
+      # %{documents}"); the per-kind template stays the fallback for keys
+      # nobody translated specifically.
+      template = sentence_text("fragments.#{statement.kind}.#{statement.key}") ||
+                 sentence_text(statement.kind)
       return nil if template.nil?
 
       prefix, suffix = template.split(DOCUMENTS_PLACEHOLDER, 2)

data/lib/clickwrap/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Clickwrap
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 
   # The canonical schema version for receipts, event digests, and presentation
   # manifests. This is deliberately independent of VERSION: gem releases may

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clickwrap
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - rameerez