clickhouse-native 0.5.0-aarch64-linux-gnu → 0.7.0-aarch64-linux-gnu

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aca1fe60826ebd4ce6195574e7f54d42149441dfad431a71edc5418844ee69fd
-  data.tar.gz: b6dd6f2324bf040366dfef102e642b3b2d8426aff1cb4046375c54f5f54bdb4f
+  metadata.gz: 36b4983fdf477c8450778f09e2b0470966267587ce9b1b80b16eb7ea7e9cee53
+  data.tar.gz: d076a6896a96511376c7a0721dbfd7fd06ac2d235fc36efa39a5bca55effa41e
 SHA512:
-  metadata.gz: 83c3730225c9f95e6a48c2e84780024d2fe18ef85d84ae7e935bc6b3b0488f30d8bae9034fda77c1de9e855570980131a526fe375dbde64b5f219a2ca87fb995
-  data.tar.gz: e5eeb85c767f9d29239d8bb6cac7051fa87d8f38f2f5fbd7d0a7ad9c2a98fceb03a8199c9f3632ea1b4edcdd4c5700d0170817d9e50f5da303a4a998d2ae4aa1
+  metadata.gz: 3d8a3d88089a58c4295be2a8565def7cd2586a19bcda7b40b28d128483bed3b15d1863d1b4255f8b00676da6a3ec5ad7d1103577c24b02c3f7675361109e968e
+  data.tar.gz: 7370beaa8d36fd238bb22574f678ed2d1de2c29bb928b2567250314734eb76c928e6c2252e8454669b2910830acc571568cb612a42e0b1d720addda4289110ad

data/lib/clickhouse_native/pool.rb

@@ -4,8 +4,6 @@ require "connection_pool"
 
 module ClickhouseNative
   class Pool
-    STALE_IVAR = :@clickhouse_native_settings_stale
-
     attr_reader :host, :port, :database
 
     def initialize(host:, port:, database: "default", user: "default", password: "",
@@ -23,19 +21,20 @@ module ClickhouseNative
       end
     end
 
-    # Yields a client with the pool's session settings applied. If the
-    # previous checkout raised (which, in this gem's C++ bindings, always
-    # triggers a ResetConnection that wipes the session), re-apply the SET
-    # before yielding. Exceptions re-raise after marking the client stale.
+    # On exception, discard the client rather than reuse it: an error
+    # path leaves the socket in an unknown state. The C++ binding issues
+    # ResetConnection, but a subsequent send can still surface buffered
+    # protocol errors from the prior aborted operation — those get
+    # attributed to whatever SQL we tried next (e.g. the SET reapplying
+    # session settings), producing misleading log lines and re-raises in
+    # unrelated code. A fresh socket + handshake is cheap relative to
+    # debugging that.
     def with
       @pool.with do |client|
-        reapply_settings_if_stale(client)
-        begin
-          yield client
-        rescue
-          client.instance_variable_set(STALE_IVAR, true)
-          raise
-        end
+        yield client
+      rescue
+        @pool.discard_current_connection(&:close)
+        raise
       end
     end
 
@@ -73,13 +72,6 @@ module ClickhouseNative
 
     private
 
-    def reapply_settings_if_stale(client)
-      return unless @set_sql
-      return unless client.instance_variable_get(STALE_IVAR)
-      client.execute(@set_sql)
-      client.instance_variable_set(STALE_IVAR, false)
-    end
-
     # Render a `SET key1 = val1, key2 = val2` statement once at pool setup
     # so every checked-out connection starts with the same session
     # settings. Matches how the HTTP driver injected global_params per

data/lib/clickhouse_native/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ClickhouseNative
-  VERSION = "0.5.0"
+  VERSION = "0.7.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clickhouse-native
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.7.0
 platform: aarch64-linux-gnu
 authors:
 - Yuri Smirnov
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 2.5.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 2.5.4
 description: A high-performance Ruby client for ClickHouse using the native binary
   protocol via a C++ extension wrapping clickhouse-cpp.
 email: