click_house 1.3.2 → 1.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 040e53c977b5a0ef62fd73ef8f8b21915a2ec128d0649e3882dd1779e787ff28
-  data.tar.gz: 0c9c46b6c9ce234b497fbb2cbc0834b09fd697ea6a140544465bda93c66d1b9f
+  metadata.gz: df0c8b8d3ea01025f4634338790aa3db5921890cceece2b86253f7830e805d82
+  data.tar.gz: 67fe8393ff9d0f4eadac1126494619d72041e72a6677a85666ca04443d54c649
 SHA512:
-  metadata.gz: 9b93c038ae5da62bdf3a951120da771c21e0b4ce1cd92ed2e381827dacaad0f97fb9121c488d78fab7d6a58ee5ab79d04aed5fb1195d7bd9575cdfd344ab095b
-  data.tar.gz: 52bee84670bfa5c6b8bb8d6566b94f69935b80fc15bc14c1d9223ab3a7be7e7f972c8958b0c28f4836e21ba30b9c8269a1f58375ee87ccf99cbe670df5bd14df
+  metadata.gz: 627ab431f8c10dde3b70521d0cfc06910740f4d9975023ab66f830111e7567f5b75c583df5526ae7a330e27b7346ad728ab593b833472b6b9308985f3d0be890
+  data.tar.gz: 226d194bb976f883a9f34ff6639ff1d79e3684d75a0d0d5c24f367bed65ecfe7938c844b277c481390c1bdffc18d2bc0aa9e5b5cd0077ecdad0dd9969e599574

data/.github/workflows/main.yml

@@ -0,0 +1,68 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  rspec:
+    runs-on: ubuntu-latest
+
+    services:
+      clickhouse:
+        image: yandex/clickhouse-server:20.12.3.3
+        ports: 
+          - 8123:8123
+
+    strategy:
+      matrix:
+        ruby-version: [2.7, 2.6, 2.5, 2.4]
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+
+      - name: Cache gems
+        uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-${{ matrix.ruby-version }}-bundler-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-${{ matrix.ruby-version }}-bundler-
+
+      - name: Install gems
+        run: |
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+
+      - name: Run tests
+        run: bundle exec rspec
+
+  rubocop:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Set up Ruby 2.7
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7
+
+      - name: Cache gems
+        uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-bundler-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-bundler-
+
+      - name: Install gems
+        run: |
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+
+      - name: Run Rubocop
+        run: bundle exec rubocop

data/.rubocop.yml

@@ -3,13 +3,13 @@ require:
 
 AllCops:
   AutoCorrect: false
+  SuggestExtensions: false
   Exclude:
     - 'click_house.gemspec'
     - 'bin/*'
     - 'spec/**/*'
     - 'vendor/**/*'
   TargetRubyVersion: 2.7
-
 Bundler/OrderedGems:
   Enabled: false
 
@@ -36,6 +36,16 @@ Performance/StringInclude:
   Enabled: true
 Performance/Sum:
   Enabled: true
+Performance/ArraySemiInfiniteRangeSlice:
+  Enabled: true
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: true
+Performance/CollectionLiteralInLoop:
+  Enabled: true
+Performance/ConstantRegexp:
+  Enabled: true
+Performance/MethodObjectAsBlock:
+  Enabled: false
 
 # ============================== Metrics ============================
 Metrics/ClassLength:
@@ -44,8 +54,6 @@ Metrics/BlockLength:
   Enabled: true
 Metrics/MethodLength:
   Max: 25
-Metrics/LineLength:
-  Max: 140
 Metrics/AbcSize:
   Max: 40
 
@@ -63,6 +71,8 @@ Naming/AccessorMethodName:
   Enabled: false
 
 # ============================== Layout =============================
+Layout/LineLength:
+  Max: 140
 Layout/HashAlignment:
   EnforcedHashRocketStyle: key
   EnforcedColonStyle: key
@@ -193,6 +203,20 @@ Style/RedundantSelfAssignment:
   Enabled: true
 Style/SoleNestedConditional:
   Enabled: true
+Style/ArgumentsForwarding:
+  Enabled: true
+Style/CollectionCompact:
+  Enabled: true
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+Style/NegatedIfElseCondition:
+  Enabled: true
+Style/NilLambda:
+  Enabled: true
+Style/SwapValues:
+  Enabled: true
+Style/RedundantArgument:
+  Enabled: true
 
 # ============================== Lint ==============================
 Lint/DuplicateMethods:
@@ -247,3 +271,19 @@ Lint/UselessMethodDefinition:
   Enabled: true
 Lint/UselessTimes:
   Enabled: true
+Lint/DuplicateBranch:
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+Lint/EmptyBlock:
+  Enabled: true
+Lint/EmptyClass:
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
+Lint/ToEnumArguments:
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+Lint/UnexpectedBlockArity:
+  Enabled: true

data/CHANGELOG.md

@@ -1,3 +1,20 @@
+# 1.3.7
+* specify required ruby version [#10](https://github.com/shlima/click_house/issues/10)
+
+# 1.3.6
+* fix ruby 2.7 warning `maybe ** should be added to the call` on `ClickHouse.connection.databases`
+
+# 1.3.5
+* added `ClickHouse.connexction.explain("sql")` 
+
+# 1.3.4
+* added `ClickHouse.type_names(nullable: false)`
+* fixed `connection#create_table` column definitions
+* `ClickHouse.add_type` now handles Nullable types automatically
+
+# 1.3.3
+* fix logger typo
+
 # 1.3.2
 * fix null logger for windows users
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    click_house (1.3.2)
+    click_house (1.3.7)
       faraday
       faraday_middleware
 
@@ -18,42 +18,42 @@ GEM
       faraday (~> 1.0)
     method_source (1.0.0)
     multipart-post (2.1.1)
-    parallel (1.19.2)
+    parallel (1.20.1)
     parser (2.7.2.0)
       ast (~> 2.4.1)
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rainbow (3.0.0)
-    rake (13.0.1)
-    regexp_parser (1.8.2)
+    rake (13.0.3)
+    regexp_parser (2.0.1)
     rexml (3.2.4)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.3)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.0)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
-    rubocop (0.93.1)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.0)
+    rubocop (1.6.1)
       parallel (~> 1.10)
       parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 0.6.0)
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-ast (0.8.0)
+    rubocop-ast (1.3.0)
       parser (>= 2.7.1.5)
-    rubocop-performance (1.8.1)
-      rubocop (>= 0.87.0)
+    rubocop-performance (1.9.1)
+      rubocop (>= 0.90.0, < 2.0)
       rubocop-ast (>= 0.4.0)
     ruby-progressbar (1.10.1)
     ruby2_keywords (0.0.2)

data/README.md

@@ -2,12 +2,11 @@
 
 # ClickHouse Ruby driver
 
-[![pipeline status](https://travis-ci.com/shlima/click_house.svg?branch=master)](https://travis-ci.com/shlima/click_house)
+![CI](https://github.com/shlima/click_house/workflows/CI/badge.svg)
 [![Code Climate](https://codeclimate.com/github/shlima/click_house/badges/gpa.svg)](https://codeclimate.com/github/shlima/click_house)
 [![Gem Version](https://badge.fury.io/rb/click_house.svg)](https://badge.fury.io/rb/click_house)
 
 ```bash
-# Requires modern Ruby (>= 2.5), tested with Yandex.Clickhouse v 20.9.3.45
 gem install click_house
 ```
 
@@ -105,6 +104,11 @@ ClickHouse.connection.truncate_tables(['table_1', 'table_2'], if_exists: true, c
 ClickHouse.connection.truncate_tables # will truncate all tables in database
 ClickHouse.connection.rename_table('old_name', 'new_name', cluster: nil)
 ClickHouse.connection.rename_table(%w[table_1 table_2], %w[new_1 new_2], cluster: nil)
+
+ClickHouse.connection.select_all('SELECT * FROM visits')
+ClickHouse.connection.select_one('SELECT * FROM visits LIMIT 1')
+ClickHouse.connection.select_value('SELECT ip FROM visits LIMIT 1')
+ClickHouse.connection.explain('SELECT * FROM visits CROSS JOIN visits')
 ```
 
 ## Queries
@@ -346,7 +350,8 @@ data = @records.map do |record|
 end
 ```
 
-If native type supports arguments, define type with `%s` argument:
+If native type supports arguments, define *String* type with `%s` 
+argument and *Numeric* type with `%d` argument:
 
 ```ruby
 class DateTimeType
@@ -398,6 +403,10 @@ development:
 test:
   database: ecliptic_test
   <<: *default
+  
+production:
+  <<: *default
+  database: ecliptic_production
 ```
 
 ```ruby

data/click_house.gemspec

@@ -10,6 +10,7 @@ Gem::Specification.new do |spec|
   spec.summary       = 'Modern Ruby database driver for ClickHouse'
   spec.description   = 'Yandex ClickHouse database interface for Ruby'
   spec.homepage      = 'https://github.com/shlima/click_house'
+  spec.required_ruby_version = '>= 2.4.0'
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.

data/docker-compose.yml

@@ -2,7 +2,7 @@ version: '3.5'
 
 services:
   clickhouse:
-    image: yandex/clickhouse-server:20.9.3.45
+    image: yandex/clickhouse-server:20.12.3.3
     ports:
       - "8123:8123"
       - "9000:9000"

data/lib/click_house.rb

@@ -28,41 +28,33 @@ module ClickHouse
 
   %w[Date].each do |column|
     add_type column, Type::DateType.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::DateType.new)
   end
 
-  %w[String].each do |column|
+  %w[String FixedString(%d) UUID].each do |column|
     add_type column, Type::StringType.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::StringType.new)
   end
 
   ['DateTime(%s)'].each do |column|
     add_type column, Type::DateTimeType.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::DateTimeType.new)
   end
 
   ['DateTime64(%d, %s)'].each do |column|
     add_type column, Type::DateTime64Type.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::DateTime64Type.new)
   end
 
-  ['Decimal(%s, %s)', 'Decimal32(%s)', 'Decimal64(%s)', 'Decimal128(%s)'].each do |column|
+  ['Decimal(%d, %d)', 'Decimal32(%d)', 'Decimal64(%d)', 'Decimal128(%d)'].each do |column|
     add_type column, Type::DecimalType.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::DecimalType.new)
   end
 
   %w[UInt8 UInt16 UInt32 UInt64 Int8 Int16 Int32 Int64].each do |column|
     add_type column, Type::IntegerType.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::IntegerType.new)
   end
 
   %w[Float32 Float64].each do |column|
     add_type column, Type::FloatType.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::IntegerType.new)
   end
 
   %w[IPv4 IPv6].each do |column|
     add_type column, Type::IPType.new
-    add_type "Nullable(#{column})", Type::NullableType.new(Type::IPType.new)
   end
 end

data/lib/click_house/config.rb

@@ -2,10 +2,6 @@
 
 module ClickHouse
   class Config
-    DEFAULT_SCHEME = 'http'
-    DEFAULT_HOST = 'localhost'
-    DEFAULT_PORT = '8123'
-
     DEFAULTS = {
       adapter: Faraday.default_adapter,
       url: nil,

data/lib/click_house/connection.rb

@@ -8,6 +8,7 @@ module ClickHouse
     include Extend::ConnectionSelective
     include Extend::ConnectionInserting
     include Extend::ConnectionAltering
+    include Extend::ConnectionExplaining
 
     attr_reader :config
 

data/lib/click_house/definition/column_set.rb

@@ -3,17 +3,7 @@
 module ClickHouse
   module Definition
     class ColumnSet
-      TYPES = [
-        'UInt8', 'UInt16', 'UInt32', 'UInt64', 'Int8', 'Int16', 'Int32', 'Int64',
-        'Float32', 'Float64',
-        'Decimal(%d, %d)', 'Decimal32(%d)', 'Decimal64(%d)', 'Decimal128(%d)',
-        'String',
-        'FixedString(%d)',
-        'UUID',
-        'Date',
-        'IPv4', 'IPv6',
-        "DateTime('%s')", "DateTime64(%d, '%s')"
-      ].freeze
+      TYPES = ClickHouse.type_names(nullable: false).map { |s| s.sub('%s', "'%s'") }.freeze
 
       class << self
         # @input "DateTime('%s')"

data/lib/click_house/extend.rb

@@ -11,5 +11,6 @@ module ClickHouse
     autoload :ConnectionSelective, 'click_house/extend/connection_selective'
     autoload :ConnectionInserting, 'click_house/extend/connection_inserting'
     autoload :ConnectionAltering, 'click_house/extend/connection_altering'
+    autoload :ConnectionExplaining, 'click_house/extend/connection_explaining'
   end
 end

data/lib/click_house/extend/connection_explaining.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module ClickHouse
+  module Extend
+    module ConnectionExplaining
+      EXPLAIN = 'EXPLAIN'
+      EXPLAIN_RE = /\A(\s*#{EXPLAIN})/io.freeze
+
+      def explain(sql, io: $stdout)
+        res = execute("#{EXPLAIN} #{sql.gsub(EXPLAIN_RE, '')}")
+        io << res.body
+      end
+    end
+  end
+end

data/lib/click_house/extend/type_definition.rb

@@ -3,12 +3,21 @@
 module ClickHouse
   module Extend
     module TypeDefinition
+      NULLABLE = 'Nullable'
+      NULLABLE_RE = /#{NULLABLE}/i.freeze
+
       def types
         @types ||= Hash.new(Type::UndefinedType.new)
       end
 
-      def add_type(type, klass)
+      def add_type(type, klass, nullable: true)
         types[type] = klass
+        types["#{NULLABLE}(#{type})"] = Type::NullableType.new(klass) if nullable
+      end
+
+      # @return [Enum<String>]
+      def type_names(nullable:)
+        nullable ? types.keys : types.keys.grep_v(NULLABLE_RE)
       end
     end
   end

data/lib/click_house/middleware/logging.rb

@@ -34,7 +34,7 @@ module ClickHouse
 
         logger.info("\e[1mSQL (#{Util::Pretty.measure(elapsed)})\e[0m #{query};")
         logger.debug(body) if body
-        logger.info("\e[1mRead: #{summary.fetch(:read_rows)} rows, #{summary.fetch(:read_bytes)}. Written: #{summary.fetch(:written_rows)}, rows #{summary.fetch(:written_bytes)}\e[0m")
+        logger.info("\e[1mRead: #{summary.fetch(:read_rows)} rows, #{summary.fetch(:read_bytes)}. Written: #{summary.fetch(:written_rows)} rows, #{summary.fetch(:written_bytes)}\e[0m")
       end
       # rubocop:enable Layout/LineLength
 

data/lib/click_house/middleware/parse_csv.rb

@@ -10,7 +10,7 @@ module ClickHouse
       end
 
       define_parser do |body, parser_options|
-        CSV.parse(body, parser_options || {}) unless body.strip.empty?
+        CSV.parse(body, **Hash.new(parser_options)) unless body.strip.empty?
       end
     end
   end

data/lib/click_house/response/result_set.rb

@@ -8,6 +8,7 @@ module ClickHouse
 
       TYPE_ARGV_DELIM = ','
       NULLABLE = 'Nullable'
+      NULLABLE_TYPE_RE = /#{NULLABLE}\((.+)\)/i.freeze
 
       def_delegators :to_a,
                      :each, :fetch, :length, :count, :size, :first, :last, :[], :to_h
@@ -28,7 +29,7 @@ module ClickHouse
         # @input "Decimal(10, 5)"
         # @output "Decimal(%s, %s)"
         def extract_type_info(type)
-          type = type.gsub(/#{NULLABLE}\((.+)\)/i, '\1')
+          type = type.gsub(NULLABLE_TYPE_RE, '\1')
           nullable = Regexp.last_match(1)
           argv = []
 

data/lib/click_house/util/statement.rb

@@ -4,6 +4,7 @@ module ClickHouse
   module Util
     module Statement
       END_OF_STATEMENT = ';'
+      END_OF_STATEMENT_RE = /#{END_OF_STATEMENT}(\s+|\Z)/.freeze
 
       module_function
 
@@ -14,7 +15,7 @@ module ClickHouse
       def format(sql, format)
         return sql if sql.match?(/FORMAT/i)
 
-        "#{sql.sub(/#{END_OF_STATEMENT}(\s+|\Z)/, '')} FORMAT #{format};"
+        "#{sql.sub(END_OF_STATEMENT_RE, '')} FORMAT #{format};"
       end
     end
   end

data/lib/click_house/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ClickHouse
-  VERSION = '1.3.2'
+  VERSION = '1.3.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: click_house
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.7
 platform: ruby
 authors:
 - Aliaksandr Shylau
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-19 00:00:00.000000000 Z
+date: 2020-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -129,10 +129,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -158,6 +158,7 @@ files:
 - lib/click_house/extend/connectible.rb
 - lib/click_house/extend/connection_altering.rb
 - lib/click_house/extend/connection_database.rb
+- lib/click_house/extend/connection_explaining.rb
 - lib/click_house/extend/connection_healthy.rb
 - lib/click_house/extend/connection_inserting.rb
 - lib/click_house/extend/connection_selective.rb
@@ -202,7 +203,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/.travis.yml

@@ -1,16 +0,0 @@
-language: ruby
-
-rvm:
-  - 2.6.5
-
-services:
-  - docker
-
-before_install:
-  - docker pull yandex/clickhouse-server
-  - docker run -d -p 127.0.0.1:8123:8123 yandex/clickhouse-server
-  - bundle install
-
-script:
-  - bundle exec rubocop
-  - bundle exec rspec