click_house 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '09e50ef7cb07967ea5914134a09e8d58a10db772e6a1394d71d913a86303132f'
-  data.tar.gz: 0b2682492f1c6bf22be9f430111a700860bd69a140372761d60040c9a9e159f4
+  metadata.gz: 7cc9a21cc317327e783b02a5fd86dc4af9a8996cc9be80244074b5350db7de45
+  data.tar.gz: 69d8e8827f4c3cad0a5a05f0dbfddccc021a6f149905185406de3af671d989a3
 SHA512:
-  metadata.gz: e69ef08b15d94c9318e2c936d3be7b0a0a3ffc106ab10153d55bdd7267272a64672179be9ecfa630e96f1f3e23208df7fa639bfbeeb190019365cb4f677ce6d4
-  data.tar.gz: 12e5c562f99d4bbde45b10d78539a2c008f26a0373240273d644be83ee8772b6ad7031417b3cea9df1a286d69b23c33ee1594e8f0eb3f7ba282780d5cb183962
+  metadata.gz: 996d33f947b213b6c710275dc9b422fe2b46c0051ff08ea941f496bbbbf00dec6652c6c3310c059968219e35a4f2137386c41a194984ca83ea770ace158fdf8e
+  data.tar.gz: 0ab36517fb80d6ad07e34ff26a85469bd50f9c86d889e96ccc245a26de9980c72d45b9b6e59aef273a14c6314318a34820840d0d2c04821a6ca617b05100183f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    click_house (1.1.0)
+    click_house (1.2.0)
       faraday
       faraday_middleware
 

data/README.md

@@ -3,8 +3,11 @@
 # ClickHouse Ruby driver
 
 [![pipeline status](https://travis-ci.com/shlima/click_house.svg?branch=master)](https://travis-ci.com/shlima/click_house)
+[![Code Climate](https://codeclimate.com/github/shlima/click_house/badges/gpa.svg)](https://codeclimate.com/github/shlima/click_house)
+[![Gem Version](https://badge.fury.io/rb/click_house.svg)](https://badge.fury.io/rb/click_house)
 
 ```bash
+# Requires modern Ruby (>= 2.5), tested with Yandex.Clickhouse v 19.16.2.2
 gem install click_house
 ```
 
@@ -13,7 +16,7 @@ is a high-performance column-oriented database management system developed by
 [Yandex](https://yandex.com/company) which operates Russia's most popular search engine.
 
 > This development was inspired by currently [unmaintainable alternative](https://github.com/archan937/clickhouse)
-> but rewritten and well tested. Requires modern Ruby (>= 2.6) and Yandex ClickHouse
+> but rewritten and well tested
 
 ### Why use the HTTP interface and not the TCP interface?
 
@@ -22,13 +25,14 @@ Well, the developers of ClickHouse themselves [discourage](https://github.com/ya
 > TCP transport is more specific, we don't want to expose details.
 Despite we have full compatibility of protocol of different versions of client and server, we want to keep the ability to "break" it for very old clients. And that protocol is not too clean to make a specification.
 
+Yandex uses HTTP interface for working from Java and Perl, Python and Go as well as shell scripts. 
+
 # TOC
 
 * [Configuration](#configuration)
 * [Usage](#usage)
 * [Queries](#queries)
 * [Insert](#insert)
-* [Insert an Array](#insert-an-array)
 * [Create a table](#create-a-table)
 * [Alter table](#alter-table)
 * [Type casting](#type-casting)
@@ -181,24 +185,6 @@ ClickHouse.connection.insert('table', columns: %i[id name], values: [[1, 'Mercur
 #=> true
 ```
 
-## Insert an Array
-
-Serializing an Array of strings is pretty low level at the moment but it works (and thanks for that).
-Array of numeric types works as expected without pre-serialization   
-
-```ruby
-string_type = ClickHouse::Type::StringType.new
-array_of_string = ClickHouse::Type::ArrayType.new(string_type)
-
-data = [
-  { id: 1, tags: array_of_string.serialize(%w[ruby redis rails node]) }
-]
-
-subject.insert('rspec', columns: data.first.keys) do |buffer|
-  buffer.concat(data.map(&:values))
-end
-```
-
 ## Create a table
 ### Create table using DSL
 
@@ -296,7 +282,7 @@ ClickHouse.connection.alter_table('table', 'DROP COLUMN user_id', cluster: nil)
 # By SQL in a block
 ClickHouse.connection.alter_table('table', cluster: nil) do 
   <<~SQL
-    DROP COLUMN user_id
+    MOVE PART '20190301_14343_16206_438' TO VOLUME 'slow'
   SQL  
 end
 ```

data/lib/click_house/extend/connection_inserting.rb

@@ -5,8 +5,12 @@ module ClickHouse
     module ConnectionInserting
       def insert(table, columns:, values: [])
         yield(values) if block_given?
-        body = "#{columns.to_csv}#{values.map(&:to_csv).join('')}"
-        execute("INSERT INTO #{table} FORMAT CSVWithNames", body).success?
+
+        body = values.map do |value_row|
+          columns.zip(value_row).to_h.to_json
+        end
+
+        execute("INSERT INTO #{table} FORMAT JSONEachRow", body.join("\n")).success?
       end
     end
   end

data/lib/click_house/type/array_type.rb

@@ -5,8 +5,6 @@ module ClickHouse
     class ArrayType < BaseType
       attr_reader :subtype
 
-      STRING_QUOTE = "'"
-
       def initialize(subtype)
         @subtype = subtype
       end
@@ -16,22 +14,11 @@ module ClickHouse
       end
 
       def serialize(array, *argv)
-        return array unless string?
+        return unless array.is_a?(Array)
 
-        serialized = array.map do |value|
-          escaped = subtype.serialize(value, *argv).tr(STRING_QUOTE, '\\\\' + STRING_QUOTE)
-          format("%<quote>s#{escaped}%<quote>s", quote: STRING_QUOTE)
+        array.map do |value|
+          subtype.serialize(value, *argv)
         end
-
-        "[#{serialized.join(',')}]"
-      end
-
-      private
-
-      def string?
-        return @is_string if defined?(@is_string)
-
-        @is_string = subtype.is_a?(StringType) || subtype.is_a?(FixedStringType)
       end
     end
   end

data/lib/click_house/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ClickHouse
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: click_house
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Aliaksandr Shylau
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-10 00:00:00.000000000 Z
+date: 2019-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday