click_house-client 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27b81975f1f934997c497bd13dd33b01e9808f96640bea06bd79dbedb1fdaafd
-  data.tar.gz: 92534981627408a2654ea29bca98746e99c205064c3a8ecd863bc54a84662f9a
+  metadata.gz: f12c7192094a0cec94c354381b9be928dff901c03a9e8522dde43a695ce99b62
+  data.tar.gz: bedf93d6760663e747598c2cf9f60b90106b5d6979a7fe11dd00749cb03e4326
 SHA512:
-  metadata.gz: 730256f383d8a48927fe2a9a13541dacf6c63300a899c68e647d5457757b32db840e43eab17f2b19b02bed86582e5dbec8bbaa32d24215c5efa9f0c528b32169
-  data.tar.gz: '09e366a8fbb135fe7bb6eee89f7cdb98c3e91a70b350045cfebaeb2ec4db1bc459343e38d5eb902cc30ee1cba7b9ed2ddb10cb17e9726f791abe7dc1800e132b'
+  metadata.gz: 5fe06dbc303e5b94e72e84b0da50c96defa1be6445a77236ad29f49ed4283cb0e0d5ce147e5bafba671ac01d7064be5c3f0e4f80ff83ffe74eae7207f1b6a56e
+  data.tar.gz: a183e8f5081a5f1c4463e0b35c5fde96968023555c6b65ef4e5495a52650f747a224dfb468145cb3c5d5a55333e859398db6284952fec9c323f0bec3a4b6247e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    click_house-client (0.8.2)
+    click_house-client (0.8.3)
       activerecord (>= 7.0, < 9.0)
       activesupport (>= 7.0, < 9.0)
       addressable (~> 2.8)
@@ -136,7 +136,7 @@ CHECKSUMS
   benchmark (0.4.1) sha256=d4ef40037bba27f03b28013e219b950b82bace296549ec15a78016552f8d2cce
   bigdecimal (3.2.2) sha256=39085f76b495eb39a79ce07af716f3a6829bc35eb44f2195e2753749f2fa5adc
   byebug (12.0.0) sha256=d4a150d291cca40b66ec9ca31f754e93fed8aa266a17335f71bb0afa7fca1a1e
-  click_house-client (0.8.2)
+  click_house-client (0.8.3)
   concurrent-ruby (1.3.5) sha256=813b3e37aca6df2a21a3b9f1d497f8cbab24a2b94cab325bffe65ee0f6cbebc6
   connection_pool (2.5.3) sha256=cfd74a82b9b094d1ce30c4f1a346da23ee19dc8a062a16a85f58eab1ced4305b
   diff-lcs (1.5.0) sha256=49b934001c8c6aedb37ba19daec5c634da27b318a7a3c654ae979d6ba1929b67

data/lib/click_house/client/arel_visitor.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'active_record'
+
 module ClickHouse
   module Client
     class ArelVisitor < Arel::Visitors::ToSql

data/lib/click_house/client/query_builder.rb

@@ -29,8 +29,13 @@ module ClickHouse
         Arel::Nodes::As
       ].freeze
 
-      def initialize(table_name)
-        @table = Arel::Table.new(table_name)
+      def initialize(table, alias_name = nil)
+        @table = if table.is_a?(self.class) # subquery
+                   Arel::Nodes::TableAlias.new(table.to_arel, alias_name)
+                 else
+                   Arel::Table.new(table)
+                 end
+
         @manager = Arel::SelectManager.new(Arel::Table.engine).from(@table).project(Arel.star)
       end
 
@@ -315,7 +320,9 @@ module ClickHouse
       end
 
       def to_redacted_sql(bind_index_manager = ClickHouse::Client::BindIndexManager.new)
-        ClickHouse::Client::Redactor.redact(self, bind_index_manager)
+        visitor = ClickHouse::Client::ToRedactedSqlVisitor.new(ClickHouse::Client::ArelEngine.new,
+          bind_manager: bind_index_manager)
+        visitor.accept(manager.ast, Arel::Collectors::SQLString.new).value
       end
 
       def to_arel

data/lib/click_house/client/to_redacted_sql_visitor.rb

@@ -0,0 +1,118 @@
+# frozen_string_literal: true
+
+module ClickHouse
+  module Client
+    # Redacts the SQL query represented by the query builder.
+    #
+    # Example:
+    #   query_builder = ClickHouse::QueryBuilder.new('users').where(name: 'John Doe')
+    #   redacted_query = query_builder.to_redacted_sql
+    #   # The redacted_query will contain the SQL query with values replaced by placeholders.
+    #   output: "SELECT * FROM \"users\" WHERE \"users\".\"name\" = $1"
+    class ToRedactedSqlVisitor < ArelVisitor
+      attr_reader :bind_manager
+
+      def initialize(*args, bind_manager: ClickHouse::Client::BindIndexManager.new)
+        @bind_manager = bind_manager
+        super(*args)
+      end
+
+      private
+
+      def redaction_enabled?
+        !!@redaction_enabled
+      end
+
+      def collect_nodes_for(nodes, collector, spacer, *args)
+        return super unless spacer.strip.in?(%w[WHERE HAVING])
+
+        redaction_was = @redaction_enabled
+        @redaction_enabled = true
+        super
+        @redaction_enabled = redaction_was
+      end
+
+      # rubocop:disable Naming/MethodName -- following Arel::Visitors::Visitor pattern
+      # rubocop:disable Naming/MethodParameterName -- following Arel::Visitors::Visitor pattern
+
+      def visit_Arel_Nodes_In(o, collector)
+        return super unless redaction_enabled?
+
+        return super if o.right.is_a? Arel::Nodes::SelectStatement
+
+        super(redact_right(o), collector)
+      end
+
+      def visit_Arel_Nodes_Equality(o, collector)
+        return super unless redaction_enabled?
+
+        super(redact_right(o), collector)
+      end
+
+      def visit_Arel_Nodes_LessThan(o, collector)
+        return super unless redaction_enabled?
+
+        super(redact_right(o), collector)
+      end
+
+      def visit_Arel_Nodes_LessThanOrEqual(o, collector)
+        return super unless redaction_enabled?
+
+        super(redact_right(o), collector)
+      end
+
+      def visit_Arel_Nodes_GreaterThan(o, collector)
+        return super unless redaction_enabled?
+
+        super(redact_right(o), collector)
+      end
+
+      def visit_Arel_Nodes_GreaterThanOrEqual(o, collector)
+        return super unless redaction_enabled?
+
+        super(redact_right(o), collector)
+      end
+
+      def visit_Arel_Nodes_NamedFunction(o, collector)
+        return super unless redaction_enabled?
+
+        redacted_o = Arel::Nodes::NamedFunction.new(o.name, o.expressions.dup)
+
+        case redacted_o.name
+        when 'startsWith'
+          redacted_o.expressions[1] = Arel.sql(bind_manager.next_bind_str)
+        else
+          redacted_o.expressions = redacted_o.expressions.map do
+            Arel.sql(bind_manager.next_bind_str)
+          end
+        end
+
+        super(redacted_o, collector)
+      end
+
+      def visit_Arel_Nodes_Matches(o, collector)
+        return super unless redaction_enabled?
+
+        super(redact_right(o), collector)
+      end
+
+      def redact_right(o)
+        cloned_o = o.clone
+
+        redacted_right = if o.right.is_a?(Array)
+                           Array.new(o.right.size) do
+                             Arel.sql(bind_manager.next_bind_str)
+                           end
+                         else
+                           Arel.sql(bind_manager.next_bind_str)
+                         end
+
+        cloned_o.right = redacted_right
+        cloned_o
+      end
+
+      # rubocop:enable Naming/MethodName
+      # rubocop:enable Naming/MethodParameterName
+    end
+  end
+end

data/lib/click_house/client/version.rb

@@ -2,6 +2,6 @@
 
 module ClickHouse
   module Client
-    VERSION = "0.8.2"
+    VERSION = "0.8.3"
   end
 end

data/lib/click_house/client.rb

@@ -15,11 +15,11 @@ require_relative "client/quoting"
 require_relative "client/arel_engine"
 require_relative "client/query_like"
 require_relative "client/query"
-require_relative "client/redactor"
+require_relative "client/arel_visitor"
+require_relative "client/to_redacted_sql_visitor"
 require_relative "client/query_builder"
 require_relative "client/formatter"
 require_relative "client/response"
-require_relative "client/arel_visitor"
 
 module ClickHouse
   module Client

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: click_house-client
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - group::optimize
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-10-13 00:00:00.000000000 Z
+date: 2025-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -193,8 +193,8 @@ files:
 - lib/click_house/client/query_builder.rb
 - lib/click_house/client/query_like.rb
 - lib/click_house/client/quoting.rb
-- lib/click_house/client/redactor.rb
 - lib/click_house/client/response.rb
+- lib/click_house/client/to_redacted_sql_visitor.rb
 - lib/click_house/client/version.rb
 homepage: https://gitlab.com/gitlab-org/ruby/gems/clickhouse-client
 licenses:

data/lib/click_house/client/redactor.rb

@@ -1,93 +0,0 @@
-# frozen_string_literal: true
-
-module ClickHouse
-  module Client
-    module Redactor
-      class << self
-        # Redacts the SQL query represented by the query builder.
-        #
-        # @param query_builder [::ClickHouse::Querybuilder] The query builder object to be redacted.
-        # @return [String] The redacted SQL query as a string.
-        # @raise [ArgumentError] when the condition in the query is of an unsupported type.
-        #
-        # Example:
-        #   query_builder = ClickHouse::QueryBuilder.new('users').where(name: 'John Doe')
-        #   redacted_query = ClickHouse::Redactor.redact(query_builder)
-        #   # The redacted_query will contain the SQL query with values replaced by placeholders.
-        #   output: "SELECT * FROM \"users\" WHERE \"users\".\"name\" = $1"
-        def redact(query_builder, bind_manager = ClickHouse::Client::BindIndexManager.new)
-          redacted_constraints = query_builder.manager.constraints.map do |constraint|
-            redact_constraint(constraint, bind_manager)
-          end
-
-          cloned_query_builder = query_builder.clone
-
-          cloned_query_builder.manager.constraints.clear
-          redacted_constraints.each do |constraint|
-            cloned_query_builder.manager.where(constraint)
-          end
-
-          cloned_query_builder.to_sql
-        end
-
-        private
-
-        def redact_constraint(constraint, bind_manager)
-          case constraint
-          when Arel::Nodes::In
-            if constraint.right.is_a? Arel::Nodes::SelectStatement
-              constraint.left.in(redact_select_statement(constraint.right, bind_manager))
-            else
-              constraint.left.in(Array.new(constraint.right.size) { Arel.sql(bind_manager.next_bind_str) })
-            end
-          when Arel::Nodes::Equality
-            constraint.left.eq(Arel.sql(bind_manager.next_bind_str))
-          when Arel::Nodes::LessThan
-            constraint.left.lt(Arel.sql(bind_manager.next_bind_str))
-          when Arel::Nodes::LessThanOrEqual
-            constraint.left.lteq(Arel.sql(bind_manager.next_bind_str))
-          when Arel::Nodes::GreaterThan
-            constraint.left.gt(Arel.sql(bind_manager.next_bind_str))
-          when Arel::Nodes::GreaterThanOrEqual
-            constraint.left.gteq(Arel.sql(bind_manager.next_bind_str))
-          when Arel::Nodes::NamedFunction
-            redact_named_function(constraint, bind_manager)
-          when Arel::Nodes::Matches
-            constraint.left.matches(Arel.sql(bind_manager.next_bind_str), constraint.escape, constraint.case_sensitive)
-          else
-            raise ArgumentError, "Unsupported Arel node type for Redactor: #{constraint.class}"
-          end
-        end
-
-        def redact_named_function(constraint, bind_manager)
-          redacted_constraint =
-            Arel::Nodes::NamedFunction.new(constraint.name, constraint.expressions.dup)
-
-          case redacted_constraint.name
-          when 'startsWith'
-            redacted_constraint.expressions[1] = Arel.sql(bind_manager.next_bind_str)
-          else
-            redacted_constraint.expressions = redacted_constraint.expressions.map do
-              Arel.sql(bind_manager.next_bind_str)
-            end
-          end
-
-          redacted_constraint
-        end
-
-        def redact_select_statement(select_statement, bind_manager)
-          cloned_statement = select_statement.clone
-          cloned_statement.cores.map! do |select_core|
-            select_core.wheres = select_core.wheres.map do |where|
-              redact_constraint(where, bind_manager)
-            end
-
-            select_core
-          end
-
-          cloned_statement
-        end
-      end
-    end
-  end
-end