cleo_quality_review 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3ef174aa218590b9a2f32114c94e9ef21c73d6809e87524750d66adc70562f0b
-  data.tar.gz: d25eae8497f8b87506231b4586614729b58b93634c3ed37a935d5029abcd3056
+  metadata.gz: 2f7c748370590a154e611c6302e8bbfd9e5c3f8dc1b756e938ccba09101b6ee5
+  data.tar.gz: 85e837b45af4b31c23e9f59d613653a481a5e172da0581df8edc96945c4f409c
 SHA512:
-  metadata.gz: a3c8d5bf0d7748a797b7c82c74ff5f1e914147b16b45b13e342e49268eb5e355dcb9885953725c16f118254ff48c728782289fcf291c49478ca0aca002f071bd
-  data.tar.gz: 436193715042ed3165c0ecf04026a70e0681a96bbd5bb6adc9c842662ae405e8b5409b408c5597c21884590374b1029ef94c3230bded8667117c978511d40ce9
+  metadata.gz: 7f5f53a18a2cd9ef9e6e7c3456b416d4b2f0dcab0d36d3c4d75e70c1c97bb408659918c89d57ab284faf05e7111cd06f0fc39f34f1be0d08f611f48945fe9ace
+  data.tar.gz: dabda2763af548f1ef2be712d6b3a0ec8ca1ca03330a249ea91b35972176a3f37785677dd39334ff207aae8374d586358a0c1c3a1a402f0e9ac94ab1c4dadff5

data/cleo_quality_review.gemspec

@@ -24,7 +24,6 @@ Gem::Specification.new do |spec|
   spec.executables = ["check_quality"]
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "debride"
   spec.add_dependency "fasterer"
   spec.add_dependency "flog"
   spec.add_dependency "reek"

data/lib/cleo_quality_review/checks.rb

@@ -9,7 +9,6 @@ module CleoQualityReview
     require_relative "checks/reek"
     require_relative "checks/flog"
     require_relative "checks/fasterer"
-    require_relative "checks/debride"
 
     class << self
       ##

data/lib/cleo_quality_review/options.rb

@@ -120,7 +120,7 @@ module CleoQualityReview
     end
 
     def register_checks_option(opts)
-      opts.on("-c", "--checks CHECKS", Array, "Checks to run: all, reek, flog, fasterer, debride") { |values| checks.concat(values) }
+      opts.on("-c", "--checks CHECKS", Array, "Checks to run: all, reek, flog, fasterer") { |values| checks.concat(values) }
     end
 
     def register_only_option(opts)
@@ -128,7 +128,7 @@ module CleoQualityReview
     end
 
     def register_exclude_option(opts)
-      opts.on("-x", "--exclude CHECKS", Array, "Checks to exclude: reek, flog, fasterer, debride") { |values| exclude.concat(values) }
+      opts.on("-x", "--exclude CHECKS", Array, "Checks to exclude: reek, flog, fasterer") { |values| exclude.concat(values) }
     end
 
     def register_target_options(opts)

data/lib/cleo_quality_review/version.rb

@@ -3,5 +3,5 @@
 module CleoQualityReview
   ##
   # Gem version
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/cleo_quality_review.rb

@@ -14,7 +14,6 @@ module CleoQualityReview
   Checks.register("Reek", Checks::Reek, tool_type: :smell_detection)
   Checks.register("Flog", Checks::Flog, tool_type: :complexity)
   Checks.register("Fasterer", Checks::Fasterer, tool_type: :performance)
-  Checks.register("Debride", Checks::Debride, tool_type: :dead_code)
 
   ##
   # Register all supported LLM APIs for formatting output here

data/prompts/agent.md

@@ -7,7 +7,6 @@ Analyze the raw tool outputs and git diff provided. Prioritize actionable issues
 - **Flog**: Ignore scores below 40.0
 - **Reek**: Focus on FeatureEnvy, TooManyStatements, DuplicateMethodCall, NestedIterators, LongParameterList
 - **Fasterer**: Include all performance suggestions
-- **Debride**: Treat as lower-confidence static dead-code detection. Include only findings that are clearly actionable and avoid recommending deletion without checking dynamic call paths.
 
 ## Output Format
 
@@ -21,7 +20,7 @@ Output valid JSON matching this exact schema:
     "target_files": [<file paths from metadata>],
     "findings": [
       {
-        "tool_name": "<reek|flog|fasterer|debride>",
+        "tool_name": "<reek|flog|fasterer>",
         "tool_type": "<smell_detection|complexity|performance|dead_code>",
         "check": "<specific check type>",
         "filepath": "<relative file path>",
@@ -33,7 +32,7 @@ Output valid JSON matching this exact schema:
   "check_outputs": [
     {
       "check_name": "<check name>",
-      "tool_name": "<reek|flog|fasterer|debride>",
+      "tool_name": "<reek|flog|fasterer>",
       "tool_type": "<smell_detection|complexity|performance|dead_code>",
       "extension": "<json|txt>",
       "path": "<raw output artifact path>",

data/prompts/github.md

@@ -17,10 +17,6 @@ Reek:
 Fasterer:
   Severity: Low
 
-Debride:
-  Severity: Low
-  Notes: Lower-confidence static dead-code signal. Only report when the finding is specific, actionable, and unlikely to be a dynamic Rails call.
-
 
 You MUST NOT return so many items that the feedback is noisy and confusing. Limit yourself to maximum 10 comments.
 

data/prompts/human.md

@@ -1,10 +1,10 @@
 You are reviewing a local code change for code quality.
 
-The files provided include git diffs for local code changes, as well as generated output files from various code quality assessment tools including (but not limited to) Reek, Flog, Fasterer, Debride, etc.
+The files provided include git diffs for local code changes, as well as generated output files from various code quality assessment tools including (but not limited to) Reek, Flog, Fasterer, etc.
 
 Your task is to parse the static output files generated by these tools, and provide feedback to the human user. The diff provided is to allow you to map tool output to changes in the code. 
 
-YOU MUST NOT comment on the code diff itself, unless the comment is in relatinon to an issue reported by a tool.
+YOU MUST NOT comment on the code diff itself, unless the comment is in relation to an issue reported by a tool.
 
 Prioritize issues that are likely to matter to maintainability, correctness, readability, or long-term ownership. 
 
@@ -12,9 +12,8 @@ Avoid repeating tool output mechanically. If multiple issues of the same sort ar
 
 If a tool finding is low value or likely a false positive, say so briefly or omit it.
 
-Debride findings are lower-confidence static dead-code candidates. Do not recommend deleting code unless the finding is clearly supported by the changed code and dynamic call paths have been considered.
 
-The output will be printed in a unix terminal, and so colour-coded feedback is preferrable.
+The output will be printed in a Unix terminal, and so colour-coded feedback is preferable.
 
 1. Highest-impact issues first, with file and line references as clickable links when available.
 2. Suggested changes that are specific enough for an engineer or coding agent to implement.

data/prompts/pr_review.md

@@ -1,6 +1,6 @@
 You are the pipeline interface between code quality tools and GitHub pull request review comments.
 
-You will collate data from code quality tools including Reek, Flog, Fasterer, and Debride. The raw output is noisy, so your job is to identify only the most useful comments for the engineer whose PR triggered this flow.
+You will collate data from code quality tools including Reek, Flog, and Fasterer. The raw output is noisy, so your job is to identify only the most useful comments for the engineer whose PR triggered this flow.
 
 You MUST NOT comment on the code diff itself unless the comment is directly supported by a tool finding.
 
@@ -9,7 +9,6 @@ You MUST NOT comment on the code diff itself unless the comment is directly supp
 - **Flog**: Ignore scores below 40.0. Prioritize high-complexity methods because they are the most expensive to maintain.
 - **Reek**: Prefer actionable smells such as FeatureEnvy, TooManyStatements, DuplicateMethodCall, NestedIterators, and LongParameterList.
 - **Fasterer**: Low severity. Include only when the finding is clearly on code changed by this PR and the fix is straightforward.
-- **Debride**: Lower-confidence static dead-code signal. Include only when the candidate method is clearly made obsolete by this PR, and do not suggest deletion without noting possible dynamic Rails calls.
 
 ## Comment Selection
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cleo_quality_review
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Gavin Morrice
@@ -9,20 +9,6 @@ bindir: exe
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: debride
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: fasterer
   requirement: !ruby/object:Gem::Requirement
@@ -80,7 +66,6 @@ files:
 - lib/cleo_quality_review.rb
 - lib/cleo_quality_review/changes_diff.rb
 - lib/cleo_quality_review/checks.rb
-- lib/cleo_quality_review/checks/debride.rb
 - lib/cleo_quality_review/checks/fasterer.rb
 - lib/cleo_quality_review/checks/flog.rb
 - lib/cleo_quality_review/checks/quality_check.rb

data/lib/cleo_quality_review/checks/debride.rb

@@ -1,65 +0,0 @@
-# frozen_string_literal: true
-
-require "json"
-
-require_relative "quality_check"
-
-module CleoQualityReview
-  module Checks
-    ##
-    # Quality check implementation for Debride unused-code analyzer
-    class Debride < QualityCheck
-      self.check_name = "dead_code"
-      self.tool_name = "debride"
-      self.output_extension = "json"
-
-      private
-
-      def command(files)
-        [ruby_executable, gem_executable("debride", "debride"), "--json", "--rails", *files]
-      end
-
-      def parse(stdout, stderr)
-        findings = missing_methods(stdout).flat_map do |class_name, methods|
-          results_for_class(class_name, methods)
-        end
-        return findings unless findings.empty? && stderr.to_s.strip != ""
-
-        [result(check: "Execution error", message: stderr, filepath: nil)]
-      end
-
-      def missing_methods(stdout)
-        parsed = JSON.parse(stdout.to_s)
-        missing = parsed.fetch("missing", {})
-        return {} unless missing.is_a?(Hash)
-
-        missing
-      rescue JSON::ParserError
-        {}
-      end
-
-      def results_for_class(class_name, methods)
-        Array(methods).map { |entry| method_to_result(class_name, entry) }
-      end
-
-      def method_to_result(class_name, entry)
-        method_name, location = Array(entry)
-        filepath, line = parse_location(location)
-
-        result(
-          check: "PotentialDeadMethod",
-          message: "#{class_name}##{method_name} might not be called",
-          filepath: filepath,
-          line: line,
-        )
-      end
-
-      def parse_location(location)
-        match = location.to_s.match(/\A(?<filepath>.*):(?<line>\d+)(?:-\d+)?\z/)
-        return [nil, nil] unless match
-
-        match.values_at(:filepath, :line)
-      end
-    end
-  end
-end