clearance 2.9.1 → 2.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3164482da14d878bfca32632ebbabf81635add8143adaca1be3baa7ec41cd83
-  data.tar.gz: 037f0f5a5c30f3022b0d29a9c100e40538c0b176b4935c061ec96c469d8c3ca9
+  metadata.gz: 63e1102563fe30d25f825d35b7b9cfb97e9c7a63966350d249550786301aef68
+  data.tar.gz: 0445a9f0883f00671b612e6bddb07adcba4f5d1ba0b42946ecd5aee9eac3cb1f
 SHA512:
-  metadata.gz: 5b889666cb2a46f6bfdcf41b9aaf9c7f0414b986f07ab4f31bb4846d3b4ef900f3d6076d50d9f8463657033488b118472d9e8dace8c4786aadd0f2999f5b2bed
-  data.tar.gz: 0fbc755f11f689843852ef18201963d0d56be06b8bf22326e82d2c83162d092ade4af85dfff3469867e0cf3937f545351a84b83425094cfb064d3466c361dd7c
+  metadata.gz: 90f4330cc836c066594314824eb212bdf463ce7187803bc99123d30bf59b5223298d390af5bea1891199d126692c679682382b59e320ea7e1ad27d979e03a90f
+  data.tar.gz: 23f8e1faebcadf721cfd2434b4ef61f05fc3d17b4374ea6830ae612905c730d6939bb87a495ff9fd191a9a5d84143d0a74f42b23bf064b7fc5d954a58cbfc0f1

data/.github/workflows/tests.yml

@@ -19,10 +19,14 @@ jobs:
           - "7.0"
           - "7.1"
           - "7.2"
+          - "8.0"
         ruby:
           - "3.1.6"
           - "3.2.5"
           - "3.3.5"
+        exclude:
+          - ruby: "3.1.6"
+            gemfile: "8.0"
 
     env:
       BUNDLE_GEMFILE: gemfiles/rails_${{ matrix.gemfile }}.gemfile

data/Appraisals

@@ -14,3 +14,8 @@ end
 appraise "rails_7.2" do
   gem "railties", "~> 7.2.0"
 end
+
+appraise "rails_8.0" do
+  gem "railties", "~> 8.0.0"
+  gem 'sqlite3', '>= 2.1'
+end

data/CHANGELOG.md

@@ -5,11 +5,23 @@ complete changelog, see the git history for each version via the version links.
 
 ## [Unreleased]
 
-[Unreleased]: https://github.com/thoughtbot/clearance/compare/v2.9.1...main
+[Unreleased]: https://github.com/thoughtbot/clearance/compare/v2.9.3...main
+
+## [2.9.3] - November 26, 2024
+- Add Rails 8 to testing matrix (#1038) Hamed Asghari
+
+[2.9.3]: https://github.com/thoughtbot/clearance/compare/v2.9.2...v2.9.3
+
+## [2.9.2] - November 14, 2024
+- Fix query params being clobbered by Clearance::BackDoor (#1041) Frederick Cheung
+
+[2.9.2]: https://github.com/thoughtbot/clearance/compare/v2.9.1...v2.9.2
 
 ## [2.9.1] - October 29, 2024
  - Update gemspec
 
+[2.9.1]: https://github.com/thoughtbot/clearance/compare/v2.9.0...v2.9.1
+
 ## [2.9.0] - October 29, 2024
 - Added Rails 7.2 and Ruby 3.3 to testing matrix
   and overhauled dummy app (#1032) Hamed Asghari

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    clearance (2.9.1)
+    clearance (2.9.3)
       actionmailer (>= 5.0)
       activemodel (>= 5.0)
       activerecord (>= 5.0)
@@ -101,7 +101,7 @@ GEM
       activerecord (>= 5.a)
       database_cleaner-core (~> 2.0.0)
     database_cleaner-core (2.0.1)
-    date (3.3.4)
+    date (3.4.0)
     diff-lcs (1.5.1)
     drb (2.2.1)
     email_validator (2.2.4)
@@ -147,7 +147,7 @@ GEM
     mini_mime (1.1.5)
     mini_portile2 (2.8.7)
     minitest (5.25.1)
-    net-imap (0.5.0)
+    net-imap (0.5.1)
       date
       net-protocol
     net-pop (0.1.2)

data/Rakefile

@@ -21,7 +21,7 @@ end
 
 desc "Lint ERB templates"
 task :erb_lint do
-  sh("bundle", "exec", "erblint", "app/views/**/*.erb")
+  sh("bundle", "exec", "erb_lint", "app/views/**/*.erb")
 end
 
 desc "Run the specs and acceptance tests"

data/gemfiles/rails_8.0.gemfile

@@ -0,0 +1,20 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "addressable"
+gem "ammeter"
+gem "appraisal"
+gem "capybara"
+gem "database_cleaner"
+gem "erb_lint", require: false
+gem "factory_bot_rails"
+gem "nokogiri"
+gem "pry", require: false
+gem "rails-controller-testing"
+gem "rspec-rails"
+gem "shoulda-matchers"
+gem "sqlite3", ">= 2.1"
+gem "railties", "~> 8.0.0"
+
+gemspec path: "../"

data/lib/clearance/back_door.rb

@@ -54,7 +54,6 @@ module Clearance
       if user_param.present?
         query_string = Rack::Utils.build_query(params)
         env[Rack::QUERY_STRING] = query_string
-        env[Rack::RACK_REQUEST_QUERY_STRING] = query_string
         user = find_user(user_param)
         env[:clearance].sign_in(user)
       end

data/lib/clearance/version.rb

@@ -1,3 +1,3 @@
 module Clearance
-  VERSION = "2.9.1".freeze
+  VERSION = "2.9.3".freeze
 end

data/spec/dummy/app/controllers/application_controller.rb

@@ -2,6 +2,6 @@ class ApplicationController < ActionController::Base
   include Clearance::Controller
 
   def show
-    render inline: "Hello user #<%= current_user.id %>", layout: false
+    render inline: "Hello user #<%= current_user.id %> #{params.to_json}", layout: false
   end
 end

data/spec/requests/backdoor_spec.rb

@@ -8,4 +8,12 @@ describe "Backdoor Middleware" do
 
     expect(cookies["remember_token"]).to eq user.remember_token
   end
+
+  it "removes the `as` param but leaves other parameters unchanged" do
+    user = create(:user)
+
+    get root_path(as: user.to_param, foo: 'bar')
+
+    expect(response.body).to include('{"foo":"bar","controller":"application","action":"show"}')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clearance
 version: !ruby/object:Gem::Version
-  version: 2.9.1
+  version: 2.9.3
 platform: ruby
 authors:
 - Dan Croak
@@ -27,7 +27,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-29 00:00:00.000000000 Z
+date: 2024-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcrypt
@@ -146,7 +146,7 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
-- ".erb-lint.yml"
+- ".erb_lint.yml"
 - ".github/dependabot.yml"
 - ".github/workflows/dynamic-readme.yml"
 - ".github/workflows/dynamic-security.yml"
@@ -188,6 +188,7 @@ files:
 - gemfiles/rails_7.0.gemfile
 - gemfiles/rails_7.1.gemfile
 - gemfiles/rails_7.2.gemfile
+- gemfiles/rails_8.0.gemfile
 - lib/clearance.rb
 - lib/clearance/authentication.rb
 - lib/clearance/authorization.rb
@@ -324,7 +325,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Rails authentication & authorization with email & password.