clearance 2.9.0 → 2.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea787197f1c05708009b5318ed67814d74c11de000e314d87d0d2f9278722ea7
-  data.tar.gz: 9def5796663a629edecd2a9ad34aadb3b3430d4f00b4ba1017259bc929321911
+  metadata.gz: d073db2741ab71668d850e8dbaf90ca72b53e3e5a89d3f559b81f8f134e97f21
+  data.tar.gz: 040fa25f6c685961366b26c9ea6a5889885aee3e17969459aa902db2355160c8
 SHA512:
-  metadata.gz: 374df1a9550bb8379625497e010c79d264e328d9763341e6c5a1e1e01a42d3085650b5872d92df32a14d06c1d88f82ae9bcb4912ab717790800bce9237847c4a
-  data.tar.gz: 370f291a30b646bb3afcf9bc27fdccf13facec4c9663e44d4efbab0006430066891849c77fe788225a8145636507a8a03ac6360d3e195d7f7f304d8270a28054
+  metadata.gz: cc224586b281768a92734b9d56eaedb0788de1b894f5fbaebff4d7eb0414cfcfb90286db50206bb060fad8ec26cd9aabd9f8f8dff94253832e6b9576c86347d7
+  data.tar.gz: 279be8bc4d4d5024dd14103de0d9feac00b483364200b4cf0edda9b2a9098360f0ba8a19d9b6fe590200463d7458e291d7980a59a618628fc7b1c72d98b8e001

data/CHANGELOG.md

@@ -5,7 +5,17 @@ complete changelog, see the git history for each version via the version links.
 
 ## [Unreleased]
 
-[Unreleased]: https://github.com/thoughtbot/clearance/compare/v2.9.0...main
+[Unreleased]: https://github.com/thoughtbot/clearance/compare/v2.9.2...main
+
+## [2.9.2] - November 14, 2024
+- Fix query params being clobbered by Clearance::BackDoor (#1041) Frederick Cheung
+
+[2.9.2]: https://github.com/thoughtbot/clearance/compare/v2.9.1...v2.9.2
+
+## [2.9.1] - October 29, 2024
+ - Update gemspec
+
+[2.9.1]: https://github.com/thoughtbot/clearance/compare/v2.9.0...v2.9.1
 
 ## [2.9.0] - October 29, 2024
 - Added Rails 7.2 and Ruby 3.3 to testing matrix

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    clearance (2.8.0)
+    clearance (2.9.2)
       actionmailer (>= 5.0)
       activemodel (>= 5.0)
       activerecord (>= 5.0)
@@ -147,7 +147,7 @@ GEM
     mini_mime (1.1.5)
     mini_portile2 (2.8.7)
     minitest (5.25.1)
-    net-imap (0.4.14)
+    net-imap (0.5.0)
       date
       net-protocol
     net-pop (0.1.2)

data/clearance.gemspec

@@ -1,13 +1,13 @@
 require_relative 'lib/clearance/version'
 
 Gem::Specification.new do |s|
-  s.add_dependency 'bcrypt', '~> 3.1', '>= 3.1.1'
+  s.add_dependency 'bcrypt', '>= 3.1.1'
   s.add_dependency 'argon2', '~> 2.0', '>= 2.0.2'
   s.add_dependency 'email_validator', '~> 2.0'
-  s.add_dependency 'railties', '~> 5.0'
-  s.add_dependency 'activemodel', '~> 5.0'
-  s.add_dependency 'activerecord', '~> 5.0'
-  s.add_dependency 'actionmailer', '~> 5.0'
+  s.add_dependency 'railties', '>= 5.0'
+  s.add_dependency 'activemodel', '>= 5.0'
+  s.add_dependency 'activerecord', '>= 5.0'
+  s.add_dependency 'actionmailer', '>= 5.0'
   s.authors = [
     'Dan Croak',
     'Eugene Bolshakov',

data/lib/clearance/back_door.rb

@@ -54,7 +54,6 @@ module Clearance
       if user_param.present?
         query_string = Rack::Utils.build_query(params)
         env[Rack::QUERY_STRING] = query_string
-        env[Rack::RACK_REQUEST_QUERY_STRING] = query_string
         user = find_user(user_param)
         env[:clearance].sign_in(user)
       end

data/lib/clearance/version.rb

@@ -1,3 +1,3 @@
 module Clearance
-  VERSION = "2.9.0".freeze
+  VERSION = "2.9.2".freeze
 end

data/spec/dummy/app/controllers/application_controller.rb

@@ -2,6 +2,6 @@ class ApplicationController < ActionController::Base
   include Clearance::Controller
 
   def show
-    render inline: "Hello user #<%= current_user.id %>", layout: false
+    render inline: "Hello user #<%= current_user.id %> #{params.to_json}", layout: false
   end
 end

data/spec/requests/backdoor_spec.rb

@@ -8,4 +8,12 @@ describe "Backdoor Middleware" do
 
     expect(cookies["remember_token"]).to eq user.remember_token
   end
+
+  it "removes the `as` param but leaves other parameters unchanged" do
+    user = create(:user)
+
+    get root_path(as: user.to_param, foo: 'bar')
+
+    expect(response.body).to include('{"foo":"bar","controller":"application","action":"show"}')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: clearance
 version: !ruby/object:Gem::Version
-  version: 2.9.0
+  version: 2.9.2
 platform: ruby
 authors:
 - Dan Croak
@@ -27,15 +27,12 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-29 00:00:00.000000000 Z
+date: 2024-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcrypt
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.1
@@ -43,9 +40,6 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.1
@@ -87,56 +81,56 @@ dependencies:
   name: railties
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
   name: actionmailer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
 description: |2