clearance 0.8.3 → 0.8.4

data/CHANGELOG.textile

@@ -1,3 +1,10 @@
+h2. 0.8.4
+
+* [#48] remove unnecessary require 'factory_girl' in generator (Dan Croak)
+* reference gemcutter (not github) as the gem source in README (Dan Croak)
+* add IRC, rdoc.info links to README (Dan Croak)
+* move user confirmation email trigger into model (Chad Pytel)
+
 h2. 0.8.3 (09/21/2009)
 
 * [#27] remove class_eval in Clearance::Authentication. (Anuj Dutta)

data/README.textile

@@ -4,6 +4,16 @@ Rails authentication with email & password.
 
 "We have clearance, Clarence.":http://www.youtube.com/v/mNRXJEE3Nz8
 
+h2. Help
+
+* "#thoughtbot":irc://irc.freenode.net/thoughtbot IRC channel on freenode
+* "documentation":http://rdoc.info/projects/thoughtbot/clearance
+* "mailing list":http://groups.google.com/group/thoughtbot-clearance
+
+h2. Bugs, Patches
+
+Fork away and create a "Github Issue":http://github.com/thoughtbot/clearance/issues. Please don't send pull requests.
+
 h2. Suspenders
 
 Clearance is included in "Suspenders":http://github.com/thoughtbot/suspenders, which thoughtbot uses on all of our apps. We highly recommend you try it. Suspenders is the "King Gem" in our ecosystem, representing what we think the current state-of-the-art is in Rails development.
@@ -15,10 +25,10 @@ Clearance is a Rails engine. It works with versions of Rails greater than 2.3.
 In config/environment.rb:
 
 <pre>
-config.gem "thoughtbot-clearance",
+config.gem "clearance",
   :lib     => 'clearance',
-  :source  => 'http://gems.github.com',
-  :version => '0.8.2'
+  :source  => 'http://gemcutter.org',
+  :version => '0.8.3'
 </pre>
 
 Vendor the gem:
@@ -111,14 +121,5 @@ h2. Authors
 
 Clearance was extracted out of "Hoptoad":http://hoptoadapp.com. We merged the authentication code from two of thoughtbot's clients' Rails apps and have since used it each time we need authentication. The following people have improved the library. Thank you!
 
-Dan Croak, Mike Burns, Jason Morrison, Joe Ferris, Eugene Bolshakov, Nick Quaranto, Josh Nichols, Mike Breen, Marcel Görner, Bence Nagy, Ben Mabey, Eloy Duran, Tim Pope, Mihai Anca, Mark Cornick, Shay Arnett, Joshua Clayton, Mustafa Ekim, Jon Yurek, & Anuj Dutta.
-
-h2. Questions?
-
-Ask the "mailing list":http://groups.google.com/group/thoughtbot-clearance
-
-h2. Suggestions, Bugs, Refactoring?
-
-Fork away and create a "Github Issue":http://github.com/thoughtbot/clearance/issues. Please don't send pull requests.
-
+Dan Croak, Mike Burns, Jason Morrison, Joe Ferris, Eugene Bolshakov, Nick Quaranto, Josh Nichols, Mike Breen, Marcel Görner, Bence Nagy, Ben Mabey, Eloy Duran, Tim Pope, Mihai Anca, Mark Cornick, Shay Arnett, Joshua Clayton, Mustafa Ekim, Jon Yurek, Anuj Dutta, and Chad Pytel.
 

data/Rakefile

@@ -80,7 +80,7 @@ task :default => ['test:basic', 'test:features',
 
 gem_spec = Gem::Specification.new do |gem_spec|
   gem_spec.name        = "clearance"
-  gem_spec.version     = "0.8.3"
+  gem_spec.version     = "0.8.4"
   gem_spec.summary     = "Rails authentication with email & password."
   gem_spec.email       = "support@thoughtbot.com"
   gem_spec.homepage    = "http://github.com/thoughtbot/clearance"
@@ -90,7 +90,7 @@ gem_spec = Gem::Specification.new do |gem_spec|
                           "Josh Nichols", "Mike Breen", "Marcel Görner",
                           "Bence Nagy", "Ben Mabey", "Eloy Duran",
                           "Tim Pope", "Mihai Anca", "Mark Cornick",
-                          "Shay Arnett", "Jon Yurek"]
+                          "Shay Arnett", "Jon Yurek", "Chad Pytel"]
   gem_spec.files       = FileList["[A-Z]*", "{app,config,generators,lib,shoulda_macros,rails}/**/*"]
 end
 

data/app/controllers/clearance/users_controller.rb

@@ -12,7 +12,6 @@ class Clearance::UsersController < ApplicationController
   def create
     @user = ::User.new params[:user]
     if @user.save
-      ::ClearanceMailer.deliver_confirmation @user
       flash_notice_after_create
       redirect_to(url_after_create)
     else

data/generators/clearance/clearance_generator.rb

@@ -1,6 +1,5 @@
 require File.expand_path(File.dirname(__FILE__) + "/lib/insert_commands.rb")
 require File.expand_path(File.dirname(__FILE__) + "/lib/rake_commands.rb")
-require 'factory_girl'
 
 class ClearanceGenerator < Rails::Generator::Base
 

data/generators/clearance_features/templates/features/step_definitions/clearance_steps.rb

@@ -63,11 +63,13 @@ end
 
 Then /^a password reset message should be sent to "(.*)"$/ do |email|
   user = User.find_by_email(email)
-  sent = ActionMailer::Base.deliveries.first
-  assert_equal [user.email], sent.to
-  assert_match /password/i, sent.subject
+  assert !ActionMailer::Base.deliveries.empty?
+  ActionMailer::Base.deliveries.any? do |email|
+    email.to == user.email && 
+    email.subject =~ /password/i &&
+    email.body =~ /#{user.confirmation_token}/
+  end
   assert !user.confirmation_token.blank?
-  assert_match /#{user.confirmation_token}/, sent.body
 end
 
 When /^I follow the password reset link sent to "(.*)"$/ do |email|

data/lib/clearance/user.rb

@@ -86,6 +86,8 @@ module Clearance
           before_save :initialize_salt,
                       :encrypt_password,
                       :initialize_confirmation_token
+
+          after_create :send_confirmation_email, :unless => :email_confirmed?
         end
       end
     end
@@ -180,6 +182,10 @@ module Clearance
       def password_required?
         encrypted_password.blank? || !password.blank?
       end
+
+      def send_confirmation_email
+        ClearanceMailer.deliver_confirmation self
+      end
     end
 
     module ClassMethods

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: clearance
 version: !ruby/object:Gem::Version 
-  version: 0.8.3
+  version: 0.8.4
 platform: ruby
 authors: 
 - Dan Croak
@@ -21,11 +21,12 @@ authors:
 - Mark Cornick
 - Shay Arnett
 - Jon Yurek
+- Chad Pytel
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2009-10-21 00:00:00 -04:00
+date: 2009-12-08 00:00:00 -05:00
 default_executable: 
 dependencies: []
 
@@ -113,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.4
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 3
 summary: Rails authentication with email & password.