clc-promote 0.8.7 → 0.9.4

data/spec/unit/promote/versioner_spec.rb

@@ -2,181 +2,194 @@ require 'promote'
 require_relative '../support/dummy_log'
 
 describe Promote::Versioner do
-  before(:all) {
+  before(:all) do
     cb_dir = '/tmp/promote_test_cookbooks'
     FileUtils.rm_rf(cb_dir) if Dir.exist?(cb_dir)
     Dir.mkdir(cb_dir)
-    FileUtils.cp_r(File.join(File.dirname(File.dirname(__FILE__)), 'stubs'), cb_dir)
-  }
-
-  let(:cookbook_dir) {'/tmp/promote_test_cookbooks/stubs'}
-  let(:test_cookbook) {'cookbook_1'}
-  let(:config) {Promote::Config.new(:cookbook_directory => cookbook_dir)}
-	let(:fake_file) { double('file') }
-
-	let(:artifact_file) { "" }
-	let(:fake_berks) { double('berksfile', :install => nil) }
-	before {
-		allow(Berkshelf::Berksfile).to receive(:from_file).and_return(fake_berks)
-		allow_any_instance_of(Promote::GitRepo).to receive(:git).and_return(Git::Base.new)
-		allow_any_instance_of(Git::Base).to receive(:tags).and_return([
-			double("tag", :name => '1.0', :sha => 'abc'),
-			double("tag", :name => '1.1', :sha => 'def'),
-			double("tag", :name => '1.2', :sha => 'ghi')
-		])
-		allow_any_instance_of(Git::Base).to receive(:log).with(10000).and_return(
-			PromoteSpecs::DummyLog.new([
-				{:msg => 'blah', :sha => 'aaa'},
-				{:msg => 'CI:bumping', :sha => 'bbb'},
-				{:msg => 'blah', :sha => 'ccc'}
-			]))
-		config = Promote::Config.new
-	}
+    FileUtils.cp_r(
+      File.join(File.dirname(File.dirname(__FILE__)), 'stubs'),
+      cb_dir
+    )
+  end
+
+  let(:cookbook_dir) { '/tmp/promote_test_cookbooks/stubs' }
+  let(:test_cookbook) { 'cookbook_1' }
+  let(:config) { Promote::Config.new(cookbook_directory: cookbook_dir) }
+  let(:fake_file) { double('file') }
+
+  let(:artifact_file) { '' }
+  let(:fake_berks) { double('berksfile', install: nil) }
+  before do
+    allow(Berkshelf::Berksfile).to receive(:from_file).and_return(fake_berks)
+    allow_any_instance_of(Promote::GitRepo).to receive(:git)
+      .and_return(Git::Base.new)
+    allow_any_instance_of(Git::Base).to receive(:tags).and_return([
+      double('tag', name: '1.0', sha: 'abc'),
+      double('tag', name: '1.1', sha: 'def'),
+      double('tag', name: '1.2', sha: 'ghi')
+    ])
+    allow_any_instance_of(Git::Base).to receive(:log).with(10_000).and_return(
+      PromoteSpecs::DummyLog.new([
+        { msg: 'blah', sha: 'aaa' },
+        { msg: 'CI:bumping', sha: 'bbb' },
+        { msg: 'blah', sha: 'ccc' }
+      ]))
+  end
 
   subject { Promote::Versioner.new(config) }
 
-	context 'version_cookbook' do
-		context 'when versioning a new cookbook version' do
-			it "writes the new version and sha to the file" do
-				subject.version_cookbook(test_cookbook)
-				expect(Promote::Cookbook.new(test_cookbook, config).version.to_s).to eq('1.2.2')
-			end
-
-			it "adds the new version and sha to the cookbook" do
-				subject.version_cookbook(test_cookbook)
-				expect(Promote::Cookbook.new(test_cookbook, config).raw_metadata).to end_with("#sha1 'aaa'")
-			end
-		end
-
-		context 'when versioning a cookbook with no changes' do
-			it "does not write to metadata rb" do
-				expect(subject.version_cookbook(test_cookbook)).to be nil
-			end
-		end
-	end
-
-	context 'version_cookbooks' do
-		let(:cookbooks) {[
-			File.join(subject.config.cookbook_directory, "cookbook1"),
-			File.join(subject.config.cookbook_directory, "cookbook2"),
-			File.join(subject.config.cookbook_directory, "cookbook3")
-		]}
-		before {
-			allow(subject).to receive(:version_cookbook)
-			allow(Dir).to receive(:glob).with(
-				File.join(subject.config.cookbook_directory, "*")).and_return(cookbooks)
-		}
-
-		it "versions each cookbook" do
-			cookbooks.each do |cookbook|
-				expect(subject).to receive(:version_cookbook).with(File.basename(cookbook))
-			end
-			subject.version_cookbooks
-		end
-	end
-
-	context 'version_environment' do
-		before {
-			regex = File.join(config.environment_directory,'test.json')
-			allow(File).to receive(:read).with(regex).and_return(artifact_file)
-			allow(File).to receive(:open).with(regex, "w").and_yield(fake_file)
-		}
-
-		context 'when versioning a new environment with no version' do
-			let(:artifact_file) do
-				<<-EOS
-					{
-					  "name": "QA1",
-					  "chef_type": "environment",
-					  "json_class": "Chef::Environment",
-					  "override_attributes": {
-					    "environment_parent": "QA"
-					  }
-					}
-				EOS
-			end
-
-			it "writes the new version and sha to the file" do
-				parsed = JSON.parse(artifact_file)
-				parsed['override_attributes']['version'] = '1.2.2'
-				parsed['override_attributes']['sha1'] = 'aaa'
-				expect(fake_file).to receive(:<<).with(JSON.pretty_generate(parsed))
-				subject.version_environment('test')
-			end
-		end
-
-		context 'when versioning a new environment with old version' do
-
-			let(:artifact_file) do
-				<<-EOS
-					{
-					  "name": "QA1",
-					  "chef_type": "environment",
-					  "json_class": "Chef::Environment",
-					  "override_attributes": {
-					    "environment_parent": "QA",
-	    				"version": "1.0.0",
-	    				"sha1": "ccc"
-					  }
-					}
-				EOS
-			end
-
-			it "writes the new version and sha to the file" do
-				parsed = JSON.parse(artifact_file)
-				parsed['override_attributes']['version'] = '1.2.2'
-				parsed['override_attributes']['sha1'] = 'aaa'
-				expect(fake_file).to receive(:<<).with(JSON.pretty_generate(parsed))
-				subject.version_environment('test')
-			end
-		end
-
-		context 'when commiting an environment with no changes' do
-			let(:artifact_file) do
-				<<-EOS
-					{
-					  "name": "QA1",
-					  "chef_type": "environment",
-					  "json_class": "Chef::Environment",
-					  "override_attributes": {
-					    "environment_parent": "QA",
-	    				"version": "1.2.2",
-	    				"sha1": "aaa"
-					  }
-					}
-				EOS
-			end
-
-			it "does not write to the file" do
-				expect(fake_file).not_to receive(:<<)
-				subject.version_environment('test')
-			end
-		end
-	end
-
-	context 'version_environments' do
-		let(:environments) {%w{dir/environment1.json dir/environment2.json dir/environment3.json}}
-		before {
-			allow(subject).to receive(:version_environment)
-			allow(Dir).to receive(:glob).with(
-				File.join(subject.config.environment_directory, "*.json")).and_return(environments)
-		}
-
-		it "versions each environment" do
-			environments.each do |environment|
-				expect(subject).to receive(:version_environment).with(
-					File.basename(environment ,File.extname(environment)))
-			end
-			subject.version_environments
-		end
-	end
+  context 'version_cookbook' do
+    context 'when versioning a new cookbook version' do
+      let(:cookbook) { Promote::Cookbook.new(test_cookbook, config) }
+      it 'writes the new version and sha to the file' do
+        subject.version_cookbook(test_cookbook)
+        expect(cookbook.version.to_s).to eq('1.2.2')
+      end
+
+      it 'adds the new version and sha to the cookbook' do
+        subject.version_cookbook(test_cookbook)
+        expect(cookbook.raw_metadata).to end_with("#sha1 'aaa'")
+      end
+    end
+
+    context 'when versioning a cookbook with no changes' do
+      it 'does not write to metadata rb' do
+        expect(subject.version_cookbook(test_cookbook)).to be nil
+      end
+    end
+  end
+
+  context 'version_cookbooks' do
+    let(:cookbooks) do
+      [
+        File.join(subject.config.cookbook_directory, 'cookbook1'),
+        File.join(subject.config.cookbook_directory, 'cookbook2'),
+        File.join(subject.config.cookbook_directory, 'cookbook3')
+      ]
+    end
+    before do
+      allow(subject).to receive(:version_cookbook)
+      allow(Dir).to receive(:glob).with(
+        File.join(subject.config.cookbook_directory, '*')).and_return(cookbooks)
+    end
+
+    it 'versions each cookbook' do
+      cookbooks.each do |cookbook|
+        expect(subject).to receive(:version_cookbook)
+          .with(File.basename(cookbook))
+      end
+      subject.version_cookbooks
+    end
+  end
+
+  context 'version_environment' do
+    before do
+      regex = File.join(config.environment_directory, 'test.json')
+      allow(File).to receive(:read).with(regex).and_return(artifact_file)
+      allow(File).to receive(:open).with(regex, 'w').and_yield(fake_file)
+    end
+
+    context 'when versioning a new environment with no version' do
+      let(:artifact_file) do
+        <<-EOS
+          {
+            "name": "QA1",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "override_attributes": {
+              "environment_parent": "QA"
+            }
+          }
+        EOS
+      end
+
+      it 'writes the new version and sha to the file' do
+        parsed = JSON.parse(artifact_file)
+        parsed['override_attributes']['version'] = '1.2.2'
+        parsed['override_attributes']['sha1'] = 'aaa'
+        expect(fake_file).to receive(:<<).with(JSON.pretty_generate(parsed))
+        subject.version_environment('test')
+      end
+    end
+
+    context 'when versioning a new environment with old version' do
+      let(:artifact_file) do
+        <<-EOS
+          {
+            "name": "QA1",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "override_attributes": {
+              "environment_parent": "QA",
+              "version": "1.0.0",
+              "sha1": "ccc"
+            }
+          }
+        EOS
+      end
+
+      it 'writes the new version and sha to the file' do
+        parsed = JSON.parse(artifact_file)
+        parsed['override_attributes']['version'] = '1.2.2'
+        parsed['override_attributes']['sha1'] = 'aaa'
+        expect(fake_file).to receive(:<<).with(JSON.pretty_generate(parsed))
+        subject.version_environment('test')
+      end
+    end
+
+    context 'when commiting an environment with no changes' do
+      let(:artifact_file) do
+        <<-EOS
+          {
+            "name": "QA1",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "override_attributes": {
+              "environment_parent": "QA",
+              "version": "1.2.2",
+              "sha1": "aaa"
+            }
+          }
+        EOS
+      end
+
+      it 'does not write to the file' do
+        expect(fake_file).not_to receive(:<<)
+        subject.version_environment('test')
+      end
+    end
+  end
+
+  context 'version_environments' do
+    let(:environments) do
+      [
+        'dir/environment1.json',
+        'dir/environment2.json',
+        'dir/environment3.json'
+      ]
+    end
+    before do
+      allow(subject).to receive(:version_environment)
+      allow(Dir).to receive(:glob).with(
+        File.join(subject.config.environment_directory, '*.json'))
+        .and_return(environments)
+    end
+
+    it 'versions each environment' do
+      environments.each do |environment|
+        expect(subject).to receive(:version_environment).with(
+          File.basename(environment, File.extname(environment)))
+      end
+      subject.version_environments
+    end
+  end
 
   context 'version_role' do
-    before {
-      regex = File.join(config.role_directory,'test.json')
+    before do
+      regex = File.join(config.role_directory, 'test.json')
       allow(File).to receive(:read).with(regex).and_return(artifact_file)
-      allow(File).to receive(:open).with(regex, "w").and_yield(fake_file)
-    }
+      allow(File).to receive(:open).with(regex, 'w').and_yield(fake_file)
+    end
 
     context 'when versioning a new role with no version' do
       let(:artifact_file) do
@@ -191,7 +204,7 @@ describe Promote::Versioner do
         }
         EOS
       end
-      it "writes the new version and sha to the file" do
+      it 'writes the new version and sha to the file' do
         parsed = JSON.parse(artifact_file)
         parsed['override_attributes']['version'] = '1.2.2'
         parsed['override_attributes']['sha1'] = 'aaa'
@@ -210,9 +223,9 @@ describe Promote::Versioner do
         }
         EOS
       end
-      it "adds an override_attributes key to the role" do
+      it 'adds an override_attributes key to the role' do
         parsed = JSON.parse(artifact_file)
-        override_hash = { "override_attributes" => {} }
+        override_hash = { 'override_attributes' => {} }
         parsed.merge!(override_hash)
         expect(fake_file).to receive(:<<).with(JSON.pretty_generate(parsed))
         subject.version_role('test')
@@ -220,7 +233,6 @@ describe Promote::Versioner do
     end
 
     context 'when versioning a new role with old version' do
-
       let(:artifact_file) do
         <<-EOS
         {
@@ -236,7 +248,7 @@ describe Promote::Versioner do
         EOS
       end
 
-      it "writes the new version and sha to the file" do
+      it 'writes the new version and sha to the file' do
         parsed = JSON.parse(artifact_file)
         parsed['override_attributes']['version'] = '1.2.2'
         parsed['override_attributes']['sha1'] = 'aaa'
@@ -261,7 +273,7 @@ describe Promote::Versioner do
         EOS
       end
 
-      it "does not write to the file" do
+      it 'does not write to the file' do
         expect(fake_file).not_to receive(:<<)
         subject.version_role('test')
       end
@@ -269,158 +281,169 @@ describe Promote::Versioner do
   end
 
   context 'version_roles' do
-    let(:roles) {%w{dir/role1.json dir/role2.json dir/role3.json}}
-    before {
+    let(:roles) { %w(dir/role1.json dir/role2.json dir/role3.json) }
+    before do
       allow(subject).to receive(:version_role)
       allow(Dir).to receive(:glob).with(
-      File.join(subject.config.role_directory, "*.json")).and_return(roles)
-    }
+        File.join(subject.config.role_directory, '*.json')).and_return(roles)
+    end
 
-    it "versions each role" do
+    it 'versions each role' do
       roles.each do |role|
         expect(subject).to receive(:version_role).with(
-        File.basename(role ,File.extname(role)))
+          File.basename(role, File.extname(role)))
       end
       subject.version_roles
     end
   end
 
-	context 'constrain_environment' do
-		before {
-			regex = File.join(config.environment_directory,'test.json')
-			allow(File).to receive(:read).with(regex).and_return(artifact_file)
-			allow(File).to receive(:open).with(regex, "w").and_yield(fake_file)
-		}
-
-		let(:artifact_file) do
-			<<-EOS
-				{
-				  "name": "QA1",
-				  "chef_type": "environment",
-				  "json_class": "Chef::Environment"
-				}
-			EOS
-		end
-		before {
-			allow(File).to receive(:exist?).with(/Berksfile$/).and_return(true)
-			allow(fake_berks).to receive(:list).and_return([
-				double('Dependency', :name => 'cookbook1', :locked_version => Semverse::Version.new('1.1.1')),
-				double('Dependency', :name => 'cookbook2', :locked_version => Semverse::Version.new('2.2.2')),
-				double('Dependency', :name => 'cookbook3', :locked_version => Semverse::Version.new('3.3.3'))
-				])
-		}
-		it "writes the cookbook constraints to the file" do
-			expect(fake_file).to receive(:<<).with(an_instance_of(String)) do |arg|
-				parsed = JSON.parse(arg)
-				expect(parsed['cookbook_versions']['cookbook1']).to eq('1.1.1')
-				expect(parsed['cookbook_versions']['cookbook2']).to eq('2.2.2')
-				expect(parsed['cookbook_versions']['cookbook3']).to eq('3.3.3')
-			end
-			subject.constrain_environment('test', 'test_cookbook')
-		end
-	end
-
-	context 'is_dirty' do
-		before {
-			regex = File.join(config.environment_directory,'test.json')
-			allow(File).to receive(:read).with(regex).and_return(artifact_file)
-			allow(File).to receive(:open).with(regex, "w").and_yield(fake_file)
-			allow(File).to receive(:read).with(/new.json/).and_return(
-					<<-EOS
-						{
-						  "name": "test",
-						  "chef_type": "environment",
-						  "json_class": "Chef::Environment",
-						  "cookbook_versions": {
-						    "cookbook1": "1.1.1",
-						    "cookbook2": "2.2.2",
-						    "cookbook3": "3.3.3"
-						  }
-						}
-					EOS
-				)
-		}
-
-		context "cookbook is dirty" do
-
-			let(:artifact_file) do
-				<<-EOS
-					{
-					  "name": "LKG",
-					  "chef_type": "environment",
-					  "json_class": "Chef::Environment",
-					  "cookbook_versions": {
-					    "cookbook1": "1.1.1.hash",
-					    "cookbook2": "1.1.1.hash",
-					    "cookbook3": "3.3.3.hash"
-					  }
-					}
-				EOS
-			end
-
-			it "returns dirty" do
-				expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be(true)
-			end
-		end
-		context "cookbook has same version but different hash" do
-
-			let(:artifact_file) do
-				<<-EOS
-					{
-					  "name": "LKG",
-					  "chef_type": "environment",
-					  "json_class": "Chef::Environment",
-					  "cookbook_versions": {
-					    "cookbook1": "1.1.1.hash",
-					    "cookbook2": "2.2.2.diff_hash",
-					    "cookbook3": "3.3.3.hash"
-					  }
-					}
-				EOS
-			end
-
-			it "returns dirty" do
-				expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be(true)
-			end
-		end
-		context "cookbook is not dirty" do
-			let(:artifact_file) do
-				<<-EOS
-					{
-					  "name": "LKG",
-					  "chef_type": "environment",
-					  "json_class": "Chef::Environment",
-					  "cookbook_versions": {
-					    "cookbook1": "1.1.1.hash",
-					    "cookbook2": "2.2.2.hash",
-					    "cookbook3": "3.3.3.hash"
-					  }
-					}
-				EOS
-			end
-
-			it "returns clean" do
-				expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be(false)
-			end
-		end
-		context "cookbook is new to environment" do
-			let(:artifact_file) do
-				<<-EOS
-					{
-					  "name": "LKG",
-					  "chef_type": "environment",
-					  "json_class": "Chef::Environment",
-					  "cookbook_versions": {
-					    "cookbook1": "1.1.1.hash",
-					    "cookbook3": "3.3.3.hash"
-					  }
-					}
-				EOS
-			end
-
-			it "returns dirty" do
-				expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be(true)
-			end
-		end
-	end
+  context 'constrain_environment' do
+    before do
+      regex = File.join(config.environment_directory, 'test.json')
+      allow(File).to receive(:read).with(regex).and_return(artifact_file)
+      allow(File).to receive(:open).with(regex, 'w').and_yield(fake_file)
+    end
+
+    let(:artifact_file) do
+      <<-EOS
+        {
+          "name": "QA1",
+          "chef_type": "environment",
+          "json_class": "Chef::Environment"
+        }
+      EOS
+    end
+    before do
+      allow(File).to receive(:exist?).with(/Berksfile$/).and_return(true)
+      allow(fake_berks).to receive(:list).and_return([
+        double(
+          'Dependency',
+          name: 'cookbook1',
+          locked_version: Semverse::Version.new('1.1.1')
+        ),
+        double(
+          'Dependency',
+          name: 'cookbook2',
+          locked_version: Semverse::Version.new('2.2.2')
+        ),
+        double(
+          'Dependency',
+          name: 'cookbook3',
+          locked_version:
+          Semverse::Version.new('3.3.3')
+        )
+      ])
+    end
+    it 'writes the cookbook constraints to the file' do
+      expect(fake_file).to receive(:<<).with(an_instance_of(String)) do |arg|
+        parsed = JSON.parse(arg)
+        expect(parsed['cookbook_versions']['cookbook1']).to eq('1.1.1')
+        expect(parsed['cookbook_versions']['cookbook2']).to eq('2.2.2')
+        expect(parsed['cookbook_versions']['cookbook3']).to eq('3.3.3')
+      end
+      subject.constrain_environment('test', 'test_cookbook')
+    end
+  end
+
+  context 'is_dirty' do
+    before do
+      regex = File.join(config.environment_directory, 'test.json')
+      allow(File).to receive(:read).with(regex).and_return(artifact_file)
+      allow(File).to receive(:open).with(regex, 'w').and_yield(fake_file)
+      allow(File).to receive(:read).with(/new.json/).and_return(
+        <<-EOS
+          {
+            "name": "test",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "cookbook_versions": {
+              "cookbook1": "1.1.1",
+              "cookbook2": "2.2.2",
+              "cookbook3": "3.3.3"
+            }
+          }
+        EOS
+      )
+    end
+
+    context 'cookbook is dirty' do
+      let(:artifact_file) do
+        <<-EOS
+          {
+            "name": "LKG",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "cookbook_versions": {
+              "cookbook1": "1.1.1.hash",
+              "cookbook2": "1.1.1.hash",
+              "cookbook3": "3.3.3.hash"
+            }
+          }
+        EOS
+      end
+
+      it 'returns dirty' do
+        expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be(true)
+      end
+    end
+    context 'cookbook has same version but different hash' do
+      let(:artifact_file) do
+        <<-EOS
+          {
+            "name": "LKG",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "cookbook_versions": {
+              "cookbook1": "1.1.1.hash",
+              "cookbook2": "2.2.2.diff_hash",
+              "cookbook3": "3.3.3.hash"
+            }
+          }
+        EOS
+      end
+
+      it 'returns dirty' do
+        expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be true
+      end
+    end
+    context 'cookbook is not dirty' do
+      let(:artifact_file) do
+        <<-EOS
+          {
+            "name": "LKG",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "cookbook_versions": {
+              "cookbook1": "1.1.1.hash",
+              "cookbook2": "2.2.2.hash",
+              "cookbook3": "3.3.3.hash"
+            }
+          }
+        EOS
+      end
+
+      it 'returns clean' do
+        expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be false
+      end
+    end
+    context 'cookbook is new to environment' do
+      let(:artifact_file) do
+        <<-EOS
+          {
+            "name": "LKG",
+            "chef_type": "environment",
+            "json_class": "Chef::Environment",
+            "cookbook_versions": {
+              "cookbook1": "1.1.1.hash",
+              "cookbook3": "3.3.3.hash"
+            }
+          }
+        EOS
+      end
+
+      it 'returns dirty' do
+        expect(subject.is_dirty('new', 'test', 'cookbook2', 'hash')).to be true
+      end
+    end
+  end
 end