clc-cheffish 0.8.clc → 0.8.3.clc

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 579bebaf5cce935439331e89b3ce39236e012bbf
-  data.tar.gz: ce355bc6e80774b6a17a44640a832fb4f5b82bb7
+  metadata.gz: 37af8ecf98a56c9edf8ea77a79fa4106a70ef466
+  data.tar.gz: 06086fc87748f2412d5c87f5e72c796d6378ed92
 SHA512:
-  metadata.gz: 573774848e4ed345c30677ffc381824853053857bc024a02372148aaffc5d9026c1238cb4a43c2edd07846d787717e6f6a43f81c1589ff265b664a1a2929e87c
-  data.tar.gz: 00f427b83499d5b73c374e4468a95340be2b8e4fad6d61e4edd2135c4ce86fcfa6f28e77849f280a69bbe60eda417839699ac28edcc3db705fcafe51e887813c
+  metadata.gz: 404e7a16288c4f56a1575e9ca2039b20f67449cdb205b3864767b66b61f0f52e192b4f78ce4d5e18f3a6b300ac8cf0ac43e032915fbce8fca160f00ef1666e21
+  data.tar.gz: 0134dfe98c135aa77ebffeb35db9dfbb9b6238667732a87a18b6bbd3e45ed7fc635e1211eb6cb42c8a1bed82e6642b1690263eaf7b88d9d15d0bf518316c1b4f

data/lib/chef/provider/chef_data_bag_item.rb

@@ -170,7 +170,7 @@ class Chef::Provider::ChefDataBagItem < Cheffish::ChefProviderBase
         result = current_decrypted.merge(new_resource.raw_data || {})
       end
       result['id'] = new_resource.id
-      apply_modifiers(new_resource.raw_data_modifiers, result)
+      result = apply_modifiers(new_resource.raw_data_modifiers, result)
     end
   end
 

data/lib/chef/provider/chef_mirror.rb

@@ -12,11 +12,36 @@ class Chef::Provider::ChefMirror < Chef::Provider::LWRPBase
   end
 
   action :upload do
-    copy_to(local_fs, remote_fs)
+    with_modified_config do
+      copy_to(local_fs, remote_fs)
+    end
   end
 
   action :download do
-    copy_to(remote_fs, local_fs)
+    with_modified_config do
+      copy_to(remote_fs, local_fs)
+    end
+  end
+
+  def with_modified_config
+    # pre-Chef-12 ChefFS reads versioned_cookbooks out of Chef::Config instead of
+    # taking it as an input, so we need to modify it for the duration of copy_to
+    @old_versioned_cookbooks = Chef::Config.versioned_cookbooks
+    # If versioned_cookbooks is explicitly set, set it.
+    if !new_resource.versioned_cookbooks.nil?
+      Chef::Config.versioned_cookbooks = new_resource.versioned_cookbooks
+
+    # If new_resource.chef_repo_path is set, versioned_cookbooks defaults to true.
+    # Otherwise, it stays at its current Chef::Config value.
+    elsif new_resource.chef_repo_path
+      Chef::Config.versioned_cookbooks = true
+    end
+
+    begin
+      yield
+    ensure
+      Chef::Config.versioned_cookbooks = @old_versioned_cookbooks
+    end
   end
 
   def copy_to(src_root, dest_root)
@@ -84,7 +109,8 @@ class Chef::Provider::ChefMirror < Chef::Provider::LWRPBase
       :chef_server_url => new_resource.chef_server[:chef_server_url],
       :node_name => new_resource.chef_server[:options][:client_name],
       :client_key => new_resource.chef_server[:options][:client_key],
-      :repo_mode => repo_mode
+      :repo_mode => repo_mode,
+      :versioned_cookbooks => Chef::Config.versioned_cookbooks
     }
     Chef::ChefFS::FileSystem::ChefServerRootDir.new("remote", config)
   end

data/lib/chef/resource/chef_mirror.rb

@@ -23,8 +23,9 @@ class Chef::Resource::ChefMirror < Chef::Resource::LWRPBase
   # versioned_cookbooks defaults to true.
   attribute :chef_repo_path, :kind_of => [ String, Hash ]
 
-  # Whether the repo path contains / should contain cookbooks with versioned names,
+  # Whether the repo path should contain cookbooks with versioned names,
   # i.e. cookbooks/mysql-1.0.0, cookbooks/mysql-1.2.0, etc.
+  # Defaults to true if chef_repo_path is specified, or to Chef::Config.versioned_cookbooks otherwise.
   attribute :versioned_cookbooks, :kind_of => [ TrueClass, FalseClass ]
 
   # Chef server

data/lib/cheffish.rb

@@ -57,7 +57,7 @@ module Cheffish
     Cheffish.profiled_config(chef_config)
   end
 
-  def self.honor_local_mode(local_mode_default = true)
+  def self.honor_local_mode(local_mode_default = true, &block)
     if !Chef::Config.has_key?(:local_mode) && !local_mode_default.nil?
       Chef::Config.local_mode = local_mode_default
     end

data/lib/cheffish/chef_provider_base.rb

@@ -31,8 +31,8 @@ module Cheffish
         if new_resource.complete
           result = normalize(resource_to_json(new_resource))
         else
-          # If resource is incomplete, use current json to fill any holes
-          result = Chef::Mixin::DeepMerge.hash_only_merge(current_json, resource_to_json(new_resource))
+          # If the resource is incomplete, we use the current json to fill any holes
+          result = current_json.merge(resource_to_json(new_resource))
         end
         augment_new_json(result)
       end
@@ -131,7 +131,18 @@ module Cheffish
       modifiers.each do |path, value|
         path = [path] if !path.kind_of?(Array)
         path = path.map { |path_part| path_part.to_s }
-        parent = path[0..-2].inject(json) { |hash, path_part| hash ? hash[path_part] : nil }
+        parent = 0.upto(path.size-2).inject(json) do |hash, index|
+          if hash.nil?
+            nil
+          elsif !hash.is_a?(Hash)
+            raise "Attempt to set #{path} to #{value} when #{path[0..index-1]} is not a hash"
+          else
+            hash[path[index]]
+          end
+        end
+        if !parent.nil? && !parent.is_a?(Hash)
+          raise "Attempt to set #{path} to #{value} when #{path[0..-2]} is not a hash"
+        end
         existing_value = parent ? parent[path[-1]] : nil
 
         if value.is_a?(Proc)
@@ -139,16 +150,17 @@ module Cheffish
         end
         if value == :delete
           parent.delete(path[-1]) if parent
-          # TODO clean up parent chain if hash is completely emptied
         else
-          if !parent
-            # Create parent if necessary
-            parent = path[0..-2].inject(json) do |hash, path_part|
-              hash[path_part] = {} if !hash[path_part]
-              hash[path_part]
-            end
+          # Create parent if necessary, overwriting values
+          parent = path[0..-2].inject(json) do |hash, path_part|
+            hash[path_part] = {} if !hash[path_part]
+            hash[path_part]
+          end
+          if path.size > 0
+            parent[path[-1]] = value
+          else
+            json = value
           end
-          parent[path[-1]] = value
         end
       end
       json

data/lib/cheffish/recipe_dsl.rb

@@ -72,14 +72,22 @@ class Chef
 
           # Ensure all paths are given
           %w(acl client cookbook container data_bag environment group node role).each do |type|
-            options["#{type}_path"] ||= begin
+            # Set the options as symbol keys and then copy to string keys
+            string_key = "#{type}_path"
+            symbol_key = "#{type}_path".to_sym
+
+            options[symbol_key] ||= begin
               if options[:chef_repo_path].kind_of?(String)
                 Chef::Util::PathHelper.join(options[:chef_repo_path], "#{type}s")
               else
                 options[:chef_repo_path].map { |path| Chef::Util::PathHelper.join(path, "#{type}s")}
               end
             end
-          end
+
+            # Copy over to string keys for things that use string keys (ChefFS)...
+            # TODO: Fix ChefFS to take symbols or use something that is insensitive to the difference
+            options[string_key] = options[symbol_key]
+          end 
 
           chef_fs = Chef::ChefFS::Config.new(options).local_fs
           chef_fs.write_pretty_json = true
@@ -138,7 +146,7 @@ else
   class Chef
     class Util
       class PathHelper
-        def join(*args)
+        def self.join(*args)
           Chef::Config.path_join(*args)
         end
       end

data/lib/cheffish/version.rb

@@ -1,3 +1,3 @@
 module Cheffish
-  VERSION = '0.8.clc'
+  VERSION = '0.8.3.clc'
 end

data/spec/integration/chef_client_spec.rb

@@ -8,7 +8,7 @@ repo_path = Dir.mktmpdir('chef_repo')
 describe Chef::Resource::ChefClient do
   extend SpecSupport
 
-  when_the_chef_server 'is in multi-org mode', :osc_compat => false, :single_org => false do
+  when_the_chef_12_server 'is in multi-org mode' do
     organization 'foo'
 
     before :each do

data/spec/integration/chef_container_spec.rb

@@ -5,7 +5,7 @@ require 'chef/provider/chef_container'
 describe Chef::Resource::ChefContainer do
   extend SpecSupport
 
-  when_the_chef_server 'is in multi-org mode', :osc_compat => false, :single_org => false do
+  when_the_chef_12_server 'is in multi-org mode' do
     organization 'foo'
 
     before :each do

data/spec/integration/chef_group_spec.rb

@@ -5,7 +5,7 @@ require 'chef/provider/chef_group'
 describe Chef::Resource::ChefGroup do
   extend SpecSupport
 
-  when_the_chef_server 'is in multi-org mode', :osc_compat => false, :single_org => false do
+  when_the_chef_12_server 'is in multi-org mode' do
     organization 'foo'
 
     before :each do

data/spec/integration/chef_mirror_spec.rb

@@ -5,17 +5,20 @@ require 'chef/provider/chef_mirror'
 describe Chef::Resource::ChefMirror do
   extend SpecSupport
 
-  when_the_chef_server 'is in multi-org mode', :osc_compat => false, :single_org => false do
+  when_the_chef_12_server 'is in multi-org mode' do
     organization 'foo'
 
     before :each do
       Chef::Config.chef_server_url = URI.join(Chef::Config.chef_server_url, '/organizations/foo').to_s
     end
 
-    context 'and is empty' do
+    describe 'basic download and upload' do
       when_the_repository 'is full of stuff' do
         file 'nodes/x.json', {}
         file 'roles/x.json', {}
+        directory 'cookbooks/x' do
+          file 'metadata.rb', 'name "x"; version "2.0.0"'
+        end
 
         it "Download grabs defaults" do
           run_recipe do
@@ -37,6 +40,7 @@ describe Chef::Resource::ChefMirror do
           expect(chef_run).to have_updated('chef_mirror[]', :upload)
           expect { get('nodes/x') }.not_to raise_error
           expect { get('roles/x') }.not_to raise_error
+          expect { get('cookbooks/x/2.0.0') }.not_to raise_error
         end
 
         it 'chef_mirror with concurrency 0 fails with a reasonable message' do
@@ -50,7 +54,96 @@ describe Chef::Resource::ChefMirror do
           }.to raise_error /chef_mirror.concurrency must be above 0/
         end
       end
+    end
+
+    context 'and the Chef server has a node and role in it' do
+      node 'x', {}
+      role 'x', {}
+
+      when_the_repository 'is empty' do
+        it "Download grabs the node and role" do
+          run_recipe do
+            chef_mirror '' do
+              action :download
+            end
+          end
+          expect(chef_run).to have_updated('chef_mirror[]', :download)
+          expect(File.exist?(path_to('nodes/x.json'))).to be true
+          expect(File.exist?(path_to('roles/x.json'))).to be true
+        end
+
+        it "Upload uploads nothing" do
+          run_recipe do
+            chef_mirror '' do
+              action :upload
+            end
+          end
+          expect(chef_run).not_to have_updated('chef_mirror[]', :upload)
+        end
+      end
+    end
+
+    context 'and the Chef server has nodes and roles named x' do
+      node 'x', {}
+      role 'x', {}
+
+      when_the_repository 'has nodes and roles named y' do
+        file 'nodes/y.json', {}
+        file 'roles/y.json', {}
+
+        it "Download grabs the x's" do
+          run_recipe do
+            chef_mirror '' do
+              action :download
+            end
+          end
+          expect(chef_run).to have_updated('chef_mirror[]', :download)
+          expect(File.exist?(path_to('nodes/x.json'))).to be true
+          expect(File.exist?(path_to('roles/x.json'))).to be true
+          expect(File.exist?(path_to('nodes/y.json'))).to be true
+          expect(File.exist?(path_to('roles/y.json'))).to be true
+        end
+
+        it "Upload uploads the y's" do
+          run_recipe do
+            chef_mirror '' do
+              action :upload
+            end
+          end
+          expect(chef_run).to have_updated('chef_mirror[]', :upload)
+          expect { get('nodes/x') }.not_to raise_error
+          expect { get('roles/x') }.not_to raise_error
+          expect { get('nodes/y') }.not_to raise_error
+          expect { get('roles/y') }.not_to raise_error
+        end
+
+        it "Download with purge grabs the x's and deletes the y's" do
+          run_recipe do
+            chef_mirror '' do
+              purge true
+              action :download
+            end
+          end
+          expect(chef_run).to have_updated('chef_mirror[]', :download)
+          expect(File.exist?(path_to('nodes/x.json'))).to be true
+          expect(File.exist?(path_to('roles/x.json'))).to be true
+        end
+
+        it "Upload with :purge uploads the y's and deletes the x's" do
+          run_recipe do
+            chef_mirror '*/*.json' do
+              purge true
+              action :upload
+            end
+          end
+          expect(chef_run).to have_updated('chef_mirror[*/*.json]', :upload)
+          expect { get('nodes/y') }.not_to raise_error
+          expect { get('roles/y') }.not_to raise_error
+        end
+      end
+    end
 
+    describe "chef_repo_path" do
       when_the_repository 'has stuff but no chef_repo_path' do
         file 'repo/nodes/x.json', {}
         file 'repo/roles/x.json', {}
@@ -153,92 +246,274 @@ describe Chef::Resource::ChefMirror do
       end
     end
 
-    context 'and has stuff' do
-      node 'x', {}
-      role 'x', {}
+    describe "cookbook upload, chef_repo_path and versioned_cookbooks" do
+      when_the_repository 'has cookbooks in non-versioned format' do
+        file 'cookbooks/x-1.0.0/metadata.rb', 'name "x-1.0.0"; version "2.0.0"'
+        file 'cookbooks/y-1.0.0/metadata.rb', 'name "y-3.0.0"; version "4.0.0"'
 
-      when_the_repository 'is empty' do
-        it "Download grabs stuff" do
+        it "chef_mirror :upload uploads everything" do
           run_recipe do
             chef_mirror '' do
-              action :download
+              action :upload
             end
           end
-          expect(chef_run).to have_updated('chef_mirror[]', :download)
-          expect(File.exist?(path_to('nodes/x.json'))).to be true
-          expect(File.exist?(path_to('roles/x.json'))).to be true
+          expect(chef_run).to have_updated('chef_mirror[]', :upload)
+          expect { get('cookbooks/x-1.0.0/2.0.0') }.not_to raise_error
+          expect { get('cookbooks/y-3.0.0/4.0.0') }.not_to raise_error
         end
 
-        it "Upload uploads nothing" do
-          run_recipe do
-            chef_mirror '' do
-              action :upload
+        context 'and Chef::Config.versioned_cookbooks is false' do
+          before do
+            Chef::Config.versioned_cookbooks false
+          end
+          it "chef_mirror :upload uploads everything" do
+            run_recipe do
+              chef_mirror '' do
+                action :upload
+              end
             end
+            expect(chef_run).to have_updated('chef_mirror[]', :upload)
+            expect { get('cookbooks/x-1.0.0/2.0.0') }.not_to raise_error
+            expect { get('cookbooks/y-3.0.0/4.0.0') }.not_to raise_error
           end
-          expect(chef_run).not_to have_updated('chef_mirror[]', :upload)
         end
-      end
-    end
 
-    context 'and has nodes and roles named x' do
-      node 'x', {}
-      role 'x', {}
+        context 'and Chef::Config.chef_repo_path is not set but versioned_cookbooks is false' do
+          before do
+            Chef::Config.delete(:chef_repo_path)
+            Chef::Config.versioned_cookbooks false
+          end
 
-      when_the_repository 'has nodes and roles named y' do
-        file 'nodes/y.json', {}
-        file 'roles/y.json', {}
+          it "chef_mirror :upload with chef_repo_path and versioned_cookbooks false uploads cookbooks with name including version" do
+            repository_dir = @repository_dir
+            run_recipe do
+              chef_mirror '' do
+                chef_repo_path repository_dir
+                versioned_cookbooks false
+                action :upload
+              end
+            end
+            expect(chef_run).to have_updated('chef_mirror[]', :upload)
+            expect { get('cookbooks/x-1.0.0/2.0.0') }.not_to raise_error
+            expect { get('cookbooks/y-3.0.0/4.0.0') }.not_to raise_error
+          end
+        end
+      end
 
-        it "Download grabs the x's" do
-          run_recipe do
-            chef_mirror '' do
-              action :download
+      when_the_repository 'has cookbooks in versioned_cookbook format' do
+        file 'cookbooks/x-1.0.0/metadata.rb', 'name "x"; version "1.0.0"'
+        file 'cookbooks/x-2.0.0/metadata.rb', 'name "x"; version "2.0.0"'
+
+        context 'and Chef::Config.versioned_cookbooks is true' do
+          before do
+            Chef::Config.versioned_cookbooks true
+          end
+          it "chef_mirror :upload uploads everything" do
+            run_recipe do
+              chef_mirror '' do
+                action :upload
+              end
             end
+            expect(chef_run).to have_updated('chef_mirror[]', :upload)
+            expect { get('cookbooks/x/1.0.0') }.not_to raise_error
+            expect { get('cookbooks/x/2.0.0') }.not_to raise_error
           end
-          expect(chef_run).to have_updated('chef_mirror[]', :download)
-          expect(File.exist?(path_to('nodes/x.json'))).to be true
-          expect(File.exist?(path_to('roles/x.json'))).to be true
-          expect(File.exist?(path_to('nodes/y.json'))).to be true
-          expect(File.exist?(path_to('roles/y.json'))).to be true
         end
 
-        it "Upload uploads the y's" do
-          run_recipe do
-            chef_mirror '' do
-              action :upload
+        context 'and Chef::Config.chef_repo_path set somewhere else' do
+          before do
+            Chef::Config.chef_repo_path = '/x/y/z'
+          end
+          it "chef_mirror :upload with chef_repo_path uploads cookbooks" do
+            repository_dir = @repository_dir
+            run_recipe do
+              chef_mirror '' do
+                chef_repo_path repository_dir
+                action :upload
+              end
             end
+            expect(chef_run).to have_updated('chef_mirror[]', :upload)
+            expect { get('cookbooks/x/1.0.0') }.not_to raise_error
+            expect { get('cookbooks/x/2.0.0') }.not_to raise_error
           end
-          expect(chef_run).to have_updated('chef_mirror[]', :upload)
-          expect { get('nodes/x') }.not_to raise_error
-          expect { get('roles/x') }.not_to raise_error
-          expect { get('nodes/y') }.not_to raise_error
-          expect { get('roles/y') }.not_to raise_error
         end
 
-        it "Download with purge grabs the x's and deletes the y's" do
-          run_recipe do
-            chef_mirror '' do
-              purge true
-              action :download
+        context 'and Chef::Config.chef_repo_path is not set but versioned_cookbooks is false' do
+          before do
+            Chef::Config.delete(:chef_repo_path)
+            Chef::Config.versioned_cookbooks false
+          end
+
+          it "chef_mirror :upload with chef_repo_path uploads cookbooks with name split from version" do
+            repository_dir = @repository_dir
+            run_recipe do
+              chef_mirror '' do
+                chef_repo_path repository_dir
+                action :upload
+              end
             end
+            expect(chef_run).to have_updated('chef_mirror[]', :upload)
+            expect { get('cookbooks/x/1.0.0') }.not_to raise_error
+            expect { get('cookbooks/x/2.0.0') }.not_to raise_error
+          end
+
+          it "chef_mirror :upload with chef_repo_path and versioned_cookbooks uploads cookbooks with name split from version" do
+            repository_dir = @repository_dir
+            run_recipe do
+              chef_mirror '' do
+                chef_repo_path repository_dir
+                versioned_cookbooks true
+                action :upload
+              end
+            end
+            expect(chef_run).to have_updated('chef_mirror[]', :upload)
+            expect { get('cookbooks/x/1.0.0') }.not_to raise_error
+            expect { get('cookbooks/x/2.0.0') }.not_to raise_error
           end
-          expect(chef_run).to have_updated('chef_mirror[]', :download)
-          expect(File.exist?(path_to('nodes/x.json'))).to be true
-          expect(File.exist?(path_to('roles/x.json'))).to be true
         end
 
-        it "Upload with :purge uploads the y's and deletes the x's" do
-          run_recipe do
-            chef_mirror '*/*.json' do
-              purge true
-              action :upload
+        context 'and Chef::Config.chef_repo_path is not set but versioned_cookbooks is true' do
+          before do
+            Chef::Config.delete(:chef_repo_path)
+            Chef::Config.versioned_cookbooks true
+          end
+          it "chef_mirror :upload with chef_repo_path uploads cookbooks with name split from version" do
+            repository_dir = @repository_dir
+            run_recipe do
+              chef_mirror '' do
+                chef_repo_path repository_dir
+                action :upload
+              end
             end
+            expect(chef_run).to have_updated('chef_mirror[]', :upload)
+            expect { get('cookbooks/x/1.0.0') }.not_to raise_error
+            expect { get('cookbooks/x/2.0.0') }.not_to raise_error
           end
-          expect(chef_run).to have_updated('chef_mirror[*/*.json]', :upload)
-          expect { get('nodes/y') }.not_to raise_error
-          expect { get('roles/y') }.not_to raise_error
         end
       end
     end
 
+    describe 'cookbook download, chef_repo_path, and versioned_cookbooks' do
+      context 'when the Chef server has a cookbook with multiple versions' do
+        cookbook 'x', '1.0.0', 'metadata.rb' => 'name "x"; version "1.0.0"'
+        cookbook 'x', '2.0.0', 'metadata.rb' => 'name "x"; version "2.0.0"'
+
+        when_the_repository 'is empty' do
+          it 'chef_mirror :download downloads the latest version of the cookbook' do
+            run_recipe do
+              chef_mirror '' do
+                action :download
+              end
+            end
+            expect(chef_run).to have_updated('chef_mirror[]', :download)
+            expect(File.read(path_to('cookbooks/x/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+          end
+
+          it 'chef_mirror :download with versioned_cookbooks = true downloads all versions of the cookbook' do
+            run_recipe do
+              chef_mirror '' do
+                versioned_cookbooks true
+                action :download
+              end
+            end
+            expect(chef_run).to have_updated('chef_mirror[]', :download)
+            expect(File.read(path_to('cookbooks/x-1.0.0/metadata.rb'))).to eq('name "x"; version "1.0.0"')
+            expect(File.read(path_to('cookbooks/x-2.0.0/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+          end
+
+          context 'and Chef::Config.chef_repo_path is set elsewhere' do
+            before do
+              Chef::Config.chef_repo_path = '/x/y/z'
+            end
+
+            it 'chef_mirror :download with chef_repo_path downloads all versions of the cookbook' do
+              repository_dir = @repository_dir
+              run_recipe do
+                chef_mirror '' do
+                  chef_repo_path repository_dir
+                  action :download
+                end
+              end
+              expect(chef_run).to have_updated('chef_mirror[]', :download)
+              expect(File.read(path_to('cookbooks/x-1.0.0/metadata.rb'))).to eq('name "x"; version "1.0.0"')
+              expect(File.read(path_to('cookbooks/x-2.0.0/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+            end
+
+            it 'chef_mirror :download with chef_repo_path and versioned_cookbooks = false downloads the latest version of the cookbook' do
+              repository_dir = @repository_dir
+              run_recipe do
+                chef_mirror '' do
+                  chef_repo_path repository_dir
+                  versioned_cookbooks false
+                  action :download
+                end
+              end
+              expect(chef_run).to have_updated('chef_mirror[]', :download)
+              expect(File.read(path_to('cookbooks/x/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+            end
+          end
+
+          context 'and Chef::Config.versioned_cookbooks is true' do
+            before do
+              Chef::Config.versioned_cookbooks = true
+            end
+
+            it 'chef_mirror :download downloads all versions of the cookbook' do
+              run_recipe do
+                chef_mirror '' do
+                  action :download
+                end
+              end
+              expect(chef_run).to have_updated('chef_mirror[]', :download)
+              expect(File.read(path_to('cookbooks/x-1.0.0/metadata.rb'))).to eq('name "x"; version "1.0.0"')
+              expect(File.read(path_to('cookbooks/x-2.0.0/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+            end
+
+            it 'chef_mirror :download with versioned_cookbooks = false downloads the latest version of the cookbook' do
+              run_recipe do
+                chef_mirror '' do
+                  versioned_cookbooks false
+                  action :download
+                end
+              end
+              expect(chef_run).to have_updated('chef_mirror[]', :download)
+              expect(File.read(path_to('cookbooks/x/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+            end
+
+            context 'and Chef::Config.chef_repo_path is set elsewhere' do
+              before do
+                Chef::Config.chef_repo_path = '/x/y/z'
+              end
+
+              it 'chef_mirror :download with chef_repo_path downloads all versions of the cookbook' do
+                repository_dir = @repository_dir
+                run_recipe do
+                  chef_mirror '' do
+                    chef_repo_path repository_dir
+                    action :download
+                  end
+                end
+                expect(chef_run).to have_updated('chef_mirror[]', :download)
+                expect(File.read(path_to('cookbooks/x-1.0.0/metadata.rb'))).to eq('name "x"; version "1.0.0"')
+                expect(File.read(path_to('cookbooks/x-2.0.0/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+              end
+
+              it 'chef_mirror :download with chef_repo_path and versioned_cookbooks = false downloads the latest version of the cookbook' do
+                repository_dir = @repository_dir
+                run_recipe do
+                  chef_mirror '' do
+                    chef_repo_path repository_dir
+                    versioned_cookbooks false
+                    action :download
+                  end
+                end
+                expect(chef_run).to have_updated('chef_mirror[]', :download)
+                expect(File.read(path_to('cookbooks/x/metadata.rb'))).to eq('name "x"; version "2.0.0"')
+              end
+            end
+          end
+        end
+      end
+    end
   end
 end