clamby 1.6.6 → 1.6.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e9bf0bfa99f769f41a964838dca46fcb5d6b4c2a2e1653ff43c3a40fde25480f
-  data.tar.gz: 95615a8f2c69aa42a593f909a426266253026c7bc3d24a74dfabb13dd931c526
+  metadata.gz: 81853e9529f298f606bb599f22da044e9ada2f805d2d6f6635caac455450e93e
+  data.tar.gz: d122cf67adcfd0187c8fabd7153ca7fe20643b075f9bcfe77c8d482075462f74
 SHA512:
-  metadata.gz: d4af568ba3f78fb465a18625ff9e9fca343de65b95b155b57cd3b7156d19db876457837331896c3c9c6767326a93f6dcf01f73c5518180df9ff95b7af8868b5e
-  data.tar.gz: 3c2b5004c4b5dbb2fc627a2d20a79307361b5385b3b53dc0500fe1683430db9619d90a18e0aa414d28ce103bbbe9265409462c0d3845f0e6667a76ff788743a6
+  metadata.gz: c56dc7d74dfa3e29eeeca5d44b0cee9fc55efbc55269bcee95cd5108cb8c09ac8faa5a353bd6932ae7602adf1686bec8df4671a5afd57997bb0bdf605d2c2bdc
+  data.tar.gz: 85b9072343ce8061cb67ab7607a52570f6d42459e9ad3467c3497c381a9df6cdea3832435dd276e306b1b5fdc1a8bb415940e0a90371027f65497952f215a89b

data/.travis.yml

@@ -9,7 +9,9 @@ rvm:
   - 2.5.3
   - 2.6.3
   - 2.6.5
-install: 
+  - 2.6.6
+  - 2.7.2
+install:
  - sudo apt-get install clamav
  - sudo freshclam
 

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# v1.6.8
+ - [codezomb](https://github.com/kobaltz/clamby/commits?author=codezomb)  - Allow paths to be escaped #37
+
 # v1.6.5
  - [bennacer860](https://github.com/kobaltz/clamby/commits?author=bennacer860) - Added config data dir option
 
@@ -25,7 +28,7 @@
 
 # v1.3.2
  - [emilong](https://github.com/kobaltz/clamby/commits/master?author=emilong) added `stream` option
- 
+
 # v1.3.1
  - [zealot128](https://github.com/kobaltz/clamby/commits/master?author=zealot128) added `silence_output` option
 
@@ -43,7 +46,7 @@
  - Refactor of logic
  - Cleanup
  - Thanks to @hderms for contributing!
- 
+
 # v1.1.0
  - Changed `scan()` to `safe?()`
  - Added `virus?()`
@@ -70,7 +73,7 @@ HTTP request sent, awaiting response... 200 OK
 Length: 68 [application/octet-stream]
 Saving to: 'eicar.com'
 
-100%[=================>] 68          --.-K/s   in 0s      
+100%[=================>] 68          --.-K/s   in 0s
 
 2014-03-10 21:35:50 (13.0 MB/s) - 'eicar.com' saved [68/68]
 

data/clamby.gemspec

@@ -21,5 +21,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-  spec.add_development_dependency "byebug"
 end

data/lib/clamby/command.rb

@@ -16,7 +16,7 @@ module Clamby
     def self.scan(path)
       return nil unless file_exists?(path)
 
-      args = [path, '--no-summary']
+      args = [Shellwords.escape(path), '--no-summary']
 
       if Clamby.config[:daemonize]
         args << '--fdpass' if Clamby.config[:fdpass]

data/lib/clamby/version.rb

@@ -1,3 +1,3 @@
 module Clamby
-  VERSION = "1.6.6"
+  VERSION = "1.6.8"
 end

data/spec/clamby/command_spec.rb

@@ -134,9 +134,7 @@ describe Clamby::Command do
 
         it 'executes the clamscan executable from the custom path' do
           expect(runner).to receive(:system).with(
-            "#{custom_path}/clamscan",
-            '--no-summary',
-            good_path,
+            "#{custom_path}/clamscan --no-summary #{good_path}",
             {}
           ) { system("exit 0", out: File::NULL) }
 
@@ -149,9 +147,7 @@ describe Clamby::Command do
 
         it 'executes the clamdscan executable from the custom path' do
           expect(runner).to receive(:system).with(
-            "#{custom_path}/clamdscan",
-            '--no-summary',
-            good_path,
+            "#{custom_path}/clamdscan --no-summary #{good_path}",
             {}
           ) { system("exit 0", out: File::NULL) }
 
@@ -159,5 +155,11 @@ describe Clamby::Command do
         end
       end
     end
+
+    describe 'special filenames' do
+      it 'does not fail' do
+        expect(described_class.scan(special_path)).to be(false)
+      end
+    end
   end
 end

data/spec/fixtures/safe (special).txt

@@ -0,0 +1,2 @@
+This is a virus-free file.
+It is used by automated tests.

data/spec/support/shared_context.rb

@@ -1,4 +1,5 @@
 RSpec.shared_context 'paths' do
+  let(:special_path) { File.expand_path('../../fixtures/safe (special).txt', __FILE__) }
   let(:good_path) { File.expand_path('../../fixtures/safe.txt', __FILE__) }
   let(:bad_path) { File.expand_path("not-here/#{rand 10e6}.txt", __FILE__) }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: clamby
 version: !ruby/object:Gem::Version
-  version: 1.6.6
+  version: 1.6.8
 platform: ruby
 authors:
 - kobaltz
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-05 00:00:00.000000000 Z
+date: 2021-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Clamby allows users to scan files uploaded with Paperclip or Carrierwave.
   If a file has a virus, then you can delete this file and discard it without causing
   harm to other users.
@@ -93,6 +79,7 @@ files:
 - spec/.DS_Store
 - spec/clamby/command_spec.rb
 - spec/clamby_spec.rb
+- spec/fixtures/safe (special).txt
 - spec/fixtures/safe.txt
 - spec/spec_helper.rb
 - spec/support/shared_context.rb
@@ -115,7 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.2.32
 signing_key:
 specification_version: 4
 summary: Scan file uploads with ClamAV
@@ -123,6 +110,7 @@ test_files:
 - spec/.DS_Store
 - spec/clamby/command_spec.rb
 - spec/clamby_spec.rb
+- spec/fixtures/safe (special).txt
 - spec/fixtures/safe.txt
 - spec/spec_helper.rb
 - spec/support/shared_context.rb