ckeditor5 1.9.0 → 1.11.0

data/lib/ckeditor5/rails/assets/webcomponents/utils.mjs

@@ -0,0 +1,155 @@
+/**
+ * Executes callback when DOM is ready
+ *
+ * @param {() => void} callback - Function to execute when DOM is ready
+ */
+function execIfDOMReady(callback) {
+  switch (document.readyState) {
+    case 'loading':
+      document.addEventListener('DOMContentLoaded', callback, { once: true });
+      break;
+
+    case 'interactive':
+    case 'complete':
+      setTimeout(callback, 0);
+      break;
+
+    default:
+      console.warn('Unexpected document.readyState:', document.readyState);
+      setTimeout(callback, 0);
+  }
+}
+
+/**
+ * Dynamically imports modules based on configuration
+ *
+ * @param {Array<Object>} imports - Array of import configurations
+ * @param {Object} imports[].name - Name of inline plugin (for inline type)
+ * @param {Object} imports[].code - Source code of inline plugin (for inline type)
+ * @param {Object} imports[].import_name - Module path to import (for external type)
+ * @param {Object} imports[].import_as - Name to import as (for external type)
+ * @param {Object} imports[].window_name - Global window object name (for external type)
+ * @param {('inline'|'external')} imports[].type - Type of import
+ * @returns {Promise<Array<any>>} Array of loaded modules
+ * @throws {Error} When plugin loading fails
+ */
+function loadAsyncImports(imports = []) {
+  const loadInlinePlugin = async ({ name, code }) => {
+    const module = await import(`data:text/javascript,${encodeURIComponent(code)}`);
+
+    if (!module.default) {
+      throw new Error(`Inline plugin "${name}" must export a default class/function!`);
+    }
+
+    return module.default;
+  };
+
+  const loadExternalPlugin = async ({ import_name, import_as, window_name }) => {
+    if (window_name) {
+      if (!Object.prototype.hasOwnProperty.call(window, window_name)) {
+        throw new Error(
+          `Plugin window['${window_name}'] not found in global scope. ` +
+          'Please ensure the plugin is loaded before CKEditor initialization.'
+        );
+      }
+
+      return window[window_name];
+    }
+
+    const module = await import(import_name);
+    const imported = module[import_as || 'default'];
+
+    if (!imported) {
+      throw new Error(`Plugin "${import_as}" not found in the ESM module "${import_name}"!`);
+    }
+
+    return imported;
+  };
+
+  return Promise.all(imports.map(item => {
+    switch(item.type) {
+      case 'inline':
+        return loadInlinePlugin(item);
+
+      case 'external':
+      default:
+        return loadExternalPlugin(item);
+    }
+  }));
+}
+
+/**
+ * Checks if a key is safe to use in configuration objects to prevent prototype pollution
+ *
+ * @param {string} key - Key name to check
+ * @returns {boolean} True if key is safe to use
+ */
+function isSafeKey(key) {
+  return typeof key === 'string' &&
+          key !== '__proto__' &&
+          key !== 'constructor' &&
+          key !== 'prototype';
+}
+
+/**
+ * Resolves element references in configuration object.
+ * Looks for objects with { $element: "selector" } format and replaces them with actual DOM elements.
+ *
+ * @param {Object} obj - Configuration object to process
+ * @returns {Object} Processed configuration object with resolved element references
+ * @throws {Error} When element reference is invalid
+ */
+function resolveElementReferences(obj) {
+  if (!obj || typeof obj !== 'object') {
+    return obj;
+  }
+
+  if (Array.isArray(obj)) {
+    return obj.map(item => resolveElementReferences(item));
+  }
+
+  const result = Object.create(null);
+
+  for (const key of Object.getOwnPropertyNames(obj)) {
+    if (!isSafeKey(key)) {
+      console.warn(`Suspicious key "${key}" detected in config, skipping`);
+      continue;
+    }
+
+    const value = obj[key];
+
+    if (value && typeof value === 'object') {
+      if (value.$element) {
+        const selector = value.$element;
+
+        if (typeof selector !== 'string') {
+          console.warn(`Invalid selector type for "${key}", expected string`);
+          continue;
+        }
+
+        const element = document.querySelector(selector);
+
+        if (!element) {
+          console.warn(`Element not found for selector: ${selector}`);
+        }
+
+        result[key] = element || null;
+      } else {
+        result[key] = resolveElementReferences(value);
+      }
+    } else {
+      result[key] = value;
+    }
+  }
+
+  return result;
+}
+
+/**
+ * Generates a unique identifier string
+ *
+ * @returns {string} Random string that can be used as unique identifier
+ */
+function uid() {
+  return Math.random().toString(36).substring(2);
+}

data/lib/ckeditor5/rails/cdn/ckbox_bundle.rb

@@ -8,38 +8,47 @@ module CKEditor5::Rails
       attr_reader :cdn, :version, :theme, :translations
 
       def initialize(version, theme: :lark, cdn: Engine.default_preset.cdn, translations: [])
-        raise ArgumentError, 'version must be semver' unless version.is_a?(Semver)
-        raise ArgumentError, 'theme must be a string' unless theme.is_a?(String)
-        raise ArgumentError, 'translations must be an array' unless translations.is_a?(Array)
-
         super()
 
         @cdn = cdn
         @version = version
         @theme = theme
         @translations = translations
+
+        validate!
       end
 
       def scripts
         @scripts ||= [
           Assets::JSExportsMeta.new(
-            create_cdn_url('ckbox', 'ckbox.js', version),
-            *translations_js_exports_meta
+            create_cdn_url('ckbox', version, 'ckbox.js'),
+            *translations_js_exports_meta,
+            window_name: 'CKBox'
           )
         ]
       end
 
       def stylesheets
         @stylesheets ||= [
-          create_cdn_url('ckbox', "styles/themes/#{theme}.css", version)
+          create_cdn_url('ckbox', version, "styles/themes/#{theme}.css")
         ]
       end
 
       private
 
+      def validate!
+        raise ArgumentError, 'version must be semver' unless version.is_a?(Semver)
+        raise ArgumentError, 'translations must be an array' unless translations.is_a?(Array)
+
+        return if theme.is_a?(String) || theme.is_a?(Symbol)
+
+        raise ArgumentError,
+              'theme must be a string or symbol'
+      end
+
       def translations_js_exports_meta
         translations.map do |lang|
-          url = create_cdn_url('ckbox', "translations/#{lang}.js", version)
+          url = create_cdn_url('ckbox', version, "translations/#{lang}.js")
 
           Assets::JSExportsMeta.new(url, window_name: 'CKBOX_TRANSLATIONS', translation: true)
         end

data/lib/ckeditor5/rails/cdn/helpers.rb

@@ -6,7 +6,7 @@ require_relative 'ckbox_bundle'
 
 module CKEditor5::Rails
   module Cdn::Helpers
-    def ckeditor5_cdn_assets(preset: :default, **kwargs)
+    def ckeditor5_assets(preset: :default, **kwargs)
       merge_with_editor_preset(preset, **kwargs) => {
         cdn:,
         version:,
@@ -32,15 +32,7 @@ module CKEditor5::Rails
 
     Cdn::UrlGenerator::CDN_THIRD_PARTY_GENERATORS.each_key do |key|
       define_method(:"ckeditor5_#{key.to_s.parameterize}_assets") do |**kwargs|
-        ckeditor5_cdn_assets(**kwargs.merge(cdn: key))
-      end
-    end
-
-    def ckeditor5_assets(**kwargs)
-      if kwargs[:license_key] && kwargs[:license_key] != 'GPL'
-        ckeditor5_cloud_assets(**kwargs)
-      else
-        ckeditor5_cdn_assets(**kwargs.merge(cdn: Engine.default_preset.cdn))
+        ckeditor5_assets(**kwargs.merge(cdn: key))
       end
     end
 
@@ -62,7 +54,7 @@ module CKEditor5::Rails
 
         raise ArgumentError,
               "Poor thing. You forgot to define #{key}. Make sure you passed `#{key}:` parameter to " \
-              "`ckeditor5_cdn_assets` or defined default one in your `#{preset}` preset!"
+              "`ckeditor5_assets` or defined default one in your `#{preset}` preset!"
       end
 
       hash

data/lib/ckeditor5/rails/cdn/url_generator.rb

@@ -20,9 +20,11 @@ module CKEditor5::Rails::Cdn
 
     CDN_COMMERCIAL_GENERATORS = {
       cloud: lambda { |bundle, version, path|
-        domain = bundle == 'ckbox' ? 'ckbox.io' : 'ckeditor.com'
+        "https://cdn.ckeditor.com/#{bundle}/#{version}/#{path}"
+      },
 
-        "https://cdn.#{domain}/#{bundle}/#{version}/#{path}"
+      ckbox: lambda { |bundle, version, path|
+        "https://cdn.ckbox.io/#{bundle}/#{version}/#{path}"
       }
     }.freeze
 
@@ -31,11 +33,11 @@ module CKEditor5::Rails::Cdn
     end
 
     def create_cdn_url(bundle, version, path)
-      generator = CDN_THIRD_PARTY_GENERATORS[cdn] || CDN_COMMERCIAL_GENERATORS[cdn] || cdn
+      executor = CDN_THIRD_PARTY_GENERATORS[cdn] || CDN_COMMERCIAL_GENERATORS[cdn] || cdn
 
-      raise ArgumentError, "Unknown provider: #{cdn}" unless generator
+      raise ArgumentError, "Unknown provider: #{cdn}" if executor.blank? || !executor.respond_to?(:call)
 
-      generator.call(bundle, version, path)
+      executor.call(bundle, version, path)
     end
   end
 end

data/lib/ckeditor5/rails/helpers.rb

@@ -1,14 +1,12 @@
 # frozen_string_literal: true
 
 require_relative 'cdn/helpers'
-require_relative 'cloud/helpers'
 require_relative 'editor/helpers'
 require_relative 'context/helpers'
 
 module CKEditor5::Rails
   module Helpers
     include Cdn::Helpers
-    include Cloud::Helpers
     include Editor::Helpers
     include Context::Helpers
   end

data/lib/ckeditor5/rails/presets/preset_builder.rb

@@ -22,6 +22,18 @@ module CKEditor5::Rails
         }
       end
 
+      def premium?
+        @premium
+      end
+
+      def gpl?
+        license_key == 'GPL'
+      end
+
+      def menubar?
+        @config.dig(:menuBar, :isVisible) || false
+      end
+
       def to_h_with_overrides(**overrides)
         {
           version: overrides.fetch(:version, version),
@@ -44,13 +56,18 @@ module CKEditor5::Rails
       def ckbox(version = nil, theme: :lark)
         return @ckbox if version.nil?
 
-        @ckbox = { version: version, theme: theme }
+        @ckbox = {
+          version: version,
+          theme: theme
+        }
       end
 
       def license_key(license_key = nil)
         return @license_key if license_key.nil?
 
         @license_key = license_key
+
+        cdn(:cloud) unless gpl?
       end
 
       def gpl
@@ -134,7 +151,9 @@ module CKEditor5::Rails
         names.each { |name| plugin(name, **kwargs) }
       end
 
-      def language(ui, content: ui) # rubocop:disable Naming/MethodParameterName
+      def language(ui = nil, content: ui) # rubocop:disable Naming/MethodParameterName
+        return @config[:language] if ui.nil?
+
         @config[:language] = {
           ui: ui,
           content: content

data/lib/ckeditor5/rails/version.rb

@@ -2,6 +2,6 @@
 
 module CKEditor5
   module Rails
-    VERSION = '1.9.0'
+    VERSION = '1.11.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ckeditor5
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 1.11.0
 platform: ruby
 authors:
 - Mateusz Bagiński
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-14 00:00:00.000000000 Z
+date: 2024-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -45,12 +45,16 @@ files:
 - lib/ckeditor5/rails.rb
 - lib/ckeditor5/rails/assets/assets_bundle.rb
 - lib/ckeditor5/rails/assets/assets_bundle_html_serializer.rb
-- lib/ckeditor5/rails/assets/webcomponent.mjs
+- lib/ckeditor5/rails/assets/webcomponent_bundle.rb
+- lib/ckeditor5/rails/assets/webcomponents/components/context.mjs
+- lib/ckeditor5/rails/assets/webcomponents/components/editable.mjs
+- lib/ckeditor5/rails/assets/webcomponents/components/editor.mjs
+- lib/ckeditor5/rails/assets/webcomponents/components/ui-part.mjs
+- lib/ckeditor5/rails/assets/webcomponents/utils.mjs
 - lib/ckeditor5/rails/cdn/ckbox_bundle.rb
 - lib/ckeditor5/rails/cdn/ckeditor_bundle.rb
 - lib/ckeditor5/rails/cdn/helpers.rb
 - lib/ckeditor5/rails/cdn/url_generator.rb
-- lib/ckeditor5/rails/cloud/helpers.rb
 - lib/ckeditor5/rails/context/helpers.rb
 - lib/ckeditor5/rails/context/props.rb
 - lib/ckeditor5/rails/editor/config_helpers.rb

data/lib/ckeditor5/rails/cloud/helpers.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-module CKEditor5::Rails
-  module Cloud
-    module Helpers
-      def ckeditor5_cloud_assets(license_key:, **kwargs)
-        raise 'Cloud assets are not permitted in GPL license!' if license_key == 'GPL'
-
-        ckeditor5_cdn_assets(cdn: :cloud, license_key: license_key, **kwargs)
-      end
-    end
-  end
-end