ckeditor5 1.24.8 → 1.24.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4c35c8f39b99348a0ee09b5310615a94a94209cb5349c6933c16b421efdd6bd7
-  data.tar.gz: b340af703a46590660d3f2a84388533edc11589212828b6525c0687e7f5cf42c
+  metadata.gz: bbaa06c0cde62bfe01904bb70ca7c8e0f4db04610d2f71543d1fbd657182e781
+  data.tar.gz: 36ac98e55c8d927fc094cac0b60dd23284a0667ca0d3387b0858d980bc0f33bd
 SHA512:
-  metadata.gz: b7c04e1eef833834a9770494a5b817750b184c1416324b7848bf80af4943aecfe9816e8ce3a6e66d8da65173711aedc6f5e6d47e336082c4db31427abf1df059
-  data.tar.gz: 385a2b21314d8c79a511a3023e44da03188f976af9942c88b05648b0d03e840e155fc3af76b482977516b8f2767849196813aa7971db8bfdc69e6bc1d7ad0fae
+  metadata.gz: 525255ffbc1aadedfe42eea761822f123f3f4de0617e19a443dcb3051d95841ced3f3fda0c8d73241094c84c4e6eac410f26b33ea9ebd1271d9ddd15ab52bcf3
+  data.tar.gz: 85f17299ba06f3187f7211eb345e93c4d5e7efbd6c2772fb855df883c7af732fd61ce8f32c788899fba3012fcb90770627c33b52182a280b70329a88f8361ce6

data/README.md

@@ -794,6 +794,23 @@ CKEditor5::Rails.configure do
   plugin :YourPlugin, window_name: 'YourPlugin'
 end
 ```
+
+If there is no `window.YourPlugin` object, the plugin will dispatch window event to load. To handle this event, you can use the `window.addEventListener` method:
+
+```js
+window.addEventListener('ckeditor:request-cjs-plugin:YourPlugin', () => {
+  window.YourPlugin = (async () => {
+    const { Plugin } = await import('ckeditor5');
+
+    return class YourPlugin extends Plugin {
+      // Your plugin code
+    };
+  })();
+});
+```
+
+⚠️ The event handler must be attached before the plugin is requested. If the plugin is requested before the event handler is attached, the plugin will not be loaded.
+
 </details>
 
 #### `plugins(*names, **kwargs)` method
@@ -1865,7 +1882,7 @@ end
 
 ```js
 // app/javascript/custom_plugins/highlight.js
-import { Plugin, Command, ButtonView } from 'ckeditor5';
+const { Plugin, Command, ButtonView } = await import('ckeditor5');
 
 return class MyCustomPlugin extends Plugin {
   static get pluginName() {

data/lib/ckeditor5/rails/editor/props_plugin.rb

@@ -7,16 +7,20 @@ module CKEditor5::Rails::Editor
     def initialize(name, premium: false, **js_import_meta_attrs)
       super(name)
 
-      js_import_meta_attrs[:import_name] ||= if premium
-                                               'ckeditor5-premium-features'
-                                             else
-                                               'ckeditor5'
-                                             end
+      if js_import_meta_attrs[:window_name]
+        @js_import_meta = ::CKEditor5::Rails::Assets::JSImportMeta.new(**js_import_meta_attrs)
+      else
+        js_import_meta_attrs[:import_name] ||= if premium
+                                                 'ckeditor5-premium-features'
+                                               else
+                                                 'ckeditor5'
+                                               end
 
-      @js_import_meta = ::CKEditor5::Rails::Assets::JSImportMeta.new(
-        import_as: js_import_meta_attrs[:window_name] ? nil : name,
-        **js_import_meta_attrs
-      )
+        @js_import_meta = ::CKEditor5::Rails::Assets::JSImportMeta.new(
+          import_as: name,
+          **js_import_meta_attrs
+        )
+      end
     end
 
     # Compress a little bit default plugins to make output smaller

data/lib/ckeditor5/rails/presets/preset_builder.rb

@@ -167,7 +167,7 @@ module CKEditor5::Rails
       def translations(*translations)
         return @translations if translations.empty?
 
-        @translations = translations
+        @translations = translations.map { |t| t.to_sym.downcase }
       end
 
       # Set or get editor version
@@ -328,7 +328,11 @@ module CKEditor5::Rails
       def language(ui = nil, content: ui) # rubocop:disable Naming/MethodParameterName
         return config[:language] if ui.nil?
 
-        @translations << ui.to_sym unless @translations.map(&:to_sym).include?(ui.to_sym)
+        # Normalize language codes, as the translation packs used to be in lowercase
+        ui = ui.to_sym.downcase
+        content = content.to_sym.downcase
+
+        @translations << ui unless @translations.map(&:to_sym).include?(ui)
 
         config[:language] = {
           ui: ui,

data/lib/ckeditor5/rails/version.rb

@@ -2,7 +2,7 @@
 
 module CKEditor5
   module Rails
-    VERSION = '1.24.8'
+    VERSION = '1.24.10'
 
     DEFAULT_CKEDITOR_VERSION = '44.1.0'
   end

data/spec/e2e/features/editor_types_spec.rb

@@ -96,6 +96,15 @@ RSpec.describe 'CKEditor5 Types Integration', type: :feature, js: true do
         expect(plugin_exists).to be true
       end
     end
+
+    it 'initializes the window plugin' do
+      visit 'classic'
+
+      eventually do
+        plugin_exists = page.evaluate_script('window.__customWindowPlugin !== undefined')
+        expect(plugin_exists).to be true
+      end
+    end
   end
 
   describe 'Decoupled Editor' do

data/spec/lib/ckeditor5/rails/presets/preset_builder_spec.rb

@@ -450,6 +450,22 @@ RSpec.describe CKEditor5::Rails::Presets::PresetBuilder do
       builder.language(:pl, content: :en)
       expect(builder.config[:language]).to eq({ ui: :pl, content: :en })
     end
+
+    it 'normalizes language codes to lowercase symbols when string provided' do
+      builder.language('PL', content: 'EN')
+      expect(builder.config[:language]).to eq({ ui: :pl, content: :en })
+    end
+
+    it 'adds normalized UI language to translations' do
+      builder.language('PL')
+      expect(builder.translations).to include(:pl)
+      expect(builder.translations).not_to include('PL')
+    end
+
+    it 'handles mixed string and symbol inputs' do
+      builder.language('PL', content: :EN)
+      expect(builder.config[:language]).to eq({ ui: :pl, content: :en })
+    end
   end
 
   describe '#deep_copy_toolbar' do

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: ckeditor5
 version: !ruby/object:Gem::Version
-  version: 1.24.8
+  version: 1.24.10
 platform: ruby
 authors:
 - Mateusz Bagiński
 - Łukasz Modliński
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-01-11 00:00:00.000000000 Z
+date: 2025-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -45,7 +45,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-description: 
+description:
 email: cziken58@gmail.com
 executables: []
 extensions: []
@@ -147,7 +147,7 @@ metadata:
   documentation_uri: https://github.com/Mati365/ckeditor5-rails
   source_code_uri: https://github.com/Mati365/ckeditor5-rails
   bug_tracker_uri: https://github.com/Mati365/ckeditor5-rails/issues
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -163,7 +163,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.5.22
-signing_key: 
+signing_key:
 specification_version: 4
 summary: CKEditor 5 for Rails
 test_files: