ckeditor5 1.24.0 → 1.24.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0ee1985934d17921821b5d298275a64b71154309e0492f8da8aaae33c7dab2bd
-  data.tar.gz: 880ec9989cd23462c889b35e68c7b49bdc9842c826b19326095d6380550220b8
+  metadata.gz: afb2870df1641fcf9fc15b9a7951c80e887991808078d56cc9ec67febad405c3
+  data.tar.gz: 725cb66917c42b51c48ecbc41161359ff73e81de17c0a0f95e6ddcc3b58bb7bc
 SHA512:
-  metadata.gz: d7b01be500143a77b4457b50115daea67bc64351cb58b37e7f8cfe50f2c28cd0b8007633b85697ca90878a09b0c3a37df00fcae4d3927aff7bad57e27d21ca92
-  data.tar.gz: 202ed9359e0b7b57d260f391c46bcd6a985eda11fb91df409bc345470c879a587487f8f7a23382d440b5963a797411dc6c58a60ddfe43e2ab24dc70b642a7fb0
+  metadata.gz: 5c8729eb7e323a8f240d4877171d64e27a5dab46567921c1372f57b9be635b4eac0d4e9492fd6693b0ef448533ca56a233498fe570866f734f2da5377c4140b3
+  data.tar.gz: 3ed9851296ad8cce6282a0c9262120436118552c7166490059bafd29ad82e83f8930c93a3464a780672b4c38aa9468b34a36cf1e8e613cfc34114b8523c22942

data/lib/ckeditor5/rails/context/preset_builder.rb

@@ -39,6 +39,7 @@ module CKEditor5::Rails
       #     toolbar :bold, :italic
       #   end
       def initialize(&block)
+        @disallow_inline_plugin_compression = true
         @config = {
           plugins: []
         }

data/lib/ckeditor5/rails/editor/props_inline_plugin.rb

@@ -46,7 +46,7 @@ module CKEditor5::Rails::Editor
       <<~JS
         window.addEventListener('ckeditor:request-cjs-plugin:#{@plugin.name}', () => {
           window['#{@plugin.name}'] = #{code.html_safe};
-        });
+        }, { once: true });
       JS
     end
   end

data/lib/ckeditor5/rails/presets/concerns/plugin_methods.rb

@@ -14,7 +14,7 @@ module CKEditor5::Rails
         class UnsupportedESModuleError < StandardError; end
 
         included do
-          attr_reader :disallow_inline_plugins
+          attr_reader :disallow_inline_plugins, :disallow_inline_plugin_compression
         end
 
         # Registers an external plugin loaded from a URL
@@ -62,7 +62,11 @@ module CKEditor5::Rails
           end
 
           wrapped_code = "(async () => { #{code} })();"
-          minified_code = Terser.new(compress: false, mangle: true).compile(wrapped_code)
+          minified_code = wrapped_code
+
+          unless disallow_inline_plugin_compression
+            minified_code = Terser.new(compress: false, mangle: true).compile(minified_code)
+          end
 
           register_plugin(Editor::PropsInlinePlugin.new(name, minified_code))
         end

data/lib/ckeditor5/rails/version.rb

@@ -2,7 +2,7 @@
 
 module CKEditor5
   module Rails
-    VERSION = '1.24.0'
+    VERSION = '1.24.2'
 
     DEFAULT_CKEDITOR_VERSION = '44.1.0'
   end

data/spec/lib/ckeditor5/rails/cdn/helpers_spec.rb

@@ -427,6 +427,29 @@ RSpec.describe CKEditor5::Rails::Cdn::Helpers do
       expect(result).to have_tag('script', with: { nonce: 'test-nonce' })
     end
 
+    context 'event listener' do
+      it 'adds event listeners for ckeditor:request-cjs-plugin' do
+        result = helper.ckeditor5_inline_plugins_tags(preset)
+
+        expect(result).to include("window.addEventListener('ckeditor:request-cjs-plugin:Plugin1'")
+        expect(result).to include("window.addEventListener('ckeditor:request-cjs-plugin:Plugin2'")
+      end
+
+      it 'adds event listeners only once' do
+        result = helper.ckeditor5_inline_plugins_tags(preset)
+
+        expect(result.scan("window.addEventListener('ckeditor:request-cjs-plugin:Plugin1'").count).to eq(1)
+        expect(result.scan("window.addEventListener('ckeditor:request-cjs-plugin:Plugin2'").count).to eq(1)
+      end
+
+      it('each event listener has once option') do
+        result = helper.ckeditor5_inline_plugins_tags(preset)
+
+        expect(result).to include('{ once: true }')
+        expect(result.scan('{ once: true }').length).to eq(2)
+      end
+    end
+
     context 'with preset having no inline plugins' do
       let(:empty_preset) do
         CKEditor5::Rails::Presets::PresetBuilder.new do

data/spec/lib/ckeditor5/rails/context/preset_builder_spec.rb

@@ -102,9 +102,7 @@ RSpec.describe CKEditor5::Rails::Context::PresetBuilder do
     it 'accepts plugin options' do
       plugin = builder.inline_plugin('Test', plugin_code)
 
-      expect(plugin.code).to eq(
-        '(async()=>{const{Plugin:t}=await import("ckeditor5");return class n extends t{}})();'
-      )
+      expect(plugin.code).to eq("(async () => { #{plugin_code} })();")
     end
   end
 

data/spec/lib/ckeditor5/rails/editor/props_inline_plugin_spec.rb

@@ -36,3 +36,35 @@ RSpec.describe CKEditor5::Rails::Editor::PropsInlinePlugin do
     end
   end
 end
+
+RSpec.describe CKEditor5::Rails::Editor::InlinePluginWindowInitializer do
+  let(:plugin) do
+    CKEditor5::Rails::Editor::PropsInlinePlugin.new(:CustomPlugin, 'const plugin = {}')
+  end
+
+  subject(:initializer) { described_class.new(plugin) }
+
+  describe '#to_html' do
+    it 'generates script tag with event listener' do
+      result = initializer.to_html
+
+      expect(result).to be_html_safe
+      expect(result).to include('script')
+      expect(result).to include("window.addEventListener('ckeditor:request-cjs-plugin:CustomPlugin'")
+      expect(result).to include("window['CustomPlugin']")
+    end
+
+    it 'adds nonce attribute when provided' do
+      result = initializer.to_html(nonce: 'test-nonce')
+
+      expect(result).to include('nonce="test-nonce"')
+    end
+
+    it 'wraps plugin code in event handler' do
+      result = initializer.to_html
+
+      expect(result).to include('const plugin = {}')
+      expect(result).to include('{ once: true }')
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ckeditor5
 version: !ruby/object:Gem::Version
-  version: 1.24.0
+  version: 1.24.2
 platform: ruby
 authors:
 - Mateusz Bagiński
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-12-20 00:00:00.000000000 Z
+date: 2024-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails