ckeditor5 1.20.1 → 1.21.0

data/spec/lib/ckeditor5/rails/editor/props_spec.rb

@@ -3,34 +3,29 @@
 require 'spec_helper'
 
 RSpec.describe CKEditor5::Rails::Editor::Props do
-  let(:controller_context) do
-    {
-      bundle: double('Bundle', translations_scripts: [{ path: 'translations/en.js' }]),
-      license_key: nil
-    }
-  end
+  let(:bundle) { CKEditor5::Rails::Assets::AssetsBundle.new }
   let(:type) { :classic }
   let(:config) { { plugins: [], toolbar: { items: [] } } }
 
   describe '#initialize' do
     it 'accepts valid editor type' do
-      expect { described_class.new(controller_context, :classic, {}) }.not_to raise_error
+      expect { described_class.new(type, {}, bundle: bundle) }.not_to raise_error
     end
 
     it 'raises error for invalid editor type' do
-      expect { described_class.new(controller_context, :invalid, {}) }
+      expect { described_class.new(:invalid, {}, bundle: bundle) }
         .to raise_error(ArgumentError, 'Invalid editor type: invalid')
     end
   end
 
   describe '#to_attributes' do
-    subject(:props) { described_class.new(controller_context, type, config) }
+    subject(:props) { described_class.new(type, config, bundle: bundle) }
 
     it 'includes required attributes' do
       attributes = props.to_attributes
       expect(attributes).to include(
         type: 'ClassicEditor',
-        translations: String,
+        bundle: String,
         plugins: String,
         config: String,
         watchdog: true
@@ -38,33 +33,18 @@ RSpec.describe CKEditor5::Rails::Editor::Props do
     end
 
     context 'with editable height' do
-      subject(:props) { described_class.new(controller_context, type, config, editable_height: '500px') }
+      subject(:props) { described_class.new(type, config, bundle: bundle, editable_height: '500px') }
 
       it 'includes editable-height attribute' do
         expect(props.to_attributes['editable-height']).to eq('500px')
       end
     end
 
-    context 'with language' do
-      subject(:props) { described_class.new(controller_context, type, config, language: 'pl') }
-
-      it 'includes language in config' do
-        config_json = props.to_attributes[:config]
-
-        expect(config_json).to include('language')
-        expect(JSON.parse(config_json)['language']).to eq({ 'ui' => 'pl' })
-      end
-    end
-
-    context 'with license key' do
-      let(:controller_context) do
-        { bundle: double('Bundle', translations_scripts: []), license_key: 'ABC123' }
-      end
+    context 'with watchdog disabled' do
+      subject(:props) { described_class.new(type, config, bundle: bundle, watchdog: false) }
 
-      it 'includes license key in config' do
-        config_json = props.to_attributes[:config]
-        expect(config_json).to include('licenseKey')
-        expect(JSON.parse(config_json)['licenseKey']).to eq('ABC123')
+      it 'includes watchdog: false in attributes' do
+        expect(props.to_attributes[:watchdog]).to be false
       end
     end
   end
@@ -87,7 +67,7 @@ RSpec.describe CKEditor5::Rails::Editor::Props do
 
       it 'raises error when editable height is set' do
         expect do
-          described_class.new(controller_context, type, config, editable_height: '500px')
+          described_class.new(type, config, bundle: bundle, editable_height: '500px')
         end.to raise_error(CKEditor5::Rails::Editor::InvalidEditableHeightError)
       end
     end
@@ -96,18 +76,18 @@ RSpec.describe CKEditor5::Rails::Editor::Props do
       let(:type) { :classic }
 
       it 'accepts integer values' do
-        props = described_class.new(controller_context, type, config, editable_height: 500)
+        props = described_class.new(type, config, bundle: bundle, editable_height: 500)
         expect(props.to_attributes['editable-height']).to eq('500px')
       end
 
       it 'accepts pixel string values' do
-        props = described_class.new(controller_context, type, config, editable_height: '500px')
+        props = described_class.new(type, config, bundle: bundle, editable_height: '500px')
         expect(props.to_attributes['editable-height']).to eq('500px')
       end
 
       it 'raises error for invalid values' do
         expect do
-          described_class.new(controller_context, type, config, editable_height: '500em')
+          described_class.new(type, config, bundle: bundle, editable_height: '500em')
         end.to raise_error(CKEditor5::Rails::Editor::InvalidEditableHeightError)
       end
     end

data/spec/lib/ckeditor5/rails/engine_spec.rb

@@ -61,6 +61,16 @@ RSpec.describe CKEditor5::Rails::Engine do
         expect(described_class.find_preset(:custom)).to eq(preset)
       end
     end
+
+    describe '.presets' do
+      before do
+        RSpec::Mocks.space.proxy_for(described_class).reset
+      end
+
+      it 'returns presets from configuration' do
+        expect(described_class.presets).to eq(described_class.base.presets)
+      end
+    end
   end
 
   describe 'initializers' do

data/spec/lib/ckeditor5/rails/hooks/form_spec.rb

@@ -11,18 +11,31 @@ RSpec.describe CKEditor5::Rails::Hooks::Form do
     end
 
     before do
-      template.ckeditor5_assets(version: '34.1.0')
+      template.ckeditor5_assets(version: '34.1.0', automatic_upgrades: false, cdn: :jsdelivr)
     end
 
     describe '#build_editor' do
       subject(:rendered_editor) { builder.build_editor(:content) }
 
       it 'renders ckeditor element' do
+        bundle_json = {
+          scripts: [
+            {
+              import_name: 'ckeditor5',
+              url: 'https://cdn.jsdelivr.net/npm/ckeditor5@34.1.0/dist/browser/ckeditor5.js',
+              translation: false
+            }
+          ],
+          stylesheets: [
+            'https://cdn.jsdelivr.net/npm/ckeditor5@34.1.0/dist/browser/ckeditor5.css'
+          ]
+        }.to_json
+
         attrs = {
           name: 'post[content]',
           id: 'post_content',
           type: 'ClassicEditor',
-          translations: '[]',
+          bundle: bundle_json,
           watchdog: 'true'
         }
 

data/spec/lib/ckeditor5/rails/plugins/wproofreader_spec.rb

@@ -24,6 +24,7 @@ RSpec.describe CKEditor5::Rails::Plugins::WProofreader do
         expected_hash = {
           type: :external,
           stylesheets: ["#{default_cdn}@#{default_version}/dist/browser/index.css"],
+          translation: false,
           url: "#{default_cdn}@#{default_version}/dist/browser/index.js",
           import_name: "#{default_cdn}@#{default_version}/dist/browser/index.js",
           import_as: 'WProofreader'
@@ -47,6 +48,7 @@ RSpec.describe CKEditor5::Rails::Plugins::WProofreader do
         expected_hash = {
           type: :external,
           stylesheets: ["#{custom_cdn}@#{custom_version}/dist/browser/index.css"],
+          translation: false,
           url: "#{custom_cdn}@#{custom_version}/dist/browser/index.js",
           import_name: "#{custom_cdn}@#{custom_version}/dist/browser/index.js",
           import_as: 'WProofreader'

data/spec/lib/ckeditor5/rails/version_detector_spec.rb

@@ -118,7 +118,7 @@ RSpec.describe CKEditor5::Rails::VersionDetector do
 
   private
 
-  def setup_http_mock(response) # rubocop:disable Metrics/AbcSize
+  def setup_http_mock(response)
     allow(Net::HTTP).to receive(:new).and_return(
       double('Net::HTTP').tap do |http|
         allow(http).to receive(:use_ssl=)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ckeditor5
 version: !ruby/object:Gem::Version
-  version: 1.20.1
+  version: 1.21.0
 platform: ruby
 authors:
 - Mateusz Bagiński
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-12-02 00:00:00.000000000 Z
+date: 2024-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -53,6 +53,7 @@ files:
 - lib/ckeditor5/rails/assets/webcomponents/utils.mjs
 - lib/ckeditor5/rails/cdn/ckbox_bundle.rb
 - lib/ckeditor5/rails/cdn/ckeditor_bundle.rb
+- lib/ckeditor5/rails/cdn/concerns/bundle_builder.rb
 - lib/ckeditor5/rails/cdn/helpers.rb
 - lib/ckeditor5/rails/cdn/url_generator.rb
 - lib/ckeditor5/rails/context/helpers.rb
@@ -83,9 +84,11 @@ files:
 - lib/ckeditor5/rails/semver.rb
 - lib/ckeditor5/rails/version.rb
 - lib/ckeditor5/rails/version_detector.rb
+- spec/e2e/features/ajax_form_integration_spec.rb
 - spec/e2e/features/context_spec.rb
 - spec/e2e/features/editor_types_spec.rb
 - spec/e2e/features/form_integration_spec.rb
+- spec/e2e/features/lazy_assets_spec.rb
 - spec/e2e/features/locale_spec.rb
 - spec/e2e/spec_helper.rb
 - spec/e2e/support/eventually.rb
@@ -149,9 +152,11 @@ signing_key:
 specification_version: 4
 summary: CKEditor 5 for Rails
 test_files:
+- spec/e2e/features/ajax_form_integration_spec.rb
 - spec/e2e/features/context_spec.rb
 - spec/e2e/features/editor_types_spec.rb
 - spec/e2e/features/form_integration_spec.rb
+- spec/e2e/features/lazy_assets_spec.rb
 - spec/e2e/features/locale_spec.rb
 - spec/e2e/spec_helper.rb
 - spec/e2e/support/eventually.rb