ckeditor5 1.15.10 → 1.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1cdcc72197788bc6dc57bb3b01158c932dbf27621084414bc832c5d772e01701
-  data.tar.gz: 7d6874e08d93346f9d478f46e2240bbc5df78a32700f50087de8fe8e4301cfc8
+  metadata.gz: e91fe2d11179c703901756efa978fcedcd3030d0381c4e550ab8c9c15ef73a19
+  data.tar.gz: 4119948cdae51969b3d1e77801f20faecd81cfbf2755388fc444421e7da8bdb9
 SHA512:
-  metadata.gz: 7dc9311974b2dd72a05fd61cea086585179e64700f800618d06f4bffd079f31ad99d31f1ea5917d7c28cdd4e03d675122b546d25518ed43a99928f2061afd448
-  data.tar.gz: 199da996b61646c658dbbe0c8119419220b669442a5eba6fc1c973dad7793e3db8e3a1e8808e075e8d0477236fd8741fa2927eae9c141fc7bb87364df6fee7ae
+  metadata.gz: d4f236d5bc883344daa8fa9bc0b7d55e3898360dd8fabfd48265bbd1eedf3c654e8ba6baf5b0a1ba5ffa215c6b2c14a60c02f7182b81885a875b0a4902f67746
+  data.tar.gz: 593de9199583c1f22a38b9858967eca63b9c98eef8b7a6a1e5a06ccfa1df759424dab96ed88c1719614744b26c8a32920722156875ba748e66c80272eeb0fd78

data/Gemfile

@@ -24,6 +24,7 @@ end
 
 group :test, :development do
   gem 'capybara', '~> 3.40'
+  gem 'cuprite', '~> 0.15.0'
   gem 'rspec', '~> 3.13'
   gem 'rspec-expectations', '~> 3.13'
   gem 'rspec-html-matchers', '~> 0.10.0'

data/lib/ckeditor5/rails/assets/webcomponents/components/context.mjs

@@ -12,7 +12,12 @@ class CKEditorContextComponent extends HTMLElement {
   /** @type {Set<CKEditorComponent>} */
   #connectedEditors = new Set();
 
+  /** @type {String} Attributes checksum hash */
+  #integrity = '';
+
   async connectedCallback() {
+    this.#integrity = this.getAttribute('integrity');
+
     try {
       execIfDOMReady(() => this.#initializeContext());
     } catch (error) {
@@ -52,6 +57,22 @@ class CKEditorContextComponent extends HTMLElement {
     this.#connectedEditors.delete(editor);
   }
 
+  /**
+   * Validates editor configuration integrity hash to prevent attacks.
+   */
+  async #validateIntegrity() {
+    const integrity = await calculateChecksum({
+      plugins: this.getAttribute('plugins'),
+    });
+
+    if (integrity !== this.#integrity) {
+      throw new Error(
+        'Configuration integrity check failed. It means that #integrity attributes mismatch from attributes passed to webcomponent. ' +
+        'This could be a security issue. Please check if you are passing correct attributes to the webcomponent.'
+      );
+    }
+  }
+
   /**
    * Initialize CKEditor context with shared configuration
    *
@@ -66,6 +87,8 @@ class CKEditorContextComponent extends HTMLElement {
       this.instance = null;
     }
 
+    await this.#validateIntegrity();
+
     const { Context, ContextWatchdog } = await import('ckeditor5');
     const plugins = await this.#getPlugins();
     const config = this.#getConfig();

data/lib/ckeditor5/rails/assets/webcomponents/components/editor.mjs

@@ -40,6 +40,9 @@ class CKEditorComponent extends HTMLElement {
   /** @type {String} ID of editor within context */
   #contextEditorId = null;
 
+  /** @type {String} Attributes checksum hash */
+  #integrity = '';
+
   /** @type {(event: CustomEvent) => void} Event handler for editor change */
   get oneditorchange() {
     return this.#getEventHandler('editorchange');
@@ -106,9 +109,11 @@ class CKEditorComponent extends HTMLElement {
   /**
    * Lifecycle callback when element is connected to DOM
    * Initializes the editor when DOM is ready
+   *
    * @protected
    */
   connectedCallback() {
+    this.#integrity = this.getAttribute('integrity');
     this.#context = this.closest('ckeditor-context-component');
     this.#initialHTML = this.innerHTML;
 
@@ -228,6 +233,23 @@ class CKEditorComponent extends HTMLElement {
     return resolveElementReferences(config);
   }
 
+  /**
+   * Validates editor configuration integrity hash to prevent attacks.
+   */
+  async #validateIntegrity() {
+    const integrity = await calculateChecksum({
+      translations: this.getAttribute('translations'),
+      plugins: this.getAttribute('plugins'),
+    });
+
+    if (integrity !== this.#integrity) {
+      throw new Error(
+        'Configuration integrity check failed. It means that #integrity attributes mismatch from attributes passed to webcomponent. ' +
+        'This could be a security issue. Please check if you are passing correct attributes to the webcomponent.'
+      );
+    }
+  }
+
   /**
    * Creates a new CKEditor instance
    *
@@ -237,6 +259,8 @@ class CKEditorComponent extends HTMLElement {
    * @throws {Error} When initialization fails
    */
   async #initializeEditor(editablesOrContent) {
+    await this.#validateIntegrity();
+
     const Editor = await this.#getEditorConstructor();
     const [plugins, translations] = await Promise.all([
       this.#getPlugins(),

data/lib/ckeditor5/rails/assets/webcomponents/utils.mjs

@@ -66,16 +66,18 @@ function loadAsyncImports(imports = []) {
     return imported;
   };
 
-  return Promise.all(imports.map(item => {
-    switch(item.type) {
-      case 'inline':
-        return loadInlinePlugin(item);
-
-      case 'external':
-      default:
-        return loadExternalPlugin(item);
-    }
-  }));
+  return Promise.all(
+    imports.map(async (item) => {
+      switch(item.type) {
+        case 'inline':
+          return loadInlinePlugin(item);
+
+        case 'external':
+        default:
+          return loadExternalPlugin(item);
+      }
+    })
+  );
 }
 
 /**
@@ -153,3 +155,24 @@ function resolveElementReferences(obj) {
 function uid() {
   return Math.random().toString(36).substring(2);
 }
+
+/**
+ * Calculates checksum for an object.
+ */
+async function calculateChecksum(obj) {
+  const objCopy = { ...obj, checksum: undefined };
+
+  return sha256(JSON.stringify(objCopy));
+}
+
+/**
+ * Calculates SHA-256 hash for a string
+ */
+async function sha256(str) {
+  const buffer = new TextEncoder().encode(str);
+  const hashBuffer = await crypto.subtle.digest('SHA-256', buffer);
+
+  return Array.from(new Uint8Array(hashBuffer))
+    .map(b => b.toString(16).padStart(2, '0'))
+    .join('');
+}

data/lib/ckeditor5/rails/concerns/checksum.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'digest'
+require 'json'
+
+module CKEditor5::Rails::Concerns
+  module Checksum
+    private
+
+    def calculate_object_checksum(obj)
+      json = JSON.generate(obj)
+      Digest::SHA256.hexdigest(json)
+    end
+  end
+end

data/lib/ckeditor5/rails/context/props.rb

@@ -3,14 +3,16 @@
 module CKEditor5::Rails
   module Context
     class Props
+      include CKEditor5::Rails::Concerns::Checksum
+
       def initialize(config)
         @config = config
       end
 
       def to_attributes
         {
-          plugins: serialize_plugins,
-          config: serialize_config
+          **serialized_attributes,
+          integrity: integrity_checksum
         }
       end
 
@@ -18,6 +20,19 @@ module CKEditor5::Rails
 
       attr_reader :config
 
+      def integrity_checksum
+        unsafe_attributes = serialized_attributes.slice(:plugins)
+
+        calculate_object_checksum(unsafe_attributes)
+      end
+
+      def serialized_attributes
+        @serialized_attributes ||= {
+          plugins: serialize_plugins,
+          config: serialize_config
+        }
+      end
+
       def serialize_plugins
         (config[:plugins] || []).map { |plugin| Editor::PropsPlugin.normalize(plugin).to_h }.to_json
       end

data/lib/ckeditor5/rails/editor/props.rb

@@ -5,6 +5,8 @@ require_relative 'editable_height_normalizer'
 
 module CKEditor5::Rails::Editor
   class Props
+    include CKEditor5::Rails::Concerns::Checksum
+
     EDITOR_TYPES = {
       classic: 'ClassicEditor',
       inline: 'InlineEditor',
@@ -25,8 +27,9 @@ module CKEditor5::Rails::Editor
 
     def to_attributes
       {
+        **serialized_attributes,
         type: EDITOR_TYPES[@type],
-        **serialized_attributes
+        integrity: integrity_checksum
       }
     end
 
@@ -38,14 +41,24 @@ module CKEditor5::Rails::Editor
 
     attr_reader :controller_context, :watchdog, :type, :config, :editable_height
 
+    def integrity_checksum
+      unsafe_attributes = serialized_attributes.slice(:translations, :plugins)
+
+      calculate_object_checksum(unsafe_attributes)
+    end
+
     def serialized_attributes
-      {
+      return @serialized_attributes if defined?(@serialized_attributes)
+
+      attributes = {
         translations: serialize_translations,
         plugins: serialize_plugins,
         config: serialize_config,
         watchdog: watchdog
       }
-        .merge(editable_height ? { 'editable-height' => editable_height } : {})
+
+      attributes.merge!(editable_height ? { 'editable-height' => editable_height } : {})
+      @serialized_attributes = attributes
     end
 
     def serialize_translations

data/lib/ckeditor5/rails/editor/props_base_plugin.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module CKEditor5::Rails
+  module Editor
+    class PropsBasePlugin
+      include Concerns::Checksum
+
+      attr_reader :name
+
+      def initialize(name)
+        @name = name
+      end
+
+      def to_h
+        raise NotImplementedError, 'This method must be implemented in a subclass'
+      end
+    end
+  end
+end

data/lib/ckeditor5/rails/editor/props_inline_plugin.rb

@@ -1,11 +1,14 @@
 # frozen_string_literal: true
 
+require_relative 'props_base_plugin'
+
 module CKEditor5::Rails::Editor
-  class PropsInlinePlugin
-    attr_reader :name, :code
+  class PropsInlinePlugin < PropsBasePlugin
+    attr_reader :code
 
     def initialize(name, code)
-      @name = name
+      super(name)
+
       @code = code
       validate_code!
     end

data/lib/ckeditor5/rails/editor/props_plugin.rb

@@ -1,12 +1,14 @@
 # frozen_string_literal: true
 
-module CKEditor5::Rails::Editor
-  class PropsPlugin
-    attr_reader :name, :js_import_meta
+require_relative 'props_base_plugin'
 
-    delegate :to_h, to: :import_meta
+module CKEditor5::Rails::Editor
+  class PropsPlugin < PropsBasePlugin
+    attr_reader :js_import_meta
 
     def initialize(name, premium: false, **js_import_meta)
+      super(name)
+
       @name = name
       @js_import_meta = if js_import_meta.empty?
                           { import_name: premium ? 'ckeditor5-premium-features' : 'ckeditor5' }

data/lib/ckeditor5/rails/version.rb

@@ -2,7 +2,7 @@
 
 module CKEditor5
   module Rails
-    VERSION = '1.15.10'
+    VERSION = '1.16.0'
 
     DEFAULT_CKEDITOR_VERSION = '43.3.1'
   end

data/lib/ckeditor5/rails.rb

@@ -5,6 +5,7 @@ module CKEditor5
     require_relative 'rails/version'
     require_relative 'rails/version_detector'
     require_relative 'rails/semver'
+    require_relative 'rails/concerns/checksum'
     require_relative 'rails/assets/assets_bundle'
     require_relative 'rails/assets/assets_bundle_html_serializer'
     require_relative 'rails/helpers'

data/spec/e2e/features/editor_types_spec.rb

@@ -0,0 +1,178 @@
+# frozen_string_literal: true
+
+require 'e2e/spec_helper'
+
+RSpec.describe 'CKEditor5 Types Integration', type: :feature, js: true do
+  shared_examples 'an editor' do |path|
+    before { visit path }
+
+    it 'loads and initializes the editor' do
+      expect(page).to have_css('.ck-editor__editable', wait: 10)
+    end
+  end
+
+  shared_examples 'an editor that fires change event with main payload' do |path|
+    before { visit path }
+
+    it 'sends properly change events with proper payload' do
+      editor = first('.ck-editor__editable')
+
+      # Set up detailed change event listener
+      page.execute_script(<<~JS)
+        window._editorEvents = [];
+        document.querySelector('ckeditor-component').addEventListener('editor-change', (e) => {
+          window._editorEvents.push({
+            data: e.detail.data,
+            hasEditor: !!e.detail.editor
+          });
+        });
+      JS
+
+      # Clear editor and type text
+      editor.click
+      editor.send_keys([[:control, 'a'], :backspace])
+      editor.send_keys('Hello from keyboard!')
+
+      # Wait for change events and verify the last one
+      eventually do
+        events = page.evaluate_script('window._editorEvents')
+        last_event = events.last
+
+        expect(last_event['data']).to eq('main' => '<p>Hello from keyboard!</p>')
+        expect(last_event['hasEditor']).to be true
+      end
+    end
+  end
+
+  shared_examples 'a multiroot editor that fires change events' do |path, editables| # rubocop:disable Metrics/BlockLength
+    before { visit path }
+
+    it 'sends properly change events with proper payload for editables' do # rubocop:disable Metrics/BlockLength
+      editors = editables.map do |name|
+        find("[data-testid='#{name}-editable']")
+      end
+
+      # Set up detailed change event listener
+      page.execute_script(<<~JS)
+        window._editorEvents = [];
+        document.querySelector('ckeditor-component').addEventListener('editor-change', (e) => {
+          window._editorEvents.push({
+            data: e.detail.data,
+            hasEditor: !!e.detail.editor
+          });
+        });
+      JS
+
+      # Test each editable
+      expected_data = {}
+      editors.each_with_index do |editor, index|
+        editor.click
+        editor.send_keys([[:control, 'a'], :backspace])
+        content = "Content for #{editables[index]}"
+        editor.send_keys(content)
+        expected_data[editables[index]] = "<p>#{content}</p>"
+      end
+
+      # Wait for change events and verify the last one
+      eventually do
+        events = page.evaluate_script('window._editorEvents')
+        last_event = events.last
+
+        expect(last_event['data']).to eq(expected_data)
+        expect(last_event['hasEditor']).to be true
+      end
+    end
+  end
+
+  describe 'Classic Editor' do
+    it_behaves_like 'an editor', 'classic'
+    it_behaves_like 'an editor that fires change event with main payload', 'classic'
+  end
+
+  describe 'Decoupled Editor' do
+    before { visit 'decoupled' }
+
+    it_behaves_like 'an editor', 'decoupled'
+    it_behaves_like 'an editor that fires change event with main payload', 'decoupled'
+
+    it 'has separate toolbar' do
+      expect(page).to have_css('.toolbar-container .ck-toolbar')
+    end
+  end
+
+  describe 'Balloon Editor' do
+    before { visit 'balloon' }
+
+    it_behaves_like 'an editor', 'balloon'
+    it_behaves_like 'an editor that fires change event with main payload', 'balloon'
+
+    it 'shows balloon toolbar on selection' do
+      editor = first('.ck-editor__editable')
+      editor.click
+
+      expect(page).to have_css('.ck-balloon-panel', wait: 5)
+    end
+  end
+
+  describe 'Inline Editor' do
+    it_behaves_like 'an editor', 'inline'
+    it_behaves_like 'an editor that fires change event with main payload', 'inline'
+  end
+
+  describe 'Multiroot Editor' do
+    before { visit 'multiroot' }
+
+    it_behaves_like 'an editor', 'multiroot'
+    it_behaves_like 'a multiroot editor that fires change events', 'multiroot', %w[toolbar content]
+
+    it 'supports multiple editable areas' do
+      expect(page).to have_css('.ck-editor__editable', minimum: 2)
+    end
+
+    it 'shares toolbar between editables' do
+      expect(page).to have_css('.ck-toolbar', count: 1)
+    end
+
+    it 'handles dynamically added editables' do # rubocop:disable Metrics/BlockLength
+      # Set up event listener
+      page.execute_script(<<~JS)
+        window._newEditableEvents = [];
+        document.querySelector('ckeditor-component').addEventListener('editor-change', (e) => {
+          window._newEditableEvents.push({
+            data: e.detail.data,
+            hasEditor: !!e.detail.editor
+          });
+        });
+      JS
+
+      # Add new editable component
+      page.execute_script(<<~JS)
+        const container = document.querySelector('[data-testid="multiroot-editor"]');
+        const newEditable = document.createElement('ckeditor-editable-component');
+        newEditable.setAttribute('name', 'new-root');
+        container.appendChild(newEditable);
+      JS
+
+      sleep 0.1 # Wait for component initialization
+
+      # Find and interact with new editable
+      new_editable = find("[name='new-root']")
+      new_editable.click
+      new_editable.send_keys('Content for new root')
+
+      # Verify the change event
+      eventually do
+        events = page.evaluate_script('window._newEditableEvents')
+        last_event = events.last
+
+        expect(last_event['data']).to include(
+          'content' => '',
+          'new-root' => '<p>Content for new root</p>',
+          'toolbar' => '<p>This is a toolbar editable</p>'
+        )
+
+        expect(last_event['hasEditor']).to be true
+      end
+    end
+  end
+end

data/spec/e2e/features/form_integration_spec.rb

@@ -0,0 +1,60 @@
+# frozen_string_literal: true
+
+require 'e2e/spec_helper'
+
+RSpec.describe 'Form Integration', type: :feature, js: true do
+  before do
+    visit('form')
+    setup_form_tracking(page)
+  end
+
+  shared_examples 'a form with CKEditor' do |form_testid, editor_testid, submit_testid| # rubocop:disable Metrics/BlockLength
+    let(:form) { find("[data-testid='#{form_testid}']") }
+    let(:editor) { find("[data-testid='#{editor_testid}']") }
+    let(:editable) { editor.find('.ck-editor__editable') }
+    let(:text_field) { editor.find('textarea', visible: :hidden) }
+    let(:submit_button) { find("[data-testid='#{submit_testid}']") }
+
+    it 'loads editor properly' do
+      expect(page).to have_css("[data-testid='#{editor_testid}'] .ck-editor__editable")
+      expect(editor).to have_invisible_textarea
+    end
+
+    it 'validates required fields' do
+      editable.click
+      editable.send_keys([[:control, 'a'], :backspace])
+
+      text_field.set('')
+      submit_button.click
+
+      expect(form).not_to have_been_submitted
+      expect(text_field).to be_invalid
+    end
+
+    it 'submits with valid data' do
+      editable.click
+      editable.send_keys('New content')
+      text_field.set('Second field value')
+
+      submit_button.click
+
+      eventually do
+        expect(form).to have_been_submitted
+      end
+    end
+  end
+
+  describe 'Rails form' do
+    it_behaves_like 'a form with CKEditor',
+                    'rails-form',
+                    'rails-form-editor',
+                    'rails-form-submit'
+  end
+
+  describe 'Simple form' do
+    it_behaves_like 'a form with CKEditor',
+                    'simple-form',
+                    'simple-form-editor',
+                    'simple-form-submit'
+  end
+end

data/spec/e2e/spec_helper.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+require 'capybara'
+require 'capybara/rspec'
+require 'capybara/cuprite'
+
+ENV['RAILS_ENV'] ||= 'test'
+
+require File.expand_path('../../sandbox/config/environment', __dir__)
+
+require 'capybara/rails'
+
+Capybara.app = Rails.application
+
+Capybara.register_driver(:cuprite) do |app|
+  driver = Capybara::Cuprite::Driver.new(
+    app,
+    window_size: [1200, 800],
+    headless: ENV['HEADLESS'] == 'true',
+    browser_options: {
+      'no-sandbox': nil,
+      'disable-gpu': nil,
+      'enable-logging': nil
+    },
+    process_timeout: 20,
+    timeout: 20,
+    inspector: true
+  )
+
+  process = driver.browser.process
+  puts ''
+  puts "Browser: #{process.browser_version}"
+  puts "Protocol: #{process.protocol_version}"
+  puts "V8: #{process.v8_version}"
+  puts "Webkit: #{process.webkit_version}"
+  driver
+end
+
+Capybara.server = :webrick
+Capybara.default_driver = :cuprite
+Capybara.javascript_driver = :cuprite
+
+Dir[File.expand_path('support/**/*.rb', __dir__)].each { |f| require f }

data/spec/e2e/support/eventually.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+# Add eventually helper for async operations
+def eventually(timeout: 5, delay: 0.1)
+  deadline = Time.zone.now + timeout
+  loop do
+    yield
+    break
+  rescue RSpec::Expectations::ExpectationNotMetError, StandardError => e
+    raise e if Time.zone.now >= deadline
+
+    sleep delay
+  end
+end

data/spec/e2e/support/form_helpers.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module FormHelpers
+  def setup_form_tracking(driver)
+    driver.execute_script <<~JS
+      window.lastSubmittedForm = null;
+
+      document.addEventListener('submit', (e) => {
+        e.preventDefault();
+        window.lastSubmittedForm = e.target.id;
+      });
+    JS
+  end
+end
+
+RSpec.configure do |config|
+  config.include FormHelpers, type: :feature
+end
+
+RSpec::Matchers.define :be_invalid do
+  match do |element|
+    element[:validity] == 'false' ||
+      element.evaluate_script('!this.validity.valid')
+  end
+end
+
+RSpec::Matchers.define :have_been_submitted do
+  match do |form|
+    page.evaluate_script('window.lastSubmittedForm') == form['id']
+  end
+end
+
+RSpec::Matchers.define :have_invisible_textarea do
+  match do |element|
+    element.has_css?('textarea', visible: :hidden)
+  end
+end

data/spec/lib/ckeditor5/rails/concerns/checksum_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe CKEditor5::Rails::Concerns::Checksum do
+  let(:dummy_class) do
+    Class.new do
+      include CKEditor5::Rails::Concerns::Checksum
+
+      public :calculate_object_checksum
+    end
+  end
+
+  subject(:instance) { dummy_class.new }
+
+  describe '#calculate_object_checksum' do
+    it 'returns a 16-character string' do
+      result = instance.calculate_object_checksum({ test: 'value' })
+      expect(result).to eq(
+        'f98be16ebfa861cb39a61faff9e52b33f5bcc16bb6ae72e728d226dc07093932'
+      )
+    end
+
+    it 'returns consistent checksums for the same input' do
+      input = { name: 'test', value: 123 }
+      first_result = instance.calculate_object_checksum(input)
+      second_result = instance.calculate_object_checksum(input)
+      expect(first_result).to eq(second_result)
+    end
+
+    it 'returns different checksums for different inputs' do
+      result1 = instance.calculate_object_checksum({ a: 1 })
+      result2 = instance.calculate_object_checksum({ a: 2 })
+      expect(result1).not_to eq(result2)
+    end
+
+    it 'handles arrays' do
+      result = instance.calculate_object_checksum([1, 2, 3])
+      expect(result).to eq(
+        'a615eeaee21de5179de080de8c3052c8da901138406ba71c38c032845f7d54f4'
+      )
+    end
+
+    it 'is order dependent for hashes' do
+      result1 = instance.calculate_object_checksum({ a: 1, b: 2 })
+      result2 = instance.calculate_object_checksum({ b: 2, a: 1 })
+      expect(result1).not_to eq(result2)
+    end
+  end
+end

data/spec/lib/ckeditor5/rails/context/props_spec.rb

@@ -25,9 +25,15 @@ RSpec.describe CKEditor5::Rails::Context::Props do
   describe '#to_attributes' do
     subject(:attributes) { props.to_attributes }
 
+    it 'returns integrity property' do
+      expect(attributes[:integrity]).to eq(
+        '24e46c3ee19f6764930b38ecdf62c0ac824a0acbe6616b46199d892afb211acb'
+      )
+    end
+
     it 'returns a hash with plugins and config keys' do
       expect(attributes).to be_a(Hash)
-      expect(attributes.keys).to match_array(%i[plugins config])
+      expect(attributes.keys).to match_array(%i[plugins integrity config])
     end
 
     describe ':plugins key' do

data/spec/lib/ckeditor5/rails/editor/props_base_plugin_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe CKEditor5::Rails::Editor::PropsBasePlugin do
+  let(:concrete_class) do
+    Class.new(described_class) do
+      def to_unsafe_h
+        { type: :test, name: name }
+      end
+    end
+  end
+
+  let(:instance) { concrete_class.new(:TestPlugin) }
+
+  describe '#initialize' do
+    it 'sets the name attribute' do
+      expect(instance.name).to eq(:TestPlugin)
+    end
+  end
+
+  describe '#to_h' do
+    it 'raises NotImplementedError' do
+      expect { instance.to_h }.to raise_error(NotImplementedError)
+    end
+  end
+end

data/spec/lib/ckeditor5/rails/editor/props_spec.rb

@@ -28,11 +28,13 @@ RSpec.describe CKEditor5::Rails::Editor::Props do
 
     it 'includes required attributes' do
       attributes = props.to_attributes
+
       expect(attributes).to include(
         type: 'ClassicEditor',
         translations: String,
         plugins: String,
         config: String,
+        integrity: '358d88b83d041f208d94ac957b2fd68135f1caab5c0d101d33cf04d5d39d81ef',
         watchdog: true
       )
     end

data/spec/spec_helper.rb

@@ -36,7 +36,7 @@ require 'rspec-html-matchers'
 
 Dir[File.expand_path('support/**/*.rb', __dir__)].each { |f| require f }
 
-Rails.application.initialize!
+Rails.application.initialize! unless Rails.application.initialized?
 
 RSpec.configure do |config|
   config.expect_with :rspec do |expectations|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ckeditor5
 version: !ruby/object:Gem::Version
-  version: 1.15.10
+  version: 1.16.0
 platform: ruby
 authors:
 - Mateusz Bagiński
@@ -55,6 +55,7 @@ files:
 - lib/ckeditor5/rails/cdn/ckeditor_bundle.rb
 - lib/ckeditor5/rails/cdn/helpers.rb
 - lib/ckeditor5/rails/cdn/url_generator.rb
+- lib/ckeditor5/rails/concerns/checksum.rb
 - lib/ckeditor5/rails/context/helpers.rb
 - lib/ckeditor5/rails/context/props.rb
 - lib/ckeditor5/rails/editor/editable_height_normalizer.rb
@@ -62,6 +63,7 @@ files:
 - lib/ckeditor5/rails/editor/helpers/config_helpers.rb
 - lib/ckeditor5/rails/editor/helpers/editor_helpers.rb
 - lib/ckeditor5/rails/editor/props.rb
+- lib/ckeditor5/rails/editor/props_base_plugin.rb
 - lib/ckeditor5/rails/editor/props_inline_plugin.rb
 - lib/ckeditor5/rails/editor/props_plugin.rb
 - lib/ckeditor5/rails/engine.rb
@@ -76,17 +78,24 @@ files:
 - lib/ckeditor5/rails/semver.rb
 - lib/ckeditor5/rails/version.rb
 - lib/ckeditor5/rails/version_detector.rb
+- spec/e2e/features/editor_types_spec.rb
+- spec/e2e/features/form_integration_spec.rb
+- spec/e2e/spec_helper.rb
+- spec/e2e/support/eventually.rb
+- spec/e2e/support/form_helpers.rb
 - spec/lib/ckeditor5/rails/assets/asset_bundle_hml_serializer_spec.rb
 - spec/lib/ckeditor5/rails/assets/assets_bundle_spec.rb
 - spec/lib/ckeditor5/rails/cdn/ckbox_bundle_spec.rb
 - spec/lib/ckeditor5/rails/cdn/ckeditor_bundle_spec.rb
 - spec/lib/ckeditor5/rails/cdn/helpers_spec.rb
 - spec/lib/ckeditor5/rails/cdn/url_generator_spec.rb
+- spec/lib/ckeditor5/rails/concerns/checksum_spec.rb
 - spec/lib/ckeditor5/rails/context/helpers_spec.rb
 - spec/lib/ckeditor5/rails/context/props_spec.rb
 - spec/lib/ckeditor5/rails/editor/editable_height_normalizer_spec.rb
 - spec/lib/ckeditor5/rails/editor/helpers/config_helpers_spec.rb
 - spec/lib/ckeditor5/rails/editor/helpers/editor_helpers_spec.rb
+- spec/lib/ckeditor5/rails/editor/props_base_plugin_spec.rb
 - spec/lib/ckeditor5/rails/editor/props_inline_plugin_spec.rb
 - spec/lib/ckeditor5/rails/editor/props_plugin_spec.rb
 - spec/lib/ckeditor5/rails/editor/props_spec.rb
@@ -126,17 +135,24 @@ signing_key:
 specification_version: 4
 summary: CKEditor 5 for Rails
 test_files:
+- spec/e2e/features/editor_types_spec.rb
+- spec/e2e/features/form_integration_spec.rb
+- spec/e2e/spec_helper.rb
+- spec/e2e/support/eventually.rb
+- spec/e2e/support/form_helpers.rb
 - spec/lib/ckeditor5/rails/assets/asset_bundle_hml_serializer_spec.rb
 - spec/lib/ckeditor5/rails/assets/assets_bundle_spec.rb
 - spec/lib/ckeditor5/rails/cdn/ckbox_bundle_spec.rb
 - spec/lib/ckeditor5/rails/cdn/ckeditor_bundle_spec.rb
 - spec/lib/ckeditor5/rails/cdn/helpers_spec.rb
 - spec/lib/ckeditor5/rails/cdn/url_generator_spec.rb
+- spec/lib/ckeditor5/rails/concerns/checksum_spec.rb
 - spec/lib/ckeditor5/rails/context/helpers_spec.rb
 - spec/lib/ckeditor5/rails/context/props_spec.rb
 - spec/lib/ckeditor5/rails/editor/editable_height_normalizer_spec.rb
 - spec/lib/ckeditor5/rails/editor/helpers/config_helpers_spec.rb
 - spec/lib/ckeditor5/rails/editor/helpers/editor_helpers_spec.rb
+- spec/lib/ckeditor5/rails/editor/props_base_plugin_spec.rb
 - spec/lib/ckeditor5/rails/editor/props_inline_plugin_spec.rb
 - spec/lib/ckeditor5/rails/editor/props_plugin_spec.rb
 - spec/lib/ckeditor5/rails/editor/props_spec.rb