ckeditor5 1.10.0 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3e06c4a4882429855d9570658be64f10fffd97371d0ae60e9aee2ecec08df00
-  data.tar.gz: f48eabec0f1bcab9299be0f00094f2e1078a757582a705e57d504748943b5790
+  metadata.gz: 2ff16eff85125b3b08d827a0dc6f25f85c84535ffdc37fada565a256e9a494c6
+  data.tar.gz: 505f43e893d3fa0119fd23365c83a01b729edbbc9236adcaa282c5e6a0791ac4
 SHA512:
-  metadata.gz: c989f7723dadc126c356b579f50160b09f3c359af8a791a919bcff0595c7387241f89f5a63a100c482878d0f067c094f45619628094d6a8c0659d797d75cb514
-  data.tar.gz: a411bbde271725fbaeddfc58023307837ffac5e26d4814ed13e922288846129973a2b297681076b480982485a91ed4b5c527056cf2b9b799cfbb321a5ed83762
+  metadata.gz: 7d93cdc48b6c6f8d10af216f4c0622dbd99ac08c82267ab6c3d5089f1a70395cda15b9ec345b097b40ae59b8611c492711fefc8b6a33d09a42110bf294077465
+  data.tar.gz: 60ea317d04dbc4305cf878925234b28eeb380e508f1991f9021be042e1d88d35ae11914947e1aeca088846b2cad91d2625b79cfb09dafe661fcd32b1e4080acf

data/Gemfile

@@ -6,11 +6,21 @@ gem 'bundler', '~> 2.5', '>= 2.5.21'
 
 group :development do
   gem 'brakeman', '~> 6.1', '>= 6.1.1', require: false
+  gem 'guard', '~> 2.19', '>= 2.19.0'
+  gem 'guard-process', '~> 1.2'
+  gem 'pry', '~> 0.15', '>= 0.15.0'
+  gem 'rails', '~> 7.0', '>= 7.0.0'
   gem 'rake', '~> 13.2', '>= 13.2.1'
   gem 'rspec', '~> 3.13'
+  gem 'rspec-expectations', '~> 3.13'
+  gem 'rspec-rails', '~> 7.0'
   gem 'rubocop', '~> 1.66', require: false
   gem 'rubocop-rails', '~> 2.26', '>= 2.26.2', require: false
   gem 'rubocop-rails-omakase', '~> 1.0.0', require: false
+  gem 'simple_form', '~> 5.3', '>= 5.3.0'
+  gem 'slim', '~> 5.2', '>= 5.2.0'
+  gem 'sprockets-rails', '~> 3.2', '>= 3.2.2'
+  gem 'sqlite3', '>= 1.4'
 end
 
 group :test, :development do

data/README.md

@@ -117,6 +117,7 @@ Voilà! You have CKEditor 5 integrated with your Rails application. 🎉
     - [`editor-error` event](#editor-error-event)
     - [`editor-change` event](#editor-change-event)
     - [Inline event handling](#inline-event-handling)
+  - [Gem Development 🛠](#gem-development-)
   - [Trademarks 📜](#trademarks-)
   - [License 📜](#license-)
 
@@ -1314,7 +1315,21 @@ You can also define event handlers directly in the view using the `oneditorchang
   }
 </script>
 
-<%= ckeditor5_editor style: 'width: 600px', id: 'editor', oneditorchange: 'onEditorChange', oneditorerror: 'onEditorError', oneditorready: 'onEditorReady' %>
+<%= ckeditor5_editor id: 'editor',
+    oneditorchange: 'onEditorChange',
+    oneditorerror: 'onEditorError',
+    oneditorready: 'onEditorReady'
+%>
+```
+
+## Gem Development 🛠
+
+If you want to contribute to the gem, you can clone the repository and run the following commands:
+
+```sh
+gem install bundler -v 2.5.22
+bundle install
+bundle exec guard
 ```
 
 ## Trademarks 📜

data/lib/ckeditor5/rails/assets/assets_bundle_html_serializer.rb

@@ -43,7 +43,7 @@ module CKEditor5::Rails::Assets
 
     def window_scripts_tags
       @window_scripts_tags ||= safe_join(bundle.scripts.filter_map do |script|
-        tag.script(src: script.url, nonce: true, async: true) if script.window?
+        tag.script(src: script.url, nonce: true, crossorigin: 'anonymous') if script.window?
       end)
     end
 

data/lib/ckeditor5/rails/cdn/ckbox_bundle.rb

@@ -8,38 +8,47 @@ module CKEditor5::Rails
       attr_reader :cdn, :version, :theme, :translations
 
       def initialize(version, theme: :lark, cdn: Engine.default_preset.cdn, translations: [])
-        raise ArgumentError, 'version must be semver' unless version.is_a?(Semver)
-        raise ArgumentError, 'theme must be a string' unless theme.is_a?(String)
-        raise ArgumentError, 'translations must be an array' unless translations.is_a?(Array)
-
         super()
 
         @cdn = cdn
         @version = version
         @theme = theme
         @translations = translations
+
+        validate!
       end
 
       def scripts
         @scripts ||= [
           Assets::JSExportsMeta.new(
-            create_cdn_url('ckbox', 'ckbox.js', version),
-            *translations_js_exports_meta
+            create_cdn_url('ckbox', version, 'ckbox.js'),
+            *translations_js_exports_meta,
+            window_name: 'CKBox'
           )
         ]
       end
 
       def stylesheets
         @stylesheets ||= [
-          create_cdn_url('ckbox', "styles/themes/#{theme}.css", version)
+          create_cdn_url('ckbox', version, "styles/themes/#{theme}.css")
         ]
       end
 
       private
 
+      def validate!
+        raise ArgumentError, 'version must be semver' unless version.is_a?(Semver)
+        raise ArgumentError, 'translations must be an array' unless translations.is_a?(Array)
+
+        return if theme.is_a?(String) || theme.is_a?(Symbol)
+
+        raise ArgumentError,
+              'theme must be a string or symbol'
+      end
+
       def translations_js_exports_meta
         translations.map do |lang|
-          url = create_cdn_url('ckbox', "translations/#{lang}.js", version)
+          url = create_cdn_url('ckbox', version, "translations/#{lang}.js")
 
           Assets::JSExportsMeta.new(url, window_name: 'CKBOX_TRANSLATIONS', translation: true)
         end

data/lib/ckeditor5/rails/cdn/url_generator.rb

@@ -20,9 +20,11 @@ module CKEditor5::Rails::Cdn
 
     CDN_COMMERCIAL_GENERATORS = {
       cloud: lambda { |bundle, version, path|
-        domain = bundle == 'ckbox' ? 'ckbox.io' : 'ckeditor.com'
+        "https://cdn.ckeditor.com/#{bundle}/#{version}/#{path}"
+      },
 
-        "https://cdn.#{domain}/#{bundle}/#{version}/#{path}"
+      ckbox: lambda { |bundle, version, path|
+        "https://cdn.ckbox.io/#{bundle}/#{version}/#{path}"
       }
     }.freeze
 
@@ -31,11 +33,11 @@ module CKEditor5::Rails::Cdn
     end
 
     def create_cdn_url(bundle, version, path)
-      generator = CDN_THIRD_PARTY_GENERATORS[cdn] || CDN_COMMERCIAL_GENERATORS[cdn] || cdn
+      executor = CDN_THIRD_PARTY_GENERATORS[cdn] || CDN_COMMERCIAL_GENERATORS[cdn] || cdn
 
-      raise ArgumentError, "Unknown provider: #{cdn}" unless generator
+      raise ArgumentError, "Unknown provider: #{cdn}" if executor.blank? || !executor.respond_to?(:call)
 
-      generator.call(bundle, version, path)
+      executor.call(bundle, version, path)
     end
   end
 end

data/lib/ckeditor5/rails/presets/preset_builder.rb

@@ -56,7 +56,10 @@ module CKEditor5::Rails
       def ckbox(version = nil, theme: :lark)
         return @ckbox if version.nil?
 
-        @ckbox = { version: version, theme: theme }
+        @ckbox = {
+          version: version,
+          theme: theme
+        }
       end
 
       def license_key(license_key = nil)

data/lib/ckeditor5/rails/version.rb

@@ -2,6 +2,6 @@
 
 module CKEditor5
   module Rails
-    VERSION = '1.10.0'
+    VERSION = '1.11.1'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ckeditor5
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.1
 platform: ruby
 authors:
 - Mateusz Bagiński
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-19 00:00:00.000000000 Z
+date: 2024-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails