ckeditor 4.1.6 → 4.2.0

data/lib/ckeditor/backend/dragonfly.rb

@@ -1,6 +1,8 @@
 module Ckeditor
   module Backend
     module Dragonfly
+      FORMATS = %w(bz2 gz lzma xz).freeze
+
       def self.included(base)
         base.send(:extend, ::Dragonfly::Model)
         base.send(:extend, ::Dragonfly::Model::Validations)
@@ -14,7 +16,7 @@ module Ckeditor
             # This is not ideal but Dragonfly doesn't return double
             # extensions. Having said that, the other backends
             # currently don't use attachment_file_types at all.
-            [ 'bz2', 'gz', 'lzma', 'xz' ].each do |f|
+            FORMATS.each do |f|
               formats << f if formats.include?("tar.#{f}")
             end
           end
@@ -26,7 +28,7 @@ module Ckeditor
       end
 
       module InstanceMethods
-        delegate :url, :path, :size, :image?, :width, :height, :to => :data
+        delegate :url, :path, :size, :image?, :width, :height, to: :data
 
         alias_attribute :data_file_name, :data_name
         alias_attribute :data_content_type, :"data.mime_type"
@@ -36,7 +38,7 @@ module Ckeditor
 
         def url_thumb_options
           if data.basename.present?
-            { :basename => "thumb_#{data.basename}" }
+            { basename: "thumb_#{data.basename}" }
           else
             {}
           end

data/lib/ckeditor/backend/paperclip.rb

@@ -10,9 +10,9 @@ module Ckeditor
         def self.extended(base)
           base.class_eval do
             before_validation :extract_content_type
-            before_create :read_dimensions, :parameterize_filename
+            before_create :extract_dimensions, :parameterize_filename
 
-            delegate :url, :path, :styles, :size, :content_type, :to => :data
+            delegate :url, :path, :styles, :size, :content_type, to: :data
           end
         end
       end
@@ -24,28 +24,28 @@ module Ckeditor
 
         protected
 
-          def file
-            @file ||= data.respond_to?(:queued_for_write) ? data.queued_for_write[:original] : data.to_file
-          end
+        def file
+          @file ||= data.respond_to?(:queued_for_write) ? data.queued_for_write[:original] : data.to_file
+        end
 
-          def parameterize_filename
-            unless data_file_name.blank?
-              filename = Ckeditor::Utils.parameterize_filename(data_file_name)
-              self.data.instance_write(:file_name, filename)
-            end
+        def parameterize_filename
+          unless data_file_name.blank?
+            filename = Ckeditor::Utils.parameterize_filename(data_file_name)
+            data.instance_write(:file_name, filename)
           end
+        end
 
-          def read_dimensions
-            if image? && has_dimensions?
-              self.width = geometry.width
-              self.height = geometry.height
-            end
+        def extract_dimensions
+          if image? && has_dimensions?
+            self.width = geometry.width
+            self.height = geometry.height
           end
+        end
 
-          def extract_content_type
-            path = file.nil? ? nil : file.path
-            self.data_content_type = Utils::ContentTypeDetector.new(path).detect
-          end
+        def extract_content_type
+          path = file.nil? ? nil : file.path
+          self.data_content_type = Utils::ContentTypeDetector.new(path).detect
+        end
       end
     end
   end

data/lib/ckeditor/backend/refile.rb

@@ -24,14 +24,16 @@ module Ckeditor
         ::Refile.attachment_url(self, :data, *attrs)
       end
 
-      def read_dimensions
+      def magick
+        @magick ||= MiniMagick::Image.open(model.to_io)
+      end
+
+      def extract_dimensions
         if model.image? && model.has_dimensions?
-          magick = MiniMagick::Image.open(model.to_io)
           model.width = magick.width
           model.height = magick.height
         end
       end
-      
     end
   end
 end

data/lib/ckeditor/helpers/controllers.rb

@@ -5,30 +5,30 @@ module Ckeditor
 
       protected
 
-        def ckeditor_current_user
-          instance_eval &Ckeditor.current_user_method
-        end
+      def ckeditor_current_user
+        instance_exec(&Ckeditor.current_user_method)
+      end
 
-        def ckeditor_authorize!
-          instance_eval &Ckeditor.authorize_with
-        end
+      def ckeditor_authorize!
+        instance_exec(&Ckeditor.authorize_with)
+      end
 
-        def ckeditor_before_create_asset(asset)
-          asset.assetable = ckeditor_current_user if ckeditor_current_user
-          return true
-        end
+      def ckeditor_before_create_asset(asset)
+        asset.assetable = ckeditor_current_user if ckeditor_current_user
+        true
+      end
 
-        def ckeditor_pictures_scope(options = {})
-          ckeditor_filebrowser_scope(options)
-        end
+      def ckeditor_pictures_scope(options = {})
+        ckeditor_filebrowser_scope(options)
+      end
 
-        def ckeditor_attachment_files_scope(options = {})
-          ckeditor_filebrowser_scope(options)
-        end
+      def ckeditor_attachment_files_scope(options = {})
+        ckeditor_filebrowser_scope(options)
+      end
 
-        def ckeditor_filebrowser_scope(options = {})
-          { :order => [:id, :desc] }.merge(options)
-        end
+      def ckeditor_filebrowser_scope(options = {})
+        { order: [:id, :desc] }.merge(options)
+      end
     end
   end
 end

data/lib/ckeditor/helpers/form_builder.rb

@@ -4,7 +4,7 @@ module Ckeditor
       extend ActiveSupport::Concern
 
       def cktext_area(method, options = {})
-        @template.send("cktext_area", @object_name, method, objectify_options(options))
+        @template.cktext_area(@object_name, method, objectify_options(options))
       end
     end
   end

data/lib/ckeditor/hooks/cancan.rb

@@ -33,8 +33,6 @@ module Ckeditor
         @controller.current_ability.can?(action.to_sym, model_object) if action
       end
 
-      private
-
       module ControllerExtension
         def current_ability
           # use ckeditor_current_user instead of default current_user so it works with

data/lib/ckeditor/hooks/formtastic.rb

@@ -1,4 +1,4 @@
-require "formtastic"
+require 'formtastic'
 
 class CkeditorInput
   include ::Formtastic::Inputs::Base
@@ -6,7 +6,7 @@ class CkeditorInput
   def to_html
     input_wrapping do
       label_html <<
-      builder.cktext_area(method, input_html_options)
+        builder.cktext_area(method, input_html_options)
     end
   end
 end

data/lib/ckeditor/hooks/pundit.rb

@@ -6,7 +6,6 @@ module Ckeditor
     # You can create another adapter for different authorization behavior, just be certain it
     # responds to each of the public methods here.
     class PunditAuthorization
-
       include Ckeditor::Helpers::Controllers
 
       # See the +authorize_with+ config method for where the initialization happens.
@@ -28,11 +27,9 @@ module Ckeditor
       # This takes the same arguments as +authorize+. The difference is that this will
       # return a boolean whereas +authorize+ will raise an exception when not authorized.
       def authorized?(action, model_object = nil)
-        Pundit.policy(@controller.current_user_for_pundit, model_object).public_send(action + '?' ) if action
+        Pundit.policy(@controller.current_user_for_pundit, model_object).public_send(action + '?') if action
       end
 
-      private
-
       module ControllerExtension
         def current_user_for_pundit
           # use ckeditor_current_user instead of default current_user so it works with

data/lib/ckeditor/hooks/simple_form.rb

@@ -1,20 +1,15 @@
 require 'simple_form'
 
-module Ckeditor::Hooks::SimpleForm
-  class CkeditorInput < ::SimpleForm::Inputs::Base
-    def input(wrapper_options = nil)
-      @builder.cktext_area(attribute_name, input_html_options)
+module Ckeditor
+  module Hooks
+    module SimpleForm
+      class CkeditorInput < ::SimpleForm::Inputs::Base
+        def input(_wrapper_options = nil)
+          @builder.cktext_area(attribute_name, input_html_options)
+        end
+      end
     end
   end
 end
 
-::SimpleForm::FormBuilder.map_type :ckeditor, :to => Ckeditor::Hooks::SimpleForm::CkeditorInput
-
-# TODO: remove this after a while, SimpleForm::FormBuilder#ckeditor is deprecated.
-class SimpleForm::FormBuilder
-  def ckeditor(attribute_name, options={}, &block)
-    warn "[DEPRECATION] calling f.ckeditor(:#{attribute_name}, ...) is deprecated, call f.input(:#{attribute_name}, :as => :ckeditor, #{options.to_s[1..-1]}) #{Kernel.caller.first}"
-    options[:as] = :ckeditor
-    self.input(attribute_name, options, &block)
-  end
-end
+::SimpleForm::FormBuilder.map_type :ckeditor, to: Ckeditor::Hooks::SimpleForm::CkeditorInput

data/lib/ckeditor/http.rb

@@ -39,33 +39,30 @@ module Ckeditor
     # Usage (paperclip example)
     # @asset.data = QqFile.new(params[:qqfile], request)
     class QqFile < ::Tempfile
+      attr_reader :original_filename
 
-      def initialize(filename, request, tmpdir = Dir::tmpdir)
-        @original_filename  = filename
+      def initialize(filename, request, tmpdir = Dir.tmpdir)
+        @original_filename = filename
         @request = request
 
-        super Digest::SHA1.hexdigest(filename), tmpdir
+        super(Digest::SHA1.hexdigest(filename), tmpdir)
         binmode
         fetch
       end
 
       def fetch
-        self.write(body)
-        self.rewind
+        write(body)
+        rewind
         self
       end
 
-      def original_filename
-        @original_filename
-      end
-
       def content_type
         @request.content_type
       end
 
       def body
         if @request.raw_post.respond_to?(:force_encoding)
-          @request.raw_post.force_encoding("UTF-8")
+          @request.raw_post.force_encoding('UTF-8')
         else
           @request.raw_post
         end
@@ -76,7 +73,8 @@ module Ckeditor
     # file upload hash with UploadedFile objects
     def self.normalize_param(*args)
       value = args.first
-      if Hash === value && value.has_key?(:tempfile)
+
+      if value.is_a?(Hash) && value.key?(:tempfile)
         UploadedFile.new(value)
       elsif value.is_a?(String)
         QqFile.new(*args)

data/lib/ckeditor/orm/active_record.rb

@@ -12,9 +12,9 @@ module Ckeditor
         module ClassMethods
           def self.extended(base)
             base.class_eval do
-              self.table_name = "ckeditor_assets"
+              self.table_name = 'ckeditor_assets'
 
-              belongs_to :assetable, :polymorphic => true
+              belongs_to :assetable, polymorphic: true
             end
           end
         end

data/lib/ckeditor/orm/base.rb

@@ -20,7 +20,7 @@ module Ckeditor
           end
 
           def format_created_at
-            self.created_at.strftime("%d.%m.%Y")
+            I18n.l(created_at, format: :default)
           end
 
           def url_content
@@ -37,11 +37,11 @@ module Ckeditor
 
           def as_json(options = nil)
             options = {
-              :methods => as_json_methods,
-              :root => "asset"
+              methods: as_json_methods,
+              root: 'asset'
             }.merge(options || {})
 
-            super options
+            super(options)
           end
         end
       end

data/lib/ckeditor/orm/mongoid.rb

@@ -26,12 +26,12 @@ module Ckeditor
         module ClassMethods
           def self.extended(base)
             base.class_eval do
-              field :data_content_type, :type => String
-              field :data_file_size, :type => Integer
-              field :width, :type => Integer
-              field :height, :type => Integer
+              field :data_content_type, type: String
+              field :data_file_size, type: Integer
+              field :width, type: Integer
+              field :height, type: Integer
 
-              belongs_to :assetable, :polymorphic => true
+              belongs_to :assetable, polymorphic: true
             end
           end
         end

data/lib/ckeditor/paginatable.rb

@@ -53,4 +53,4 @@ module Ckeditor
       (offset / limit_value) + 1
     end
   end
-end
+end

data/lib/ckeditor/rails.rb

@@ -0,0 +1,33 @@
+module Ckeditor
+  class Engine < ::Rails::Engine
+    isolate_namespace Ckeditor
+
+    initializer 'ckeditor.assets_precompile', group: :all do |app|
+      app.config.assets.precompile += Ckeditor.assets
+    end
+
+    initializer 'ckeditor.helpers' do
+      ActiveSupport.on_load(:action_controller) do
+        ActionController::Base.send :include, Ckeditor::Helpers::Controllers
+      end
+
+      ActiveSupport.on_load :action_view do
+        ActionView::Base.send :include, Ckeditor::Helpers::ViewHelper
+        ActionView::Base.send :include, Ckeditor::Helpers::FormHelper
+        ActionView::Helpers::FormBuilder.send :include, Ckeditor::Helpers::FormBuilder
+      end
+    end
+
+    initializer 'ckeditor.hooks' do
+      require 'ckeditor/hooks/formtastic'  if Object.const_defined?('Formtastic')
+      require 'ckeditor/hooks/simple_form' if Object.const_defined?('SimpleForm')
+
+      require 'ckeditor/hooks/cancan' if Object.const_defined?('CanCan')
+      require 'ckeditor/hooks/pundit' if Object.const_defined?('Pundit')
+    end
+
+    rake_tasks do
+      load Ckeditor.root_path.join('lib/tasks/ckeditor.rake')
+    end
+  end
+end

data/lib/ckeditor/text_area.rb

@@ -32,22 +32,22 @@ module Ckeditor
 
     protected
 
-      def render(input)
-        output_buffer << input
-        output_buffer << javascript_tag(Utils.js_replace(options['id'], ck_options))
-        output_buffer
-      end
+    def render(input)
+      output_buffer << input
+      output_buffer << javascript_tag(Utils.js_replace(options['id'], ck_options))
+      output_buffer
+    end
 
-      def output_buffer
-        @output_buffer ||= ActiveSupport::SafeBuffer.new
-      end
+    def output_buffer
+      @output_buffer ||= ActiveSupport::SafeBuffer.new
+    end
 
-      def build_tag(object_name, method)
-        if defined?(ActionView::Base::Tags::TextArea)
-          ActionView::Base::Tags::TextArea.new(object_name, method, template, options.symbolize_keys)
-        else
-          ActionView::Base::InstanceTag.new(object_name, method, template, options.delete('object'))
-        end
+    def build_tag(object_name, method)
+      if defined?(ActionView::Base::Tags::TextArea)
+        ActionView::Base::Tags::TextArea.new(object_name, method, template, options.symbolize_keys)
+      else
+        ActionView::Base::InstanceTag.new(object_name, method, template, options.delete('object'))
       end
+    end
   end
 end

data/lib/ckeditor/utils.rb

@@ -15,7 +15,7 @@ module Ckeditor
         return filename unless Ckeditor.parameterize_filenames
 
         extension = File.extname(filename)
-        basename = filename.gsub(/#{extension}$/, "")
+        basename = filename.gsub(/#{extension}$/, '')
 
         [basename.parameterize('_'), extension].join.downcase
       end
@@ -30,23 +30,23 @@ module Ckeditor
           js << "if (CKEDITOR.instances['#{dom_id}'] == undefined) { CKEDITOR.replace('#{dom_id}'); }"
         end
 
-        js << "} else { setTimeout(arguments.callee, 50); } })();"
-        js.join(" ").html_safe
+        js << '} else { setTimeout(arguments.callee, 50); } })();'
+        js.join.html_safe
       end
 
       def js_fileuploader(uploader_type, options = {})
-        options = { :multiple => true, :element => "fileupload" }.merge(options)
+        options = { multiple: true, element: 'fileupload' }.merge(options)
 
         case uploader_type.to_s.downcase
-          when "image" then
-            options[:action] = JavascriptCode.new("EDITOR.config.filebrowserImageUploadUrl")
-            options[:allowedExtensions] = Ckeditor.image_file_types
-          when "flash" then
-            options[:action] = JavascriptCode.new("EDITOR.config.filebrowserFlashUploadUrl")
-            options[:allowedExtensions] = ["swf"]
-          else
-            options[:action] = JavascriptCode.new("EDITOR.config.filebrowserUploadUrl")
-            options[:allowedExtensions] = Ckeditor.attachment_file_types
+        when 'image' then
+          options[:action] = JavascriptCode.new('EDITOR.config.filebrowserImageUploadUrl')
+          options[:allowedExtensions] = Ckeditor.image_file_types
+        when 'flash' then
+          options[:action] = JavascriptCode.new('EDITOR.config.filebrowserFlashUploadUrl')
+          options[:allowedExtensions] = Ckeditor.flash_file_types
+        else
+          options[:action] = JavascriptCode.new('EDITOR.config.filebrowserUploadUrl')
+          options[:allowedExtensions] = Ckeditor.attachment_file_types
         end
 
         js_options = ActiveSupport::JSON.encode(options)
@@ -56,21 +56,19 @@ module Ckeditor
       end
 
       def filethumb(filename)
-        extname = filename.blank? ? "unknown" : File.extname(filename).gsub(/^\./, '')
+        extname = filename.blank? ? 'unknown' : File.extname(filename).gsub(/^\./, '')
         image = "#{extname}.gif"
-        source = Ckeditor.root_path.join("app/assets/javascripts/ckeditor/filebrowser/images/thumbs")
+        source = Ckeditor.root_path.join('app/assets/javascripts/ckeditor/filebrowser/images/thumbs')
 
-        unless File.exists?(File.join(source, image))
-          image = "unknown.gif"
-        end
+        image = 'unknown.gif' unless File.exist?(File.join(source, image))
 
-        File.join(Ckeditor.relative_path, "filebrowser/images/thumbs", image)
+        File.join(Ckeditor.relative_path, 'filebrowser/images/thumbs', image)
       end
 
       def select_assets(path, relative_path)
         relative_folder = Ckeditor.root_path.join(relative_path)
         folder = relative_folder.join(path)
-        extensions = '*.{js,css,png,gif,jpg}'
+        extensions = '*.{js,css,png,gif,jpg,html}'
         languages = (Ckeditor.assets_languages || [])
 
         # Files at root